[GitHub] [flink-connector-aws] reswqa closed pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations

2023-06-18 Thread via GitHub
reswqa closed pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations URL: https://github.com/apache/flink-connector-aws/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-connector-aws] reswqa commented on pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations

2023-06-18 Thread via GitHub
reswqa commented on PR #78: URL: https://github.com/apache/flink-connector-aws/pull/78#issuecomment-1596541116 Closed as Chesnay's comment in [FLINK-31804](https://issues.apache.org/jira/browse/FLINK-31804): `Connectors should just skip the architecture tests when running against later

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #621: [FLINK-32334] Also check if no taskmanager are running while waiting for cluster shutdown

2023-06-18 Thread via GitHub
gyfora commented on PR #621: URL: https://github.com/apache/flink-kubernetes-operator/pull/621#issuecomment-1596513964 The PR looks good but you have some check style validations before I can merge this -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Closed] (FLINK-31314) Hybrid Shuffle may not release result partitions when running multiple jobs in a session cluster

2023-06-18 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan closed FLINK-31314. - Resolution: Won't Fix > Hybrid Shuffle may not release result partitions when running multiple jobs >

[GitHub] [flink] TanYuxin-tyx commented on pull request #22089: [FLINK-31314][runtime] Fix Hybrid Shuffle may not release result partitions belonging to the finished jobs

2023-06-18 Thread via GitHub
TanYuxin-tyx commented on PR #22089: URL: https://github.com/apache/flink/pull/22089#issuecomment-1596483633 Closing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] TanYuxin-tyx closed pull request #22089: [FLINK-31314][runtime] Fix Hybrid Shuffle may not release result partitions belonging to the finished jobs

2023-06-18 Thread via GitHub
TanYuxin-tyx closed pull request #22089: [FLINK-31314][runtime] Fix Hybrid Shuffle may not release result partitions belonging to the finished jobs URL: https://github.com/apache/flink/pull/22089 -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Closed] (FLINK-32332) Jar files for catalog function are not listed correctly

2023-06-18 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong closed FLINK-32332. - Resolution: Won't Fix > Jar files for catalog function are not listed correctly >

[jira] [Commented] (FLINK-32332) Jar files for catalog function are not listed correctly

2023-06-18 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733997#comment-17733997 ] Fang Yong commented on FLINK-32332: --- Thanks [~jark] to clear this. If so, I will close this issue and

[GitHub] [flink] FangYongs closed pull request #22777: [FLINK-32332][sql-gateway] Show jars being used by function

2023-06-18 Thread via GitHub
FangYongs closed pull request #22777: [FLINK-32332][sql-gateway] Show jars being used by function URL: https://github.com/apache/flink/pull/22777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-06-18 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1233485463 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalogOptions.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed

[GitHub] [flink] flinkbot commented on pull request #22821: [FLINK-32351][table] Introduce base interfaces for call procedure

2023-06-18 Thread via GitHub
flinkbot commented on PR #22821: URL: https://github.com/apache/flink/pull/22821#issuecomment-1596437586 ## CI report: * b4bd39b644bf46533db9be1d5ab119cdd6d6a0b2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32351) Introduce base interfaces for call procedure

2023-06-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32351: --- Labels: pull-request-available (was: ) > Introduce base interfaces for call procedure >

[GitHub] [flink] luoyuxia opened a new pull request, #22821: [FLINK-32351][table] Introduce base interfaces for call procedure

2023-06-18 Thread via GitHub
luoyuxia opened a new pull request, #22821: URL: https://github.com/apache/flink/pull/22821 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] flinkbot commented on pull request #22820: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-18 Thread via GitHub
flinkbot commented on PR #22820: URL: https://github.com/apache/flink/pull/22820#issuecomment-1596418228 ## CI report: * f44931f66bdfc9ec6e141f4185982980038b445c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] LadyForest commented on pull request #22818: [FLINK-31956][table] Extend COMPILE AND EXECUTE PLAN statement to read/write from/to Flink FileSystem

2023-06-18 Thread via GitHub
LadyForest commented on PR #22818: URL: https://github.com/apache/flink/pull/22818#issuecomment-1596414747 Should rebase master after https://github.com/apache/flink/pull/22820 merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (FLINK-32374) ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32374: --- Labels: pull-request-available (was: ) > ExecNodeGraphInternalPlan#writeToFile should

[GitHub] [flink] LadyForest opened a new pull request, #22820: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-18 Thread via GitHub
LadyForest opened a new pull request, #22820: URL: https://github.com/apache/flink/pull/22820 ## What is the purpose of the change This PR fixes the issue that `COMPILED PLAN` statement may generate invalid JSON when overwriting the existing JSON with a shorter version. ##

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #22721: [FLINK-27243][table] Support SHOW PARTITIONS statement for partitioned table

2023-06-18 Thread via GitHub
ruanhang1993 commented on code in PR #22721: URL: https://github.com/apache/flink/pull/22721#discussion_r1233467048 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowPartitionsOperation.java: ## @@ -66,10 +66,6 @@ public

[jira] [Commented] (FLINK-20628) Port RabbitMQ Sources to FLIP-27 API

2023-06-18 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733990#comment-17733990 ] RocMarshal commented on FLINK-20628: Hi, [pscls|https://github.com/pscls] Thank you very much for

[jira] [Updated] (FLINK-32332) Jar files for catalog function are not listed correctly

2023-06-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32332: --- Labels: pull-request-available (was: ) > Jar files for catalog function are not listed

[GitHub] [flink] flinkbot commented on pull request #22819: [FLINK-32370][client] Fix warn log in result fetcher when job is finished

2023-06-18 Thread via GitHub
flinkbot commented on PR #22819: URL: https://github.com/apache/flink/pull/22819#issuecomment-1596392637 ## CI report: * 41b9ce75fe99467f82f22563d064d209daa64e46 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-31721) Move JobStatusHook to flink-core module

2023-06-18 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-31721. Fix Version/s: 1.18.0 Resolution: Fixed master: fa94fb5a0271590c89edf6f3c0d4f274cf995e7d > Move

[jira] [Updated] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32370: --- Labels: pull-request-available (was: ) > JDBC SQl gateway e2e test is unstable >

[GitHub] [flink] FangYongs opened a new pull request, #22819: [FLINK-32370][client] Fix warn log in result fetcher when job is finished

2023-06-18 Thread via GitHub
FangYongs opened a new pull request, #22819: URL: https://github.com/apache/flink/pull/22819 ## What is the purpose of the change This PR aims to fix warn log in result fetcher when job is finished which should log debug log in fetcher. ## Brief change log - Use

[GitHub] [flink] fredia commented on pull request #22799: [FLINK-25872][state/changelog] Hotfix! Fix the description of Changel…

2023-06-18 Thread via GitHub
fredia commented on PR #22799: URL: https://github.com/apache/flink/pull/22799#issuecomment-1596386751 @reswqa Thanks for the review and suggestion, I amended the commit message as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Reopened] (FLINK-32361) error after replace dependent jar file

2023-06-18 Thread Spongebob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Spongebob reopened FLINK-32361: --- Hi [~Adhip] yes I think this is a bug so I report this issue here. > error after replace dependent jar

[jira] [Comment Edited] (FLINK-32361) error after replace dependent jar file

2023-06-18 Thread Spongebob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733980#comment-17733980 ] Spongebob edited comment on FLINK-32361 at 6/19/23 1:57 AM: Hi [~mapohl] yes

[jira] [Assigned] (FLINK-32374) ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-18 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-32374: Assignee: Jane Chan > ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for

[jira] [Updated] (FLINK-32374) ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-18 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-32374: -- Description: If the existing JSON plan is not truncated when overwriting, and the newly generated

[jira] [Created] (FLINK-32374) ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-18 Thread Jane Chan (Jira)
Jane Chan created FLINK-32374: - Summary: ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting Key: FLINK-32374 URL: https://issues.apache.org/jira/browse/FLINK-32374

[jira] [Commented] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-18 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733975#comment-17733975 ] Fang Yong commented on FLINK-32370: --- Thanks [~chesnay], I'll look at it and try to fix it :) > JDBC

[jira] [Commented] (FLINK-32319) flink can't the partition of network after restart

2023-06-18 Thread wgcn (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733968#comment-17733968 ] wgcn commented on FLINK-32319: -- It work after I increase "taskmanager.memory.network",but I'm not sure why

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

2023-06-18 Thread via GitHub
snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1233372251 ## flink-table/flink-sql-jdbc-driver/pom.xml: ## @@ -84,6 +84,12 @@ ${project.version} test +

[GitHub] [flink] zhuzhurk commented on a diff in pull request #22798: [FLINK-32288][runtime] Improve the scheduling performance of AdaptiveBatchScheduler

2023-06-18 Thread via GitHub
zhuzhurk commented on code in PR #22798: URL: https://github.com/apache/flink/pull/22798#discussion_r122596 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/DefaultInputConsumableDecider.java: ## @@ -65,6 +65,18 @@ public boolean isInputConsumable(

[GitHub] [flink] zhuzhurk commented on a diff in pull request #22798: [FLINK-32288][runtime] Improve the scheduling performance of AdaptiveBatchScheduler

2023-06-18 Thread via GitHub
zhuzhurk commented on code in PR #22798: URL: https://github.com/apache/flink/pull/22798#discussion_r122596 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/DefaultInputConsumableDecider.java: ## @@ -65,6 +65,18 @@ public boolean isInputConsumable(

[GitHub] [flink] lsyldliu commented on pull request #22734: [FLINK-32277][table-runtime] Introduce the basic operator fusion codegen framework

2023-06-18 Thread via GitHub
lsyldliu commented on PR #22734: URL: https://github.com/apache/flink/pull/22734#issuecomment-1596184352 > The table module is failed, could you have a check? Let me take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] gaoyunhaii closed pull request #22344: [FLINK-31721][core] Move JobStatusHook to flink-core module

2023-06-18 Thread via GitHub
gaoyunhaii closed pull request #22344: [FLINK-31721][core] Move JobStatusHook to flink-core module URL: https://github.com/apache/flink/pull/22344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] zhougit86 commented on pull request #22624: [FLINK-32132][table-planner] Cast function CODEGEN does not work as e…

2023-06-18 Thread via GitHub
zhougit86 commented on PR #22624: URL: https://github.com/apache/flink/pull/22624#issuecomment-1596157634 > @zhougit86 Thanks for contribution. But i'm still trying to understand what's the problem and why your changes can fix it. Could you please provide a reproducible case so that I can

[jira] [Commented] (FLINK-28620) SQL Client doesn't properly print values of INTERVAL type

2023-06-18 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733900#comment-17733900 ] Sergey Nuyanzin commented on FLINK-28620: - [~jark] it looks like it was fixed at some  point of

[jira] [Commented] (FLINK-17224) Precision of TIME type does not work correctly

2023-06-18 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733897#comment-17733897 ] Sergey Nuyanzin commented on FLINK-17224: - [~dwysakowicz], [~jark]  I have it supportedincluding

[GitHub] [flink] xintongsong commented on a diff in pull request #22804: [FLINK-31644][network] Implement the disk tier producer for the tiered storage

2023-06-18 Thread via GitHub
xintongsong commented on code in PR #22804: URL: https://github.com/apache/flink/pull/22804#discussion_r1233232708 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/file/SegmentNettyPayload.java: ## @@ -0,0 +1,55 @@ +/* + *

[GitHub] [flink] xintongsong commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-18 Thread via GitHub
xintongsong commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1233228687 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageConsumerClient.java: ## @@ -43,8 +68,25 @@ public