[GitHub] [flink] X-czh commented on pull request #23302: [FLINK-32848][tests][JUnit5 migration] Migrate flink-runtime/shuffle tests to JUnit5

2023-09-13 Thread via GitHub
X-czh commented on PR #23302: URL: https://github.com/apache/flink/pull/23302#issuecomment-1718807193 Hi @FangYongs, could you help check the change when you are free? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Closed] (FLINK-33066) Enable to inject environment variable from secret/configmap to operatorPod

2023-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-33066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-33066. -- Fix Version/s: kubernetes-operator-1.7.0 Resolution: Fixed 1053e26 in main > Enable

[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #671: [FLINK-33066] Support all k8s methods to configure env variable in operatorPod

2023-09-13 Thread via GitHub
mbalassi merged PR #671: URL: https://github.com/apache/flink-kubernetes-operator/pull/671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-33051) GlobalFailureHandler interface should be retired in favor of LabeledGlobalFailureHandler

2023-09-13 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong reassigned FLINK-33051: - Assignee: Matt Wang > GlobalFailureHandler interface should be retired in favor of >

[jira] [Commented] (FLINK-33051) GlobalFailureHandler interface should be retired in favor of LabeledGlobalFailureHandler

2023-09-13 Thread Matt Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764970#comment-17764970 ] Matt Wang commented on FLINK-33051: --- [~pgaref] got it, i will take it > GlobalFailureHandler

[jira] [Commented] (FLINK-33051) GlobalFailureHandler interface should be retired in favor of LabeledGlobalFailureHandler

2023-09-13 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764964#comment-17764964 ] Panagiotis Garefalakis commented on FLINK-33051: [~wangm92]  – not sure I am going to

[GitHub] [flink] swuferhong commented on a diff in pull request #23412: [FLINK-33083] Properly apply ReadingMetadataSpec for a TableSourceScan

2023-09-13 Thread via GitHub
swuferhong commented on code in PR #23412: URL: https://github.com/apache/flink/pull/23412#discussion_r1325238554 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/DynamicTableSourceSpec.java: ## @@ -95,29 +92,19 @@ private

[GitHub] [flink] swuferhong commented on a diff in pull request #23412: [FLINK-33083] Properly apply ReadingMetadataSpec for a TableSourceScan

2023-09-13 Thread via GitHub
swuferhong commented on code in PR #23412: URL: https://github.com/apache/flink/pull/23412#discussion_r1325320081 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/DynamicTableSourceSpec.java: ## @@ -95,29 +92,19 @@ private

[GitHub] [flink-ml] zhaozijun109 commented on pull request #255: [FLINK-33003] Support isolation forest algorithm in Flink ML ([fix] related ListStateWithCache)

2023-09-13 Thread via GitHub
zhaozijun109 commented on PR #255: URL: https://github.com/apache/flink-ml/pull/255#issuecomment-1718703862 @lindong28 Hi, could you please Re-run triggered it? Because the failures( Error: BoundedPerRoundStreamIterationITCase.testPerRoundIterationWithState:170 expected:<3> but was:<4>

[jira] [Assigned] (FLINK-25593) A redundant scan could be skipped if it is an input of join and the other input is empty after partition prune

2023-09-13 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-25593: Assignee: Yunhong Zheng (was: luoyuxia) > A redundant scan could be skipped if it is an input

[jira] [Commented] (FLINK-25593) A redundant scan could be skipped if it is an input of join and the other input is empty after partition prune

2023-09-13 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764951#comment-17764951 ] Yunhong Zheng commented on FLINK-25593: --- Hi, [~jark] . I think the better final plan of this case

[jira] [Commented] (FLINK-33053) Watcher leak in Zookeeper HA mode

2023-09-13 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764950#comment-17764950 ] Zili Chen commented on FLINK-33053: --- But it's possible to add an option to explicitly identify the

[jira] [Commented] (FLINK-25593) A redundant scan could be skipped if it is an input of join and the other input is empty after partition prune

2023-09-13 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764949#comment-17764949 ] Yunhong Zheng commented on FLINK-25593: --- Hi, [~luoyuxia] .Is this still in progress? If not, could

[jira] [Commented] (FLINK-33053) Watcher leak in Zookeeper HA mode

2023-09-13 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764948#comment-17764948 ] Zili Chen commented on FLINK-33053: --- No. Both {{CuratorCache}} and {{TreeCache}} doesn't "own" the

[jira] [Closed] (FLINK-32863) Improve Flink UI's time precision from second level to millisecond level

2023-09-13 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo closed FLINK-32863. -- Fix Version/s: 1.19.0 Resolution: Fixed > Improve Flink UI's time precision from second level

[jira] [Commented] (FLINK-32863) Improve Flink UI's time precision from second level to millisecond level

2023-09-13 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764946#comment-17764946 ] Yangze Guo commented on FLINK-32863: master: 2d74260f41275add3c16ea72ee4ecedbec45f9d4 > Improve

[jira] [Commented] (FLINK-32925) Select executing Release Manager

2023-09-13 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764945#comment-17764945 ] Qingsheng Ren commented on FLINK-32925: --- Jing's public key has been published:

[jira] [Assigned] (FLINK-32925) Select executing Release Manager

2023-09-13 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-32925: - Assignee: Jing Ge > Select executing Release Manager >

[jira] [Resolved] (FLINK-32802) Release Testing: Verify FLIP-291: Externalized Declarative Resource Management

2023-09-13 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-32802. --- Resolution: Done > Release Testing: Verify FLIP-291: Externalized Declarative Resource

[jira] [Resolved] (FLINK-32726) [Umbrella] Test Flink Release 1.18

2023-09-13 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-32726. --- Resolution: Done > [Umbrella] Test Flink Release 1.18 > --

[jira] [Commented] (FLINK-33053) Watcher leak in Zookeeper HA mode

2023-09-13 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764943#comment-17764943 ] Yangze Guo commented on FLINK-33053: Thanks for the pointer [~tison] . I'd like to add a safetynet

[jira] [Assigned] (FLINK-33053) Watcher leak in Zookeeper HA mode

2023-09-13 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo reassigned FLINK-33053: -- Assignee: Yangze Guo > Watcher leak in Zookeeper HA mode > -

[GitHub] [flink] flinkbot commented on pull request #23413: [FLINK-33086] Protect failure enrichment against unhandled exceptions

2023-09-13 Thread via GitHub
flinkbot commented on PR #23413: URL: https://github.com/apache/flink/pull/23413#issuecomment-1718644833 ## CI report: * b88ee0b7f2f6bb9a9ab8f496d333261434152c61 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] pgaref commented on pull request #23413: [FLINK-33086] Protect failure enrichment against unhandled exceptions

2023-09-13 Thread via GitHub
pgaref commented on PR #23413: URL: https://github.com/apache/flink/pull/23413#issuecomment-1718641984 cc @zentol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (FLINK-33086) Protect failure enrichment against unhandled exceptions

2023-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33086: --- Labels: pull-request-available (was: ) > Protect failure enrichment against unhandled

[GitHub] [flink] pgaref opened a new pull request, #23413: [FLINK-33086] Protect failure enrichment against unhandled exceptions

2023-09-13 Thread via GitHub
pgaref opened a new pull request, #23413: URL: https://github.com/apache/flink/pull/23413 ## What is the purpose of the change https://issues.apache.org/jira/browse/FLINK-33086 ## Brief change log *(for example:)* - *The TaskInfo is stored in the blob

[GitHub] [flink] libenchao commented on pull request #23323: [FLINK-32738][formats] PROTOBUF format supports projection push down

2023-09-13 Thread via GitHub
libenchao commented on PR #23323: URL: https://github.com/apache/flink/pull/23323#issuecomment-1718633599 @maosuhan @ljw-hit Are you interested in reviewing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (FLINK-33086) Protect failure enrichment against unhandled exceptions

2023-09-13 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-33086: --- Description: Existing

[GitHub] [flink] wangzzu commented on pull request #23405: [FLINK-31895] Add End-to-end integration tests for failure labels

2023-09-13 Thread via GitHub
wangzzu commented on PR #23405: URL: https://github.com/apache/flink/pull/23405#issuecomment-1718632460 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-32775) Support yarn.provided.lib.dirs to add parent directory to classpath

2023-09-13 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764937#comment-17764937 ] Yang Wang commented on FLINK-32775: --- Thanks [~argoyal]  for your contribution. > Support

[jira] [Closed] (FLINK-32775) Support yarn.provided.lib.dirs to add parent directory to classpath

2023-09-13 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang closed FLINK-32775. - Resolution: Fixed > Support yarn.provided.lib.dirs to add parent directory to classpath >

[jira] [Updated] (FLINK-32775) Support yarn.provided.lib.dirs to add parent directory to classpath

2023-09-13 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-32775: -- Fix Version/s: 1.19.0 > Support yarn.provided.lib.dirs to add parent directory to classpath >

[jira] [Commented] (FLINK-32775) Support yarn.provided.lib.dirs to add parent directory to classpath

2023-09-13 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764936#comment-17764936 ] Yang Wang commented on FLINK-32775: --- Merged in master via 1f9621806451411af26ccbab5c5342ef3308e219. >

[jira] [Created] (FLINK-33086) Protect failure enrichment against unhandled exceptions

2023-09-13 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-33086: -- Summary: Protect failure enrichment against unhandled exceptions Key: FLINK-33086 URL: https://issues.apache.org/jira/browse/FLINK-33086 Project:

[GitHub] [flink] wangyang0918 merged pull request #23164: [FLINK- 32775]Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-09-13 Thread via GitHub
wangyang0918 merged PR #23164: URL: https://github.com/apache/flink/pull/23164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] pgaref commented on pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded

2023-09-13 Thread via GitHub
pgaref commented on PR #23386: URL: https://github.com/apache/flink/pull/23386#issuecomment-1718622106 > Thanks @pgaref for preparing this PR. I left two comments. Please take a look. Appreciate the review @huwh ! Updated the PR, please let me know what you think -- This is an

[GitHub] [flink] swuferhong commented on a diff in pull request #23412: [FLINK-33083] Properly apply ReadingMetadataSpec for a TableSourceScan

2023-09-13 Thread via GitHub
swuferhong commented on code in PR #23412: URL: https://github.com/apache/flink/pull/23412#discussion_r1325238554 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/DynamicTableSourceSpec.java: ## @@ -95,29 +92,19 @@ private

[jira] [Updated] (FLINK-33052) codespeed and benchmark server is down

2023-09-13 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33052: Summary: codespeed and benchmark server is down (was: codespeed server is down) > codespeed and

[jira] [Updated] (FLINK-32995) TPC-DS end-to-end test fails with chmod: cannot access '../target/generator/dsdgen_linux':

2023-09-13 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32995: --- Labels: stale-critical test-stability (was: test-stability) I am the [Flink Jira

[jira] [Updated] (FLINK-32753) Print JVM flags on AZP

2023-09-13 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32753: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the

[GitHub] [flink-kubernetes-operator] srpraneeth commented on a diff in pull request #670: [FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

2023-09-13 Thread via GitHub
srpraneeth commented on code in PR #670: URL: https://github.com/apache/flink-kubernetes-operator/pull/670#discussion_r1325010706 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java: ## @@ -420,13 +421,24 @@ private

[GitHub] [flink] architgyl commented on pull request #23164: [FLINK- 32775]Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-09-13 Thread via GitHub
architgyl commented on PR #23164: URL: https://github.com/apache/flink/pull/23164#issuecomment-1718211945 > @architgyl Could you please verify this PR in a real YARN cluster whether it solves your original requirement about hive config? After then I will merge this PR. I have

[GitHub] [flink] venkata91 commented on a diff in pull request #23313: [FLINK-20767][table planner] Support filter push down on nested fields

2023-09-13 Thread via GitHub
venkata91 commented on code in PR #23313: URL: https://github.com/apache/flink/pull/23313#discussion_r1324917758 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala: ## @@ -395,9 +397,19 @@ class

[GitHub] [flink] venkata91 commented on a diff in pull request #23313: [FLINK-20767][table planner] Support filter push down on nested fields

2023-09-13 Thread via GitHub
venkata91 commented on code in PR #23313: URL: https://github.com/apache/flink/pull/23313#discussion_r1324916866 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala: ## @@ -395,9 +397,19 @@ class

[GitHub] [flink] venkata91 commented on a diff in pull request #23313: [FLINK-20767][table planner] Support filter push down on nested fields

2023-09-13 Thread via GitHub
venkata91 commented on code in PR #23313: URL: https://github.com/apache/flink/pull/23313#discussion_r1324893510 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala: ## @@ -538,8 +550,34 @@ class

[GitHub] [flink] venkata91 commented on a diff in pull request #23313: [FLINK-20767][table planner] Support filter push down on nested fields

2023-09-13 Thread via GitHub
venkata91 commented on code in PR #23313: URL: https://github.com/apache/flink/pull/23313#discussion_r1324865286 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/rules/logical/PushFilterIntoTableSourceScanRuleTest.java: ## @@ -118,4 +151,34

[GitHub] [flink] mxm commented on a diff in pull request #23406: [FLINK-32884] [flink-clients] PyFlink remote execution should support URLs with paths and https scheme

2023-09-13 Thread via GitHub
mxm commented on code in PR #23406: URL: https://github.com/apache/flink/pull/23406#discussion_r1324778392 ## flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java: ## @@ -80,6 +80,23 @@ public class RestOptions { .withDescription(

[jira] [Resolved] (FLINK-33029) Drop python 3.7 support

2023-09-13 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi resolved FLINK-33029. --- Resolution: Fixed 50cb4ee on master > Drop python 3.7 support > --- >

[jira] [Closed] (FLINK-33029) Drop python 3.7 support

2023-09-13 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-33029. - > Drop python 3.7 support > --- > > Key: FLINK-33029 >

[jira] [Updated] (FLINK-33029) Drop python 3.7 support

2023-09-13 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi updated FLINK-33029: -- Fix Version/s: 1.19.0 > Drop python 3.7 support > --- > >

[GitHub] [flink] gaborgsomogyi merged pull request #23359: [FLINK-33029][python] Drop python 3.7 support

2023-09-13 Thread via GitHub
gaborgsomogyi merged PR #23359: URL: https://github.com/apache/flink/pull/23359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33018) GCP Pubsub PubSubConsumingTest.testStoppingConnectorWhenDeserializationSchemaIndicatesEndOfStream failed

2023-09-13 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764749#comment-17764749 ] Ryan Skraba commented on FLINK-33018: - I don't think this JIRA is necessarily a blocker -- it looks

[GitHub] [flink] becketqin commented on a diff in pull request #23313: [FLINK-20767][table planner] Support filter push down on nested fields

2023-09-13 Thread via GitHub
becketqin commented on code in PR #23313: URL: https://github.com/apache/flink/pull/23313#discussion_r1324619744 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala: ## @@ -538,8 +550,34 @@ class

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #672: [FLINK-33081] Apply parallelism overrides in scale

2023-09-13 Thread via GitHub
gyfora commented on code in PR #672: URL: https://github.com/apache/flink-kubernetes-operator/pull/672#discussion_r1324638095 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java: ## @@ -74,6 +76,36 @@

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #672: [FLINK-33081] Apply parallelism overrides in scale

2023-09-13 Thread via GitHub
gyfora commented on code in PR #672: URL: https://github.com/apache/flink-kubernetes-operator/pull/672#discussion_r1324635598 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java: ## @@ -140,86 +171,73 @@

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #672: [FLINK-33081] Apply parallelism overrides in scale

2023-09-13 Thread via GitHub
gyfora commented on code in PR #672: URL: https://github.com/apache/flink-kubernetes-operator/pull/672#discussion_r1324633942 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java: ## @@ -74,6 +76,36 @@

[GitHub] [flink-kubernetes-operator] sbrother commented on pull request #668: Give cluster/job role access to k8s services API

2023-09-13 Thread via GitHub
sbrother commented on PR #668: URL: https://github.com/apache/flink-kubernetes-operator/pull/668#issuecomment-1717779633 No problem, I just requested an Apache Jira account. And yes, I think that's what I mean. I had created a Flink Session Controller using a basic FlinkDeployment

[jira] [Commented] (FLINK-33053) Watcher leak in Zookeeper HA mode

2023-09-13 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764723#comment-17764723 ] Zili Chen commented on FLINK-33053: --- But we don't have other shared watchers so we can force remove

[jira] [Commented] (FLINK-33053) Watcher leak in Zookeeper HA mode

2023-09-13 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764721#comment-17764721 ] Zili Chen commented on FLINK-33053: --- See

[GitHub] [flink] flinkbot commented on pull request #23412: [FLINK-33083] Properly apply ReadingMetadataSpec for a TableSourceScan

2023-09-13 Thread via GitHub
flinkbot commented on PR #23412: URL: https://github.com/apache/flink/pull/23412#issuecomment-1717739419 ## CI report: * 75b651538a1fa083c211ab8c4020822590b89043 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33083) SupportsReadingMetadata is not applied when loading a CompiledPlan

2023-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33083: --- Labels: pull-request-available (was: ) > SupportsReadingMetadata is not applied when

[GitHub] [flink] dawidwys opened a new pull request, #23412: [FLINK-33083] Properly apply ReadingMetadataSpec for a TableSourceScan

2023-09-13 Thread via GitHub
dawidwys opened a new pull request, #23412: URL: https://github.com/apache/flink/pull/23412 ## What is the purpose of the change The PR fixes creating a TableSourceScan to also include a proper ReadingMetadataSpec which has been applied on the source. ## Brief change log

[jira] [Comment Edited] (FLINK-33052) codespeed server is down

2023-09-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764675#comment-17764675 ] Yuan Mei edited comment on FLINK-33052 at 9/13/23 2:14 PM: --- Hey [~pnowojski] 

[jira] [Commented] (FLINK-33053) Watcher leak in Zookeeper HA mode

2023-09-13 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764702#comment-17764702 ] Zili Chen commented on FLINK-33053: --- I noticed that the {{TreeCache}}'s close call {{removeWatches}}

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #672: [FLINK-33081] Apply parallelism overrides in scale

2023-09-13 Thread via GitHub
mxm commented on code in PR #672: URL: https://github.com/apache/flink-kubernetes-operator/pull/672#discussion_r1324308777 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java: ## @@ -74,6 +76,36 @@ public

[jira] [Comment Edited] (FLINK-33052) codespeed server is down

2023-09-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764675#comment-17764675 ] Yuan Mei edited comment on FLINK-33052 at 9/13/23 1:44 PM: --- Hey [~pnowojski] 

[jira] [Comment Edited] (FLINK-33052) codespeed server is down

2023-09-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764675#comment-17764675 ] Yuan Mei edited comment on FLINK-33052 at 9/13/23 1:41 PM: --- Hey [~pnowojski] 

[jira] [Comment Edited] (FLINK-33052) codespeed server is down

2023-09-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764675#comment-17764675 ] Yuan Mei edited comment on FLINK-33052 at 9/13/23 1:39 PM: --- Hey [~pnowojski] 

[jira] [Comment Edited] (FLINK-33052) codespeed server is down

2023-09-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764675#comment-17764675 ] Yuan Mei edited comment on FLINK-33052 at 9/13/23 1:35 PM: --- Hey [~pnowojski] 

[jira] [Comment Edited] (FLINK-33052) codespeed server is down

2023-09-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764675#comment-17764675 ] Yuan Mei edited comment on FLINK-33052 at 9/13/23 1:35 PM: --- Hey [~pnowojski] 

[jira] [Updated] (FLINK-28758) FlinkKafkaConsumer fails to stop with savepoint

2023-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28758: --- Labels: pull-request-available (was: ) > FlinkKafkaConsumer fails to stop with savepoint

[GitHub] [flink-connector-kafka] boring-cyborg[bot] commented on pull request #48: [FLINK-28758] Fix stop-with-savepoint for FlinkKafkaConsumer

2023-09-13 Thread via GitHub
boring-cyborg[bot] commented on PR #48: URL: https://github.com/apache/flink-connector-kafka/pull/48#issuecomment-1717647945 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[jira] [Comment Edited] (FLINK-33052) codespeed server is down

2023-09-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764675#comment-17764675 ] Yuan Mei edited comment on FLINK-33052 at 9/13/23 1:31 PM: --- Hey [~pnowojski] 

[jira] [Comment Edited] (FLINK-33052) codespeed server is down

2023-09-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764675#comment-17764675 ] Yuan Mei edited comment on FLINK-33052 at 9/13/23 1:31 PM: --- Hey [~pnowojski] 

[jira] [Comment Edited] (FLINK-33052) codespeed server is down

2023-09-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764675#comment-17764675 ] Yuan Mei edited comment on FLINK-33052 at 9/13/23 1:31 PM: --- Hey [~pnowojski] 

[jira] [Comment Edited] (FLINK-33052) codespeed server is down

2023-09-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764675#comment-17764675 ] Yuan Mei edited comment on FLINK-33052 at 9/13/23 1:30 PM: --- Hey [~pnowojski] 

[jira] [Commented] (FLINK-33052) codespeed server is down

2023-09-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764675#comment-17764675 ] Yuan Mei commented on FLINK-33052: -- # I think this issue is very critical as you mentioned # Since

[jira] [Commented] (FLINK-31966) Flink Kubernetes operator lacks TLS support

2023-09-13 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764674#comment-17764674 ] Gyula Fora commented on FLINK-31966: [~tagarr] I think that sounds reasonable. I think this would

[jira] [Assigned] (FLINK-28758) FlinkKafkaConsumer fails to stop with savepoint

2023-09-13 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-28758: -- Assignee: Piotr Nowojski (was: Mark Cho) > FlinkKafkaConsumer fails to stop with

[jira] [Commented] (FLINK-28758) FlinkKafkaConsumer fails to stop with savepoint

2023-09-13 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764673#comment-17764673 ] Piotr Nowojski commented on FLINK-28758: I will try to take care of that > FlinkKafkaConsumer

[jira] [Assigned] (FLINK-33083) SupportsReadingMetadata is not applied when loading a CompiledPlan

2023-09-13 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reassigned FLINK-33083: Assignee: Dawid Wysakowicz > SupportsReadingMetadata is not applied when loading

[jira] [Commented] (FLINK-33083) SupportsReadingMetadata is not applied when loading a CompiledPlan

2023-09-13 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764666#comment-17764666 ] Yunhong Zheng commented on FLINK-33083: --- It looks like this is a planner bug, and we don't have

[GitHub] [flink] flinkbot commented on pull request #23411: [FLINK-21949][table] Support ARRAY_AGG aggregate function

2023-09-13 Thread via GitHub
flinkbot commented on PR #23411: URL: https://github.com/apache/flink/pull/23411#issuecomment-1717597767 ## CI report: * 10081ad9bdba84b3dac22fb7a6137994cc79622b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-21949) Support ARRAY_AGG aggregate function

2023-09-13 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764658#comment-17764658 ] Jiabao Sun commented on FLINK-21949: The pull request is ready for review now. This implementation

[jira] [Updated] (FLINK-21949) Support ARRAY_AGG aggregate function

2023-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21949: --- Labels: pull-request-available (was: ) > Support ARRAY_AGG aggregate function >

[GitHub] [flink] Jiabao-Sun opened a new pull request, #23411: [FLINK-21949][table] Support ARRAY_AGG aggregate function

2023-09-13 Thread via GitHub
Jiabao-Sun opened a new pull request, #23411: URL: https://github.com/apache/flink/pull/23411 ## What is the purpose of the change [FLINK-21949][table] Support ARRAY_AGG aggregate function Some nosql databases like mongodb and elasticsearch support nested data types.

[jira] [Closed] (FLINK-32704) Supports spilling to disk when feedback channel memory buffer is full

2023-09-13 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin closed FLINK-32704. Resolution: Fixed > Supports spilling to disk when feedback channel memory buffer is full >

[GitHub] [flink] hejufang commented on pull request #23403: [FLINK-32863][runtime-web] Improve Flink UI's time precision from sec…

2023-09-13 Thread via GitHub
hejufang commented on PR #23403: URL: https://github.com/apache/flink/pull/23403#issuecomment-1717554816 @masteryhx Thank you for your suggestion. I have adjusted the precision of checkpoint related time. please review. cc @KarmaGYZ

[GitHub] [flink-kubernetes-operator] dongwoo6kim commented on pull request #671: [FLINK-33066] Support all k8s methods to configure env variable in operatorPod

2023-09-13 Thread via GitHub
dongwoo6kim commented on PR #671: URL: https://github.com/apache/flink-kubernetes-operator/pull/671#issuecomment-1717548787 Thanks @mbalassi. I have updated the docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-33053) Watcher leak in Zookeeper HA mode

2023-09-13 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764640#comment-17764640 ] Yangze Guo commented on FLINK-33053: JFYI, I'm still investigating the root cause of this, but I

[GitHub] [flink] flinkbot commented on pull request #23410: [FLINK-33085][table-planner] Improve the error message when the invalidated lookupTableSource without primary key is used as temporal join t

2023-09-13 Thread via GitHub
flinkbot commented on PR #23410: URL: https://github.com/apache/flink/pull/23410#issuecomment-1717541375 ## CI report: * a5f93f4153d0b8430d836a35a6f79b80caa76457 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-32704) Supports spilling to disk when feedback channel memory buffer is full

2023-09-13 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764635#comment-17764635 ] Dong Lin commented on FLINK-32704: -- Merged to apache/flink-ml master branch

[jira] [Assigned] (FLINK-32704) Supports spilling to disk when feedback channel memory buffer is full

2023-09-13 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-32704: Assignee: Jiang Xin > Supports spilling to disk when feedback channel memory buffer is full >

[GitHub] [flink-ml] lindong28 merged pull request #248: [FLINK-32704] Supports spilling to disk when feedback channel memory buffer is full

2023-09-13 Thread via GitHub
lindong28 merged PR #248: URL: https://github.com/apache/flink-ml/pull/248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-ml] lindong28 commented on pull request #248: [FLINK-32704] Supports spilling to disk when feedback channel memory buffer is full

2023-09-13 Thread via GitHub
lindong28 commented on PR #248: URL: https://github.com/apache/flink-ml/pull/248#issuecomment-1717534003 Thanks for the update! LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-33085) Improve the error message when the invalidate lookupTableSource without primary key is used as temporal join table

2023-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33085: --- Labels: pull-request-available (was: ) > Improve the error message when the invalidate

[GitHub] [flink] swuferhong opened a new pull request, #23410: [FLINK-33085][table-planner] Improve the error message when the invalidated lookupTableSource without primary key is used as temporal joi

2023-09-13 Thread via GitHub
swuferhong opened a new pull request, #23410: URL: https://github.com/apache/flink/pull/23410 ## What is the purpose of the change Improve the error message when the invalidate `lookupTableSource` without primary key is used as temporal join table. This pr can check the

[jira] [Closed] (FLINK-33011) Operator deletes HA data unexpectedly

2023-09-13 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33011. -- Fix Version/s: kubernetes-operator-1.7.0 Resolution: Fixed merged to main

[jira] [Created] (FLINK-33085) Improve the error message when the invalidate lookupTableSource without primary key is used as temporal join table

2023-09-13 Thread Yunhong Zheng (Jira)
Yunhong Zheng created FLINK-33085: - Summary: Improve the error message when the invalidate lookupTableSource without primary key is used as temporal join table Key: FLINK-33085 URL:

[jira] [Updated] (FLINK-21949) Support ARRAY_AGG aggregate function

2023-09-13 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun updated FLINK-21949: --- Summary: Support ARRAY_AGG aggregate function (was: Support collect to array aggregate function)

  1   2   >