Re: [PR] [FLINK-32853][runtime][JUnit5 Migration] The security, taskmanager an… [flink]

2023-10-12 Thread via GitHub
zhangyy91 commented on code in PR #23265: URL: https://github.com/apache/flink/pull/23265#discussion_r1357750511 ## flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerLocationTest.java: ## @@ -38,57 +38,61 @@ class TaskManagerLocationTest { @Test

Re: [PR] [FLINK-33171][table planner] Table SQL support Not Equal for TimePoint type and TimeString [flink]

2023-10-12 Thread via GitHub
lincoln-lil commented on code in PR #23478: URL: https://github.com/apache/flink/pull/23478#discussion_r1357746002 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala: ## @@ -488,6 +488,18 @@ object

[jira] [Commented] (FLINK-33052) codespeed and benchmark server is down

2023-10-12 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774779#comment-17774779 ] Yuan Mei commented on FLINK-33052: -- As the pipeline has been running daily, and the reported results

[jira] [Comment Edited] (FLINK-33052) codespeed and benchmark server is down

2023-10-12 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774779#comment-17774779 ] Yuan Mei edited comment on FLINK-33052 at 10/13/23 4:19 AM: As the pipeline

Re: [PR] [FLINK-33060] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-10-12 Thread via GitHub
Zakelly commented on PR #23441: URL: https://github.com/apache/flink/pull/23441#issuecomment-1760742148 > I suggest a cleaner approach with the interfaces. I remove the description for ListState in the base interface. -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-33060] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-10-12 Thread via GitHub
Zakelly commented on PR #23441: URL: https://github.com/apache/flink/pull/23441#issuecomment-1760741020 > Thanks for the pr! Changes about these comments LGTM. But I found some implementaion is not consistent. (See PartitionableListState#update,

[jira] [Assigned] (FLINK-33266) Support plan cache for SQL jobs

2023-10-12 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-33266: -- Assignee: Dan Zou > Support plan cache for SQL jobs > --- > >

[jira] [Assigned] (FLINK-33267) Support PreparedStatement in JDBC Driver

2023-10-12 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-33267: -- Assignee: Dan Zou > Support PreparedStatement in JDBC Driver >

[jira] [Assigned] (FLINK-33267) Support PreparedStatement in JDBC Driver

2023-10-12 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-33267: -- Assignee: Dan Zou (was: Dan Zou) > Support PreparedStatement in JDBC Driver >

Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]

2023-10-12 Thread via GitHub
bvarghese1 commented on code in PR #23491: URL: https://github.com/apache/flink/pull/23491#discussion_r1357730455 ## flink-architecture-tests/flink-architecture-tests-base/src/test/java/PredicatesTest.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]

2023-10-12 Thread via GitHub
bvarghese1 commented on code in PR #23491: URL: https://github.com/apache/flink/pull/23491#discussion_r1357730243 ## flink-architecture-tests/flink-architecture-tests-base/src/test/java/PredicatesTest.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-33041][docs] Add an article to guide users to migrate their DataSet jobs to DataStream [flink]

2023-10-12 Thread via GitHub
WencongLiu commented on PR #23362: URL: https://github.com/apache/flink/pull/23362#issuecomment-1760715029 Thanks for the careful review of @yunfengzhou-hub . I've updated a round of changes. Please take a look when you have time.  -- This is an automated message from the Apache Git

Re: [PR] [FLINK-33041][docs] Add an article to guide users to migrate their DataSet jobs to DataStream [flink]

2023-10-12 Thread via GitHub
WencongLiu commented on code in PR #23362: URL: https://github.com/apache/flink/pull/23362#discussion_r1357723514 ## docs/content/docs/dev/datastream/dataset_migration.md: ## @@ -0,0 +1,699 @@ +--- +title: "How To Migrate From DataSet to DataStream" +weight: 302 +type: docs

Re: [PR] [FLINK-33041][docs] Add an article to guide users to migrate their DataSet jobs to DataStream [flink]

2023-10-12 Thread via GitHub
WencongLiu commented on code in PR #23362: URL: https://github.com/apache/flink/pull/23362#discussion_r1357722446 ## docs/content/docs/dev/datastream/dataset_migration.md: ## @@ -0,0 +1,699 @@ +--- +title: "How To Migrate From DataSet to DataStream" +weight: 302 +type: docs

[jira] [Created] (FLINK-33267) Support PreparedStatement in JDBC Driver

2023-10-12 Thread Dan Zou (Jira)
Dan Zou created FLINK-33267: --- Summary: Support PreparedStatement in JDBC Driver Key: FLINK-33267 URL: https://issues.apache.org/jira/browse/FLINK-33267 Project: Flink Issue Type: New Feature

Re: [PR] [FLINK-33041][docs] Add an article to guide users to migrate their DataSet jobs to DataStream [flink]

2023-10-12 Thread via GitHub
WencongLiu commented on code in PR #23362: URL: https://github.com/apache/flink/pull/23362#discussion_r1357722046 ## docs/content/docs/dev/datastream/dataset_migration.md: ## @@ -0,0 +1,699 @@ +--- +title: "How To Migrate From DataSet to DataStream" +weight: 302 +type: docs

Re: [PR] [FLINK-33041][docs] Add an article to guide users to migrate their DataSet jobs to DataStream [flink]

2023-10-12 Thread via GitHub
WencongLiu commented on code in PR #23362: URL: https://github.com/apache/flink/pull/23362#discussion_r1357721747 ## docs/content/docs/dev/datastream/dataset_migration.md: ## @@ -0,0 +1,699 @@ +--- +title: "How To Migrate From DataSet to DataStream" +weight: 302 +type: docs

Re: [PR] [FLINK-33041][docs] Add an article to guide users to migrate their DataSet jobs to DataStream [flink]

2023-10-12 Thread via GitHub
WencongLiu commented on code in PR #23362: URL: https://github.com/apache/flink/pull/23362#discussion_r1357721372 ## docs/content/docs/dev/datastream/dataset_migration.md: ## @@ -0,0 +1,699 @@ +--- +title: "How To Migrate From DataSet to DataStream" +weight: 302 +type: docs

Re: [PR] [FLINK-33041][docs] Add an article to guide users to migrate their DataSet jobs to DataStream [flink]

2023-10-12 Thread via GitHub
WencongLiu commented on code in PR #23362: URL: https://github.com/apache/flink/pull/23362#discussion_r1357720771 ## docs/content/docs/dev/datastream/dataset_migration.md: ## @@ -0,0 +1,699 @@ +--- +title: "How To Migrate From DataSet to DataStream" +weight: 302 +type: docs

Re: [PR] [FLINK-33041][docs] Add an article to guide users to migrate their DataSet jobs to DataStream [flink]

2023-10-12 Thread via GitHub
WencongLiu commented on code in PR #23362: URL: https://github.com/apache/flink/pull/23362#discussion_r1357718475 ## docs/content/docs/dev/datastream/dataset_migration.md: ## @@ -0,0 +1,699 @@ +--- +title: "How To Migrate From DataSet to DataStream" +weight: 302 +type: docs

Re: [PR] [FLINK-33041][docs] Add an article to guide users to migrate their DataSet jobs to DataStream [flink]

2023-10-12 Thread via GitHub
WencongLiu commented on code in PR #23362: URL: https://github.com/apache/flink/pull/23362#discussion_r1357718013 ## docs/content/docs/dev/datastream/dataset_migration.md: ## @@ -0,0 +1,699 @@ +--- +title: "How To Migrate From DataSet to DataStream" +weight: 302 +type: docs

Re: [PR] [FLINK-33041][docs] Add an article to guide users to migrate their DataSet jobs to DataStream [flink]

2023-10-12 Thread via GitHub
WencongLiu commented on code in PR #23362: URL: https://github.com/apache/flink/pull/23362#discussion_r1357717514 ## docs/content/docs/dev/datastream/dataset_migration.md: ## @@ -0,0 +1,699 @@ +--- +title: "How To Migrate From DataSet to DataStream" +weight: 302 +type: docs

Re: [PR] [FLINK-33041][docs] Add an article to guide users to migrate their DataSet jobs to DataStream [flink]

2023-10-12 Thread via GitHub
WencongLiu commented on code in PR #23362: URL: https://github.com/apache/flink/pull/23362#discussion_r1357717027 ## docs/content/docs/dev/datastream/dataset_migration.md: ## @@ -0,0 +1,699 @@ +--- +title: "How To Migrate From DataSet to DataStream" +weight: 302 +type: docs

[jira] [Created] (FLINK-33266) Support plan cache for SQL jobs

2023-10-12 Thread Dan Zou (Jira)
Dan Zou created FLINK-33266: --- Summary: Support plan cache for SQL jobs Key: FLINK-33266 URL: https://issues.apache.org/jira/browse/FLINK-33266 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-33041][docs] Add an article to guide users to migrate their DataSet jobs to DataStream [flink]

2023-10-12 Thread via GitHub
WencongLiu commented on code in PR #23362: URL: https://github.com/apache/flink/pull/23362#discussion_r1357716450 ## docs/content/docs/dev/datastream/dataset_migration.md: ## @@ -0,0 +1,699 @@ +--- +title: "How To Migrate From DataSet to DataStream" +weight: 302 +type: docs

Re: [PR] [FLINK-33255] [table] Validate argument count during type inference [flink]

2023-10-12 Thread via GitHub
flinkbot commented on PR #23520: URL: https://github.com/apache/flink/pull/23520#issuecomment-1760701170 ## CI report: * 33c4ce7266d1645b5c1c4aab80335bfc0d790438 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33255) Validate argument count during type inference

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33255: --- Labels: pull-request-available (was: ) > Validate argument count during type inference >

[PR] [FLINK-33255] [table] Validate argument count during type inference [flink]

2023-10-12 Thread via GitHub
bvarghese1 opened a new pull request, #23520: URL: https://github.com/apache/flink/pull/23520 - Previously, TypeInferenceOperandInference was not validating argument counts which led to bugs like FLINK-33248 - This commit adds a check to validate argument count and throws an exception

Re: [PR] [FLINK-33097][autoscaler] Initialize the generic autoscaler module and interfaces [flink-kubernetes-operator]

2023-10-12 Thread via GitHub
1996fanrui commented on code in PR #677: URL: https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1355991932 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -166,6 +197,13 @@ private static

Re: [PR] [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler [flink]

2023-10-12 Thread via GitHub
1996fanrui commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1357685699 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java: ## @@ -570,8 +659,9 @@ public void setHowToHandleFailure(Function

[jira] [Updated] (FLINK-33052) codespeed and benchmark server is down

2023-10-12 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei updated FLINK-33052: - Affects Version/s: 1.19.0 (was: 1.18.0) > codespeed and benchmark server is

[jira] [Commented] (FLINK-20539) Type mismatch when using ROW in computed column

2023-10-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774769#comment-17774769 ] lincoln lee commented on FLINK-20539: - [~xuyangzhong] assigned to you, thanks for contributing! >

[jira] [Assigned] (FLINK-20539) Type mismatch when using ROW in computed column

2023-10-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-20539: --- Assignee: xuyang > Type mismatch when using ROW in computed column >

Re: [PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-10-12 Thread via GitHub
flinkbot commented on PR #23519: URL: https://github.com/apache/flink/pull/23519#issuecomment-1760687641 ## CI report: * 4017c6b05eac33e0d805db1d0cf5dc0562f51207 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-20539) Type mismatch when using ROW in computed column

2023-10-12 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774768#comment-17774768 ] xuyang commented on FLINK-20539: The cause is that in Flink, we always treat the ROW as a struct type

[jira] [Updated] (FLINK-20539) Type mismatch when using ROW in computed column

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-20539: --- Labels: auto-unassigned pull-request-available (was: auto-unassigned) > Type mismatch when

[PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-10-12 Thread via GitHub
xuyangzhong opened a new pull request, #23519: URL: https://github.com/apache/flink/pull/23519 ## What is the purpose of the change When using row as a computed column and select the computed column as a query, an exception will be thrown by calcite because of the type mismatch

[PR] [hotfix][docs] Fix scan.bounded.mode missing forward options [flink-connector-kafka]

2023-10-12 Thread via GitHub
Tan-JiaLiang opened a new pull request, #60: URL: https://github.com/apache/flink-connector-kafka/pull/60 1. add `scan.bounded.mode`, `scan.startup.specific-offsets`, `scan.bounded.specific-offsets` into forward options. 2. fix `scan.bounded.mode` docs. -- This is an automated message

[jira] [Updated] (FLINK-33264) Support source parallelism setting for DataGen connector

2023-10-12 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-33264: -- Component/s: Connectors / Parent > Support source parallelism setting for DataGen connector >

[jira] [Created] (FLINK-33265) Support source parallelism setting for Kafka connector

2023-10-12 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-33265: - Summary: Support source parallelism setting for Kafka connector Key: FLINK-33265 URL: https://issues.apache.org/jira/browse/FLINK-33265 Project: Flink

[jira] [Created] (FLINK-33264) Support source parallelism setting for DataGen connector

2023-10-12 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-33264: - Summary: Support source parallelism setting for DataGen connector Key: FLINK-33264 URL: https://issues.apache.org/jira/browse/FLINK-33264 Project: Flink

[jira] [Created] (FLINK-33263) Implement ParallelismProvider for sources in Blink planner

2023-10-12 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-33263: - Summary: Implement ParallelismProvider for sources in Blink planner Key: FLINK-33263 URL: https://issues.apache.org/jira/browse/FLINK-33263 Project: Flink

[jira] [Created] (FLINK-33262) Extend source provider interfaces with the new parallelism provider interface

2023-10-12 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-33262: - Summary: Extend source provider interfaces with the new parallelism provider interface Key: FLINK-33262 URL: https://issues.apache.org/jira/browse/FLINK-33262

[jira] [Created] (FLINK-33261) FLIP-367: Support Setting Parallelism for Table/SQL Sources

2023-10-12 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-33261: - Summary: FLIP-367: Support Setting Parallelism for Table/SQL Sources Key: FLINK-33261 URL: https://issues.apache.org/jira/browse/FLINK-33261 Project: Flink

Re: [PR] [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods [flink]

2023-10-12 Thread via GitHub
afedulov commented on PR #22850: URL: https://github.com/apache/flink/pull/22850#issuecomment-1760525388 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods [flink]

2023-10-12 Thread via GitHub
afedulov commented on PR #22850: URL: https://github.com/apache/flink/pull/22850#issuecomment-1760494158 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-32896][Runtime/Coordination] Incorrect `Map.computeIfAbsent(..., ...::new)` usage which misinterprets key as initial capacity [flink]

2023-10-12 Thread via GitHub
tzy-0x7cf commented on PR #23518: URL: https://github.com/apache/flink/pull/23518#issuecomment-1760385322 @wuchong Can you look at it? I think it's a very simple change : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-32896][Runtime/Coordination] Incorrect `Map.computeIfAbsent(..., ...::new)` usage which misinterprets key as initial capacity [flink]

2023-10-12 Thread via GitHub
tzy-0x7cf commented on PR #23518: URL: https://github.com/apache/flink/pull/23518#issuecomment-1760362681 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-33224) Flink Batch Job does not complete when using Kafka topics with empty partitions

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774683#comment-17774683 ] Martijn Visser commented on FLINK-33224: The Flink community only supports the last two minor

[jira] [Comment Edited] (FLINK-33224) Flink Batch Job does not complete when using Kafka topics with empty partitions

2023-10-12 Thread Kanthi Vaidya (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774672#comment-17774672 ] Kanthi Vaidya edited comment on FLINK-33224 at 10/12/23 7:49 PM: -

[jira] [Commented] (FLINK-33224) Flink Batch Job does not complete when using Kafka topics with empty partitions

2023-10-12 Thread Kanthi Vaidya (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774672#comment-17774672 ] Kanthi Vaidya commented on FLINK-33224: --- [~martijnvisser] I am talking about Apache Flink 1.14.6.

Re: [PR] [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods [flink]

2023-10-12 Thread via GitHub
afedulov commented on code in PR #22850: URL: https://github.com/apache/flink/pull/22850#discussion_r1357296350 ## flink-connectors/flink-connector-datagen-test/pom.xml: ## @@ -0,0 +1,89 @@ + + +http://maven.apache.org/POM/4.0.0; +

Re: [PR] [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods [flink]

2023-10-12 Thread via GitHub
afedulov commented on code in PR #22850: URL: https://github.com/apache/flink/pull/22850#discussion_r1357296350 ## flink-connectors/flink-connector-datagen-test/pom.xml: ## @@ -0,0 +1,89 @@ + + +http://maven.apache.org/POM/4.0.0; +

Re: [PR] [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods [flink]

2023-10-12 Thread via GitHub
afedulov commented on PR #22850: URL: https://github.com/apache/flink/pull/22850#issuecomment-1760234850 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-33260) Custom Error Handling for Kinesis Consumer

2023-10-12 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-33260: -- Fix Version/s: aws-connector-4.2.0 > Custom Error Handling for Kinesis Consumer >

[jira] [Updated] (FLINK-33260) Custom Error Handling for Kinesis Consumer

2023-10-12 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-33260: -- Description: Background The Kinesis Consumer exposes various configuration that allows the

[jira] [Created] (FLINK-33260) Custom Error Handling for Kinesis Consumer

2023-10-12 Thread Danny Cranmer (Jira)
Danny Cranmer created FLINK-33260: - Summary: Custom Error Handling for Kinesis Consumer Key: FLINK-33260 URL: https://issues.apache.org/jira/browse/FLINK-33260 Project: Flink Issue Type:

[jira] [Resolved] (FLINK-29365) Millisecond behind latest jumps after Flink 1.15.2 upgrade

2023-10-12 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-29365. --- Resolution: Cannot Reproduce Resolving as cannot reproduce since this is stale >

[jira] [Commented] (FLINK-32399) Fix flink-sql-connector-kinesis build for maven 3.8.6+

2023-10-12 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774628#comment-17774628 ] Hong Liang Teoh commented on FLINK-32399: - Ah, that's a good call. We will need to make some

[jira] [Created] (FLINK-33259) flink-connector-aws should use/extend the common connector workflow

2023-10-12 Thread Hong Liang Teoh (Jira)
Hong Liang Teoh created FLINK-33259: --- Summary: flink-connector-aws should use/extend the common connector workflow Key: FLINK-33259 URL: https://issues.apache.org/jira/browse/FLINK-33259 Project:

[jira] [Assigned] (FLINK-32399) Fix flink-sql-connector-kinesis build for maven 3.8.6+

2023-10-12 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh reassigned FLINK-32399: --- Assignee: Aleksandr Pilipenko > Fix flink-sql-connector-kinesis build for maven

Re: [PR] [FLINK-32896][Runtime/Coordination] Incorrect `Map.computeIfAbsent(..., ...::new)` usage which misinterprets key as initial capacity [flink]

2023-10-12 Thread via GitHub
flinkbot commented on PR #23518: URL: https://github.com/apache/flink/pull/23518#issuecomment-1760020240 ## CI report: * 1100f6cfe4f94541c93dcc0c288c31cb548bbe62 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32896) Incorrect `Map.computeIfAbsent(..., ...::new)` usage which misinterprets key as initial capacity

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32896: --- Labels: pull-request-available starter (was: starter) > Incorrect

[PR] [FLINK-32896] [Runtime/Coordination] Incorrect `Map.computeIfAbsent(..., ...::new)` usage which misinterprets key as initial capacity [flink]

2023-10-12 Thread via GitHub
tzy-0x7cf opened a new pull request, #23518: URL: https://github.com/apache/flink/pull/23518 ## What is the purpose of the change The are multiple cases in the code which look like this: `map.computeIfAbsent(..., ArrayList::new)` Not only does this create a new

Re: [PR] [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods [flink]

2023-10-12 Thread via GitHub
afedulov commented on PR #22850: URL: https://github.com/apache/flink/pull/22850#issuecomment-1759851532 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] add announcement blog post for Flink 1.18 [flink-web]

2023-10-12 Thread via GitHub
knaufk commented on code in PR #680: URL: https://github.com/apache/flink-web/pull/680#discussion_r1356995521 ## docs/content/posts/2023-10-10-release-1.18.0.md: ## @@ -0,0 +1,542 @@ +--- +authors: +- JingGe: + name: "Jing Ge" + twitter: jingengineer +- KonstantinKnauf: +

Re: [PR] add announcement blog post for Flink 1.18 [flink-web]

2023-10-12 Thread via GitHub
knaufk commented on code in PR #680: URL: https://github.com/apache/flink-web/pull/680#discussion_r1356975072 ## docs/content/posts/2023-10-10-release-1.18.0.md: ## @@ -0,0 +1,542 @@ +--- +authors: +- JingGe: + name: "Jing Ge" + twitter: jingengineer +- KonstantinKnauf: +

Re: [PR] add announcement blog post for Flink 1.18 [flink-web]

2023-10-12 Thread via GitHub
knaufk commented on code in PR #680: URL: https://github.com/apache/flink-web/pull/680#discussion_r1356959254 ## docs/content/posts/2023-10-10-release-1.18.0.md: ## @@ -0,0 +1,542 @@ +--- +authors: +- JingGe: + name: "Jing Ge" + twitter: jingengineer +- KonstantinKnauf: +

[jira] [Created] (FLINK-33258) Remove Kafka/Gelly module

2023-10-12 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33258: - Summary: Remove Kafka/Gelly module Key: FLINK-33258 URL: https://issues.apache.org/jira/browse/FLINK-33258 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-33190) [Umbrella]Externalized Connectors should directly depend on 3rd-party libs instead of shaded repo

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774560#comment-17774560 ] Martijn Visser commented on FLINK-33190: [~jingge] I checked the connectors and I believe that

Re: [PR] [hotfix][docs] Add aliases for moved pages [flink-web]

2023-10-12 Thread via GitHub
MartijnVisser merged PR #684: URL: https://github.com/apache/flink-web/pull/684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-32399) Fix flink-sql-connector-kinesis build for maven 3.8.6+

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774541#comment-17774541 ] Martijn Visser commented on FLINK-32399: [~hong] So now AWS can use the same template as the

[jira] [Resolved] (FLINK-32399) Fix flink-sql-connector-kinesis build for maven 3.8.6+

2023-10-12 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh resolved FLINK-32399. - Resolution: Fixed > Fix flink-sql-connector-kinesis build for maven 3.8.6+ >

[jira] [Commented] (FLINK-32399) Fix flink-sql-connector-kinesis build for maven 3.8.6+

2023-10-12 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774539#comment-17774539 ] Hong Liang Teoh commented on FLINK-32399: - merged commit

Re: [PR] [FLINK-32399][Connectors/Kinesis] Update shading configuration for Kinesis SQL connector to support maven 3.8.6+ [flink-connector-aws]

2023-10-12 Thread via GitHub
hlteoh37 merged PR #87: URL: https://github.com/apache/flink-connector-aws/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33252) LicenseChecker fails in GHA but succeeds in Azure

2023-10-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774534#comment-17774534 ] Matthias Pohl commented on FLINK-33252: --- There are, indeed, 12 issues in GHA which do not show up

[jira] [Closed] (FLINK-33250) HBase Connector should directly depend on 3rd-party libs instead of flink-shaded repo

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-33250. -- Fix Version/s: hbase-3.0.1 Resolution: Fixed Fixed in

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
MartijnVisser merged PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-25916) Using upsert-kafka with a flush buffer results in Null Pointer Exception

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774517#comment-17774517 ] Martijn Visser commented on FLINK-25916: [~kibebr] Indeed it's fixed in 3.0.0-1.17 > Using

[jira] [Updated] (FLINK-27075) Migrate CI from Azure to Github Actions

2023-10-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-27075: -- Description: Current base commit:

[jira] [Commented] (FLINK-25916) Using upsert-kafka with a flush buffer results in Null Pointer Exception

2023-10-12 Thread Vitor (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774498#comment-17774498 ] Vitor commented on FLINK-25916: --- [~martijnvisser]  It seems like version 3.0.0-1.17 has the fix and is

[jira] [Updated] (FLINK-33181) Table using `kinesis` connector can not be used for both read & write operations if it's defined with unsupported sink property

2023-10-12 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-33181: -- Affects Version/s: aws-connector-4.1.0 > Table using `kinesis` connector can not be used for

[jira] [Updated] (FLINK-33181) Table using `kinesis` connector can not be used for both read & write operations if it's defined with unsupported sink property

2023-10-12 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-33181: -- Fix Version/s: aws-connector-4.2.0 > Table using `kinesis` connector can not be used for both

[jira] [Assigned] (FLINK-33181) Table using `kinesis` connector can not be used for both read & write operations if it's defined with unsupported sink property

2023-10-12 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-33181: - Assignee: Khanh Vu > Table using `kinesis` connector can not be used for both read &

[jira] [Commented] (FLINK-33181) Table using `kinesis` connector can not be used for both read & write operations if it's defined with unsupported sink property

2023-10-12 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774486#comment-17774486 ] Danny Cranmer commented on FLINK-33181: --- Hey [~martijnvisser]. Yep, [~khanhvu]  is on our team. >

[jira] [Closed] (FLINK-33199) ArchitectureTests should test for fully qualified class names instead of Class objects

2023-10-12 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-33199. Fix Version/s: 1.19.0 Resolution: Fixed master:

Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]

2023-10-12 Thread via GitHub
zentol merged PR #23491: URL: https://github.com/apache/flink/pull/23491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (FLINK-25916) Using upsert-kafka with a flush buffer results in Null Pointer Exception

2023-10-12 Thread Vitor (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774483#comment-17774483 ] Vitor edited comment on FLINK-25916 at 10/12/23 12:32 PM: -- [~martijnvisser] 

Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArchitectureTests [flink]

2023-10-12 Thread via GitHub
zentol commented on code in PR #23491: URL: https://github.com/apache/flink/pull/23491#discussion_r1356745320 ## flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/Predicates.java: ## @@ -62,40 +68,42 @@ public static

[jira] [Commented] (FLINK-25916) Using upsert-kafka with a flush buffer results in Null Pointer Exception

2023-10-12 Thread Vitor (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774483#comment-17774483 ] Vitor commented on FLINK-25916: --- [~martijnvisser]  Hey. I think it was only a misunderstanding on my

Re: [PR] [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler [flink]

2023-10-12 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1356736651 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/scalingpolicy/EnforceParallelismChangeRescalingController.java: ## @@ -0,0 +1,41 @@ +/* +

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356731370 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -40,18 +40,15 @@ import

[jira] [Commented] (FLINK-33251) SQL Client query execution aborts after a few seconds: ConnectTimeoutException

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774475#comment-17774475 ] Martijn Visser commented on FLINK-33251: [~rmoff] Are you on VPN by any chance? > SQL Client

[jira] [Commented] (FLINK-33249) comment should be parsed by StringLiteral() instead of SqlCharStringLiteral to avoid parsing failure

2023-10-12 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774468#comment-17774468 ] xiaogang zhou commented on FLINK-33249: --- [~martijnvisser] Sure thing, Let me provide a test to

Re: [PR] Bump org.apache.calcite:calcite-core from 1.16.0 to 1.32.0 in /flink-connectors/flink-sql-connector-hive-3.1.3 [flink]

2023-10-12 Thread via GitHub
snuyanzin commented on PR #23052: URL: https://github.com/apache/flink/pull/23052#issuecomment-1759481799 @dependabot ignore this dependency in case of Flink this is not just a version bump... -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Bump org.apache.calcite:calcite-core from 1.16.0 to 1.32.0 in /flink-connectors/flink-sql-connector-hive-3.1.3 [flink]

2023-10-12 Thread via GitHub
dependabot[bot] commented on PR #23052: URL: https://github.com/apache/flink/pull/23052#issuecomment-1759481883 OK, I won't notify you about org.apache.calcite:calcite-core again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Bump org.apache.calcite:calcite-core from 1.16.0 to 1.32.0 in /flink-connectors/flink-sql-connector-hive-3.1.3 [flink]

2023-10-12 Thread via GitHub
dependabot[bot] closed pull request #23052: Bump org.apache.calcite:calcite-core from 1.16.0 to 1.32.0 in /flink-connectors/flink-sql-connector-hive-3.1.3 URL: https://github.com/apache/flink/pull/23052 -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (FLINK-33235) Improve the Quickstart guide for Flink OLAP and translate to Chinese

2023-10-12 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774466#comment-17774466 ] xiangyu feng commented on FLINK-33235: -- [~martijnvisser] Sorry I didn't make myself clear. I mean

Re: [PR] [FLINK-33246][tests] Add AutoRescalingITCase [flink]

2023-10-12 Thread via GitHub
StefanRRichter commented on code in PR #23510: URL: https://github.com/apache/flink/pull/23510#discussion_r1356717197 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java: ## @@ -0,0 +1,935 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33030][python]Add python 3.11 support [flink]

2023-10-12 Thread via GitHub
gaborgsomogyi commented on PR #23417: URL: https://github.com/apache/flink/pull/23417#issuecomment-1759471969 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

  1   2   3   >