Re: [PR] FLINK-33600][table] print the query time cost for batch query in cli [flink]

2023-11-26 Thread via GitHub
flinkbot commented on PR #23809: URL: https://github.com/apache/flink/pull/23809#issuecomment-1827310156 ## CI report: * 20ebdff8ebda287f1640c770a3bbe164a29f2be8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] FLINK-33600][table] print the query time cost for batch query in cli [flink]

2023-11-26 Thread via GitHub
JingGe opened a new pull request, #23809: URL: https://github.com/apache/flink/pull/23809 ## What is the purpose of the change print the query time cost for batch query in cli ## Brief change log - define new table config to swtich the display the query time cost

[jira] [Updated] (FLINK-33600) Print cost time for batch queries in SQL Client

2023-11-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33600: --- Labels: pull-request-available (was: ) > Print cost time for batch queries in SQL Client >

[jira] [Commented] (FLINK-32667) Use standalone store and embedding writer for jobs with no-restart-strategy in session cluster

2023-11-26 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789941#comment-17789941 ] Yangze Guo commented on FLINK-32667: FYI, since FLINK-33033 has been merged and proves the benefit

[jira] [Assigned] (FLINK-32667) Use standalone store and embedding writer for jobs with no-restart-strategy in session cluster

2023-11-26 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo reassigned FLINK-32667: -- Assignee: Yangze Guo (was: Fang Yong) > Use standalone store and embedding writer for jobs

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-26 Thread via GitHub
KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405582679 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the

Re: [PR] [FLINK-26013][flink-core][test] add archunit tests for the test code [flink]

2023-11-26 Thread via GitHub
JingGe merged PR #23799: URL: https://github.com/apache/flink/pull/23799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-33656) If json.ignose-parse-errors =true is configured and Array parsing errors occur, other columns will be empty

2023-11-26 Thread duke (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] duke updated FLINK-33656: - Description: If json.ignore-parse-errors is set to true and Array parsing errors occur, the fields following

[jira] [Updated] (FLINK-33656) If json.ignose-parse-errors =true is configured and Array parsing errors occur, other columns will be empty

2023-11-26 Thread duke (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] duke updated FLINK-33656: - Attachment: image-2023-11-27-14-03-10-885.png > If json.ignose-parse-errors =true is configured and Array

[jira] [Updated] (FLINK-33656) If json.ignose-parse-errors =true is configured and Array parsing errors occur, other columns will be empty

2023-11-26 Thread duke (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] duke updated FLINK-33656: - Attachment: image-2023-11-27-14-02-52-065.png > If json.ignose-parse-errors =true is configured and Array

[jira] [Updated] (FLINK-33656) If json.ignose-parse-errors =true is configured and Array parsing errors occur, other columns will be empty

2023-11-26 Thread duke (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] duke updated FLINK-33656: - Attachment: image-2023-11-27-14-02-30-666.png > If json.ignose-parse-errors =true is configured and Array

[jira] [Updated] (FLINK-33656) If json.ignose-parse-errors =true is configured and Array parsing errors occur, other columns will be empty

2023-11-26 Thread duke (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] duke updated FLINK-33656: - Attachment: image-2023-11-27-14-02-01-252.png > If json.ignose-parse-errors =true is configured and Array

[jira] [Updated] (FLINK-33656) If json.ignose-parse-errors =true is configured and Array parsing errors occur, other columns will be empty

2023-11-26 Thread duke (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] duke updated FLINK-33656: - Attachment: image-2023-11-27-14-01-12-187.png > If json.ignose-parse-errors =true is configured and Array

[jira] [Updated] (FLINK-33656) If json.ignose-parse-errors =true is configured and Array parsing errors occur, other columns will be empty

2023-11-26 Thread duke (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] duke updated FLINK-33656: - Attachment: image-2023-11-27-14-00-41-176.png > If json.ignose-parse-errors =true is configured and Array

[jira] [Updated] (FLINK-33656) If json.ignose-parse-errors =true is configured and Array parsing errors occur, other columns will be empty

2023-11-26 Thread duke (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] duke updated FLINK-33656: - Attachment: image-2023-11-27-14-00-04-672.png > If json.ignose-parse-errors =true is configured and Array

[jira] [Updated] (FLINK-33656) If json.ignose-parse-errors =true is configured and Array parsing errors occur, other columns will be empty

2023-11-26 Thread duke (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] duke updated FLINK-33656: - Attachment: image-2023-11-27-13-59-42-066.png > If json.ignose-parse-errors =true is configured and Array

[jira] [Updated] (FLINK-33656) If json.ignose-parse-errors =true is configured and Array parsing errors occur, other columns will be empty

2023-11-26 Thread duke (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] duke updated FLINK-33656: - Attachment: image-2023-11-27-13-58-22-513.png > If json.ignose-parse-errors =true is configured and Array

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub
JingGe merged PR #23786: URL: https://github.com/apache/flink/pull/23786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-11-26 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789903#comment-17789903 ] Hangxiang Yu edited comment on FLINK-27681 at 11/27/23 4:33 AM:

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-11-26 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789903#comment-17789903 ] Hangxiang Yu commented on FLINK-27681: -- [~pnowojski] [~fanrui]  Thanks for joining in the

[jira] [Created] (FLINK-33656) If json.ignose-parse-errors =true is configured and Array parsing errors occur, other columns will be empty

2023-11-26 Thread duke (Jira)
duke created FLINK-33656: Summary: If json.ignose-parse-errors =true is configured and Array parsing errors occur, other columns will be empty Key: FLINK-33656 URL: https://issues.apache.org/jira/browse/FLINK-33656

[jira] [Updated] (FLINK-33656) If json.ignose-parse-errors =true is configured and Array parsing errors occur, other columns will be empty

2023-11-26 Thread duke (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] duke updated FLINK-33656: - Description: Flink SQL  If json.ignose-parse-errors =true is configured and Array parsing errors occur, other

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-11-26 Thread via GitHub
masteryhx commented on code in PR #23253: URL: https://github.com/apache/flink/pull/23253#discussion_r1403926743 ## flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java: ## @@ -157,6 +157,14 @@ public class CliFrontendParser {

Re: [PR] [FLINK-27681] RocksdbStatebackend verify incremental sst file checksum during checkpoint [flink]

2023-11-26 Thread via GitHub
mayuehappy commented on code in PR #23765: URL: https://github.com/apache/flink/pull/23765#discussion_r1405583287 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java: ## @@

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-26 Thread via GitHub
KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405582679 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-11-26 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789892#comment-17789892 ] Yue Ma commented on FLINK-27681: Hi [~pnowojski] and [~fanrui] , thanks for your repiles.   {quote}If

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-11-26 Thread via GitHub
masteryhx commented on PR #21635: URL: https://github.com/apache/flink/pull/21635#issuecomment-1827061892 > Thanks @masteryhx for the contribution! > > I didn't finish the review, and left some minor comments. Please take a look in your free time, thanks~ Thanks a lot for your

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-11-26 Thread via GitHub
masteryhx commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1405573786 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerUtil.java: ## @@ -34,21 +34,21 @@ public class CompositeTypeSerializerUtil {

[jira] [Assigned] (FLINK-31449) Remove DeclarativeSlotManager related logic

2023-11-26 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu reassigned FLINK-31449: - Assignee: Weihua Hu > Remove DeclarativeSlotManager related logic >

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-11-26 Thread via GitHub
xiangforever2014 commented on PR #23253: URL: https://github.com/apache/flink/pull/23253#issuecomment-1827056077 @masteryhx hope to get your reply, many thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-31275) Flink supports reporting and storage of source/sink tables relationship

2023-11-26 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789890#comment-17789890 ] Fang Yong commented on FLINK-31275: --- [~mobuchowski] Sorry for the late reply. What does the `DataSet`

[jira] [Commented] (FLINK-33638) Support variable-length data generation for variable-length data types

2023-11-26 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789889#comment-17789889 ] Yubin Li commented on FLINK-33638: -- [~lincoln] thanks very much! > Support variable-length data

Re: [PR] [FLINK-33643][runtime] Allow StreamExecutionEnvironment's executeAsync API to use default JobName [flink]

2023-11-26 Thread via GitHub
huwh commented on code in PR #23794: URL: https://github.com/apache/flink/pull/23794#discussion_r1405565272 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java: ## @@ -2213,12 +2211,24 @@ public final JobClient

[jira] [Assigned] (FLINK-33643) Allow StreamExecutionEnvironment's executeAsync API to use default JobName

2023-11-26 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu reassigned FLINK-33643: - Assignee: Matt Wang (was: Weihua Hu) > Allow StreamExecutionEnvironment's executeAsync API to

[jira] [Assigned] (FLINK-33643) Allow StreamExecutionEnvironment's executeAsync API to use default JobName

2023-11-26 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu reassigned FLINK-33643: - Assignee: Weihua Hu > Allow StreamExecutionEnvironment's executeAsync API to use default

[jira] [Commented] (FLINK-33378) Prepare actions for flink version 1.18

2023-11-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789866#comment-17789866 ] Sergey Nuyanzin commented on FLINK-33378: - Merged as

[jira] [Resolved] (FLINK-33378) Prepare actions for flink version 1.18

2023-11-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33378. - Fix Version/s: jdbc-3.2.0 Resolution: Fixed > Prepare actions for flink version

[jira] [Updated] (FLINK-33378) Prepare actions for flink version 1.18

2023-11-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33378: Summary: Prepare actions for flink version 1.18 (was: Bump flink version on

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-26 Thread via GitHub
snuyanzin merged PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-26 Thread via GitHub
snuyanzin commented on PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#issuecomment-1826937228 ok, let's merge it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-33655] Upgrade ArchUnit to 1.2.0 to support java 21 [flink]

2023-11-26 Thread via GitHub
flinkbot commented on PR #23808: URL: https://github.com/apache/flink/pull/23808#issuecomment-1826929519 ## CI report: * 2a21eee935d0b0d9db3195d3b2ac02d18e42e348 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33655) Upgrade Archunit to 1.1.0+

2023-11-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33655: --- Labels: pull-request-available (was: ) > Upgrade Archunit to 1.1.0+ >

[jira] [Updated] (FLINK-33655) Upgrade Archunit to 1.1.0+

2023-11-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33655: Description: ASM 9.5 (which has support for java 21[1]) came only with ArchUnit 1.1.0 [2]

[PR] [FLINK-33655] Upgrade ArchUnit to 1.2.0 to support java 21 [flink]

2023-11-26 Thread via GitHub
snuyanzin opened a new pull request, #23808: URL: https://github.com/apache/flink/pull/23808 ## What is the purpose of the change The minimum ArchUnit supporting java 21 is 1.1.0 so need to bump ArchUnit to support java 21 ## Verifying this change This change is a

[jira] [Updated] (FLINK-33655) Upgrade Archunit to 1.1.0+

2023-11-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33655: Description: ASM 9.5 (which has support for java 21[1]) came only with ArchUnit 1.1.0 [2]

[jira] [Updated] (FLINK-33655) Upgrade Archunit to 1.1.0+

2023-11-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33655: Description: ASM 9.5 (which has support for java 21) came only with ArchUnit 1.1.0 With

[jira] [Updated] (FLINK-33655) Upgrade Archunit to 1.1.0+

2023-11-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33655: Summary: Upgrade Archunit to 1.1.0+ (was: Upgrade archunit to 1.1.0+) > Upgrade Archunit

[jira] [Updated] (FLINK-33655) Upgrade archunit to 1.1.0+

2023-11-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33655: Summary: Upgrade archunit to 1.1.0+ (was:

[jira] [Created] (FLINK-33655) ScalaSerializersMigrationTest#testStableAnonymousClassnameGeneration fails with jdk21

2023-11-26 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33655: --- Summary: ScalaSerializersMigrationTest#testStableAnonymousClassnameGeneration fails with jdk21 Key: FLINK-33655 URL: https://issues.apache.org/jira/browse/FLINK-33655

[jira] [Commented] (FLINK-33443) Make the test "testWriteComplexType" stable

2023-11-26 Thread huiyang chi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789859#comment-17789859 ] huiyang chi commented on FLINK-33443: - Hi Martijn : I can understand that currently this problem is

[jira] [Assigned] (FLINK-33654) deprecate DummyStreamExecutionEnvironment

2023-11-26 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge reassigned FLINK-33654: --- Assignee: Jing Ge > deprecate DummyStreamExecutionEnvironment >

[jira] [Created] (FLINK-33654) deprecate DummyStreamExecutionEnvironment

2023-11-26 Thread Jing Ge (Jira)
Jing Ge created FLINK-33654: --- Summary: deprecate DummyStreamExecutionEnvironment Key: FLINK-33654 URL: https://issues.apache.org/jira/browse/FLINK-33654 Project: Flink Issue Type: Improvement

[jira] [Resolved] (FLINK-33651) Update the Chinese version checkpointing doc in fault tolerance

2023-11-26 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-33651. - Resolution: Fixed > Update the Chinese version checkpointing doc in fault tolerance >

[jira] [Commented] (FLINK-33651) Update the Chinese version checkpointing doc in fault tolerance

2023-11-26 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789845#comment-17789845 ] Jing Ge commented on FLINK-33651: - master: db0403c3f39ccd60f0c0a59f12caa63c521e1d17 > Update the

[jira] [Closed] (FLINK-33457) FlinkImageBuilder checks for Java 21

2023-11-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33457. --- > FlinkImageBuilder checks for Java 21 > > >

[jira] [Commented] (FLINK-33457) FlinkImageBuilder checks for Java 21

2023-11-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789844#comment-17789844 ] Sergey Nuyanzin commented on FLINK-33457: - Merged to master as

[jira] [Resolved] (FLINK-33457) FlinkImageBuilder checks for Java 21

2023-11-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33457. - Fix Version/s: 1.19.0 Resolution: Fixed > FlinkImageBuilder checks for Java 21 >

Re: [PR] [FLINK-33457][tests] FlinkImageBuilder checks for Java 21 [flink]

2023-11-26 Thread via GitHub
snuyanzin merged PR #23662: URL: https://github.com/apache/flink/pull/23662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub
JingGe commented on PR #23786: URL: https://github.com/apache/flink/pull/23786#issuecomment-1826886399 Thanks @snuyanzin for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33457][tests] FlinkImageBuilder checks for Java 21 [flink]

2023-11-26 Thread via GitHub
snuyanzin commented on PR #23662: URL: https://github.com/apache/flink/pull/23662#issuecomment-1826886015 Thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub
snuyanzin commented on code in PR #23786: URL: https://github.com/apache/flink/pull/23786#discussion_r1405469301 ## flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java: ## @@ -240,6 +232,16 @@ void testBatchResult() {

Re: [PR] [FLINK-33651][Runtime][doc] update state checkpoins doc in Chinese [flink]

2023-11-26 Thread via GitHub
JingGe merged PR #23807: URL: https://github.com/apache/flink/pull/23807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]

2023-11-26 Thread via GitHub
JingGe merged PR #23805: URL: https://github.com/apache/flink/pull/23805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-26 Thread via GitHub
surendralilhore commented on PR #23768: URL: https://github.com/apache/flink/pull/23768#issuecomment-1826843398 There is one more Jira to fix this issue in better way : [FLINK-33548](https://issues.apache.org/jira/browse/FLINK-33548) -- This is an automated message from the Apache Git

Re: [PR] [FLINK-33609] Take into account the resource limit specified in the pod template. [flink]

2023-11-26 Thread via GitHub
surendralilhore closed pull request #23768: [FLINK-33609] Take into account the resource limit specified in the pod template. URL: https://github.com/apache/flink/pull/23768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Resolved] (FLINK-33609) Take into account the resource limit specified in the pod template.

2023-11-26 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surendra Singh Lilhore resolved FLINK-33609. Resolution: Duplicate There is one more Jira to fix this issue in better

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub
JingGe commented on PR #23786: URL: https://github.com/apache/flink/pull/23786#issuecomment-1826828710 good catch! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub
snuyanzin commented on PR #23786: URL: https://github.com/apache/flink/pull/23786#issuecomment-1826815890 Thanks for driving this i would suggest to replace 2 more same occurrences e.g. at

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub
snuyanzin commented on code in PR #23786: URL: https://github.com/apache/flink/pull/23786#discussion_r1405421318 ## flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java: ## @@ -226,7 +222,7 @@ void testBatchResult() {

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub
snuyanzin commented on code in PR #23786: URL: https://github.com/apache/flink/pull/23786#discussion_r1405421199 ## flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java: ## @@ -226,7 +222,7 @@ void testBatchResult() {

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-26 Thread via GitHub
snuyanzin commented on code in PR #23786: URL: https://github.com/apache/flink/pull/23786#discussion_r1405421199 ## flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java: ## @@ -226,7 +222,7 @@ void testBatchResult() {

Re: [PR] [FLINK-33651][Runtime][doc] update state checkpoins doc in Chinese [flink]

2023-11-26 Thread via GitHub
1996fanrui commented on PR #23807: URL: https://github.com/apache/flink/pull/23807#issuecomment-1826810102 Hey @JingGe , would you mind squashing all commits in advance? Or squash and merge it is fine. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]

2023-11-26 Thread via GitHub
JingGe commented on PR #23805: URL: https://github.com/apache/flink/pull/23805#issuecomment-1826798523 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]

2023-11-26 Thread via GitHub
JingGe commented on PR #23805: URL: https://github.com/apache/flink/pull/23805#issuecomment-1826797827 Thanks @snuyanzin for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33651][Runtime][doc] update state checkpoins doc in Chinese [flink]

2023-11-26 Thread via GitHub
JingGe commented on code in PR #23807: URL: https://github.com/apache/flink/pull/23807#discussion_r1405404799 ## docs/content.zh/docs/dev/datastream/fault-tolerance/checkpointing.md: ## @@ -71,7 +74,13 @@ Checkpoint 其他的属性包括: - *externalized checkpoints*: 你可以配置周期存储

Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]

2023-11-26 Thread via GitHub
snuyanzin commented on code in PR #23805: URL: https://github.com/apache/flink/pull/23805#discussion_r1405381059 ## docs/content/docs/dev/table/functions/udfs.md: ## @@ -227,6 +227,20 @@ env.from("MyTable").select(call(classOf[MyConcatFunction], $"a", $"b", $"c")); {{< /tab

[jira] [Created] (FLINK-33653) Introduce a benchmark for balanced tasks scheduling

2023-11-26 Thread RocMarshal (Jira)
RocMarshal created FLINK-33653: -- Summary: Introduce a benchmark for balanced tasks scheduling Key: FLINK-33653 URL: https://issues.apache.org/jira/browse/FLINK-33653 Project: Flink Issue Type:

[jira] [Created] (FLINK-33652) First Steps documentation is having empty page link

2023-11-26 Thread Pranav Sharma (Jira)
Pranav Sharma created FLINK-33652: - Summary: First Steps documentation is having empty page link Key: FLINK-33652 URL: https://issues.apache.org/jira/browse/FLINK-33652 Project: Flink Issue

Re: [PR] [FLINK-33651][Runtime][doc] update state checkpoins doc in Chinese [flink]

2023-11-26 Thread via GitHub
1996fanrui commented on code in PR #23807: URL: https://github.com/apache/flink/pull/23807#discussion_r1405361586 ## docs/content.zh/docs/dev/datastream/fault-tolerance/checkpointing.md: ## @@ -71,7 +74,13 @@ Checkpoint 其他的属性包括: - *externalized checkpoints*: 你可以配置周期存储

[jira] [Closed] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-11-26 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge closed FLINK-33301. --- Resolution: Won't Fix > Add Java and Maven version checks in the bash script of Flink release process >

Re: [PR] [FLINK-33651][Runtime][doc] update state checkpoins doc in Chinese [flink]

2023-11-26 Thread via GitHub
JingGe commented on code in PR #23807: URL: https://github.com/apache/flink/pull/23807#discussion_r1405358365 ## docs/content.zh/docs/dev/datastream/fault-tolerance/checkpointing.md: ## @@ -71,7 +74,13 @@ Checkpoint 其他的属性包括: - *externalized checkpoints*: 你可以配置周期存储

Re: [PR] [FLINK-33651][Runtime][doc] update state checkpoins doc in Chinese [flink]

2023-11-26 Thread via GitHub
JingGe commented on code in PR #23807: URL: https://github.com/apache/flink/pull/23807#discussion_r1405358365 ## docs/content.zh/docs/dev/datastream/fault-tolerance/checkpointing.md: ## @@ -71,7 +74,13 @@ Checkpoint 其他的属性包括: - *externalized checkpoints*: 你可以配置周期存储

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-26 Thread via GitHub
1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405313903 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-26 Thread via GitHub
1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405352714 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33651][Runtime][doc] update state checkpoins doc in Chinese [flink]

2023-11-26 Thread via GitHub
1996fanrui commented on code in PR #23807: URL: https://github.com/apache/flink/pull/23807#discussion_r1405351938 ## docs/content.zh/docs/dev/datastream/fault-tolerance/checkpointing.md: ## @@ -71,7 +74,13 @@ Checkpoint 其他的属性包括: - *externalized checkpoints*: 你可以配置周期存储

Re: [PR] [hotfix][Junit5 Migration] Upgrade the LocalInputPreferredSlotSharingStrategyTest to junit5 [flink]

2023-11-26 Thread via GitHub
1996fanrui merged PR #23806: URL: https://github.com/apache/flink/pull/23806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: