Re: [PR] [FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module [flink]

2023-12-14 Thread via GitHub
flinkbot commented on PR #23932: URL: https://github.com/apache/flink/pull/23932#issuecomment-1857412172 ## CI report: * bd328df2d2f1dea0cbe121e16a83734451e19306 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-27876][table-planner] Choose the right side as build side when using default shuffle hash strategy if left size is equal with right [flink]

2023-12-14 Thread via GitHub
xuyangzhong commented on PR #19866: URL: https://github.com/apache/flink/pull/19866#issuecomment-1857405822 Hi, @lsyldliu. I rebased the master. Could you have a look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (FLINK-33853) [JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module

2023-12-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33853: --- Labels: pull-request-available (was: ) > [JUnit5 Migration] Migrate Junit5 for

[PR] [FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module [flink]

2023-12-14 Thread via GitHub
RocMarshal opened a new pull request, #23932: URL: https://github.com/apache/flink/pull/23932 ## What is the purpose of the change [FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module ## Brief

[jira] [Updated] (FLINK-33853) [JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module

2023-12-14 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33853: --- Summary: [JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime

[jira] [Created] (FLINK-33853) Migrate Junit5 for DefaultDeclarativeSlotPool test classes

2023-12-14 Thread RocMarshal (Jira)
RocMarshal created FLINK-33853: -- Summary: Migrate Junit5 for DefaultDeclarativeSlotPool test classes Key: FLINK-33853 URL: https://issues.apache.org/jira/browse/FLINK-33853 Project: Flink Issue

[jira] [Updated] (FLINK-33853) [JUnit5 Migration] Migrate Junit5 for DefaultDeclarativeSlotPool test classes of runtime module

2023-12-14 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33853: --- Summary: [JUnit5 Migration] Migrate Junit5 for DefaultDeclarativeSlotPool test classes of runtime

[jira] [Updated] (FLINK-33450) Implement JdbcAutoScalerStateStore

2023-12-14 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33450: Description: Design doc:

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-12-14 Thread via GitHub
1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1427526869 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ## @@ -103,12 +106,35 @@ public class

[jira] [Comment Edited] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-12-14 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779841#comment-17779841 ] Leonard Xu edited comment on FLINK-32850 at 12/15/23 6:58 AM: -- Merged

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.netty package of flink-runtime module [flink]

2023-12-14 Thread via GitHub
leonardBang merged PR #23607: URL: https://github.com/apache/flink/pull/23607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33798][statebackend/rocksdb] automatically clean up rocksdb logs when the task exited. [flink]

2023-12-14 Thread via GitHub
1996fanrui commented on code in PR #23922: URL: https://github.com/apache/flink/pull/23922#discussion_r1427612626 ## flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java: ## @@ -359,6 +361,50

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.api package of flink-runtime module [flink]

2023-12-14 Thread via GitHub
leonardBang commented on PR #23590: URL: https://github.com/apache/flink/pull/23590#issuecomment-1857368418 @dawidwys Would you like to help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.buffer package of flink-runtime module [flink]

2023-12-14 Thread via GitHub
leonardBang commented on PR #23604: URL: https://github.com/apache/flink/pull/23604#issuecomment-1857368007 @reswqa Could you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [ FLINK-33603][FileSystems] shade guava in gs-fs filesystem [flink]

2023-12-14 Thread via GitHub
singhravidutt commented on PR #23489: URL: https://github.com/apache/flink/pull/23489#issuecomment-1857360296 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-12-14 Thread Tongtong Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797041#comment-17797041 ] Tongtong Zhu commented on FLINK-33588: -- [~jingge] CI report is no problem is Success

[jira] [Updated] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-12-14 Thread Tongtong Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tongtong Zhu updated FLINK-33588: - Attachment: image-2023-12-15-13-59-28-201.png > Fix Flink Checkpointing Statistics Bug >

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-14 Thread via GitHub
flashJd commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1427581625 ## flink-autoscaler/pom.xml: ## @@ -66,6 +66,12 @@ under the License. jackson-databind + +

Re: [PR] [FLINK-33509] Fix flaky test testNodeAffinity() in InitTaskManagerDecoratorTest.java [flink]

2023-12-14 Thread via GitHub
wanglijie95 commented on code in PR #23694: URL: https://github.com/apache/flink/pull/23694#discussion_r1427580681 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/decorators/InitTaskManagerDecoratorTest.java: ## @@ -282,12 +282,22 @@ void

Re: [PR] [FLINK-27876][table-planner] Choose the right side as build side when using default shuffle hash strategy if left size is equal with right [flink]

2023-12-14 Thread via GitHub
xuyangzhong commented on code in PR #19866: URL: https://github.com/apache/flink/pull/19866#discussion_r1427570136 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/MultipleInputCreationTest.xml: ## @@ -109,39 +109,6 @@

Re: [PR] [FLINK-33541][table-planner] function RAND and RAND_INTEGER should return type nullable if the arguments are nullable [flink]

2023-12-14 Thread via GitHub
xuyangzhong commented on PR #23779: URL: https://github.com/apache/flink/pull/23779#issuecomment-1857309968 Hi, @libenchao sorry for this noise. I have updated this pr to test non-deterministic results about RAND and RAND_INTEGER. Could you have a look again? -- This is an automated

[jira] [Created] (FLINK-33852) FLIP-403 High Availability Services for OLAP Scenarios

2023-12-14 Thread Yangze Guo (Jira)
Yangze Guo created FLINK-33852: -- Summary: FLIP-403 High Availability Services for OLAP Scenarios Key: FLINK-33852 URL: https://issues.apache.org/jira/browse/FLINK-33852 Project: Flink Issue

[jira] [Commented] (FLINK-32895) Introduce the max attempts for Exponential Delay Restart Strategy

2023-12-14 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797017#comment-17797017 ] Rui Fan commented on FLINK-32895: - Merged to master(1.19) via :

[jira] [Resolved] (FLINK-32895) Introduce the max attempts for Exponential Delay Restart Strategy

2023-12-14 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-32895. - Fix Version/s: 1.19.0 Resolution: Fixed > Introduce the max attempts for Exponential Delay

Re: [PR] [FLINK-20772][State] Make TtlValueState#update follow the description of interface about null values [flink]

2023-12-14 Thread via GitHub
Zakelly commented on PR #23928: URL: https://github.com/apache/flink/pull/23928#issuecomment-1857273442 @masteryhx Thanks so much for your review! I have update my PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-14 Thread via GitHub
1996fanrui merged PR #23247: URL: https://github.com/apache/flink/pull/23247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-14 Thread via GitHub
1996fanrui commented on PR #23247: URL: https://github.com/apache/flink/pull/23247#issuecomment-1857272908 Thanks everyone for the review, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-20772][State] Make TtlValueState#update follow the description of interface about null values [flink]

2023-12-14 Thread via GitHub
Zakelly commented on code in PR #23928: URL: https://github.com/apache/flink/pull/23928#discussion_r1427540869 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/TtlValueStateTestContext.java: ## @@ -21,14 +21,14 @@ import

Re: [PR] [FLINK-20772][State] Make TtlValueState#update follow the description of interface about null values [flink]

2023-12-14 Thread via GitHub
masteryhx commented on code in PR #23928: URL: https://github.com/apache/flink/pull/23928#discussion_r1427533090 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlValueState.java: ## @@ -48,7 +48,11 @@ public T value() throws IOException { @Override

Re: [PR] [hotfix] [tests] Per-class the lifecycle of mini-cluster in `ClientHeartbeatTest`. [flink]

2023-12-14 Thread via GitHub
reswqa commented on PR #23910: URL: https://github.com/apache/flink/pull/23910#issuecomment-1857249121 To be honest, I prefer to leave it as it is. Since I don't see much benefit, this `1s` speed up doesn't necessarily show up in the CI environment, but it does increase the instability of

[jira] [Commented] (FLINK-33819) Support setting CompressType in RocksDBStateBackend

2023-12-14 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796992#comment-17796992 ] Hangxiang Yu commented on FLINK-33819: -- Linked FLINK-20684 as it has been discussed before. Linked 

Re: [PR] [hotfix] Run push_pr.yml against multiple Flink versions [flink-connector-gcp-pubsub]

2023-12-14 Thread via GitHub
boring-cyborg[bot] commented on PR #21: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/21#issuecomment-1857232953 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) --

Re: [PR] [FLINK-33588][Flink-Runtime] Fix NullArgumentException of getQuantile method in DescriptiveStatisticsHistogramStatistics [flink]

2023-12-14 Thread via GitHub
zhutong6688 commented on PR #23931: URL: https://github.com/apache/flink/pull/23931#issuecomment-1857225538 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-12-14 Thread via GitHub
KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1427515808 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ## @@ -127,7 +155,28 @@ public void

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-12-14 Thread via GitHub
KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1427515551 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ## @@ -127,7 +155,28 @@ public void

Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]

2023-12-14 Thread via GitHub
xintongsong commented on code in PR #23870: URL: https://github.com/apache/flink/pull/23870#discussion_r1427504078 ## flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java: ## @@ -173,6 +173,18 @@ public class TaskManagerOptions {

[PR] [hotfix] Use flink SNAPSHOT version in weekly.yml to check changes quickly [flink-connector-kafka]

2023-12-14 Thread via GitHub
ruanhang1993 opened a new pull request, #75: URL: https://github.com/apache/flink-connector-kafka/pull/75 I find that some connectors(e.g. ES, mongodb, JDBC) are using the SNAPSHOT flink versions for main branch in `weekly.yml`. I think this will help to check changes in these version

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-12-14 Thread via GitHub
KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1427513961 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java: ## @@ -200,10 +226,45 @@ protected void

Re: [PR] [hotfix] Test connector against Flink 1.16.2, 1.17.1, 1.18.0 instead of Flink SNAPSHOT version [flink-connector-mongodb]

2023-12-14 Thread via GitHub
ruanhang1993 commented on PR #20: URL: https://github.com/apache/flink-connector-mongodb/pull/20#issuecomment-1857208606 Hi, @Jiabao-Sun . I think using all SNAPSHOT versions could help us to check the changes in Flink. Let's keep the settings now. Close this PR. -- This is an

Re: [PR] [hotfix] Test connector against Flink 1.16.2, 1.17.1, 1.18.0 instead of Flink SNAPSHOT version [flink-connector-mongodb]

2023-12-14 Thread via GitHub
ruanhang1993 closed pull request #20: [hotfix] Test connector against Flink 1.16.2, 1.17.1, 1.18.0 instead of Flink SNAPSHOT version URL: https://github.com/apache/flink-connector-mongodb/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] Add missing word [flink-web]

2023-12-14 Thread via GitHub
tombentley opened a new pull request, #705: URL: https://github.com/apache/flink-web/pull/705 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (FLINK-32573) Translate "Custom Serialization for Managed State" page into Chinese

2023-12-14 Thread Jinsui Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796980#comment-17796980 ] Jinsui Chen commented on FLINK-32573: - hi, [~Wencong Liu] . Would you please assign this to me? >

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-12-14 Thread via GitHub
masteryhx commented on PR #21635: URL: https://github.com/apache/flink/pull/21635#issuecomment-1857189693 > Hi @masteryhx , sorry for the late reply! > > After reading your PR, I finally figured out why the default implementation of old method and new method should call each other. I

Re: [PR] [hotfix] Test connector against Flink 1.16.2, 1.17.1, 1.18.0 instead of Flink SNAPSHOT version [flink-connector-mongodb]

2023-12-14 Thread via GitHub
ruanhang1993 commented on PR #20: URL: https://github.com/apache/flink-connector-mongodb/pull/20#issuecomment-1857189111 @Jiabao-Sun Thanks for the quick reply. I am not sure whether this PR is correct. It seems like every connector has different settings for the CI to use the SNAPSHOT

Re: [PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-14 Thread via GitHub
zhengzhili333 commented on PR #23880: URL: https://github.com/apache/flink/pull/23880#issuecomment-1857188917 Thank you for your suggestion, I have modified that interface and also corrected the point you mentioned earlier. -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-12-14 Thread via GitHub
masteryhx commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1427497404 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java: ## @@ -124,11 +124,40 @@ void readSnapshot(int readVersion,

[jira] [Commented] (FLINK-33449) Support array_contains_seq function

2023-12-14 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796978#comment-17796978 ] xuyang commented on FLINK-33449: Hi, [~leoyy] , thanks for your explanation. After your description, I

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-14 Thread via GitHub
xiangforever2014 commented on code in PR #23253: URL: https://github.com/apache/flink/pull/23253#discussion_r1427489342 ## flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java: ## @@ -164,6 +164,14 @@ public class CliFrontendParser {

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-14 Thread via GitHub
reswqa commented on code in PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#discussion_r1427487497 ## flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBuilderBaseTest.java: ## @@ -99,7

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-14 Thread via GitHub
reswqa commented on code in PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#discussion_r1427487497 ## flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBuilderBaseTest.java: ## @@ -99,7

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-14 Thread via GitHub
reswqa commented on code in PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#discussion_r1427487497 ## flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBuilderBaseTest.java: ## @@ -99,7

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-14 Thread via GitHub
reswqa commented on code in PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#discussion_r1427487497 ## flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBuilderBaseTest.java: ## @@ -99,7

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-14 Thread via GitHub
xiangforever2014 commented on code in PR #23253: URL: https://github.com/apache/flink/pull/23253#discussion_r1427486664 ## flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java: ## @@ -188,6 +207,21 @@ CompletableFuture triggerSavepoint( */

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-14 Thread via GitHub
1996fanrui commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1427486350 ## flink-autoscaler/pom.xml: ## @@ -66,6 +66,12 @@ under the License. jackson-databind + +

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-14 Thread via GitHub
xiangforever2014 commented on code in PR #23253: URL: https://github.com/apache/flink/pull/23253#discussion_r1427483790 ## docs/content.zh/docs/deployment/cli.md: ## @@ -125,6 +125,43 @@ Lastly, you can optionally provide what should be the [binary format]({{< ref "d The

[jira] [Commented] (FLINK-33819) Support setting CompressType in RocksDBStateBackend

2023-12-14 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796977#comment-17796977 ] xiangyu feng commented on FLINK-33819: -- +1 for this. This will save lots of cpu usage for jobs with

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-12-14 Thread via GitHub
1996fanrui commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1427479694 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java: ## @@ -124,11 +124,40 @@ void readSnapshot(int readVersion,

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-14 Thread via GitHub
1996fanrui commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1427474826 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -219,6 +219,22 @@ private static

[jira] [Closed] (FLINK-32862) Support INIT operation type to be compatible with DTS on Alibaba Cloud

2023-12-14 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hang Ruan closed FLINK-32862. - Resolution: Won't Fix > Support INIT operation type to be compatible with DTS on Alibaba Cloud >

Re: [PR] [FLINK-33809] HiveCatalog load hivemetastore-site.xml [flink]

2023-12-14 Thread via GitHub
cuibo01 commented on PR #23924: URL: https://github.com/apache/flink/pull/23924#issuecomment-1857131919 hi @luoyuxia Can you review the pr ? Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (FLINK-33756) Missing record with CUMULATE/HOP windows using an optimization

2023-12-14 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796949#comment-17796949 ] Jim Hughes commented on FLINK-33756: Hi [~jeyhunkarimov], I am not actively working on it; I'll

[jira] [Commented] (FLINK-33756) Missing record with CUMULATE/HOP windows using an optimization

2023-12-14 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796939#comment-17796939 ] Jeyhun Karimov commented on FLINK-33756: [~jhughes] Yes it is just printing/logging on various

[jira] [Updated] (FLINK-33836) Propose a pull request for website updates

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33836: Description: The final step of building the candidate is to propose a website pull request containing

[jira] [Resolved] (FLINK-33835) Stage source and binary releases on dist.apache.org

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-33835. - Resolution: Fixed > Stage source and binary releases on dist.apache.org >

[jira] [Resolved] (FLINK-33834) Build and stage Java and Python artifacts

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-33834. - Resolution: Fixed > Build and stage Java and Python artifacts >

Re: [PR] [hotfix] [tests] Per-class the lifecycle of mini-cluster in `ClientHeartbeatTest`. [flink]

2023-12-14 Thread via GitHub
TestBoost commented on PR #23910: URL: https://github.com/apache/flink/pull/23910#issuecomment-1856543512 Hi, So to clarify, would the preferred change be to start a cluster per-test-class and to share between test methods? Looking at the test class, perhaps this could be

[jira] [Commented] (FLINK-33666) MergeTableLikeUtil uses different constraint name than Schema

2023-12-14 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796882#comment-17796882 ] Jim Hughes commented on FLINK-33666: [~twalthr] Yes, the issue has been resolved. The issue was a

[jira] [Commented] (FLINK-33666) MergeTableLikeUtil uses different constraint name than Schema

2023-12-14 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796862#comment-17796862 ] Timo Walther commented on FLINK-33666: -- [~jhughes] was this issue resolved? Was it just a problem

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-12-14 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796843#comment-17796843 ] Piotr Nowojski commented on FLINK-27681: I could help reviewing and generally speaking support

[jira] [Commented] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-12-14 Thread Tongtong Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796841#comment-17796841 ] Tongtong Zhu commented on FLINK-33588: -- [~jingge] The New PR #23931

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-12-14 Thread via GitHub
Zakelly commented on PR #21635: URL: https://github.com/apache/flink/pull/21635#issuecomment-1856242365 Hi @masteryhx , sorry for the late reply! After reading your PR, I finally figured out why the default implementation of old method and new method should call each other. I think

Re: [PR] [FLINK-33588][Flink-Runtime] Fix NullArgumentException of getQuantile method in DescriptiveStatisticsHistogramStatistics [flink]

2023-12-14 Thread via GitHub
zhutong6688 commented on PR #23931: URL: https://github.com/apache/flink/pull/23931#issuecomment-1856196745 old PR is #23749 and #23915. This PR is new, but the content is the same -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix NullArgumentException of getQuantile method in DescriptiveStatisticsHistogramStatistics [flink]

2023-12-14 Thread via GitHub
flinkbot commented on PR #23931: URL: https://github.com/apache/flink/pull/23931#issuecomment-1856171367 ## CI report: * ee5a7de3a7921a54c8561cb20ab7c56f2e6c7de7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix] Set version to 1.1.0 and not 1.0.1 [flink-connector-shared-utils]

2023-12-14 Thread via GitHub
echauchot opened a new pull request, #31: URL: https://github.com/apache/flink-connector-shared-utils/pull/31 @zentol next version jira label for new connector-parent already exists but contains version 1.1.0 and not 1.0.1 (hence this change). Do you agree that the yet-to-release changes

[PR] Fix NullArgumentException of getQuantile method in DescriptiveStatisticsHistogramStatistics [flink]

2023-12-14 Thread via GitHub
zhutong6688 opened a new pull request, #23931: URL: https://github.com/apache/flink/pull/23931 ## What is the purpose of the change Fix NullArgumentException of getQuantile method in DescriptiveStatisticsHistogramStatistics ## Brief change log This

[jira] [Resolved] (FLINK-33831) Checkout the release branch

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-33831. - Resolution: Fixed > Checkout the release branch > --- > > Key:

[jira] [Updated] (FLINK-33830) Select executing Release Manager

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33830: Affects Version/s: 1.18.0 (was: 1.17.0) > Select executing Release Manager >

[jira] [Resolved] (FLINK-33830) Select executing Release Manager

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-33830. - Fix Version/s: (was: 1.17.0) Resolution: Fixed > Select executing Release Manager >

[jira] [Updated] (FLINK-33829) Review Release Notes in JIRA

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33829: Description: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12353640 (was:

[jira] [Updated] (FLINK-33827) Review and update documentation

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33827: Description: (was: There are a few pages in the documentation that need to be reviewed and updated

[jira] [Updated] (FLINK-33827) No need for patch release - Review and update documentation

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33827: Summary: No need for patch release - Review and update documentation (was: Review and update

[jira] [Closed] (FLINK-33827) No need for patch release - Review and update documentation

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge closed FLINK-33827. --- Resolution: Won't Fix > No need for patch release - Review and update documentation >

[jira] [Updated] (FLINK-33827) Review and update documentation

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33827: Fix Version/s: (was: 1.17.0) > Review and update documentation > --- > >

Re: [PR] [hotfix] Set version to 1.1.0 and not 1.0.1 [flink-connector-shared-utils]

2023-12-14 Thread via GitHub
echauchot commented on PR #28: URL: https://github.com/apache/flink-connector-shared-utils/pull/28#issuecomment-1856141477 I just realized that I submitted the PR against main branch instead of parent-pom branch, closing and reopening ... -- This is an automated message from the Apache

Re: [PR] [hotfix] Set version to 1.1.0 and not 1.0.1 [flink-connector-shared-utils]

2023-12-14 Thread via GitHub
echauchot closed pull request #28: [hotfix] Set version to 1.1.0 and not 1.0.1 URL: https://github.com/apache/flink-connector-shared-utils/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-33851) Start End of Life discussion thread for now outdated Flink minor version

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33851: Summary: Start End of Life discussion thread for now outdated Flink minor version (was: CLONE - Start

[jira] [Updated] (FLINK-33850) Updates the docs stable version

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33850: Summary: Updates the docs stable version (was: CLONE - Updates the docs stable version) > Updates the

Re: [PR] 4 lab exercises squashed [flink-training]

2023-12-14 Thread via GitHub
ness-RemusVitan closed pull request #67: 4 lab exercises squashed URL: https://github.com/apache/flink-training/pull/67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (FLINK-33848) Other announcements

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33848: Summary: Other announcements (was: CLONE - Other announcements) > Other announcements >

[jira] [Updated] (FLINK-33848) CLONE - Other announcements

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33848: Description: h3. Recordkeeping Use 

[jira] [Updated] (FLINK-33849) CLONE - Update reference data for Migration Tests

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33849: Fix Version/s: (was: 1.19.0) (was: 1.18.1) > CLONE - Update reference data for

[jira] [Updated] (FLINK-33849) No need for patch release - Update reference data for Migration Tests

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33849: Summary: No need for patch release - Update reference data for Migration Tests (was: CLONE - Update

[jira] [Updated] (FLINK-33848) CLONE - Other announcements

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33848: Description: h3. Recordkeeping Use 

[jira] [Updated] (FLINK-33844) Update japicmp configuration

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33844: Fix Version/s: (was: 1.18.1) > Update japicmp configuration > > >

[jira] [Updated] (FLINK-33846) Remove outdated versions

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33846: Summary: Remove outdated versions (was: CLONE - Remove outdated versions) > Remove outdated versions >

[jira] [Updated] (FLINK-33844) Update japicmp configuration

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33844: Fix Version/s: (was: 1.19.0) > Update japicmp configuration > > >

[jira] [Updated] (FLINK-33847) Apache mailing lists announcements

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33847: Summary: Apache mailing lists announcements (was: CLONE - Apache mailing lists announcements) > Apache

[jira] [Updated] (FLINK-33845) Merge website pull request

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33845: Summary: Merge website pull request (was: CLONE - Merge website pull request) > Merge website pull

[jira] [Updated] (FLINK-33844) Update japicmp configuration

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33844: Summary: Update japicmp configuration (was: CLONE - Update japicmp configuration) > Update japicmp

[jira] [Assigned] (FLINK-33844) Update japicmp configuration

2023-12-14 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge reassigned FLINK-33844: --- Assignee: Jing Ge (was: Sergey Nuyanzin) > Update japicmp configuration >

  1   2   3   >