Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-18 Thread via GitHub
yunfengzhou-hub commented on PR #23927: URL: https://github.com/apache/flink/pull/23927#issuecomment-1862278523 Hi @TanYuxin-tyx could you please take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-12-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798468#comment-17798468 ] Jing Ge commented on FLINK-33588: - [~zhutong66] Thanks for the feedback. Could you please add UT or IT?

Re: [PR] [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support [flink-connector-elasticsearch]

2023-12-18 Thread via GitHub
rinkako commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1862265394 > > @mtfelisb Are you still active on this PR? > > Hi, @MartijnVisser. Yes, I'm waiting for review. Also, I'll not implement the `DynamicTableSink` because

Re: [PR] [FLINK-33798][statebackend/rocksdb] automatically clean up rocksdb logs when the task exited. [flink]

2023-12-18 Thread via GitHub
liming30 commented on code in PR #23922: URL: https://github.com/apache/flink/pull/23922#discussion_r1430990459 ## flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java: ## @@ -359,6 +365,58 @@

Re: [PR] [FLINK-33798][statebackend/rocksdb] automatically clean up rocksdb logs when the task exited. [flink]

2023-12-18 Thread via GitHub
liming30 commented on code in PR #23922: URL: https://github.com/apache/flink/pull/23922#discussion_r1430988502 ## flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java: ## @@ -359,6 +365,58 @@

Re: [PR] [FLINK-33798][statebackend/rocksdb] automatically clean up rocksdb logs when the task exited. [flink]

2023-12-18 Thread via GitHub
liming30 commented on code in PR #23922: URL: https://github.com/apache/flink/pull/23922#discussion_r1430987609 ## flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java: ## @@ -359,6 +365,58 @@

[jira] [Commented] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-12-18 Thread Tongtong Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798442#comment-17798442 ] Tongtong Zhu commented on FLINK-33588: -- [~jingge] I have tested this change on the local cluster

[jira] [Updated] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-12-18 Thread Tongtong Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tongtong Zhu updated FLINK-33588: - Attachment: image-2023-12-19-14-03-27-062.png > Fix Flink Checkpointing Statistics Bug >

[jira] [Updated] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-12-18 Thread Tongtong Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tongtong Zhu updated FLINK-33588: - Attachment: image-2023-12-19-14-02-49-083.png > Fix Flink Checkpointing Statistics Bug >

Re: [PR] [FLINK-32877][Filesystem]add HTTP options to gcs-cloud-storage client [flink]

2023-12-18 Thread via GitHub
singhravidutt commented on PR #23226: URL: https://github.com/apache/flink/pull/23226#issuecomment-1862159340 > Also @singhravidutt what's your Jira user name, so I can assign this ticket to you? you can assign this to me now. My jira username is: singhravidutt -- This is an

[jira] [Commented] (FLINK-32346) JdbcNumericBetweenParametersProvider Sharding key boundaries large storage long integer overflow, use BigDecimal instead Long

2023-12-18 Thread zhilinli (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798422#comment-17798422 ] zhilinli commented on FLINK-32346: -- Currently the documentation and the code already diverge. The

[jira] [Comment Edited] (FLINK-32346) JdbcNumericBetweenParametersProvider Sharding key boundaries large storage long integer overflow, use BigDecimal instead Long

2023-12-18 Thread zhilinli (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798422#comment-17798422 ] zhilinli edited comment on FLINK-32346 at 12/19/23 4:38 AM: Due to some

Re: [PR] [FLINK-31650][metrics][rest] Remove transient metrics for subtasks in terminal state [flink]

2023-12-18 Thread via GitHub
X-czh commented on PR #23447: URL: https://github.com/apache/flink/pull/23447#issuecomment-1862095289 @wanglijie95 Squashed and rebased, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-33198][Format/Avro] support local timezone timestamp logic type in AVRO [flink]

2023-12-18 Thread via GitHub
leonardBang commented on PR #23511: URL: https://github.com/apache/flink/pull/23511#issuecomment-1862084984 Hi, @HuangZhenQiu Would you like to rebase the PR to the latest master branch ? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-18 Thread via GitHub
xiangforever2014 commented on PR #23253: URL: https://github.com/apache/flink/pull/23253#issuecomment-1862077615 @masteryhx kindly remind~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33861] Implement restore tests for WindowRank node [flink]

2023-12-18 Thread via GitHub
flinkbot commented on PR #23956: URL: https://github.com/apache/flink/pull/23956#issuecomment-1862077122 ## CI report: * 8db6276722e5ead414953e0c782ca1b062e902a2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33877][streaming] Fix unstable test of CollectSinkFunctionTest.testConfiguredPortIsUsed [flink]

2023-12-18 Thread via GitHub
flinkbot commented on PR #23955: URL: https://github.com/apache/flink/pull/23955#issuecomment-1862076600 ## CI report: * e5da58df5653766d430260ae75c1c5f186652b8b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33198][Format/Avro] support local timezone timestamp logic type in AVRO [flink]

2023-12-18 Thread via GitHub
wuchong commented on PR #23511: URL: https://github.com/apache/flink/pull/23511#issuecomment-1862075968 Hi @PatrickRen @leonardBang , do you have time to help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-33798][statebackend/rocksdb] automatically clean up rocksdb logs when the task exited. [flink]

2023-12-18 Thread via GitHub
1996fanrui commented on code in PR #23922: URL: https://github.com/apache/flink/pull/23922#discussion_r1430885170 ## flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java: ## @@ -359,6 +365,58

[jira] [Commented] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-18 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798417#comment-17798417 ] Jiabao Sun commented on FLINK-33877: Based on the exception stack trace, it is possible that port

[PR] [FLINK-33861] Implement restore tests for WindowRank node [flink]

2023-12-18 Thread via GitHub
bvarghese1 opened a new pull request, #23956: URL: https://github.com/apache/flink/pull/23956 ## What is the purpose of the change *Add restore tests for WindowRank node* ## Verifying this change This change added tests and can be verified as follows: - Added

[jira] [Updated] (FLINK-33861) Implement restore tests for WindowRank node

2023-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33861: --- Labels: pull-request-available (was: ) > Implement restore tests for WindowRank node >

[jira] [Updated] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33877: --- Labels: pull-request-available test-stability (was: test-stability) >

[PR] [FLINK-33877][streaming] Fix unstable test of CollectSinkFunctionTest.testConfiguredPortIsUsed [flink]

2023-12-18 Thread via GitHub
Jiabao-Sun opened a new pull request, #23955: URL: https://github.com/apache/flink/pull/23955 ## What is the purpose of the change [FLINK-33877][streaming] Fix unstable test of CollectSinkFunctionTest.testConfiguredPortIsUsed

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-18 Thread via GitHub
flashJd commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1430882288 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java: ## @@ -143,7 +145,11 @@ public CollectedMetricHistory

Re: [PR] [FLINK-33502][runtime] The preparation step of ScheduledSubpartitionReader should not shut down the process [flink]

2023-12-18 Thread via GitHub
flinkbot commented on PR #23954: URL: https://github.com/apache/flink/pull/23954#issuecomment-1862054502 ## CI report: * ba611f6691b0383e2861828d2e3d968d1d4aa74d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-12-18 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798413#comment-17798413 ] Wencong Liu commented on FLINK-33502: - Sorry for the late reply. I've just identified the issue and

[PR] [FLINK-33502][runtime] The preparation step of ScheduledSubpartitionReader should not shut down the process [flink]

2023-12-18 Thread via GitHub
WencongLiu opened a new pull request, #23954: URL: https://github.com/apache/flink/pull/23954 ## What is the purpose of the change *The preparation step of ScheduledSubpartitionReader should not shut down the process.* ## Does this pull request potentially affect one of the

[jira] [Updated] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-18 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun updated FLINK-33877: --- Labels: test-stability (was: ) > CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to

Re: [PR] [FLINK-31650][metrics][rest] Remove transient metrics for subtasks in terminal state [flink]

2023-12-18 Thread via GitHub
X-czh commented on code in PR #23447: URL: https://github.com/apache/flink/pull/23447#discussion_r1430859019 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java: ## @@ -570,6 +578,19 @@ void retainSubtasks(Set activeSubtasks) {

Re: [PR] [FLINK-31650][metrics][rest] Remove transient metrics for subtasks in terminal state [flink]

2023-12-18 Thread via GitHub
JunRuiLee commented on code in PR #23447: URL: https://github.com/apache/flink/pull/23447#discussion_r1430850407 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java: ## @@ -570,6 +578,19 @@ void retainSubtasks(Set activeSubtasks)

Re: [PR] [FLINK-33689][table-runtime] Fix JsonObjectAggFunction can't retract records when enabling LocalGlobal. [flink]

2023-12-18 Thread via GitHub
lincoln-lil commented on code in PR #23827: URL: https://github.com/apache/flink/pull/23827#discussion_r1430848529 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/AggregateITCase.scala: ## @@ -1916,4 +1916,44 @@ class

Re: [PR] [FLINK-33534][runtime] Support configuring PARALLELISM_OVERRIDES during job submission [flink]

2023-12-18 Thread via GitHub
flinkbot commented on PR #23953: URL: https://github.com/apache/flink/pull/23953#issuecomment-1861985105 ## CI report: * 0165b2d94c1464a19c1b74f77e2fbaa1e5e236eb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33878) Many Keyed Operators extends `TableStreamOperator` which is marked without key.

2023-12-18 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-33878: --- Summary: Many Keyed Operators extends `TableStreamOperator` which is marked without key. (was: Many Keyed

[jira] [Commented] (FLINK-33878) Many Keyed Operator extends `TableStreamOperator` which is marked without key.

2023-12-18 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798406#comment-17798406 ] xuyang commented on FLINK-33878: Do you think we should fix it? If yes, I want to take this Jira and fix

[jira] [Created] (FLINK-33878) Many Keyed Operator extends `TableStreamOperator` which is marked without key.

2023-12-18 Thread xuyang (Jira)
xuyang created FLINK-33878: -- Summary: Many Keyed Operator extends `TableStreamOperator` which is marked without key. Key: FLINK-33878 URL: https://issues.apache.org/jira/browse/FLINK-33878 Project: Flink

[jira] [Commented] (FLINK-33878) Many Keyed Operator extends `TableStreamOperator` which is marked without key.

2023-12-18 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798405#comment-17798405 ] xuyang commented on FLINK-33878: cc [~qingyue]  > Many Keyed Operator extends `TableStreamOperator`

Re: [PR] [FLINK-33534][runtime] Support configuring PARALLELISM_OVERRIDES during job submission [flink]

2023-12-18 Thread via GitHub
yunfengzhou-hub commented on PR #23953: URL: https://github.com/apache/flink/pull/23953#issuecomment-1861973471 Hi @reswqa could you please take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] [FLINK-33534][runtime] Support configuring PARALLELISM_OVERRIDES during job submission [flink]

2023-12-18 Thread via GitHub
yunfengzhou-hub opened a new pull request, #23953: URL: https://github.com/apache/flink/pull/23953 ## What is the purpose of the change This pull request supports configuring the PARALLELISM_OVERRIDES configuration during the job submission process. Before this PR, Flink has

[jira] [Closed] (FLINK-33534) PipelineOptions.PARALLELISM_OVERRIDES is not picked up from jar submission request

2023-12-18 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-33534. -- Fix Version/s: 1.19.0 Resolution: Fixed master(1.19) via

Re: [PR] [FLINK-33534][runtime] Support configuring PARALLELISM_OVERRIDES during job submission [flink]

2023-12-18 Thread via GitHub
reswqa merged PR #23944: URL: https://github.com/apache/flink/pull/23944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33876][table-planner][JUnit5 Migration] Introduce methodName method in TableTestBase [flink]

2023-12-18 Thread via GitHub
Jiabao-Sun commented on PR #23952: URL: https://github.com/apache/flink/pull/23952#issuecomment-1861943681 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-18 Thread Jiabao Sun (Jira)
Jiabao Sun created FLINK-33877: -- Summary: CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException Key: FLINK-33877 URL: https://issues.apache.org/jira/browse/FLINK-33877 Project:

[jira] [Updated] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-18 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun updated FLINK-33877: --- Priority: Critical (was: Major) > CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to

[jira] [Commented] (FLINK-33531) Nightly Python fails with NPE at metadataHandlerProvider on AZP (StreamDependencyTests.test_add_python_archive)

2023-12-18 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798370#comment-17798370 ] Sergey Nuyanzin commented on FLINK-33531: - Merged to 1.18.1 as

Re: [PR] [BP-1.18][FLINK-33531][python] Remove cython upper bounds [flink]

2023-12-18 Thread via GitHub
snuyanzin merged PR #23950: URL: https://github.com/apache/flink/pull/23950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2023-12-18 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798369#comment-17798369 ] Jim Hughes commented on FLINK-27756:

[jira] [Commented] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2023-12-18 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798368#comment-17798368 ] Jim Hughes commented on FLINK-27756:

Re: [PR] [BP-1.18][FLINK-33531][python] Remove cython upper bounds [flink]

2023-12-18 Thread via GitHub
snuyanzin commented on PR #23950: URL: https://github.com/apache/flink/pull/23950#issuecomment-1861775006 thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Fix a few doc mistakes [flink-kubernetes-operator]

2023-12-18 Thread via GitHub
ryanvanhuuksloot opened a new pull request, #736: URL: https://github.com/apache/flink-kubernetes-operator/pull/736 ## What is the purpose of the change Fix a few things in the docs ## Brief change log Fix a few things in the docs ## Verifying this change No

Re: [PR] Fix a few doc mistakes [flink-kubernetes-operator]

2023-12-18 Thread via GitHub
ryanvanhuuksloot commented on PR #736: URL: https://github.com/apache/flink-kubernetes-operator/pull/736#issuecomment-1861544730 Someone with merge privileges please merge after reviewing  -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-33872] Retrieve checkpoint history for jobs in completed state [flink]

2023-12-18 Thread via GitHub
dannycranmer commented on code in PR #23949: URL: https://github.com/apache/flink/pull/23949#discussion_r1430540231 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java: ## @@ -683,6 +685,129 @@ public void testRetrieveCheckpointStats() throws

Re: [PR] [FLINK-33872] Retrieve checkpoint history for jobs in completed state [flink]

2023-12-18 Thread via GitHub
dannycranmer commented on PR #23949: URL: https://github.com/apache/flink/pull/23949#issuecomment-1861348278 CI Failure: > Dec 18 16:52:43 16:52:43.222 [ERROR] DispatcherTest.testRetrieveCheckpointStatsOnNonExistentJob:804 -- This is an automated message from the Apache Git

Re: [PR] [FLINK-33872] Retrieve checkpoint history for jobs in completed state [flink]

2023-12-18 Thread via GitHub
dannycranmer commented on code in PR #23949: URL: https://github.com/apache/flink/pull/23949#discussion_r1430540231 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java: ## @@ -683,6 +685,129 @@ public void testRetrieveCheckpointStats() throws

Re: [PR] [FLINK-33872] Retrieve checkpoint history for jobs in completed state [flink]

2023-12-18 Thread via GitHub
dannycranmer commented on code in PR #23949: URL: https://github.com/apache/flink/pull/23949#discussion_r1430538449 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java: ## @@ -683,6 +685,129 @@ public void testRetrieveCheckpointStats() throws

Re: [PR] [FLINK-30535] Introduce TTL state based benchmarks [flink-benchmarks]

2023-12-18 Thread via GitHub
Zakelly commented on code in PR #83: URL: https://github.com/apache/flink-benchmarks/pull/83#discussion_r1430468167 ## src/main/java/org/apache/flink/state/benchmark/ttl/TtlStateBenchmarkBase.java: ## @@ -0,0 +1,48 @@ +package org.apache.flink.state.benchmark.ttl; + +import

Re: [PR] Bump org.apache.commons:commons-compress from 1.23.0 to 1.24.0 [flink-connector-jdbc]

2023-12-18 Thread via GitHub
eskabetxe commented on PR #84: URL: https://github.com/apache/flink-connector-jdbc/pull/84#issuecomment-1861086328 @MartijnVisser LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [BP-1.18][FLINK-33531][python] Remove cython upper bounds [flink]

2023-12-18 Thread via GitHub
JingGe commented on PR #23950: URL: https://github.com/apache/flink/pull/23950#issuecomment-1860976058 @snuyanzin thanks for the heads-up. Let's add it into 1.18.1 release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (FLINK-33531) Nightly Python fails with NPE at metadataHandlerProvider on AZP (StreamDependencyTests.test_add_python_archive)

2023-12-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33531: Affects Version/s: 1.18.0 > Nightly Python fails with NPE at metadataHandlerProvider on AZP >

[jira] [Updated] (FLINK-33531) Nightly Python fails with NPE at metadataHandlerProvider on AZP (StreamDependencyTests.test_add_python_archive)

2023-12-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33531: Fix Version/s: 1.18.1 > Nightly Python fails with NPE at metadataHandlerProvider on AZP >

[jira] [Commented] (FLINK-33531) Nightly Python fails with NPE at metadataHandlerProvider on AZP (StreamDependencyTests.test_add_python_archive)

2023-12-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798275#comment-17798275 ] Jing Ge commented on FLINK-33531: - let's add it into 1.18.1 release > Nightly Python fails with NPE at

[PR] [FLINK-33560][Connectors/AWS] Externalize AWS Python connectors from Flink to AWS project [flink-connector-aws]

2023-12-18 Thread via GitHub
dannycranmer opened a new pull request, #121: URL: https://github.com/apache/flink-connector-aws/pull/121 ## Purpose of the change Inspired by https://github.com/apache/flink-connector-kafka/pull/69, moves `kinesis.py` and `test_kinesis.py` from `apache/flink` to

[jira] [Updated] (FLINK-33560) Externalize Kinesis Python connector code

2023-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33560: --- Labels: pull-request-available (was: ) > Externalize Kinesis Python connector code >

Re: [PR] [FLINK-30535] Introduce TTL state based benchmarks [flink-benchmarks]

2023-12-18 Thread via GitHub
Zakelly commented on code in PR #83: URL: https://github.com/apache/flink-benchmarks/pull/83#discussion_r1430371694 ## src/main/java/org/apache/flink/state/benchmark/ttl/TtlListStateBenchmark.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (FLINK-32850) [JUnit5 Migration] The io package of flink-runtime module

2023-12-18 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798267#comment-17798267 ] Jiabao Sun commented on FLINK-32850: Merged master (1.19) via:

Re: [PR] [FLINK-33823] Make PlannerQueryOperation SQL serializable [flink]

2023-12-18 Thread via GitHub
twalthr commented on code in PR #23948: URL: https://github.com/apache/flink/pull/23948#discussion_r1430361998 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/PlannerQueryOperation.java: ## @@ -72,6 +75,13 @@ public String

Re: [PR] [FLINK-33876][table-planner][JUnit5 Migration] Introduce methodName method in TableTestBase [flink]

2023-12-18 Thread via GitHub
flinkbot commented on PR #23952: URL: https://github.com/apache/flink/pull/23952#issuecomment-1860933072 ## CI report: * 85c84e98f1c1c483972dbe30b4e30ca127817360 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33823] Make PlannerQueryOperation SQL serializable [flink]

2023-12-18 Thread via GitHub
twalthr commented on code in PR #23948: URL: https://github.com/apache/flink/pull/23948#discussion_r1430361475 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/PlannerQueryOperation.java: ## @@ -72,6 +75,13 @@ public String

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-12-18 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798178#comment-17798178 ] david radley edited comment on FLINK-33365 at 12/18/23 4:12 PM: [~Sergey

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-12-18 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798178#comment-17798178 ] david radley edited comment on FLINK-33365 at 12/18/23 4:10 PM: [~Sergey

[jira] [Updated] (FLINK-33876) [JUnit5 Migration] Introduce methodName method in TableTestBase

2023-12-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33876: --- Labels: pull-request-available (was: ) > [JUnit5 Migration] Introduce methodName method in

Re: [PR] [FLINK-33876][table-planner][JUnit5 Migration] Introduce methodName method in TableTestBase [flink]

2023-12-18 Thread via GitHub
Jiabao-Sun commented on PR #23952: URL: https://github.com/apache/flink/pull/23952#issuecomment-1860909405 Hi @leonardBang, please help review it when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] [FLINK-33876][table-planner][JUnit5 Migration] Introduce methodName method in TableTestBase [flink]

2023-12-18 Thread via GitHub
Jiabao-Sun opened a new pull request, #23952: URL: https://github.com/apache/flink/pull/23952 ## What is the purpose of the change [FLINK-33876][table-planner][JUnit5 Migration] Introduce methodName method in TableTestBase ## Brief change log After completing

[jira] [Updated] (FLINK-33876) [JUnit5 Migration] Introduce methodName method in TableTestBase

2023-12-18 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun updated FLINK-33876: --- Summary: [JUnit5 Migration] Introduce methodName method in TableTestBase (was: [JUnit5 Migration]

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2023-12-18 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798256#comment-17798256 ] Ahmed Hamdy commented on FLINK-31472: - [~Sergey Nuyanzin] I have pushed a PR with the fix, would be

[jira] [Created] (FLINK-33876) [JUnit5 Migration] Introduce testName method in TableTestBase

2023-12-18 Thread Jiabao Sun (Jira)
Jiabao Sun created FLINK-33876: -- Summary: [JUnit5 Migration] Introduce testName method in TableTestBase Key: FLINK-33876 URL: https://issues.apache.org/jira/browse/FLINK-33876 Project: Flink

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.api package of flink-runtime module [flink]

2023-12-18 Thread via GitHub
dawidwys merged PR #23590: URL: https://github.com/apache/flink/pull/23590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33862) Flink Unit Test Failures on 1.18.0

2023-12-18 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798251#comment-17798251 ] Prabhu Joseph commented on FLINK-33862: --- Yes right. Thanks [~martijnvisser]. > Flink Unit Test

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.api package of flink-runtime module [flink]

2023-12-18 Thread via GitHub
dawidwys commented on code in PR #23590: URL: https://github.com/apache/flink/pull/23590#discussion_r1430305765 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/CheckpointBarrierTest.java: ## @@ -22,37 +22,29 @@ import

Re: [PR] [FLINK-33823] Make PlannerQueryOperation SQL serializable [flink]

2023-12-18 Thread via GitHub
twalthr commented on code in PR #23948: URL: https://github.com/apache/flink/pull/23948#discussion_r1430298273 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/PlannerQueryOperation.java: ## @@ -72,6 +75,13 @@ public String

[jira] [Commented] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-12-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798240#comment-17798240 ] Jing Ge commented on FLINK-33588: - [~zhutong66] could you please write a test for your change? > Fix

[jira] [Comment Edited] (FLINK-32964) KinesisStreamsSink cant renew credentials with WebIdentityTokenFileCredentialsProvider

2023-12-18 Thread Jan Kamieth (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798229#comment-17798229 ] Jan Kamieth edited comment on FLINK-32964 at 12/18/23 2:42 PM: --- Hi, we

[jira] [Comment Edited] (FLINK-32964) KinesisStreamsSink cant renew credentials with WebIdentityTokenFileCredentialsProvider

2023-12-18 Thread Jan Kamieth (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798229#comment-17798229 ] Jan Kamieth edited comment on FLINK-32964 at 12/18/23 2:41 PM: --- Hi, we

[jira] [Comment Edited] (FLINK-32964) KinesisStreamsSink cant renew credentials with WebIdentityTokenFileCredentialsProvider

2023-12-18 Thread Jan Kamieth (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798229#comment-17798229 ] Jan Kamieth edited comment on FLINK-32964 at 12/18/23 2:41 PM: --- Hi, we

[jira] [Comment Edited] (FLINK-32964) KinesisStreamsSink cant renew credentials with WebIdentityTokenFileCredentialsProvider

2023-12-18 Thread Jan Kamieth (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798229#comment-17798229 ] Jan Kamieth edited comment on FLINK-32964 at 12/18/23 2:40 PM: --- Hi, we

[jira] [Comment Edited] (FLINK-32964) KinesisStreamsSink cant renew credentials with WebIdentityTokenFileCredentialsProvider

2023-12-18 Thread Jan Kamieth (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798229#comment-17798229 ] Jan Kamieth edited comment on FLINK-32964 at 12/18/23 2:40 PM: --- Hi, we

[jira] [Created] (FLINK-33875) Support slots wait mechanism at DeclarativeSlotPoolBridge side for Default Scheduler

2023-12-18 Thread RocMarshal (Jira)
RocMarshal created FLINK-33875: -- Summary: Support slots wait mechanism at DeclarativeSlotPoolBridge side for Default Scheduler Key: FLINK-33875 URL: https://issues.apache.org/jira/browse/FLINK-33875

[jira] [Updated] (FLINK-33874) Support resource request wait mechanism at DefaultDeclarativeSlotPool side for Default Scheduler

2023-12-18 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33874: --- Summary: Support resource request wait mechanism at DefaultDeclarativeSlotPool side for Default

[jira] [Comment Edited] (FLINK-32964) KinesisStreamsSink cant renew credentials with WebIdentityTokenFileCredentialsProvider

2023-12-18 Thread Jan Kamieth (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798229#comment-17798229 ] Jan Kamieth edited comment on FLINK-32964 at 12/18/23 2:36 PM: --- Hi, we

[jira] [Updated] (FLINK-33874) Introduce resource request wait mechanism at DefaultDeclarativeSlotPool side for Default Scheduler

2023-12-18 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33874: --- Parent: FLINK-31757 Issue Type: Sub-task (was: New Feature) > Introduce resource request

[jira] [Created] (FLINK-33874) Introduce resource request wait mechanism at DefaultDeclarativeSlotPool side for Default Scheduler

2023-12-18 Thread RocMarshal (Jira)
RocMarshal created FLINK-33874: -- Summary: Introduce resource request wait mechanism at DefaultDeclarativeSlotPool side for Default Scheduler Key: FLINK-33874 URL: https://issues.apache.org/jira/browse/FLINK-33874

[jira] [Commented] (FLINK-32964) KinesisStreamsSink cant renew credentials with WebIdentityTokenFileCredentialsProvider

2023-12-18 Thread Jan Kamieth (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798229#comment-17798229 ] Jan Kamieth commented on FLINK-32964: - Hi, we have the same issue in the same setup. Flink 1.17

[jira] [Commented] (FLINK-33873) Create a Redis HyperLogLog Connector for Flink

2023-12-18 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798220#comment-17798220 ] Martijn Visser commented on FLINK-33873: [~jinsuichen] I've granted you the necessary

[jira] [Updated] (FLINK-32949) Allow specifying the ServerSocket port for the collect function when accessing the TaskManager from the client.

2023-12-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-32949: Fix Version/s: 1.19.0 > Allow specifying the ServerSocket port for the collect function when > accessing

[jira] [Resolved] (FLINK-32949) Allow specifying the ServerSocket port for the collect function when accessing the TaskManager from the client.

2023-12-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-32949. - Resolution: Fixed > Allow specifying the ServerSocket port for the collect function when > accessing

[jira] [Commented] (FLINK-32949) Allow specifying the ServerSocket port for the collect function when accessing the TaskManager from the client.

2023-12-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798219#comment-17798219 ] Jing Ge commented on FLINK-32949: - master: e6169cee12d66ce22f7907b8dc947d4e96228b30 > Allow specifying

Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]

2023-12-18 Thread via GitHub
JingGe merged PR #23870: URL: https://github.com/apache/flink/pull/23870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-31481][table] Support enhanced show databases syntax [flink]

2023-12-18 Thread via GitHub
jnh5y commented on PR #23612: URL: https://github.com/apache/flink/pull/23612#issuecomment-1860558626 > Hi @jnh5y could you please check if your comments are addressed? Thanks! Hi @jeyhunkarimov, sorry to be slow to look again. Things are looking good. @dawidwys would you be

Re: [PR] [FLINK-31481][table] Support enhanced show databases syntax [flink]

2023-12-18 Thread via GitHub
jnh5y commented on code in PR #23612: URL: https://github.com/apache/flink/pull/23612#discussion_r1430168768 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java: ## @@ -0,0 +1,58 @@ +/* + *

Re: [PR] [FLINK-31481][table] Support enhanced show databases syntax [flink]

2023-12-18 Thread via GitHub
jnh5y commented on code in PR #23612: URL: https://github.com/apache/flink/pull/23612#discussion_r1430167319 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowDatabasesOperation.java: ## @@ -20,26 +20,108 @@ import

  1   2   3   >