Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

2023-12-20 Thread via GitHub
leonardBang commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1433677957 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/TwoPhaseCommittingSink.java: ## @@ -40,17 +37,9 @@ * @param The type of the committables. */

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-20 Thread via GitHub
yunfengzhou-hub commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1433659493 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeResultPartition.java: ## @@ -533,7 +533,7 @@ public void close() { }

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-20 Thread via GitHub
yunfengzhou-hub commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1433656381 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionIndexSet.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33877][streaming] Adjusting CollectSinkFunctionTest.testConfiguredPortIsUsed's assertion message to work with JDK 17 & 21 [flink]

2023-12-20 Thread via GitHub
Jiabao-Sun commented on PR #23976: URL: https://github.com/apache/flink/pull/23976#issuecomment-1865720524 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2023-12-20 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799285#comment-17799285 ] Jiabao Sun commented on FLINK-27756:

[jira] [Closed] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-12-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-33502. -- Resolution: Fixed master(1.19) 593e443cd85962ffa512e26d1a900eccf5f705ca. Feel free to reopen it if

Re: [PR] [FLINK-25476][table-planner] support CHAR type in function MAX and MIN [flink]

2023-12-20 Thread via GitHub
xuyangzhong commented on code in PR #18375: URL: https://github.com/apache/flink/pull/18375#discussion_r1433633656 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/AggregateITCase.scala: ## @@ -1331,6 +1331,81 @@ class

Re: [PR] [FLINK-33502][network] Refactor DiskIOScheduler to handle exceptions more gracefully and improve error handling logic [flink]

2023-12-20 Thread via GitHub
reswqa merged PR #23954: URL: https://github.com/apache/flink/pull/23954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33502][network] Refactor DiskIOScheduler to handle exceptions more gracefully and improve error handling logic [flink]

2023-12-20 Thread via GitHub
reswqa commented on code in PR #23954: URL: https://github.com/apache/flink/pull/23954#discussion_r1433628981 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskIOScheduler.java: ## @@ -206,9 +206,9 @@ private int

Re: [PR] [FLINK-33502][network] Refactor DiskIOScheduler to handle exceptions more gracefully and improve error handling logic [flink]

2023-12-20 Thread via GitHub
reswqa commented on code in PR #23954: URL: https://github.com/apache/flink/pull/23954#discussion_r1433628981 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskIOScheduler.java: ## @@ -206,9 +206,9 @@ private int

Re: [PR] [FLINK-33502][network] Refactor DiskIOScheduler to handle exceptions more gracefully and improve error handling logic [flink]

2023-12-20 Thread via GitHub
WencongLiu commented on code in PR #23954: URL: https://github.com/apache/flink/pull/23954#discussion_r1433606853 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskIOScheduler.java: ## @@ -206,9 +206,9 @@ private int

Re: [PR] [FLINK-33502][network] Refactor DiskIOScheduler to handle exceptions more gracefully and improve error handling logic [flink]

2023-12-20 Thread via GitHub
reswqa commented on code in PR #23954: URL: https://github.com/apache/flink/pull/23954#discussion_r1433587339 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskIOScheduler.java: ## @@ -206,9 +206,9 @@ private int

Re: [PR] [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2023-12-20 Thread via GitHub
ferenc-csaky commented on PR #35: URL: https://github.com/apache/flink-connector-hbase/pull/35#issuecomment-1865506167 cc @MartijnVisser @snuyanzin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2023-12-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799272#comment-17799272 ] Weijie Guo commented on FLINK-33856: Yep, it seems feasible. I have assigned this to you. Before you

[jira] [Assigned] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2023-12-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-33856: -- Assignee: Jufang He > Add metrics to monitor the interaction performance between task and

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2023-12-20 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799254#comment-17799254 ] Jiang Xin commented on FLINK-33856: --- [~hejufang001] I'm sorry, I have no permission to assign but I

Re: [PR] FLINK-25029: Hadoop Caller Context Setting in Flink [flink]

2023-12-20 Thread via GitHub
liangyu-1 commented on PR #17958: URL: https://github.com/apache/flink/pull/17958#issuecomment-1865455819 Is there anyone still working on this issue? I met the same problem in my scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2023-12-20 Thread Jufang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799247#comment-17799247 ] Jufang He commented on FLINK-33856: --- [~Jiang Xin] Yes, this metrics optimization has been implemented

[jira] [Closed] (FLINK-33490) Validate the name conflicts when creating view

2023-12-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-33490. - Resolution: Fixed > Validate the name conflicts when creating view >

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799240#comment-17799240 ] Shengkai Fang commented on FLINK-33490: --- Merged into master:

Re: [PR] [FLINK-33490][table-planner] Validate the column name conflicts in view when creating view [flink]

2023-12-20 Thread via GitHub
fsk119 merged PR #23760: URL: https://github.com/apache/flink/pull/23760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-20 Thread via GitHub
TanYuxin-tyx commented on code in PR #23927: URL: https://github.com/apache/flink/pull/23927#discussion_r1432220667 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java: ## @@ -304,7 +306,15 @@ enum DataType { RECOVERY_COMPLETION(false,

[jira] [Commented] (FLINK-33897) Allow triggering unaligned checkpoint via CLI

2023-12-20 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799233#comment-17799233 ] Zakelly Lan commented on FLINK-33897: - This also require the {{SingleCheckpointBarrierHandler}}

[jira] [Commented] (FLINK-33881) [TtlListState]Avoid copy and update value in TtlListState#getUnexpiredOrNull

2023-12-20 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799232#comment-17799232 ] Zakelly Lan commented on FLINK-33881: - [~lijinzhong] Thus I have no problem. And actually I think

[jira] [Comment Edited] (FLINK-33881) [TtlListState]Avoid copy and update value in TtlListState#getUnexpiredOrNull

2023-12-20 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799232#comment-17799232 ] Zakelly Lan edited comment on FLINK-33881 at 12/21/23 2:28 AM: ---

[jira] [Assigned] (FLINK-33881) [TtlListState]Avoid copy and update value in TtlListState#getUnexpiredOrNull

2023-12-20 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-33881: --- Assignee: Jinzhong Li > [TtlListState]Avoid copy and update value in

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-20 Thread via GitHub
flashJd commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1433376746 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,24 @@ private static Map

Re: [PR] [FLINK-33877][streaming] Adjusting CollectSinkFunctionTest.testConfiguredPortIsUsed's assertion message to work with JDK 21 [flink]

2023-12-20 Thread via GitHub
flinkbot commented on PR #23976: URL: https://github.com/apache/flink/pull/23976#issuecomment-1865386058 ## CI report: * 20523a5f4595ea63effa59fb209cf610071c548f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33877][streaming] Adjusting CollectSinkFunctionTest.testConfiguredPortIsUsed's assertion message to work with JDK 21 [flink]

2023-12-20 Thread via GitHub
Jiabao-Sun commented on PR #23976: URL: https://github.com/apache/flink/pull/23976#issuecomment-1865385787 Hi @snuyanzin, please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-20 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799231#comment-17799231 ] Jiabao Sun commented on FLINK-33877: Thanks [~Sergey Nuyanzin] to report this. I noticed that it

[PR] [FLINK-33877][streaming] Adjusting CollectSinkFunctionTest.testConfiguredPortIsUsed's assertion message to work with JDK 21 [flink]

2023-12-20 Thread via GitHub
Jiabao-Sun opened a new pull request, #23976: URL: https://github.com/apache/flink/pull/23976 ## What is the purpose of the change [FLINK-33877][streaming] Adjusting CollectSinkFunctionTest.testConfiguredPortIsUsed's assertion message to work with JDK 21

[jira] [Updated] (FLINK-33880) Introducing Retry Mechanism for Listing TaskManager Pods to Prevent API Server Connection Failures

2023-12-20 Thread Yuan Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Huang updated FLINK-33880: Attachment: image-2023-12-21-10-12-37-667.png Description: When operating in Kubernetes

Re: [PR] [FLINK-33879] Avoids the potential hang of Hybrid Shuffle during redistribution [flink]

2023-12-20 Thread via GitHub
jiangxin369 commented on PR #23957: URL: https://github.com/apache/flink/pull/23957#issuecomment-1865364340 @TanYuxin-tyx Could you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (FLINK-33788) Table not found for catalogname is capital

2023-12-20 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799223#comment-17799223 ] luoyuxia commented on FLINK-33788: -- [~shaoguang] What's the problem you meet that casue the push fail?

Re: [PR] [FLIP 400] Introduces AsyncScalarFunction as a new UDF type [flink]

2023-12-20 Thread via GitHub
AlanConfluent commented on code in PR #23975: URL: https://github.com/apache/flink/pull/23975#discussion_r1433297124 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/AsyncCalcSyncModeRule.java: ## @@ -0,0 +1,146 @@ +/* + *

Re: [PR] [FLIP 400] Introduces AsyncScalarFunction as a new UDF type [flink]

2023-12-20 Thread via GitHub
flinkbot commented on PR #23975: URL: https://github.com/apache/flink/pull/23975#issuecomment-1865305626 ## CI report: * 0a5a00a39da8ce1ab4db47295b49251fa8d1c631 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLIP 400] Introduces AsyncScalarFunction as a new UDF type [flink]

2023-12-20 Thread via GitHub
AlanConfluent commented on code in PR #23975: URL: https://github.com/apache/flink/pull/23975#discussion_r1433296125 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/trait/AsyncOperatorModeTrait.java: ## @@ -0,0 +1,47 @@ +package

[PR] [FLIP 400] Introduces AsyncScalarFunction as a new UDF type [flink]

2023-12-20 Thread via GitHub
AlanConfluent opened a new pull request, #23975: URL: https://github.com/apache/flink/pull/23975 ## What is the purpose of the change This introduces `AsyncScalarFunction` a new UDF type which allows asynchronous responses. The functionality here is covered in FLIP-400:

[jira] [Updated] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2023-12-20 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Sharath Dandi updated FLINK-33817: -- Description: *Background*   The current Protobuf format

Re: [PR] [FLINK-33611] [flink-protobuf] Support Large Protobuf Schemas [flink]

2023-12-20 Thread via GitHub
sharath1709 commented on PR #23937: URL: https://github.com/apache/flink/pull/23937#issuecomment-1865255265 @libenchao Can you please review this PR? I see you're one of the main reviewer for this module in the past -- This is an automated message from the Apache Git Service. To respond

[jira] [Comment Edited] (FLINK-21224) Remove BatchExecExchange and StreamExecExchange, and replace their functionality with ExecEdge

2023-12-20 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799190#comment-17799190 ] Jim Hughes edited comment on FLINK-21224 at 12/20/23 10:08 PM: --- As a note,

[jira] [Commented] (FLINK-21224) Remove BatchExecExchange and StreamExecExchange, and replace their functionality with ExecEdge

2023-12-20 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799190#comment-17799190 ] Jim Hughes commented on FLINK-21224: As a note, if this node is used, it would need a compilled plan

Re: [PR] [FLINK-33902][ci] Adds -legacy to openssl command [flink]

2023-12-20 Thread via GitHub
XComp commented on code in PR #23961: URL: https://github.com/apache/flink/pull/23961#discussion_r1433172828 ## flink-end-to-end-tests/test-scripts/common_ssl.sh: ## @@ -67,8 +67,15 @@ function _set_conf_ssl_helper { keytool -importcert -keystore "${ssl_dir}/node.keystore"

Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]

2023-12-20 Thread via GitHub
snuyanzin commented on code in PR #23962: URL: https://github.com/apache/flink/pull/23962#discussion_r1433172250 ## flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemTest.java: ## @@ -236,6 +237,7 @@ public void testRenameNonExistingFile() throws

Re: [PR] [FLINK-27082][ci] Disables tests that relies on disabling file permissions [flink]

2023-12-20 Thread via GitHub
snuyanzin commented on code in PR #23962: URL: https://github.com/apache/flink/pull/23962#discussion_r1433172250 ## flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemTest.java: ## @@ -236,6 +237,7 @@ public void testRenameNonExistingFile() throws

Re: [PR] [FLINK-33902][ci] Adds -legacy to openssl command [flink]

2023-12-20 Thread via GitHub
snuyanzin commented on code in PR #23961: URL: https://github.com/apache/flink/pull/23961#discussion_r1433167209 ## flink-end-to-end-tests/test-scripts/common_ssl.sh: ## @@ -67,8 +67,15 @@ function _set_conf_ssl_helper { keytool -importcert -keystore

[jira] [Closed] (FLINK-33904) Add zip as a package to GitHub Actions runners

2023-12-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-33904. - Resolution: Won't Fix It will be fixed in the workflow > Add zip as a package to GitHub

Re: [PR] [FLINK-33904][test] Installs missing zip package [flink]

2023-12-20 Thread via GitHub
XComp commented on PR #23963: URL: https://github.com/apache/flink/pull/23963#issuecomment-1865091763 Closing this one because we should prep the runners in the workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-33904][test] Installs missing zip package [flink]

2023-12-20 Thread via GitHub
XComp closed pull request #23963: [FLINK-33904][test] Installs missing zip package URL: https://github.com/apache/flink/pull/23963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799161#comment-17799161 ] Sergey Nuyanzin commented on FLINK-33877: - [~jiabao.sun]could you have a look please? >

[jira] [Comment Edited] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799159#comment-17799159 ] Sergey Nuyanzin edited comment on FLINK-33877 at 12/20/23 8:07 PM: ---

[jira] [Reopened] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reopened FLINK-33877: - Have to reopen since it is reproduced again with same issue

[jira] [Created] (FLINK-33919) AutoRescalingITCase hangs on AZP

2023-12-20 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33919: --- Summary: AutoRescalingITCase hangs on AZP Key: FLINK-33919 URL: https://issues.apache.org/jira/browse/FLINK-33919 Project: Flink Issue Type:

[jira] [Updated] (FLINK-33919) AutoRescalingITCase hangs on AZP

2023-12-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33919: Issue Type: Bug (was: Improvement) > AutoRescalingITCase hangs on AZP >

[jira] [Closed] (FLINK-33918) Fix AsyncSinkWriterThrottlingTest test failure

2023-12-20 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Hughes closed FLINK-33918. -- Resolution: Duplicate Duplicate of https://issues.apache.org/jira/browse/FLINK-31472 > Fix

[jira] [Commented] (FLINK-33918) Fix AsyncSinkWriterThrottlingTest test failure

2023-12-20 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799149#comment-17799149 ] Jim Hughes commented on FLINK-33918: Sorry for the duplicate! > Fix AsyncSinkWriterThrottlingTest

[jira] [Commented] (FLINK-33918) Fix AsyncSinkWriterThrottlingTest test failure

2023-12-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799147#comment-17799147 ] Martijn Visser commented on FLINK-33918: [~jhughes] I think you might have to rebase, it appears

[jira] [Updated] (FLINK-33917) IllegalArgumentException: hostname can't be null

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33917: --- Labels: pull-request-available (was: ) > IllegalArgumentException: hostname can't be null

[PR] [FLINK-33917] fix hostname can't be null for certain edgecases [flink-kubernetes-operator]

2023-12-20 Thread via GitHub
ensctom opened a new pull request, #738: URL: https://github.com/apache/flink-kubernetes-operator/pull/738 ## What is the purpose of the change Fix hostname is null under certain edgecases. ## Brief change log *(for example:)* - refactor

[jira] [Updated] (FLINK-33918) Fix AsyncSinkWriterThrottlingTest test failure

2023-12-20 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Hughes updated FLINK-33918: --- Description: >From

[jira] [Commented] (FLINK-33918) Fix AsyncSinkWriterThrottlingTest test failure

2023-12-20 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799139#comment-17799139 ] Jim Hughes commented on FLINK-33918:

[jira] [Created] (FLINK-33918) Fix AsyncSinkWriterThrottlingTest test failure

2023-12-20 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33918: -- Summary: Fix AsyncSinkWriterThrottlingTest test failure Key: FLINK-33918 URL: https://issues.apache.org/jira/browse/FLINK-33918 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-33917) IllegalArgumentException: hostname can't be null

2023-12-20 Thread Tom (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom updated FLINK-33917: Description: In certain scenarios, if the hostname contains certain characters it will throw an exception when

[jira] [Updated] (FLINK-33917) IllegalArgumentException: hostname can't be null

2023-12-20 Thread Tom (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom updated FLINK-33917: Description: In certain scenarios, if the hostname contains certain characters it will throw an exception when

[jira] [Updated] (FLINK-33917) IllegalArgumentException: hostname can't be null

2023-12-20 Thread Tom (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom updated FLINK-33917: Description: In certain scenarios, if the hostname contains certain characters it will throw an exception when

[jira] [Created] (FLINK-33917) IllegalArgumentException: hostname can't be null

2023-12-20 Thread Tom (Jira)
Tom created FLINK-33917: --- Summary: IllegalArgumentException: hostname can't be null Key: FLINK-33917 URL: https://issues.apache.org/jira/browse/FLINK-33917 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-33531) Nightly Python fails with NPE at metadataHandlerProvider on AZP (StreamDependencyTests.test_add_python_archive)

2023-12-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799119#comment-17799119 ] Matthias Pohl commented on FLINK-33531: --- It looks like this fix is not good enough? The following

[jira] [Resolved] (FLINK-33641) JUnit5 fails to delete a directory on AZP for various table-planner tests

2023-12-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-33641. --- Resolution: Fixed > JUnit5 fails to delete a directory on AZP for various table-planner

[jira] [Comment Edited] (FLINK-33641) JUnit5 fails to delete a directory on AZP for various table-planner tests

2023-12-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799113#comment-17799113 ] Matthias Pohl edited comment on FLINK-33641 at 12/20/23 5:42 PM: - Thanks

[jira] [Commented] (FLINK-33641) JUnit5 fails to delete a directory on AZP for various table-planner tests

2023-12-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799113#comment-17799113 ] Matthias Pohl commented on FLINK-33641: --- Thanks for the point, [~jiabao.sun] . I will update my

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-20 Thread via GitHub
mxm commented on PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#issuecomment-186482 > @gyfora @mxm by the way, I'd like to discuss the logic of scaling effectiveness evaluation with you. > > 1. Now it's controlled by two config

Re: [PR] [FLINK-33795] Add a new config to forbid autoscale execution in the configured excluded periods [flink-kubernetes-operator]

2023-12-20 Thread via GitHub
mxm commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1432942758 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -264,4 +262,24 @@ private static Map

[jira] [Commented] (FLINK-33900) Multiple failures in WindowRankITCase due to NoResourceAvailableException

2023-12-20 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799095#comment-17799095 ] Jiabao Sun commented on FLINK-33900: I noticed there is information about JUnit4 in the stack

Re: [PR] [FLINK-33888] Add release flink-1.18.1 [flink-web]

2023-12-20 Thread via GitHub
GOODBOY008 commented on code in PR #706: URL: https://github.com/apache/flink-web/pull/706#discussion_r1432936588 ## docs/content/posts/2023-12-20-release-1.18.1.md: ## @@ -0,0 +1,142 @@ +--- +title: "Apache Flink 1.18.1 Release Announcement" +date: "2023-12-20T00:00:00.000Z"

Re: [PR] [FLINK-33888] Add release flink-1.18.1 [flink-web]

2023-12-20 Thread via GitHub
GOODBOY008 commented on code in PR #706: URL: https://github.com/apache/flink-web/pull/706#discussion_r1432926072 ## docs/content/posts/2023-12-20-release-1.18.1.md: ## @@ -0,0 +1,142 @@ +--- +title: "Apache Flink 1.18.1 Release Announcement" +date: "2023-12-20T00:00:00.000Z"

Re: [PR] [FLINK-33888] Add release flink-1.18.1 [flink-web]

2023-12-20 Thread via GitHub
GOODBOY008 commented on code in PR #706: URL: https://github.com/apache/flink-web/pull/706#discussion_r1432926072 ## docs/content/posts/2023-12-20-release-1.18.1.md: ## @@ -0,0 +1,142 @@ +--- +title: "Apache Flink 1.18.1 Release Announcement" +date: "2023-12-20T00:00:00.000Z"

Re: [PR] [FLINK-32849][runtime][JUnit5 Migration] The resourcemanager package of flink-runtime module [flink]

2023-12-20 Thread via GitHub
1996fanrui commented on code in PR #23973: URL: https://github.com/apache/flink/pull/23973#discussion_r1432906607 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/ResourceManagerJobMasterTest.java: ## @@ -191,12 +184,12 @@ public void

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

2023-12-20 Thread via GitHub
pvary commented on PR #23912: URL: https://github.com/apache/flink/pull/23912#issuecomment-1864763831 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.partition package of flink-runtime module [flink]

2023-12-20 Thread via GitHub
Jiabao-Sun commented on PR #23974: URL: https://github.com/apache/flink/pull/23974#issuecomment-1864760862 Hi @reswqa, please help review it when you have time. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.partition package of flink-runtime module [flink]

2023-12-20 Thread via GitHub
flinkbot commented on PR #23974: URL: https://github.com/apache/flink/pull/23974#issuecomment-1864723222 ## CI report: * 1cf28b696a2555d7933944ce559fc90250be87b3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-33860) Implement restore tests for WindowTableFunction node

2023-12-20 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33860. Fix Version/s: 1.19.0 Resolution: Implemented Implemented in

Re: [PR] [FLINK-33860] Implement restore tests for WindowTableFunction node [flink]

2023-12-20 Thread via GitHub
dawidwys merged PR #23936: URL: https://github.com/apache/flink/pull/23936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.partition package of flink-runtime module [flink]

2023-12-20 Thread via GitHub
Jiabao-Sun opened a new pull request, #23974: URL: https://github.com/apache/flink/pull/23974 ## What is the purpose of the change [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.partition package of flink-runtime module ## Brief change log

Re: [PR] [FLINK-32849][runtime][JUnit5 Migration] The resourcemanager package of flink-runtime module [flink]

2023-12-20 Thread via GitHub
flinkbot commented on PR #23973: URL: https://github.com/apache/flink/pull/23973#issuecomment-1864686150 ## CI report: * 0aa76f5a80cc057681f6d2407a2c0774a78a9b0e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33823] Make PlannerQueryOperation SQL serializable [flink]

2023-12-20 Thread via GitHub
dawidwys merged PR #23948: URL: https://github.com/apache/flink/pull/23948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-33644) FLIP-393: Make QueryOperations SQL serializable

2023-12-20 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33644. Resolution: Implemented > FLIP-393: Make QueryOperations SQL serializable >

[jira] [Closed] (FLINK-33823) Serialize PlannerQueryOperation into SQL

2023-12-20 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33823. Resolution: Implemented Implemented in 5919251d7a94264a6a72c31de0716b3f72d65437 >

[jira] [Updated] (FLINK-32849) [JUnit5 Migration] The resourcemanager package of flink-runtime module

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32849: --- Labels: pull-request-available (was: ) > [JUnit5 Migration] The resourcemanager package of

[PR] [FLINK-32849][runtime][JUnit5 Migration] The resourcemanager package of flink-runtime module [flink]

2023-12-20 Thread via GitHub
RocMarshal opened a new pull request, #23973: URL: https://github.com/apache/flink/pull/23973 ## What is the purpose of the change [runtime][JUnit5 Migration] The resourcemanager package of flink-runtime module ## Brief change log [runtime][JUnit5 Migration]

Re: [PR] [FLINK-33916][ci] Adds nightly workflow for most-recently published Flink version [flink]

2023-12-20 Thread via GitHub
flinkbot commented on PR #23972: URL: https://github.com/apache/flink/pull/23972#issuecomment-1864564943 ## CI report: * 1e973fb1650c919a738aa9fe69a0e6f9d7b9bdfb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33915][ci] Adds nightly workflow for the master branch [flink]

2023-12-20 Thread via GitHub
flinkbot commented on PR #23971: URL: https://github.com/apache/flink/pull/23971#issuecomment-1864563284 ## CI report: * 4cd00e3a6426196125c1ed5e5b03f77d7df6fba8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-33916) Workflow: Add nightly build for release-1.18

2023-12-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-33916: - Assignee: Matthias Pohl > Workflow: Add nightly build for release-1.18 >

Re: [PR] [FLINK-33914][ci] Adds basic Flink CI workflow [flink]

2023-12-20 Thread via GitHub
flinkbot commented on PR #23970: URL: https://github.com/apache/flink/pull/23970#issuecomment-1864549461 ## CI report: * ff8cb87a2880efbf3c210b31fab2d79a6c57ddee UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33916) Workflow: Add nightly build for release-1.18

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33916: --- Labels: github-actions pull-request-available (was: github-actions) > Workflow: Add

[jira] [Assigned] (FLINK-33915) Workflow: Add nightly build for the dev version (currently called "master")

2023-12-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-33915: - Assignee: Matthias Pohl > Workflow: Add nightly build for the dev version (currently

[PR] [FLINK-33916][ci] Adds nightly workflow for most-recently published Flink version [flink]

2023-12-20 Thread via GitHub
XComp opened a new pull request, #23972: URL: https://github.com/apache/flink/pull/23972 Based on the following PR(s): * https://github.com/apache/flink/pull/23961 * https://github.com/apache/flink/pull/23962 * https://github.com/apache/flink/pull/23963 *

[PR] [FLINK-33915][ci] Adds nightly workflow for the master branch [flink]

2023-12-20 Thread via GitHub
XComp opened a new pull request, #23971: URL: https://github.com/apache/flink/pull/23971 Based on the following PR(s): * https://github.com/apache/flink/pull/23961 * https://github.com/apache/flink/pull/23962 * https://github.com/apache/flink/pull/23963 *

[jira] [Updated] (FLINK-33915) Workflow: Add nightly build for the dev version (currently called "master")

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33915: --- Labels: github-actions pull-request-available (was: github-actions) > Workflow: Add

[jira] [Assigned] (FLINK-33912) Template: Add CI template for pre-compile steps

2023-12-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-33912: - Assignee: Matthias Pohl > Template: Add CI template for pre-compile steps >

[jira] [Assigned] (FLINK-33913) Template: Add CI template for running Flink's test suite

2023-12-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-33913: - Assignee: Matthias Pohl > Template: Add CI template for running Flink's test suite >

  1   2   3   >