Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/6365
Should this be a separate connector for HBase 2.x where we would also keep
a connector for HBase 1.x?
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/6378
Any reason not to use version 20 or are we just being conservative?
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5776
LGTM but I'd cc @StephanEwen since the code looks to have been ported
recently.
---
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5731#discussion_r177536243
--- Diff:
flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITCase.scala
---
@@ -23,7 +23,7 @@ import java.io._
import
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r177468202
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,451
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5488
I haven't looked at the changelog but HBase 1.4.2 was released a few weeks
ago.
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5731
Test failures, and needs rebasing.
---
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5497#discussion_r168853239
--- Diff: docs/dev/migration.md ---
@@ -145,16 +145,16 @@ public class BufferingSink implements
SinkFunction<Tuple2<String, I
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5497#discussion_r168616567
--- Diff: docs/dev/migration.md ---
@@ -145,16 +145,16 @@ public class BufferingSink implements
SinkFunction<Tuple2<String, I
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5497
+1
---
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5488#discussion_r168592172
--- Diff: flink-connectors/flink-hbase/pom.xml ---
@@ -34,7 +34,7 @@ under the License.
jar
- 1.3.1
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5419
Can we also add timestamps to the surefire messages using
`systemPropertyVariables`?
https://gualtierotesta.wordpress.com/2015/11/01/tutorial-logging-during-tests/
http
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5205
@StephanEwen of the five occurrences in `MemoryManager`,
`ChannelWriterOutputView`, and `InPlaceMutableHashTable` only one occurs in a
function that is called elsewhere. How would you write
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5205#discussion_r162199532
--- Diff: flink-core/src/main/java/org/apache/flink/util/AbstractID.java ---
@@ -186,7 +186,7 @@ private static long byteArrayToLong(byte[] ba, int
offset
Github user greghogan closed the pull request at:
https://github.com/apache/flink/pull/5294
---
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5294
[FLINK-8427] [optimizer] Checkstyle for org.apache.flink.optimizer.costs
## What is the purpose of the change
Enforce checkstyle for org.apache.flink.optimizer.costs
You can merge
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5292
[FLINK-8422] [core] Checkstyle for org.apache.flink.api.java.tuple
## What is the purpose of the change
Update TupleGenerator for Flink's checkstyle and rebuild Tuple and
TupleBuilder
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5291
[FLINK-8361] [build] Remove create_release_files.sh
## What is the purpose of the change
The monolithic create_release_files.sh does not support building without
Hadoop and has been
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5289
[hotfix] [docs] Fix typos
From the IntelliJ `Typos` inspection.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5262
I'm working on a `CHECKLIST` file for `tools/releasing` to codify these
several issues that have come up recently.
---
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5277#discussion_r160795814
--- Diff: docs/concepts/runtime.md ---
@@ -88,40 +94,36 @@ By default, Flink allows subtasks to share slots even
if they are subtasks of di
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5277#discussion_r160793612
--- Diff: docs/concepts/runtime.md ---
@@ -88,40 +94,36 @@ By default, Flink allows subtasks to share slots even
if they are subtasks of di
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5277#discussion_r160794201
--- Diff: docs/concepts/runtime.md ---
@@ -46,19 +46,23 @@ The Flink runtime consists of two types of processes:
- The **JobManagers** (also called
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5277#discussion_r160795540
--- Diff: docs/concepts/runtime.md ---
@@ -88,40 +94,36 @@ By default, Flink allows subtasks to share slots even
if they are subtasks of di
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5277#discussion_r160794027
--- Diff: docs/concepts/runtime.md ---
@@ -28,12 +28,12 @@ under the License.
## Tasks and Operator Chains
-For distributed execution
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5277#discussion_r160793754
--- Diff: docs/concepts/runtime.md ---
@@ -28,12 +28,12 @@ under the License.
## Tasks and Operator Chains
-For distributed execution
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5279
[hotfix] [build] Print cache info
Print the size of the Maven cache copied for each TravisCI job.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5242
[hotfix] Fix typos
## What is the purpose of the change
Fix typos from the IntelliJ "Typos" inspection. I have tried to preserve
British vs American English spellings
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5112
@bowenli86 Checkstyle is Java-only. There is a
[Scalastyle](http://www.scalastyle.org).
---
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5213#discussion_r159523422
--- Diff: docs/monitoring/metrics.md ---
@@ -905,7 +903,7 @@ Thus, in order to infer the metric identifier:
Job-/TaskManager
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5205
[FLINK-8037] Fix integer multiplication or shift implicitly cast to long
## What is the purpose of the change
Fixes potential overflow flagged by the IntelliJ inspection "In
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5195
[hotfix] [build] Always include Kafka 0.11 connector
Now that Flink only supports builds for Scala 2.11+ we can unconditionally
enable the Kafka 0.11 connector.
You can merge this pull request
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5180
+0
---
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5175#discussion_r158056059
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
@@ -150,8 +150,7 @@ static File initLocalStorageDirectory(String
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5156#discussion_r158037581
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -543,35 +543,45 @@ case $TEST in
printf "Running end-to-end te
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5136
I'll merge this to 1.5 only.
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5126
@StephanEwen thanks for the tip. I'll remove the added `TypeHint` methods
and commit to 1.4 and 1.5.
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5157
@joerg84 could you file a PR for this change in `docs/ops/config.md` and
elsewhere in `docs/ops/deployment/mesos.md`?
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5138
@bowenli86 the `@Public` annotation is much more than an acknowledgement,
it promises that Flink will support that API essentially forever (despite the
large number of "2.0" tickets, i
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r156386303
--- Diff: docs/monitoring/metrics.md ---
@@ -333,7 +333,7 @@ reporters will be instantiated on each job and task
manager when they are starte
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5134
@StephanEwen thanks for the link and thoughtful discussion. Including `jmh`
benchmarks has come up multiple times. Do you see any path to including such a
benchmark module in the main Flink repo?
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5144
@yew1eb thanks for this PR. It would be helpful if you could provide how
you discovered these style issues (IntelliJ analysis?) and if there is a way to
automatically discover and/or flag
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5134
@pnowojski see FLINK-2848 and FLINK-2973. Also the BSD + Patents
conversation along with Flink's dependence on Amazon's Kinesis library
(likewise [Category X](https://www.apache.org/legal
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5138
Changes to the public API require a
[FLIP](https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals).
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5133
[ERROR]
src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceUtils.java:[41,8]
(imports) UnusedImports: Unused import: java.net.InetSocketAddress.
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5133
@casidiablo please also describe why or how the removed code came to be
unused. I see that `StandaloneHaServices#RESOURCE_MANAGER_RPC_ENDPOINT_NAME`
was left unused by `433a345e`.
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5072
@yew1eb have you looked at FLINK-6965?
---
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5137
[FLINK-8223] [build] Update Hadoop versions
## What is the purpose of the change
Update Hadoop minor versions for Flink 1.5 development cycle.
## Brief change log
Update
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5136
[FLINK-8222] [build] Update Scala version
## What is the purpose of the change
This is an incremental upgrade to the Scala security release 2.11.12.
"A privilege escal
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r155625966
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/MetricRegistryImplTest.java
---
@@ -76,8 +76,27 @@ public void testIsShutdown
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r155620220
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
@@ -108,15 +118,36 @@ public static
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5135#discussion_r155627163
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -585,7 +585,7 @@ class TaskManager
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r155618187
--- Diff: docs/monitoring/metrics.md ---
@@ -329,11 +329,11 @@ or by assigning unique names to jobs and operators.
Metrics can be exposed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r155623170
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
@@ -44,7 +48,13 @@
private static
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5134
Or if `flink-benchmarks` does not need to be distributed then that code
could be contributed to the main Flink repository.
---
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5126
[FLINK-5506] [gelly] Fix CommunityDetection NullPointerException
## What is the purpose of the change
This fixes a regression which can result in `NullPointerException` when
running
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r154121821
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
---
@@ -43,8 +46,8 @@
private
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r154122694
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java ---
@@ -25,20 +25,9 @@
public class MetricOptions
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4574
@zjureel am merging this ... thanks for the PR and edits!
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4383
@zentol @fhueske I am merging the change with the extra space since this
looks to have been the original intent. I've looked at both forms without
finding a strong preference.
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4374
@RebornHuan although this change looks to be correct and makes good use of
the newer API, there is a trade-off between deleting a line of code called
during an error condition and the risk
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5076#discussion_r153503257
--- Diff: pom.xml ---
@@ -891,6 +905,41 @@ under the License
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5076#discussion_r153500167
--- Diff: pom.xml ---
@@ -891,6 +905,41 @@ under the License
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4666
@raymondtay are we still looking to make this change? Defining the mapper
may be just as likely to confuse new Flink users.
Also, when updating future PRs you want to rebase to master
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5067
+1; merging ...
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5047
Do we still want to make this change since the PR is now only adding a
single comment?
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5061
@zentol thanks, I'll merge and backport.
---
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5061
[hotfix] [docs] Update checkstyle version in documentation
## What is the purpose of the change
Update the recommended checkstyle version in the documentation to match the
active version
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5045#discussion_r152608576
--- Diff: docs/concepts/programming-model.md ---
@@ -33,53 +33,52 @@ Flink offers different levels of abstraction to develop
streaming/batch applicat
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5045#discussion_r152608405
--- Diff: docs/concepts/programming-model.md ---
@@ -132,14 +131,13 @@ One typically distinguishes different types of
windows, such as *tumbling window
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5045#discussion_r152607252
--- Diff: docs/concepts/programming-model.md ---
@@ -33,53 +33,52 @@ Flink offers different levels of abstraction to develop
streaming/batch applicat
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5045#discussion_r152612059
--- Diff: docs/concepts/runtime.md ---
@@ -107,21 +107,20 @@ With hyper-threading, each slot then takes 2 or more
hardware thread contexts
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5045#discussion_r152605878
--- Diff: docs/concepts/programming-model.md ---
@@ -33,53 +33,52 @@ Flink offers different levels of abstraction to develop
streaming/batch applicat
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5045#discussion_r152609451
--- Diff: docs/concepts/runtime.md ---
@@ -74,10 +74,10 @@ To control how many tasks a worker accepts, a worker
has so called **task slots*
Each
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5047
This change doesn't work since `WordWithCount` needs to be a POJO which
requires a default or no-args constructor and non-final public attributes or
getters/setters. Since the type is not a POJO
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5049
+1
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5012
Ah, thanks @zentol for the clarification. Very nice to have this!
---
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5006#discussion_r152591791
--- Diff: docs/dev/stream/state/queryable_state.md ---
@@ -162,14 +161,19 @@ So far, you have set up your cluster to run with
queryable state and you have
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4877
@vim-wj if you are okay with Stephan's suggestion could you close this pull
request?
Also, a small note: `FLINK-4877` references a [Jira
ticket](https://issues.apache.org/jira/browse
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/5044
[FLINK-8126] [build] Fix and update checkstyle
## What is the purpose of the change
Update to the latest checkstyle version and fix the errors not previously
detected.
## Brief
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4946#discussion_r152405696
--- Diff: flink-dist/src/main/resources/flink-conf.yaml ---
@@ -151,6 +151,9 @@ jobmanager.web.port: 8081
# Path to the Hadoop configuration
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5006#discussion_r152402516
--- Diff: docs/dev/stream/state/queryable_state.md ---
@@ -162,14 +161,19 @@ So far, you have set up your cluster to run with
queryable state and you have
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5006#discussion_r152402801
--- Diff: docs/dev/stream/state/queryable_state.md ---
@@ -162,14 +161,19 @@ So far, you have set up your cluster to run with
queryable state and you have
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5006#discussion_r152402097
--- Diff: docs/dev/stream/state/queryable_state.md ---
@@ -60,7 +60,7 @@ The Queryable State feature consists of three main
entities:
returning
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5012
LGTM. I'm puzzled why the `])` is printed out-of-order in the middle of the
stack trace.
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5020
+1
---
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5024#discussion_r152384448
--- Diff: docs/index.md ---
@@ -23,19 +24,17 @@ specific language governing permissions and limitations
under the License
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5024#discussion_r152386126
--- Diff: docs/index.md ---
@@ -23,19 +24,17 @@ specific language governing permissions and limitations
under the License
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5024#discussion_r152384103
--- Diff: docs/README.md ---
@@ -90,7 +90,7 @@ This will be replaced with the value of the variable
called `NAME` when generati
Headings
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5034
IntelliJ reports 24 instances of "unnecessary 'null' check before
'instanceof' expression".
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5023
@ChrisChinchilla I think you want to `git rebase origin/master` (or
whatever you have named upstream). Did you do a merge instead?
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5001
+1 tests are passing and the 1.4 release has been forked so we're at the
start of a new release cycle
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4968
+1
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4968
@elbaulp au contraire, thank you for fixing this bug. Do we need quotes for
the following?
line 69: pid=$FLINK_PID_DIR/flink-$FLINK_IDENT_STRING-$DAEMON.pid
line 181: done < ${pid}.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4945
@zentol but we need a check against additions to the API since 1.0.
Enabling `breakBuildOnModifications` in bugfix releases which don't add the API
wouldn't require updating compatibility versions
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4965
LGTM.
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4971
Is anyone else seeing the red/green highlights shifted two lines up for
this PR? I'm seeing this in multiple browsers and with plug-ins disabled but
only on this PR.
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4959
Looks good but I have not tested. Can we also fix the parameter swap
referenced in the JIRA?
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4968
Do we also need to quote within sub-expressions? Have you looked at the
stop script?
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4945
Isn't this API compatibility rather than checkpoint/savepoint
compatibility? And if the former should not 1.4 be checked against 1.3 (which
should be checked against 1.2, etc.)?
---
1 - 100 of 1173 matches
Mail list logo
