Github user jinmingjian commented on a diff in the pull request:
https://github.com/apache/flink/pull/3384#discussion_r102435330
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClientConnectionTest.java
---
@@ -115,13 +115,13 @@ public void run
Github user jinmingjian commented on the issue:
https://github.com/apache/flink/pull/3373
@StephanEwen Just my coding habit. Correction done.
And very appreciated for your review. I am open for more contribution!
:tada:
---
If your project is set up for it, you can reply
GitHub user jinmingjian opened a pull request:
https://github.com/apache/flink/pull/3373
[FLINK-5692] [config] Add an Option to Deactivate Kryo Fallback for
Serializers
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
GitHub user jinmingjian opened a pull request:
https://github.com/apache/flink/pull/3384
[FLINK-4422] Convert all time interval measurements to System.nanoTime() -
flink-clients
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following
Github user jinmingjian commented on the issue:
https://github.com/apache/flink/pull/3373
revision done. _"disableGenericTypes"_ makes good sense from the view of
docs (although "generic types" tends to be overused).
---
If your project is set up for it, you can
Github user jinmingjian commented on a diff in the pull request:
https://github.com/apache/flink/pull/3420#discussion_r103196536
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/ClosableBlockingQueue.java
Github user jinmingjian commented on a diff in the pull request:
https://github.com/apache/flink/pull/3420#discussion_r103195631
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KillerWatchDog.java
Github user jinmingjian commented on the issue:
https://github.com/apache/flink/pull/3420
another way is to modify the API to pass timeInNano. But considering all
references are named with test*. I suggest the conservative fix.
---
If your project is set up for it, you can reply
GitHub user jinmingjian opened a pull request:
https://github.com/apache/flink/pull/3422
[FLINK-4422] Convert all time interval measurements to System.nanoTime() -
flink-connector-kafka-base
Thanks for contributing to Apache Flink. Before you open your pull request,
please take
GitHub user jinmingjian opened a pull request:
https://github.com/apache/flink/pull/3421
[FLINK-4422] Convert all time interval measurements to System.nanoTime() -
flink-connector-kafka-0.9
Thanks for contributing to Apache Flink. Before you open your pull request,
please take
GitHub user jinmingjian opened a pull request:
https://github.com/apache/flink/pull/3419
[FLINK-4422] Convert all time interval measurements to System.nanoTime() -
flink-connector-kafka-0.10
Thanks for contributing to Apache Flink. Before you open your pull request,
please take
GitHub user jinmingjian opened a pull request:
https://github.com/apache/flink/pull/3420
[FLINK-4422] Convert all time interval measurements to System.nanoTime() -
flink-connector-kafka-0.8
Thanks for contributing to Apache Flink. Before you open your pull request,
please take
Github user jinmingjian commented on a diff in the pull request:
https://github.com/apache/flink/pull/3420#discussion_r103627979
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KillerWatchDog.java
13 matches
Mail list logo
