Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6281#discussion_r202574665
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
---
@@ -0,0 +1,397
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6281
Hi @aljoscha and @StephanEwen . I have updated the PR, please have a look.
---
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6281#discussion_r201342618
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
---
@@ -0,0 +1,397
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6281#discussion_r201059374
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Bucket.java
---
@@ -0,0 +1,297
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6281#discussion_r201059444
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Bucket.java
---
@@ -0,0 +1,297
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6176
Hi @kent2171 ! Do not worry, I can fix it ;) Thanks for having a look!
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6176
Thanks for the work @kent2171 ! I will merge this as soon as Travis gives
the green light!
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6281
Hi @xndai ! I will update an outdated design doc and will attach it to the
JIRA! I will ping you here to have a look.
---
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6281#discussion_r200909011
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/serialization/Writer.java
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/6281
[FLINK-9750] Add new StreamingFileSink with ResumableWriter.
## What is the purpose of the change
This PR is the first step towards introducing a new Streaming Filesystem
sink that works
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5342
Thanks for the work @florianschmidt1994 ! Merging this.
---
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6171#discussion_r198474417
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -330,77 +328,85 @@ private boolean isStateTimedOut(final
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6171#discussion_r198473426
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/aftermatch/AfterMatchSkipStrategy.java
---
@@ -0,0 +1,155
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6171#discussion_r198472975
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFAState.java
---
@@ -79,18 +98,18 @@ public boolean equals(Object o
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6171#discussion_r198472927
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFAState.java
---
@@ -79,18 +98,18 @@ public boolean equals(Object o
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6171#discussion_r198473858
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -330,77 +328,85 @@ private boolean isStateTimedOut(final
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6152#discussion_r197087153
--- Diff: docs/monitoring/metrics.md ---
@@ -1254,15 +1254,15 @@ Thus, in order to infer the metric identifier:
Counter
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6152#discussion_r197086995
--- Diff: docs/monitoring/metrics.md ---
@@ -1228,7 +1228,7 @@ Thus, in order to infer the metric identifier:
Meter
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6130
Hi @bowenli86,
Me, @zentol and @aljoscha both seem to have doubts about the utility of the
feature.
So given this, and to have a clean JIRA and list of PRs we have to work on,
I would
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6130
Hi @bowenli86 !
Why not having a `flatmap` after the `readFile` and for every incoming
element you emit as many copies as you want?
Personally, I am not so fond of adding methods
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5342
Thanks @florianschmidt1994 . I will, but may be not today.
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5960
@dawidwys Also when you merge the other one, could you also close this PR?
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6059
It would be great if @Aitozi could also report any numbers he has, so that
we see the benefits of the change.
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6126
I got this, it is just that I am wondering how useful this is, given that
the operators/functions are chained.
---
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6059#discussion_r194473454
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -296,42 +292,31 @@ public void resetNFAChanged
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6059#discussion_r194470370
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -296,42 +292,31 @@ public void resetNFAChanged
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6059#discussion_r194468194
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -296,42 +292,31 @@ public void resetNFAChanged
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6126
If this is correct, then I suppose we can remove it altogether so that the
code is also cleaner, right?
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6108
@zhangxinyu1 as soon as this sink is ready, I believe that the existing
File Source will be able to read the output of the Bucketing Sink. As far as
bandwidth limitations are concerned, could you
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6108
Thanks for the useful input here @zhangxinyu1 and @StephanEwen. As soon as
I have sth concrete I create the JIRA and post it here.
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6059
Hi @dawidwys! Thanks for the work.
The changes seem really good. As we discussed privately I did a review and
the comments you can find them in the branch I sent you.
The only things
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6097#discussion_r191460728
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/KeyedProcessOperatorTest.java
---
@@ -50,6 +52,30 @@
@Rule
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6097#discussion_r191460316
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/KeyedProcessOperatorTest.java
---
@@ -50,6 +52,30 @@
@Rule
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/6028
LGTM, so +1 and I will merge later.
Thanks for the work @yanghua and for the review @florianschmidt1994 .
---
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/6028#discussion_r189015635
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5955
Hi @tzulitai ! Thanks for the review. I integrated most of your comments.
The only one I left out is the one about merging the checkpointing and the
checking. I am not against that. It is just
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5955#discussion_r188614213
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobWBroadcastStateMigrationITCase.java
---
@@ -0,0 +1,418
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5922
Thanks for the review! Merging this.
---
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5922#discussion_r187924456
--- Diff: docs/dev/stream/state/broadcast_state.md ---
@@ -0,0 +1,279 @@
+---
+title: "The Broadcast State Pattern"
+nav-parent_id: strea
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5922#discussion_r187922328
--- Diff: docs/dev/stream/state/broadcast_state.md ---
@@ -0,0 +1,279 @@
+---
+title: "The Broadcast State Pattern"
+nav-parent_id: strea
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5955
Could you review it @tzulitai ?
---
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r187677168
--- Diff:
flink-end-to-end-tests/flink-queryable-state-test/src/main/java/org/apache/flink/streaming/tests/queryablestate/QsStateProducer.java
---
@@ -0,0
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r187676881
--- Diff:
flink-end-to-end-tests/test-scripts/test_queryable_state_restart_tm.sh ---
@@ -0,0 +1,120 @@
+#!/usr/bin/env bash
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r187676635
--- Diff:
flink-end-to-end-tests/test-scripts/test_queryable_state_restart_tm.sh ---
@@ -0,0 +1,120 @@
+#!/usr/bin/env bash
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r187675826
--- Diff:
flink-end-to-end-tests/test-scripts/test_queryable_state_restart_tm.sh ---
@@ -0,0 +1,120 @@
+#!/usr/bin/env bash
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r187675012
--- Diff: flink-end-to-end-tests/flink-queryable-state-test/pom.xml ---
@@ -0,0 +1,134 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r187674099
--- Diff:
flink-end-to-end-tests/flink-queryable-state-test/src/main/java/org/apache/flink/streaming/tests/queryablestate/QsStateProducer.java
---
@@ -0,0
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5993
Thanks for the work @sihuazhou and for reporting this @florianschmidt1994 !
This fixes the problem described in the JIRA but I will look at the PR a bit
more thoroughly on Monday at the latest
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5955
Could you review it @aljoscha ?
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5495
I close this and I will open an updated one.
---
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/5495
---
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/5955
[FLINK-8659] Add migration itcases for broadcast state.
As the name implies, this PR add migration tests for the newly introduced
broadcast state.
For the `scala` case, more refactoring
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r185731699
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -908,6
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5922
Thanks a lot for the reviews! I pushed a commit that integrates your
comments. Let me know if now it looks ok.
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5922
This seems like a nice suggestion.
I will do that and letâs see how it reads afterwards.
> On May 2, 2018, at 12:21 PM, Tzu-Li Tai <notificati...@github.com> wrote:
>
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5922
Thanks a lot for the comments @alpinegizmo and @tzulitai ! I integrated
most of them and I am not sure how to integrate your comment @tzulitai . Do you
have any proposal on how this can be made clearer?
---
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5922#discussion_r185449653
--- Diff: docs/dev/stream/state/broadcast_state.md ---
@@ -0,0 +1,281 @@
+---
+title: "The Broadcast State Pattern"
+nav-parent_id: strea
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184677692
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184678745
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184678478
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184676876
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184675777
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184678308
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184676407
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184673962
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184675917
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184677353
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184676633
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184676032
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184678944
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184675061
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184674272
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5913#discussion_r184674886
--- Diff: docs/dev/table/sqlClient.md ---
@@ -0,0 +1,538 @@
+---
+title: "SQL Client"
+nav-parent_id: tableapi
+nav-pos: 100
+is_
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/5922
[FLINK-8780] [docs] Add Broadcast State documentation.
R @fhueske
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink broadcast-docs-inv2
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5910
Thanks @yuqi1129, @bowenli86 and @StefanRRichter for the reviews. I
integrated your comments. If you are done with reviewing, I will merge it as
soon as Travis gives the green light.
---
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/5910
[FLINK-8841] [state] Remove HashMapSerializer and use MapSerializer instead.
## What is the purpose of the change
So far we had the `MapSerializer` and the `HashMapSerializer`. The two had
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5482#discussion_r183745456
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/JoinedStreams.java
---
@@ -137,6 +158,151 @@ public EqualTo equalTo
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5813
Sounds good @twalthr !
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5813
Thanks for the work @twalthr ! The test looks good but it fails
occasionally due to https://issues.apache.org/jira/browse/FLINK-9113. Given
that the test is unstable, I would suggest to not merge
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5830#discussion_r180541104
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/co/KeyedBroadcastProcessFunction.java
---
@@ -89,11 +89,11
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5830#discussion_r180538022
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperator.java
---
@@ -33,6 +33,8 @@
import
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5830#discussion_r180541190
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/co/KeyedBroadcastProcessFunction.java
---
@@ -89,11 +89,11
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5811
Well it seems like for these tests, the `flush` is not actually flushing.
The files are there, the `validPartLength` is correct (=6 as we just write
`test1\n`) but the data is not actually on disk
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r178827723
--- Diff:
flink-end-to-end-tests/flink-queryable-state-test/src/main/java/org/apache/flink/streaming/tests/queryablestate/EmailInformation.java
---
@@ -0,0
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r178828967
--- Diff:
flink-end-to-end-tests/flink-queryable-state-test/src/main/java/org/apache/flink/streaming/tests/queryablestate/QsBugPoc.java
---
@@ -0,0 +1,133
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r178828372
--- Diff: flink-end-to-end-tests/run-pre-commit-tests.sh ---
@@ -37,6 +37,14 @@ echo "Flink distribution directory: $FLINK_DIR"
E
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r178827995
--- Diff:
flink-end-to-end-tests/flink-queryable-state-test/src/main/java/org/apache/flink/streaming/tests/queryablestate/LabelSurrogate.java
---
@@ -0,0
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r178827936
--- Diff:
flink-end-to-end-tests/flink-queryable-state-test/src/main/java/org/apache/flink/streaming/tests/queryablestate/LabelSurrogate.java
---
@@ -0,0
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r178829164
--- Diff:
flink-end-to-end-tests/flink-queryable-state-test/src/main/java/org/apache/flink/streaming/tests/queryablestate/QsBugPoc.java
---
@@ -0,0 +1,133
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r178827415
--- Diff:
flink-end-to-end-tests/flink-queryable-state-test/src/main/java/org/apache/flink/streaming/tests/queryablestate/EmailInformation.java
---
@@ -0,0
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r178827698
--- Diff:
flink-end-to-end-tests/flink-queryable-state-test/src/main/java/org/apache/flink/streaming/tests/queryablestate/EmailInformation.java
---
@@ -0,0
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r178827543
--- Diff:
flink-end-to-end-tests/flink-queryable-state-test/src/main/java/org/apache/flink/streaming/tests/queryablestate/EmailInformation.java
---
@@ -0,0
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5807#discussion_r178827678
--- Diff:
flink-end-to-end-tests/flink-queryable-state-test/src/main/java/org/apache/flink/streaming/tests/queryablestate/EmailInformation.java
---
@@ -0,0
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5750
Thanks a lot @twalthr for the review!
---
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5756#discussion_r178030866
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -93,6 +93,10 @@ private
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5756#discussion_r15838
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -93,6 +93,10 @@ private
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5750
Hi @walterddr, I addressed most of your comments. Feel free to have another
look.
---
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5750#discussion_r177436350
--- Diff: flink-end-to-end-tests/test-scripts/common.sh ---
@@ -59,9 +162,42 @@ function start_cluster {
done
}
+function jm_watchdog
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5750#discussion_r177364376
--- Diff: flink-end-to-end-tests/test-scripts/common.sh ---
@@ -39,6 +39,109 @@ cd $TEST_ROOT
export TEST_DATA_DIR=$TEST_INFRA_DIR/temp-test-directory
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5751
Hi @sihuazhou ! I think that for now materializing the list of keys and
then passing it to the `process` is the best solution. But keep in mind that
this is only for the `HeapKeyedStateBackend
1 - 100 of 952 matches
Mail list logo
