[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105700201 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -247,27 +275,148 @@ public int compare(final StateTransition o1

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105702715 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Quantifier.java --- @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105700521 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -247,27 +275,148 @@ public int compare(final StateTransition o1

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105697591 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java --- @@ -52,14 +57,35 @@ public ComputationState

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105702140 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/InvalidPatternException.java --- @@ -0,0 +1,28 @@ +/* + * Licensed to

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105699655 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -247,27 +275,148 @@ public int compare(final StateTransition o1

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105704530 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java --- @@ -272,37 +372,42 @@ public void testBranchingPattern

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105697452 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java --- @@ -41,8 +43,11 @@ // Timestamp of the first

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105698150 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -71,19 +70,16 @@ private final NonDuplicatingTypeSerializer

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105699988 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -247,27 +275,148 @@ public int compare(final StateTransition o1

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105700500 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -247,27 +275,148 @@ public int compare(final StateTransition o1

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105704399 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java --- @@ -272,37 +372,42 @@ public void testBranchingPattern

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105698031 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -71,19 +70,16 @@ private final NonDuplicatingTypeSerializer

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105704335 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java --- @@ -272,37 +372,42 @@ public void testBranchingPattern

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105699441 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -209,33 +204,66 @@ public boolean equals(Object obj

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105704267 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java --- @@ -272,37 +372,42 @@ public void testBranchingPattern

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105702323 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/compiler/NFACompilerTest.java --- @@ -18,9 +18,13 @@ package

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105698626 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -209,33 +204,66 @@ public boolean equals(Object obj

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105701064 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -217,23 +217,22 @@ public void prune(long pruningTimestamp

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105700356 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -247,27 +275,148 @@ public int compare(final StateTransition o1

[GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3477#discussion_r105701669 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java --- @@ -55,6 +65,7 @@ public boolean equals(Object obj

[GitHub] flink pull request #3514: [FLINK-6007] Allow key removal from within the wat...

2017-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3514#discussion_r105649773 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalWatermarkCallbackService.java --- @@ -58,7 +59,17

[GitHub] flink issue #3514: [FLINK-6007] Allow key removal from within the watermark ...

2017-03-13 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3514 Thanks for the review @aljoscha . Waiting for travis and then merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #3477: [Flink-3318][cep] Add support for quantifiers to CEP's pa...

2017-03-13 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3477 Hi @dawidwys , I will start reviewing your PR now. I would say that for now it makes sense to have it with exceptions and not change the `Pattern` hierarchy. The reason is: 1) not sure

[GitHub] flink issue #3445: [FLINK-5846] [cep] Make the CEP operators backwards compa...

2017-03-11 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3445 @aljoscha , I integrated your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3484: [FLINK-4460] Side Outputs in Flink

2017-03-11 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3484 Thanks @aljoscha I will have a look on Monday. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #3514: [FLINK-6007] Allow key removal from within the wat...

2017-03-10 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3514 [FLINK-6007] Allow key removal from within the watermark callback. When deleting a key from the InternalWatermarkCallbackService, the deleted key is put into a separate set, and the actual deletion

[GitHub] flink pull request #3513: [hotfix] [doc] Fix error in ProcessFunction exampl...

2017-03-10 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3513 [hotfix] [doc] Fix error in ProcessFunction example. Fixes an error in the `ProcessFunction` documentation that was reported in the mailing list. You can merge this pull request into a Git repository

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105441679 --- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105398836 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java --- @@ -300,6 +303,36 @@ private StreamGraph

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105402746 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1528,14 +1572,16 @@ public

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105401808 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java --- @@ -441,26 +491,55 @@ public void close

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105397306 --- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105403355 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/MockOutput.java --- @@ -40,6 +41,12 @@ public void collect(StreamRecord record

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105399457 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/SideOutputTransformation.java --- @@ -0,0 +1,72

[GitHub] flink issue #3501: [FLINK-5874] Restrict key types in the DataStream API.

2017-03-10 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3501 Done! Let me know if you have any additional comments @zentol --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105407208 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -906,6 +919,256 @@ public void testChannelSelectors

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105397096 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeHint.java --- @@ -46,7 +46,15 @@ public TypeHint

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105397933 --- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105401503 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java --- @@ -387,14 +403,25 @@ public int getChainLength

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105402262 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java --- @@ -539,5 +625,26 @@ public void collect

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105403240 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/CollectorOutput.java --- @@ -53,5 +54,11 @@ public void collect(StreamRecord

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105398702 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java --- @@ -333,32 +356,40 @@ public void addEdge(Integer

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105400890 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java --- @@ -326,33 +327,48 @@ public int getChainLength

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105402830 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1618,14 +1664,16 @@ public

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105402616 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1267,14 +1291,16 @@ public

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105397483 --- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105402899 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1702,15 +1754,16 @@ public

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105401947 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java --- @@ -539,5 +625,26 @@ public void collect

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105398138 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/WindowWordCount.java --- @@ -17,13 +17,19

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105402678 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1393,14 +1428,16 @@ public

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105399939 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordWriterOutput.java --- @@ -72,6 +76,11 @@ public RecordWriterOutput

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105397424 --- Diff: flink-core/src/main/java/org/apache/flink/util/OutputTag.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] flink issue #3501: [FLINK-5874] Restrict key types in the DataStream API.

2017-03-10 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3501 Thanks for the thorough review @zentol . I integrated the comments that I agree with and commented on the rest. If you agree with the changes, I can merge it. --- If your project is set up for it

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105380399 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -906,6 +919,256 @@ public void testChannelSelectors

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105378932 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -906,6 +919,256 @@ public void testChannelSelectors

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105378808 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java --- @@ -906,6 +919,256 @@ public void testChannelSelectors

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105377853 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java --- @@ -114,9 +121,53 @@ public KeyedStream(DataStream

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105377789 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java --- @@ -114,9 +121,53 @@ public KeyedStream(DataStream

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3501#discussion_r105377617 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java --- @@ -736,7 +736,7 @@ public void restoreState(List state

[GitHub] flink issue #3477: [Flink-3318] Add support for quantifiers to CEP's pattern...

2017-03-10 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3477 Hi @dawidwys , I will do this in the beginning of next week at the latest. One thing that I saw is that in the `Pattern` class you do not check for conflicting configurations e.g. oneToMany

[GitHub] flink pull request #3484: [FLINK-4460] Side Outputs in Flink

2017-03-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3484#discussion_r105225561 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -419,6 +435,14 @@ public void

[GitHub] flink pull request #3501: [FLINK-5874] Restrict key types in the DataStream ...

2017-03-09 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3501 [FLINK-5874] Restrict key types in the DataStream API. Rejects a type from being a key in `DataStream.keyBy()` if it is: 1. it is a POJO type but does not override the `hashCode()` and

[GitHub] flink issue #3390: [FLINK-5864] CEP: fix duplicate output patterns problem.

2017-03-03 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3390 Hi @dawidwys I merged this. Can you close this PR and the related JIRA? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #3390: [FLINK-5864] CEP: fix duplicate output patterns problem.

2017-03-03 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3390 Thanks @dawidwys for the work! Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3429: [FLINK-5937] [doc] Add documentation about the stream tas...

2017-03-03 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3429 Thanks a lot for the review @StefanRRichter . I will integrate them and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #3429: [FLINK-5937] [doc] Add documentation about the str...

2017-03-03 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3429#discussion_r104136196 --- Diff: docs/internals/task_lifecycle.md --- @@ -0,0 +1,186 @@ +--- +title: "Task Lifecycle" +nav-title: Task Lifecycle +nav

[GitHub] flink issue #3445: [FLINK-5846] [cep] Make the CEP operators backwards compa...

2017-03-02 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3445 Thanks for the comment @zentol ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink pull request #3445: [FLINK-5846] [cep] Make the CEP operators backward...

2017-03-01 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3445 [FLINK-5846] [cep] Make the CEP operators backwards compatible This also contains a commit for https://issues.apache.org/jira/browse/FLINK-5932 You can merge this pull request into a Git repository

[GitHub] flink pull request #3412: [FLINK-5420] [cep] Make the CEP operators rescalab...

2017-02-28 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/3412 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3429: [FLINK-5937] [doc] Add documentation about the str...

2017-02-28 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3429 [FLINK-5937] [doc] Add documentation about the stream task lifecycle You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink task-doc

[GitHub] flink issue #3412: [FLINK-5420] [cep] Make the CEP operators rescalable

2017-02-28 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3412 Thanks for the comments @aljoscha . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #3390: [FLINK-5864] CEP: fix duplicate output patterns problem.

2017-02-28 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3390 I agree that the solution is temporary but the new version (with the richer pattern support) could take some time. As for the sorting, we could have a "pre-traversal" of the transitions, as

[GitHub] flink pull request #3390: [FLINK-5864] CEP: fix duplicate output patterns pr...

2017-02-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3390#discussion_r103405219 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -254,7 +255,18 @@ public int hashCode

[GitHub] flink issue #3412: [FLINK-5420] [cep] Make the CEP operators rescalable

2017-02-24 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3412 Thanks for the comments @aljoscha . I integrated them and waiting for Travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #3412: [FLINK-5420] [cep] Make the CEP operators rescalab...

2017-02-24 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3412 [FLINK-5420] [cep] Make the CEP operators rescalable More on the related JIRA: https://issues.apache.org/jira/browse/FLINK-5420 You can merge this pull request into a Git repository by running

[GitHub] flink issue #3381: [FLINK-5871] [cep] Enforce uniqueness of pattern names in...

2017-02-24 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3381 Thanks for the review @tillrohrmann ! I just had a question about one of the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #3381: [FLINK-5871] [cep] Enforce uniqueness of pattern n...

2017-02-24 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3381#discussion_r102916874 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/compiler/NFACompilerTest.java --- @@ -42,6 +45,43 @@ public class

[GitHub] flink pull request #3381: [FLINK-5871] [cep] Enforce uniqueness of pattern n...

2017-02-24 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3381#discussion_r102916718 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/compiler/NFACompilerTest.java --- @@ -42,6 +45,43 @@ public class

[GitHub] flink pull request #3375: [FLINK-5845] [cep] Unify keyed and non-keyed opera...

2017-02-24 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/3375 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #3375: [FLINK-5845] [cep] Unify keyed and non-keyed operators.

2017-02-24 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3375 Thanks @tillrohrmann ! I integrated your comments and merged it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #3381: [FLINK-5871] [cep] Enforce uniqueness of pattern n...

2017-02-21 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3381 [FLINK-5871] [cep] Enforce uniqueness of pattern names in CEP. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink cep-uniq-pattern-name

[GitHub] flink issue #3375: [FLINK-5845] [cep] Unify keyed and non-keyed operators.

2017-02-21 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3375 R @tillrohrmann --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink pull request #3375: [FLINK-5845] [cep] Unify keyed and non-keyed opera...

2017-02-21 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3375 [FLINK-5845] [cep] Unify keyed and non-keyed operators. This PR is the first step towards making the CEP library rescalable and backwards compatible. It just merges the keyed and non-keyed

[GitHub] flink issue #2361: [FLINK-3318][cep] Add support for quantifiers to CEP's pa...

2017-02-20 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2361 Hi @mushketyk ! Thanks a lot for the reply! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #2361: [FLINK-3318][cep] Add support for quantifiers to CEP's pa...

2017-02-20 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2361 Hi @mushketyk are you still working on this issue? In not, @dawidwys would also like to work on this issue. Please let me know what you think. --- If your project is set up for it, you

[GitHub] flink pull request #3307: [FLINK-5420] Make CEP operators rescalable

2017-02-16 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/3307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2509: [FLINK-4280][kafka-connector] Explicit start position con...

2017-02-15 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2509 Perfect! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #2509: [FLINK-4280][kafka-connector] Explicit start position con...

2017-02-15 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2509 Thanks @tzulitai and @rmetzger ! Of course, feel free to proceed with this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #2509: [FLINK-4280][kafka-connector] Explicit start position con...

2017-02-15 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2509 Hi @tzulitai and @rmetzger . I did not have time so far to look into it. I hope I will be able to do it till the end of the week. Is this ok? --- If your project is set up for it, you can reply to

[GitHub] flink pull request #3307: [FLINK-5420] Make CEP operators rescalable

2017-02-14 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3307 [FLINK-5420] Make CEP operators rescalable Transforms the CEP operators into ProcessFunctions that use only managed keyed state. Rescalability now comes out-of-the-box. In addition, for the keyed

[GitHub] flink issue #3291: [FLINK-5762] Protect initializeState() and open() by the ...

2017-02-14 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3291 Thanks a lot @StephanEwen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #3291: [FLINK-5762] Protect initializeState() and open() ...

2017-02-09 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3291 [FLINK-5762] Protect initializeState() and open() by the same lock The description is in the related jira: https://issues.apache.org/jira/browse/FLINK-5762 You can merge this pull request

[GitHub] flink pull request #3130: [FLINK-5502] Add the function migration guide in d...

2017-02-03 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/3130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #3130: [FLINK-5502] Add the function migration guide in docs.

2017-01-31 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3130 Thanks @aljoscha . I checked the changes and they look good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #3224: [FLINK-5529] [FLINK-4752] [docs] Improve / extends window...

2017-01-27 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3224 Done! Thanks a lot @aljoscha --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink pull request #3224: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-27 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/3224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-27 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/3191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3224: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-27 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3224 [FLINK-5529] [FLINK-4752] [docs] Improve / extends windowing documentation This PR is for both the issues in the title. It refactors/improves/extends the documentation of the windowing logic in

[GitHub] flink issue #2396: [FLINK-4395][cep] Eager processing of late arrivals in CE...

2017-01-27 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2396 Thanks a lot @mushketyk ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

<    1   2   3   4   5   6   7   8   9   10   >