Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
@StephanEwen @zentol , thanks for review this pr
yes, I had check the dependency.
by the way, in order to distinguish between different prometheus tasks, I
defined different
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r195281287
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191297773
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191306509
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191335598
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191336445
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191628488
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191628800
--- Diff: docs/monitoring/metrics.md ---
@@ -699,6 +699,39 @@ Flink metric types are mapped to Prometheus metric
types as follows:
All Flink
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191647381
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191351687
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191428603
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191176434
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r192630255
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6212
hi, @tillrohrmann, if you don't know, I'll ignore it. it's no problem,
:smiley:
This information is always displayed at the bottom of the page. here's it.
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6184
Please click here for details
[old-flink-9187](https://github.com/apache/flink/pull/5857)
---
Github user lamber-ken closed the pull request at:
https://github.com/apache/flink/pull/5857
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6211
Hi, @jelmerk, I have a question that when will there be two taskmanager
registered in the same registry?
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6212
hi, @StephanEwen, cc, thx
---
GitHub user lamber-ken opened a pull request:
https://github.com/apache/flink/pull/6212
[FLINK-9666] short-circuit logic should be used in boolean contexts
## What is the purpose of the change
- short-circuit logic should be used in boolean contexts
GitHub user lamber-ken reopened a pull request:
https://github.com/apache/flink/pull/6195
[FLINK-9543][METRICS] Expose JobMaster ID to metric system
## What is the purpose of the change
This pull request makes flink can expose JM_ID to metric system
## Brief change log
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/6243#discussion_r199989644
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/local/LocalFileSystem.java ---
@@ -254,7 +254,7 @@ else if (file.exists
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6247
@zentol, @tillrohrmann hi, cc. I fixed some cases access static via class
reference
---
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/6243#discussion_r17861
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/local/LocalFileSystem.java ---
@@ -254,7 +254,7 @@ else if (file.exists
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6230
@zentol, hi, I found another occurrence just after the #6212 closed.
but I can't reopen that pr, so I start a new pr refered to #6212.
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6230
@tillrohrmann, hi, cc
---
GitHub user lamber-ken reopened a pull request:
https://github.com/apache/flink/pull/6230
[FLINK-9666] short-circuit logic should be used in boolean contexts
Backport of #6212 .
@tillrohrmann, hi, cc
You can merge this pull request into a Git repository by running
GitHub user lamber-ken opened a pull request:
https://github.com/apache/flink/pull/6195
[FLINK-9543][METRICS] Expose JobMaster ID to metric system
## What is the purpose of the change
This pull request makes flink can expose JM_ID to metric system
## Brief change log
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
@zentol, @tillrohrmann, cc
I don't think there is a relationship between `FLINK-9543` and `FLINK-9187`.
At present, the focus of our discussion is on the job name of pushgateway
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
@zentol , thanks for review.
first, there is a small point that the IDs may be duplicated when use JM/TM
actual unique ID to compose the job name of pushgateway, like the picture below
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6195
@zentol, cc.
---
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/6321#discussion_r202566500
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BigDecSerializer.java
---
@@ -69,17 +69,17 @@ public void serialize
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6321
@StephanEwen, if the original authors of the code had an intention of
writing the code as it is now,
I'll follow your advice and leave it as it is.
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6321
@zentol, @StephanEwen, thank you for explaining the question about
hotfixes. I was not very clear about whether to create a jira or hotfix before.
---
Github user lamber-ken closed the pull request at:
https://github.com/apache/flink/pull/6321
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6195
@zentol, ok
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6184
@zentol, well done. If there is anything I can do for you, please let me
know.
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6261
:100:, you are welcome, thank you for your explanation, I'll close this PR.
---
Github user lamber-ken closed the pull request at:
https://github.com/apache/flink/pull/6261
---
GitHub user lamber-ken opened a pull request:
https://github.com/apache/flink/pull/6261
[FLINK-9759] [DOCS] give an right answer about the savepoint restore when
stateless operators be added, deleted etc
## What is the purpose of the change
- fix irrelevant answer about
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/6247#discussion_r200379627
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -179,7 +179,7
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/6247#discussion_r200398562
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -179,7 +179,7
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/6247#discussion_r200421209
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -116,8 +116,8
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/6247#discussion_r200421156
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -179,7 +179,7
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/6247#discussion_r200431068
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/async/AsyncIOExample.java
---
@@ -116,8 +116,8
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6247
@nekrassov, you are strict and right.
when I revert, the communication between us was removed by github.
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6230
@tillrohrmann, @zentol, cc.
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6230
I see. I didn't know before.
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6247
@nekrassov, @zentol, I'll revert it, just fix static references.
I didn't pay attention to the problem of concurrency at first.
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6247
@nekrassov, yan can open a separate JIRA. here's address
[FLINK-JIRA](https://issues.apache.org/jira/projects/FLINK)
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6321
@zentol, hi, there are two ways to contribute to flink project.
one is create a `jira FLINK-` , another is `[hotfix] XXX`.
for example, fix some checkstyle or code refactor, how
GitHub user lamber-ken opened a pull request:
https://github.com/apache/flink/pull/6321
[FLINK-9829] fix the wrapper classes be compared by symbol of '==' directly
in BigDecSerializer.java
## What is the purpose of the change
- fix the wrapper classes be compared by symbol
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6321
The commit message includes the JIRA id now.
---
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/flink/pull/6321#discussion_r202075894
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BigDecSerializer.java
---
@@ -69,17 +69,17 @@ public void serialize
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6247
@nekrassov, :+1: , you can fork `flink` project, then create a PR to fix.
---
GitHub user lamber-ken opened a pull request:
https://github.com/apache/flink/pull/6247
[FLINK-9730] [code refactor] fix access static via class reference
## What is the purpose of the change
- fix access static via class reference
## Brief change log
- fix
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6230
@zentol, thanks for review. by the way, what's the best way to backport
refactorings and code-cleanups?
---
GitHub user lamber-ken opened a pull request:
https://github.com/apache/flink/pull/5855
[FLINK-9179] add prometheus pushgateway reporter
## What is the purpose of the change
This pull request makes flink system can send metrics to prometheus via
pushgateway. when using `yarn
Github user lamber-ken closed the pull request at:
https://github.com/apache/flink/pull/5855
---
GitHub user lamber-ken opened a pull request:
https://github.com/apache/flink/pull/5857
[FLINK-9180][METRICS] add prometheus pushgateway reporter
## What is the purpose of the change
This pull request makes flink system can send metrics to prometheus via
pushgateway. when using
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
for example,
Environment
- deploy flink job on hadoop yarn using `yarn-cluster` model
- prometheus collect metrics
because we use prometheus in production, so don't want
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
cc @tillrohrmann : If you have time, please review this PR, thanks.
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
ok, I see. I'll close the PR.
by the way, need to create jira first, and then PR?
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
ok, I see, thanks a lot.
I contributed to [ClickHouse](https://github.com/yandex/ClickHouse) before,
the submission process is different.
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
@zhangminglei ,can you cc
[FLINK-9187](https://issues.apache.org/jira/browse/FLINK-9187)
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
wrong place? can you point it out, I don't know. thank you
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
ok, I see. I'll close the PR.
use `FLINK-9189`, ok?
---
Github user lamber-ken closed the pull request at:
https://github.com/apache/flink/pull/5857
---
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/5857
ok
---
GitHub user lamber-ken reopened a pull request:
https://github.com/apache/flink/pull/5857
[FLINK-9187][METRICS] add prometheus pushgateway reporter
## What is the purpose of the change
This pull request makes flink system can send metrics to prometheus via
pushgateway. when
Github user lamber-ken commented on the issue:
https://github.com/apache/flink/pull/6212
hi, @tillrohrmann , what does this mean?
I don't understand, need I delete the branch?
> Create Bucketing Table S
lamber-ken created FLINK-11235:
--
Summary: fix thread lack when elasticsearch transport client init
failed
Key: FLINK-11235
URL: https://issues.apache.org/jira/browse/FLINK-11235
Project: Flink
lamber-ken created FLINK-11218:
--
Summary: fix the default restart delay value
Key: FLINK-11218
URL: https://issues.apache.org/jira/browse/FLINK-11218
Project: Flink
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/FLINK-11218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lamber-ken updated FLINK-11218:
---
Summary: fix the default restart stragegy delay value (was: fix the
default restart delay value
[
https://issues.apache.org/jira/browse/FLINK-11010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lamber-ken updated FLINK-11010:
---
Affects Version/s: 1.8.0
> Flink SQL timestamp is inconsistent with currentProcessingT
[
https://issues.apache.org/jira/browse/FLINK-11010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lamber-ken updated FLINK-11010:
---
Affects Version/s: 1.7.1
1.7.0
> Flink SQL timestamp is inconsist
lamber-ken created FLINK-11010:
--
Summary: Flink SQL timestamp is inconsistent with
currentProcessingTime()
Key: FLINK-11010
URL: https://issues.apache.org/jira/browse/FLINK-11010
Project: Flink
lamber-ken created FLINK-11250:
--
Summary: fix thread lack when StreamTask switched from DEPLOYING
to CANCELING
Key: FLINK-11250
URL: https://issues.apache.org/jira/browse/FLINK-11250
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-11174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725618#comment-16725618
]
lamber-ken commented on FLINK-11174:
hi, [~fanweiwen], you can follow
[https://flink.apache.org/how
[
https://issues.apache.org/jira/browse/FLINK-11174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725618#comment-16725618
]
lamber-ken edited comment on FLINK-11174 at 12/20/18 6:38 AM:
--
hi
1 - 100 of 268 matches
Mail list logo
