[GitHub] flink pull request: [FLINK-1818] Added api to cancel job from clie...

2015-07-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/642#discussion_r35240432 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/Client.java --- @@ -421,6 +426,50 @@ public JobSubmissionResult run(JobGraph jobGraph

[GitHub] flink pull request: [FLINK-1818] Added api to cancel job from clie...

2015-07-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/642#issuecomment-123815171 @rainiraj Thanks for your contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-1818] Added api to cancel job from clie...

2015-07-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/642#issuecomment-123802868 Thanks @rainiraj. I think we can merge your changes with some small adjustments. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-1818] Added api to cancel job from clie...

2015-07-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/642#discussion_r35240453 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/Client.java --- @@ -421,6 +426,50 @@ public JobSubmissionResult run(JobGraph jobGraph

[GitHub] flink pull request: [FLINK-1818] Added api to cancel job from clie...

2015-07-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/642#discussion_r35240436 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/Client.java --- @@ -421,6 +426,50 @@ public JobSubmissionResult run(JobGraph jobGraph

[GitHub] flink pull request: [FLINK-2387] add streaming test case for live ...

2015-07-21 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/926 [FLINK-2387] add streaming test case for live accumulators You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink live-accumulators-streaming

[GitHub] flink pull request: [FLINK-2388] return AccumulatorResultsNotFound...

2015-07-22 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/930 [FLINK-2388] return AccumulatorResultsNotFound until archive is checked You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink accumulator

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-123648113 This only occurs with your changes, right? Then let's first fix the issue of the failing tests before merging. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-123645039 +1 for merging it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2388] return AccumulatorResultsNotFound...

2015-07-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/930#discussion_r35195856 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -688,16 +688,15 @@ class JobManager( case

[GitHub] flink pull request: [FLINK-1658] Rename AbstractEvent to AbstractT...

2015-07-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/929#issuecomment-123646781 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: [FLINK-2388] return AccumulatorResultsNotFound...

2015-07-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/930#discussion_r35195608 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -688,16 +688,15 @@ class JobManager( case

[GitHub] flink pull request: [FLINK-2388] return AccumulatorResultsNotFound...

2015-07-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/930#discussion_r35204559 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -580,6 +581,34 @@ public ExecutionContext

[GitHub] flink pull request: [FLINK-2388] return AccumulatorResultsNotFound...

2015-07-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/930#discussion_r35204984 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -687,61 +687,23 @@ class JobManager( message match

[GitHub] flink pull request: Collect(): Fixing the akka.framesize size limi...

2015-07-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/887#issuecomment-123745096 Hi @kl0u, I'm sorry that my changes overlap so much with yours. Let me know if you have any questions. I think you have my email address? --- If your project is set up

[GitHub] flink pull request: [FLINK-2388] return AccumulatorResultsNotFound...

2015-07-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/930#discussion_r35219511 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -687,61 +687,23 @@ class JobManager( message match

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-123702675 The yarn tests build fine on my machine with your branch. Seems to be a general issue within the YARN tests. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2218] Web client cannot distinguesh bet...

2015-07-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/904#issuecomment-123707491 Yes, please open a JIRA. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2388] return AccumulatorResultsNotFound...

2015-07-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/930#issuecomment-123710720 Merging this later on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: Update README.md

2015-07-17 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/912#issuecomment-122254278 Thank you. Feel free to open another pull request! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2292][FLINK-1573] add live per-task acc...

2015-07-14 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/896#issuecomment-121173161 Wasn't the rationale to have a separate message for the heartbeat and the accumulators to keep the heartbeat messages small? What do you think? In any case, I agree

[GitHub] flink pull request: [FLINK-2292][FLINK-1573] add live per-task acc...

2015-07-14 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/896#discussion_r34547975 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -408,14 +408,16 @@ public long count() throws Exception

[GitHub] flink pull request: [FLINK-2292][FLINK-1573] add live per-task acc...

2015-07-14 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/896#discussion_r34549555 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -400,13 +398,22 @@ class JobManager(protected val

[GitHub] flink pull request: [FLINK-2292][FLINK-1573] add live per-task acc...

2015-07-14 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/896#discussion_r34552275 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java --- @@ -101,9 +101,9 @@ /** * For system

[GitHub] flink pull request: [FLINK-2292][FLINK-1573] add live per-task acc...

2015-07-14 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/896#discussion_r34547621 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java --- @@ -53,32 +53,34 @@ private final

[GitHub] flink pull request: [FLINK-2292][FLINK-1573] add live per-task acc...

2015-07-14 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/896#discussion_r34547538 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java --- @@ -101,9 +101,9 @@ /** * For system

[GitHub] flink pull request: [FLINK-2292][FLINK-1573] add live per-task acc...

2015-07-14 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/896#discussion_r34548050 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/AccumulatorEvent.java --- @@ -18,32 +18,60 @@ package

[GitHub] flink pull request: [FLINK-297] [web frontend] First part of JobMa...

2015-07-15 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/677#issuecomment-121533840 +1 good to merge and this is a prerequisite for getting a first version of the new web UI in. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-2292][FLINK-1573] add live per-task acc...

2015-07-15 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/896#discussion_r34662919 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -306,99 +308,100 @@ extends Actor with ActorLogMessages

[GitHub] flink pull request: [FLINK-2359] [java api] Add factory methods to...

2015-07-15 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/911#issuecomment-121534658 Thanks for adding the generator methods. That's definitely more convenient than using `new`. I also prefer `of` instead of `create`. --- If your project is set up

[GitHub] flink pull request: Update README.md

2015-07-15 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/912#issuecomment-121535828 Thanks @chenliag613 for the pull request! I agree with @chiwanpark. If you're behind a proxy then you probably already know how to work with it. There are also other

[GitHub] flink pull request: [FLINK-2292][FLINK-1573] add live per-task acc...

2015-07-15 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/896#discussion_r34665546 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -306,99 +308,100 @@ extends Actor with ActorLogMessages

[GitHub] flink pull request: [FLINK-2292][FLINK-1573] add live per-task acc...

2015-07-15 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/896#discussion_r34674005 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/AccumulatorRegistry.java --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [taskmanager] do not process message if not co...

2015-07-15 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/914 [taskmanager] do not process message if not connected to job manager When a message is received on the task manager, it should not be processed when not connected to the job manager. At least

[GitHub] flink pull request: [FLINK-2362] - distinct is missing in DataSet ...

2015-07-20 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/922#issuecomment-122805962 Thanks for improving the documentation. Looks good to merge for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-2362] - distinct is missing in DataSet ...

2015-07-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/922#discussion_r34974826 --- Diff: docs/apis/dataset_transformations.md --- @@ -924,6 +924,183 @@ Not supported. **Note:** Extending the set of supported aggregation functions

[GitHub] flink pull request: [FLINK-2362] - distinct is missing in DataSet ...

2015-07-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/922#discussion_r34984880 --- Diff: docs/apis/programming_guide.md --- @@ -606,7 +606,17 @@ DataSetTuple3Integer, String, Double output = input.sum(0).andMin(2); /td

[GitHub] flink pull request: [FLINK-2371] improve AccumulatorLiveITCase

2015-07-20 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/925 [FLINK-2371] improve AccumulatorLiveITCase Instead of using Thread.sleep() to synchronize the checks of the accumulator values, we rely on message passing here to synchronize the task process

[GitHub] flink pull request: [FLINK-2371] improve AccumulatorLiveITCase

2015-07-21 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/925#issuecomment-123213630 In the master, I only serialize the user-defined accumulators but not the Flink accumulators. As of this pull request, the accumulators are always serialized even in local

[GitHub] flink pull request: [FLINK-2371] improve AccumulatorLiveITCase

2015-07-21 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/925#discussion_r35087953 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala --- @@ -51,10 +51,13 @@ import scala.concurrent

[GitHub] flink pull request: [FLINK-2371] improve AccumulatorLiveITCase

2015-07-21 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/925#issuecomment-123283973 Thanks for the feedback. Merging this later on if there are no objections. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2371] improve AccumulatorLiveITCase

2015-07-21 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/925#discussion_r35080434 --- Diff: flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorLiveITCase.java --- @@ -109,125 +123,157 @@ public void testProgram() throws

[GitHub] flink pull request: [FLINK-2371] improve AccumulatorLiveITCase

2015-07-21 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/925#discussion_r35080374 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -400,20 +400,16 @@ class JobManager( import

[GitHub] flink pull request: [FLINK-2371] improve AccumulatorLiveITCase

2015-07-21 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/925#issuecomment-123243258 I've updated the pull request: - add flag to FlinkMiniCluster to disabled asynchronous execution of futures via the CallingThreadDispatcher - revert changes

[GitHub] flink pull request: [FLINK-2292][FLINK-1573] add live per-task acc...

2015-07-15 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/896#issuecomment-121605629 Thanks for the feedback @StephanEwen @uce. Will merge this once Travis passes. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [taskmanager] do not process message if not co...

2015-07-15 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/914#issuecomment-121606957 @uce Great! I didn't know this existed. I'd thought there must be a way to visualize the changes in a better way. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand

2015-08-25 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1057#discussion_r37895597 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -127,7 +127,7 @@ FLINK_LIB_DIR=$FLINK_ROOT_DIR/lib # The above lib path is used by the shell

[GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand

2015-08-25 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1057#discussion_r37894302 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -127,7 +127,7 @@ FLINK_LIB_DIR=$FLINK_ROOT_DIR/lib # The above lib path is used by the shell

[GitHub] flink pull request: [hotfix] Allow setting FLINK_CONF_DIR by hand

2015-08-25 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1057#issuecomment-134679865 Very useful feature. In addition, I could also imagine that the config file could be passed as a parameter to the ./bin/flink utility. --- If your project is set up

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-08-25 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/992#discussion_r37879401 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java

[GitHub] flink pull request: [FLINK-2555] Properly pass security credential...

2015-08-25 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1038#issuecomment-134632899 I've opened another issue for that: https://issues.apache.org/jira/browse/FLINK-2573 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-23 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r42879750 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java --- @@ -304,4 +368,60 @@ public String getDescription

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-23 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r42884467 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java --- @@ -304,4 +368,60 @@ public String getDescription

[GitHub] flink pull request: [FLINK-2827] Closing FileInputStream through t...

2015-10-26 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1276#issuecomment-151091135 Looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-26 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r42979520 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java --- @@ -304,4 +368,60 @@ public String getDescription

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-27 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1214#issuecomment-151430438 Thanks. Looks much better. Let's make sure we don't break any classloader or jar dependencies during job submission. This can cause annoyances for users and we have to fix

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r43098268 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -909,7 +919,21 @@ private int handleError(Throwable t

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r43098234 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/Client.java --- @@ -271,18 +272,21 @@ public JobSubmissionResult runDetached

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r43098099 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java --- @@ -75,29 +62,31 @@ public

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r43098098 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java --- @@ -75,29 +62,31 @@ public

[GitHub] flink pull request: [FLINK-2934] Remove placeholder pages for job....

2015-10-28 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1307#issuecomment-151841903 Thanks! Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: Add org.apache.httpcomponents:(httpcore, httpc...

2015-10-27 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1301#issuecomment-151577309 +1 looks good. will merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2927] [runtime] Provide default require...

2015-10-27 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1303#issuecomment-151575894 +1 will merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r43273230 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/Client.java --- @@ -271,18 +272,21 @@ public JobSubmissionResult runDetached

[GitHub] flink pull request: [FLINK-2017] Add predefined required parameter...

2015-10-29 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1097#issuecomment-152135619 I think it's fine to have an `add(Option)` method in addition to `add(String)`. There might be cases where you want to create the Options first and add them later

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-26 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1214#issuecomment-151224527 I took a look at this again because I wanted to merge it for 0.10. However, I think it still needs a bit of work. The `ContextEnvironmentFactory` shouldn't hold the state

[GitHub] flink pull request: [FLINK-2206] Fix incorrect counts of finished,...

2015-10-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1287#issuecomment-150212141 +1 good to merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r42772489 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/Client.java --- @@ -277,12 +278,20 @@ else if (prog.isUsingInteractiveMode

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r42772667 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java --- @@ -139,6 +140,69 @@ public void shouldSubmitToJobClient

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r42772661 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java --- @@ -139,6 +140,69 @@ public void shouldSubmitToJobClient

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r42772634 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java --- @@ -161,6 +171,8 @@ public ContextEnvironmentFactory(Client

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r42772606 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java --- @@ -172,5 +184,74 @@ public ExecutionEnvironment

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-10-22 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r42772695 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java --- @@ -304,4 +368,60 @@ public String getDescription

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-11-09 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1214#issuecomment-155059238 Yes, the idea is suppress output during the dry-run and plan creation. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2730][web-dashboard] Adds cpu and memor...

2015-11-09 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1236#discussion_r44280702 --- Diff: flink-runtime-web/web-dashboard/bower.json --- @@ -23,7 +23,8 @@ "dagre-d3": "~0.4.10", "font-awesome&quo

[GitHub] flink pull request: [FLINK-2730][web-dashboard] Adds cpu and memor...

2015-11-09 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1236#discussion_r44274673 --- Diff: flink-runtime-web/web-dashboard/bower.json --- @@ -23,7 +23,8 @@ "dagre-d3": "~0.4.10", "font-awesome&quo

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-11 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1342#issuecomment-155719584 Thank you for the testing and the patch. I would like to merge this soon. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2989] job cancel button doesn't work on...

2015-11-11 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1344#issuecomment-155764939 +1 for the integration test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-11-11 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1214#issuecomment-155842188 There is a merge conflict. Looks good otherwise. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request:

2015-11-11 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/commit/976bacc65908cc35382ddbbcdc80249a700bc2d3#commitcomment-14333154 In flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java: In flink-clients/src/main/java/org/apache/flink/client

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-11 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1342#issuecomment-155770210 I was thinking about something like a reflection-based mechanism. Not sure though if this will work across different versions. Probably the API didn't change much

[GitHub] flink pull request: [FLINK-2987] Remove jersey-core and jersey-cli...

2015-11-09 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1340#issuecomment-155113703 +1 for merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...

2015-11-09 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1327#issuecomment-155119995 Could you rebase again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2904][web-dashboard] Fix truncation of ...

2015-11-09 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1321#issuecomment-155121224 I think it's fine that the boxes are not all the same size for large numbers.. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2982][cli] Fix to show streaming plans ...

2015-11-09 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1334#issuecomment-155128816 This is a valid fix. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-10 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1342#issuecomment-155380888 Thanks for the pull request. Looks good to me except for one comment. I would like to postpone merging until you have verified the changes. --- If your project is set up

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-10 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1342#discussion_r44390519 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java --- @@ -135,7 +142,40 @@ public static void setTokensFor(ContainerLaunchContext amContainer

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-11-10 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1214#issuecomment-155373495 >This is a full fledged execution of the use code, and should show any user generated out and err messages in my opinion. You're probably right. It may just s

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-11-10 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1214#issuecomment-155381011 Looks like your recent changes broke the YARN tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-11-12 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r44641729 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/DetachedEnvironment.java --- @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-11-12 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1214#discussion_r44645161 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/DetachedEnvironment.java --- @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-12 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1342#issuecomment-156061452 Dynamic class loading should work then. Would be great if you could integrate it @nielsbasjes. We understand you're not an average user since you're an open source software

[GitHub] flink pull request: [hotfix] Wrong base url for docs

2015-11-13 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1351#issuecomment-156475660 Thank you! I fixed this before I saw your pull request. Could you close the pr? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request:

2015-11-13 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/commit/976bacc65908cc35382ddbbcdc80249a700bc2d3#commitcomment-14385157 In flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java: In flink-clients/src/main/java/org/apache/flink/client

[GitHub] flink pull request: minor javadoc fix in JobManager

2015-11-16 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1358#issuecomment-157126156 Yes, that's correct. Nice diagram :) Could you post it to the mailing list when you're finished? Thank you! --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-3020][streaming] set local default para...

2015-11-16 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1360 [FLINK-3020][streaming] set local default parallelism to maxmium parallelism You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink FLINK-3020

[GitHub] flink pull request: [FLINK-2977] Added support for accessing a Ker...

2015-11-16 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1342#issuecomment-156965181 Thanks for testing this so thoroughly. +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...

2015-11-10 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1214#issuecomment-155391848 >Do you know of any change I can make to travis conf so all modules are built but only Yarn tests get executed? Yes change the build instructions in .travis.

[GitHub] flink pull request: [FLINK-2989] job cancel button doesn't work on...

2015-11-10 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1344 [FLINK-2989] job cancel button doesn't work on YARN In addition to the REST-compliant "DELETE /jobs/", allows cancellation also via a special GET request of the form "GET /jo

[GitHub] flink pull request: Remove and forbid use of SerializationUtils. F...

2015-11-10 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1343#discussion_r44404515 --- Diff: tools/maven/checkstyle.xml --- @@ -54,11 +54,18 @@ under the License

<    1   2   3   4   5   6   7   8   9   10   >