[GitHub] flink pull request: [FLINK-3667] refactor client communication

2016-06-01 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1978#discussion_r65348868 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -20,8 +20,6 @@ --- End diff -- Done. --- If your

[GitHub] flink pull request: [FLINK-3667] refactor client communication

2016-06-01 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1978#discussion_r65348898 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/Client.java --- @@ -100,6 +102,9 @@ */ private JobID lastJobID

[GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests

2016-05-31 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2056 I'm not sure whether the changes fix the problem. I think you were lucky with the build machine on Travis :) The issue on Travis is that the `ExecutionEnvironment` defaults to using the number

[GitHub] flink pull request #2147: [FLINK-1946] reduce verbosity of Yarn cluster setu...

2016-06-22 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2147 [FLINK-1946] reduce verbosity of Yarn cluster setup This removes repeated printing of messages retrieved from the Yarn cluster. Only new messages are printed. You can merge this pull request

[GitHub] flink pull request #2140: [FLINK-4079] do not load Yarn properties file for ...

2016-06-21 Thread mxm
Github user mxm closed the pull request at: https://github.com/apache/flink/pull/2140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2140: [FLINK-4079] do not load Yarn properties file for per-job...

2016-06-21 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2140 Travis has passed. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #2140: [FLINK-4079] do not load Yarn properties file for per-job...

2016-06-21 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2140 Merged with 3163638a61f49dd2df55467615096918bec3a890. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #2140: [FLINK-4079] do not load Yarn properties file for ...

2016-06-21 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2140 [FLINK-4079] do not load Yarn properties file for per-job Yarn clusters This is a backported fix for the release-1.0 branch to skip loading of the Yarn properties file for per-job Yarn clusters. You

[GitHub] flink issue #2034: [FLINK-3937] Implemented -yid option to Flink cli list, s...

2016-06-17 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2034 Merged. Thank you for your contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #2085: [FLINK-3937] programmatic resuming of clusters

2016-06-17 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2085 Merged. Thank you for your comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #2125: [FLINK-3864] Yarn tests don't check for prohibited...

2016-06-17 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2125 [FLINK-3864] Yarn tests don't check for prohibited strings in log output You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink FLINK-3864

[GitHub] flink pull request #2139: [FLINK-3838] Upgrade commons-cli to fix parsing of...

2016-06-20 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2139 [FLINK-3838] Upgrade commons-cli to fix parsing of jar args The jar arguments were not parsed correctly if options were present. For example, in `./flink run file.jar -arg value` the jar

[GitHub] flink issue #2132: [FLINK-4090] Close of OutputStream should be in finally c...

2016-06-20 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2132 Merging with a slight change to use the `Closeable` feature: ```java try (final OutputStream out = new FileOutputStream(propertiesFile

[GitHub] flink pull request #2138: [FLINK-3757] clarify JavaDoc for addAccumulator me...

2016-06-20 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2138 [FLINK-3757] clarify JavaDoc for addAccumulator method You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink FLINK-3757 Alternatively you can

[GitHub] flink pull request #:

2016-06-20 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/commit/c8fed99e3e85a4d27c6134cfa3e07fb3a8e1da2a#commitcomment-17936226 In pom.xml: In pom.xml on line 972: It does work fine for most cases. However, there are rare race conditions which render our

[GitHub] flink issue #2132: [FLINK-4090] Close of OutputStream should be in finally c...

2016-06-20 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2132 Thank you for the pull request! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #2137: [FLINK-4041] reduce log level for JobManager->Reso...

2016-06-20 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2137 [FLINK-4041] reduce log level for JobManager->ResourceManager timeouts These timeouts can be recovered and don't have to be logged as error with an Exception. You can merge this pull requ

[GitHub] flink pull request: [FLINK-3132] [docs] Initial docs restructure

2016-01-14 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1499#issuecomment-171713856 Looks very nice @uce. Would it be possible to shift the left navigation bar to the top of the main text corpus? It makes the main text corpus strangely positioned and takes

[GitHub] flink pull request: [FLINK-3170] expose task manager metrics via J...

2016-01-18 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1452#issuecomment-172523934 Closing this for a future pull request which uses a different approach and also exposes accumulators. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-3170] expose task manager metrics via J...

2016-01-18 Thread mxm
Github user mxm closed the pull request at: https://github.com/apache/flink/pull/1452 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2522] Streaming support for Flink-Scala...

2016-01-18 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1412#issuecomment-172493786 The context environment is set in the `ScalaShellRemoteEnvironment` to disable creation of new environments by the user. This is done when you first create the batch

[GitHub] flink pull request: [FLINK-2522] Streaming support for Flink-Scala...

2016-01-18 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1412#issuecomment-172494058 By the way, sorry for the late response. I was traveling. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-3132] [docs] Initial docs restructure

2016-01-14 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1499#issuecomment-171735915 Makes sense. Smaller font size will probably do it then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink issue #2168: [FLINK-3964] add hint to job submission timeout exception...

2016-06-28 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2168 Thanks for the feedback. Savepoint related errors should be forwarded to the client independently of timeouts (except maybe when the savepoint takes too long). So that should be fixed in a follow-up

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68741918 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java --- @@ -100,15 +100,22 @@ public void testRun

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68741402 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68742191 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68742325 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68742138 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68741598 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68742023 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink issue #2138: [FLINK-3757] clarify JavaDoc for addAccumulator method

2016-06-25 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2138 Thank you for the suggestion. I incorporated it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #2123: [FLINK-3904] GlobalConfiguration doesn't ensure co...

2016-06-17 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2123 [FLINK-3904] GlobalConfiguration doesn't ensure config has been loaded This PR contains two commits. The first commit simply checks whether `loadConfiguration(..)` has been called. The second commit

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-06-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r68905471 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -269,26 +269,26 @@ * Percentage of heap space to remove

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-06-29 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2177 Thanks for updating the documentation! I've made some suggestions regarding the names of the new configuration keys. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-06-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r68908671 --- Diff: docs/setup/config.md --- @@ -107,12 +109,20 @@ Please make sure to set the maximum ticket life span high long running jobs. The If you

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68910391 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -132,9 +132,9 @@ - private final Configuration

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-06-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r68905457 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -269,26 +269,26 @@ * Percentage of heap space to remove

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-06-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r68905882 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -269,26 +269,26 @@ * Percentage of heap space to remove

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-06-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r68905853 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -269,26 +269,26 @@ * Percentage of heap space to remove

[GitHub] flink pull request: [FLINK-3383] remove Maven deployment from Trav...

2016-02-10 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1619 [FLINK-3383] remove Maven deployment from Travis CI config Deployment will be handled by Apache's buildbot instances which trigger the deployment of snapshot versions every night. This way, we have

[GitHub] flink pull request: [FLINK-2721] [Storm Compatibility] Add Tuple m...

2016-02-06 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1591#discussion_r52102026 --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java --- @@ -41,55 +39,61 @@ */ public class StormTuple

[GitHub] flink pull request: [FLINK-2721] [Storm Compatibility] Add Tuple m...

2016-02-06 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1591#discussion_r52102060 --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java --- @@ -229,9 +229,24 @@ private void translateTopology

[GitHub] flink pull request: [FLINK-2721] [Storm Compatibility] Add Tuple m...

2016-02-06 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1591#discussion_r52102056 --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/SpoutCollectorTest.java --- @@ -75,12 +75,71 @@ public void

[GitHub] flink pull request: [FLINK-2721] [Storm Compatibility] Add Tuple m...

2016-02-06 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1591#discussion_r52102057 --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/SpoutCollectorTest.java --- @@ -75,12 +75,71 @@ public void

[GitHub] flink pull request: [FLINK-2721] [Storm Compatibility] Add Tuple m...

2016-02-06 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1591#issuecomment-180765494 Looks like the meta data is now completely available :). +1 for merging this. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2721] [Storm Compatibility] Add Tuple m...

2016-02-06 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1591#discussion_r52102118 --- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/tests/operators/VerifyMetaDataBolt.java --- @@ -0,0 +1,65

[GitHub] flink pull request: [FLINK-3334] [conf] Include year-month-day in ...

2016-02-08 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1604#issuecomment-181501036 This will make log files harder to read but I see that it is necessary for production systems. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-3334] [conf] Include year-month-day in ...

2016-02-08 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1604#issuecomment-181506978 +1 also from my side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2721] [Storm Compatibility] Add Tuple m...

2016-02-05 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1591#issuecomment-180288305 @mjsax Would be good to merge this. I'll take a look later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-3383] remove Maven deployment from Trav...

2016-02-11 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1619#issuecomment-182825715 Thanks for the comment. Yes, as stated above, I would like to migrate snapshot deployment to the a nightly Buildbot job at Apache's infrastructure (like we also do

[GitHub] flink pull request: [FLINK-3383] remove Maven deployment from Trav...

2016-02-11 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1619#discussion_r52591570 --- Diff: .travis.yml --- @@ -17,9 +17,9 @@ language: java matrix: include: - jdk: "oraclejdk8" - env: PROFILE="-

[GitHub] flink pull request: [FLINK-3300] fix concurrency bug in YarnJobMan...

2016-01-29 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1561#issuecomment-176723782 Test failures unrelated to the changes. Yarn tests pass in this build: https://travis-ci.org/apache/flink/jobs/105645193 --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-3300] fix concurrency bug in YarnJobMan...

2016-01-29 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1561 [FLINK-3300] fix concurrency bug in YarnJobManager Adds message passing between Hadoop's async resource manager client and the YarnJobManager actor. It helps to view the diff with ignored

[GitHub] flink pull request: [FLINK-3300] fix concurrency bug in YarnJobMan...

2016-01-29 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1561#issuecomment-176838676 Thanks for the review @tillrohrmann. Going to merge this soon as it is a release critical fix. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-2933] Flink scala libraries exposed wit...

2016-01-26 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1529#issuecomment-174956562 Yep, that is still to do alongside with the mailing list announcement. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-3265] Make RabbitMQ source threadsafe

2016-01-26 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1534#issuecomment-174941767 Thanks for the pull request. +1 Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...

2016-02-01 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1560#discussion_r51408033 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledgingSourceBase.java --- @@ -177,21 +177,19

[GitHub] flink pull request: [hotfix][yarn] Shutdown JVM when Flink-on-yarn...

2016-02-03 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1576#issuecomment-179113125 +1 Makes sense to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [hotfix][yarn] Shutdown JVM when Flink-on-yarn...

2016-02-03 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1576#issuecomment-179124457 Could we flush standard out and the log system explicitly? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-3265][tests] adapt RabbitMQ checkpointi...

2016-02-01 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1569 [FLINK-3265][tests] adapt RabbitMQ checkpointing test to runtime behavior This reverts the previous fix as this was merely a bug in the test. The methods `snapshotState` and `notifyCheckpointComplete

[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...

2016-02-01 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1560#issuecomment-178029684 Thanks for the pull request. The issue has been identified in the meantime. It is only a testing issue and not a synchronization issue in the RMQSource. --- If your

[GitHub] flink pull request: [FLINK-3265][tests] adapt RabbitMQ checkpointi...

2016-02-01 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1569#discussion_r51432976 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java --- @@ -219,7

[GitHub] flink pull request: [FLINK-3485] implement toString for Serialized...

2016-02-25 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1717 [FLINK-3485] implement toString for SerializedListAccumulator You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink FLINK-3485 Alternatively

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-02-29 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1741 [FLINK-3544] Introduce ResourceManager component So far the JobManager has been the central instance which is responsible for resource management and allocation. While thinking about how

[GitHub] flink pull request: [FLINK-3517] [dist] Only count active PIDs in ...

2016-02-26 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1716#issuecomment-189190990 +1 to merge! I find "No taskmanager daemon (pid: 27140) is running anymore on pablo." confusing. I think we could change it to something like "TaskM

[GitHub] flink pull request: [FLINK-2972] remove Chill dependency from the ...

2016-01-21 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1535 [FLINK-2972] remove Chill dependency from the test scope This eliminates the last bit of the Scala dependency of `flink-java`. If the Chill library can't be found it is replaced by one of the default

[GitHub] flink pull request: [FLINK-2933] Flink scala libraries exposed wit...

2016-01-21 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1529#issuecomment-173533784 I agree it would be nice to fix the Scala dependency of `flink-java` before merging. Let's try to find a solution. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...

2016-01-21 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1421#issuecomment-173624371 Congrats @sachingoel0101. I hope you stick with us :) Do you think you'll be able to finish the PR? --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2933] Flink scala libraries exposed wit...

2016-01-21 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1529#issuecomment-173621826 I've rebased and would like to merge soon. I'll post an announcement on the user/dev mailinglist that some module names will change. ``` Checking Scala-free modules

[GitHub] flink pull request: [FLINK-2933] Flink scala libraries exposed wit...

2016-01-23 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1529#issuecomment-174172295 `flink-java` does not have a dependency on Scala anymore because it has been removed in the course of this pull request (as referenced in this pull request, see #1535

[GitHub] flink pull request: [FLINK-2933] Flink scala libraries exposed wit...

2016-01-23 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1529#issuecomment-174176742 @fhueske `flink-storm` depends on `flink-runtime` only transitively through `flink-streaming-java`. However, I know from working with the code that it also depends

[GitHub] flink pull request: [FLINK-3285][maven] skip deployment of flink-j...

2016-01-25 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1547 [FLINK-3285][maven] skip deployment of flink-java8 module You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink FLINK-3285 Alternatively you

[GitHub] flink pull request: [FLINK-2933] Flink scala libraries exposed wit...

2016-01-20 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1529 [FLINK-2933] Flink scala libraries exposed with maven should carry scala version This pull request adds Scala suffixes to all Maven modules which dependent on a Scala version. The default Scala

[GitHub] flink pull request: [FLINK-2933] Flink scala libraries exposed wit...

2016-01-26 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1529#issuecomment-175143232 Rebased and squashed commits. For the documentation, I will update all unsuffixed module references with a Scala suffix variable. For example, flink-streaming-java

[GitHub] flink pull request:

2016-01-27 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/commit/8b34d21e054bb1df3a86f975ff29a51807858a81#commitcomment-15702724 That would be great if you could do that. I just wrote an email to the user and dev mailing list. --- If your project is set up

[GitHub] flink pull request:

2016-01-27 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/commit/8b34d21e054bb1df3a86f975ff29a51807858a81#commitcomment-15704256 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2522] Streaming support for Flink-Scala...

2016-02-15 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1412#issuecomment-184194014 @nikste Cool! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-3248] add constructor params and generi...

2016-02-18 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1670 [FLINK-3248] add constructor params and generic ConnectionFactory This adds more default constructor parameters to the RMQSource. In addition, users may override the setupConnectionFactory() method

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-10 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1741#issuecomment-194945986 Our testing infrastructure is currently very unstable. Here is at least a build where everything passes: https://travis-ci.org/mxm/flink/builds/115046589 If nobody

[GitHub] flink pull request: FLINK-3529 Add template for pull requests

2016-03-10 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1729#discussion_r55687974 --- Diff: CONTRIBUTING.md --- @@ -8,4 +8,4 @@ To make the process smooth for the project *committers* (those who review and ac Please check out

[GitHub] flink pull request: FLINK-3529 Add template for pull requests

2016-03-10 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1729#issuecomment-194879749 Yes, the test failures are unrelated. Looks good. Could you incorporate the last comments? --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: FLINK-3529 Add template for pull requests

2016-03-10 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1729#discussion_r55688207 --- Diff: PULL_REQUEST_TEMPLATE.md --- @@ -0,0 +1,18 @@ +Thanks for contributing to Apache Flink. Before you open your pull request, please take

[GitHub] flink pull request: FLINK-3428: Adds a fixed time trailing waterma...

2016-03-18 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1764#issuecomment-197937643 Thanks @kl0u. In addition to the JavaDoc, we should also document this in the streaming Programming Guide. Here: https://ci.apache.org/projects/flink/flink-docs-master/apis

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-18 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r56507764 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/FlinkResourceManager.java --- @@ -0,0 +1,796 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-18 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r56479509 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/FlinkResourceManager.java --- @@ -0,0 +1,796 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-18 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r56520101 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/FlinkResourceManager.java --- @@ -0,0 +1,796 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-18 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r56508199 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/FlinkResourceManager.java --- @@ -0,0 +1,796 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-18 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r56483788 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/FlinkResourceManager.java --- @@ -0,0 +1,796 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-3569] fix test cases that expect a diff...

2016-03-11 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1767#issuecomment-195282751 Sure. Thanks for merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-3569] fix test cases that expect a diff...

2016-03-11 Thread mxm
Github user mxm closed the pull request at: https://github.com/apache/flink/pull/1767 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-15 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r56204407 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java --- @@ -0,0 +1,343 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-15 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r56204117 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ContaineredTaskManagerParameters.java --- @@ -0,0 +1,182

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-15 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r56203861 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ContaineredTaskManagerParameters.java --- @@ -0,0 +1,182

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r55831451 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala --- @@ -366,6 +428,28 @@ abstract class FlinkMiniCluster

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r55831570 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java --- @@ -0,0 +1,344 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r55831616 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -682,27 +729,27 @@ */ public static final int

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1741#issuecomment-195382194 Thank you for checking out the PR @rmetzger! Great to see it working in a cluster environment with Task Manager failures. I didn't add anything to the documentation (apart

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r55831803 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -240,6 +246,37 @@ */ public static final String

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r56328991 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/FlinkResourceManager.java --- @@ -0,0 +1,801 @@ +/* + * Licensed

<    4   5   6   7   8   9   10   11   12   13   >