[GitHub] flink issue #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-23 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2332 Cool. Let me know if you have any questions or if you need any help. I'll keep an eye on this PR and the Bahir-flink repository. --- If your project is set up for it, you can reply to

[GitHub] flink issue #2387: [FLINK-4317, FLIP-3] [docs] Restructure docs

2016-08-22 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2387 I'm against merging it to the 1.1.x branch. Its a big change, that we would do between releases. In a few months, we'll have a new release, then users can enjoy the new layout. -

[GitHub] flink issue #2314: [FLINK-3298] Implement ActiveMQ streaming connector

2016-08-22 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2314 Okay, can do. It would be good if you could address the comment first. Sent from my iPhone > On 22.08.2016, at 16:53, Ivan Mushketyk wrote: > > @rmetzg

[GitHub] flink issue #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-22 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2332 @delding: Thanks a lot for opening a pull request for a streaming hbase connector to Flink. Would you be okay with contributing the connector to Apache Bahir, instead of Apache Flink? The

[GitHub] flink issue #2314: [FLINK-3298] Implement ActiveMQ streaming connector

2016-08-22 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2314 Do you want to open the PR at Bahir or should I do it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #2350: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-08-22 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2350#discussion_r75651032 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java --- @@ -214,14 +216,26 @@ public

[GitHub] flink issue #2031: FLINK-3967 - Flink Sink for Rethink Db

2016-08-22 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2031 Hi @mans2singh ! There's good news regarding streaming connector contributions in Apache Flink: If you are interested in hosting the code as part of an Apache project, the Apache Bahir pr

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-22 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r75648568 --- Diff: flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java --- @@ -0,0

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-22 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r75648389 --- Diff: flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/internal/AMQExceptionListener.java

[GitHub] flink issue #2314: [FLINK-3298] Implement ActiveMQ streaming connector

2016-08-22 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2314 One more thing: Let me know if you don't like to do the migration to Bahir. I understand that this is a bit annoying and our fault. I can also do the migration if you want. --- If your proje

[GitHub] flink issue #2314: [FLINK-3298] Implement ActiveMQ streaming connector

2016-08-22 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2314 Hi Ivan, thank you for addressing all my comments. I've filed a JIRA in Bahir for adding the ActiveMQ connector: https://issues.apache.org/jira/browse/BAHIR-56 I'll do a fina

[GitHub] flink issue #2382: [FLINK-4402]: Wrong metrics parameter names in documentat...

2016-08-19 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2382 merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2379: Add ManualSpeedTestITCase For Assessing State Performance

2016-08-19 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2379 Merge it :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2382: [FLINK-4402]: Wrong metrics parameter names in documentat...

2016-08-19 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2382 Thank you for your contribution. I think its good to merge. @zentol can you confirm? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #2305: [FLINK-4271] [DataStreamAPI] Enable CoGroupedStreams and ...

2016-08-19 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2305 I'm also okay with `with()` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] flink issue #2383: [FLINK-4418] [client] Improve resilience when InetAddress...

2016-08-19 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2383 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2260: [FLINK-4222] Allow Kinesis configuration to get credentia...

2016-08-19 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2260 Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2387: [FLINK-4317, FLIP-3] [docs] Restructure docs

2016-08-19 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2387 Great, thank you. +1 to merge :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #2387: [FLINK-4317, FLIP-3] [docs] Restructure docs

2016-08-19 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2387 Where are the streaming connectors linked? ![image](https://cloud.githubusercontent.com/assets/89049/17809224/5fc916f8-6615-11e6-81b2-56d8f1bfadb1.png) --- If your project is set up for

[GitHub] flink issue #2386: [FLINK-3660] Measure latency and exposes them via a metri...

2016-08-19 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2386 Good point, thank you! I'm not sure yet if I keep the format of the metrics like this. I find those nested HashMaps quite clumsy. Once this PR and the metrics-in-webinterface-pr is merged,

[GitHub] flink pull request #2386: [FLINK-3660] Measure latency and exposes them via ...

2016-08-18 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/2386 [FLINK-3660] Measure latency and exposes them via a metric This commit adds the initial runtime support for measuring latency of records going through the system. I therefore introduced a

[GitHub] flink pull request #2379: Add ManualSpeedTestITCase For Assessing State Perf...

2016-08-18 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2379#discussion_r75326928 --- Diff: flink-tests/src/test/java/org/apache/flink/test/state/ManualWindowSpeedITCase.java --- @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache

[GitHub] flink issue #2153: [FLINK-4110] Add testing skeleton to quickstart

2016-08-18 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2153 Yes, the joda-time exclusion is independent. I just experienced that this has been an issue for our users multiple times. I'll update the tests to test the `SocketTextStreamWord

[GitHub] flink issue #2260: [FLINK-4222] Allow Kinesis configuration to get credentia...

2016-08-18 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2260 Thanks a lot for the review @tzulitai. @chadnickbok Thanks a lot for the contribution! I can also offer to add the missing `break;` when merging the PR. --- If your project is set up

[GitHub] flink pull request #2350: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-08-18 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2350#discussion_r75304305 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java --- @@ -106,6 +109,140 @@ public static void

[GitHub] flink pull request #2350: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-08-18 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2350#discussion_r75304033 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java --- @@ -106,6 +109,140 @@ public static void

[GitHub] flink pull request #2350: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-08-18 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2350#discussion_r75303846 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java --- @@ -106,6 +109,140 @@ public static void

[GitHub] flink pull request #2350: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-08-18 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2350#discussion_r75303417 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java --- @@ -106,6 +109,140 @@ public static void

[GitHub] flink pull request #2350: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-08-18 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2350#discussion_r75298087 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java --- @@ -146,16 +146,24 @@ void checkAsyncException

[GitHub] flink pull request #2350: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-08-18 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2350#discussion_r75298028 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java --- @@ -146,16 +146,24 @@ void checkAsyncException

[GitHub] flink pull request #2350: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-08-18 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2350#discussion_r75297857 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java --- @@ -179,7 +195,16

[GitHub] flink issue #2378: [FLINK-4409] [build] Exclude JSR 305 from Hadoop dependen...

2016-08-17 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2378 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2314: [FLINK-3298] Implement ActiveMQ streaming connector

2016-08-17 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2314 Lets wait for the Bahir GitHub repo being opened and then open a PR there. I can't merge it there myself, because I'm not a committer, but I'm sure they'll merge it once I&#x

[GitHub] flink issue #2314: [FLINK-3298] Implement ActiveMQ streaming connector

2016-08-17 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2314 @mushketyk: The bahir community is currently setting up a repository for Flink. I think it'll be available in the next days. The connector is almost ready to be merged to bahir. -

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r75083728 --- Diff: flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java --- @@ -0,0

[GitHub] flink issue #2314: [FLINK-3298] Implement ActiveMQ streaming connector

2016-08-17 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2314 >>Were there any any dependency issues / conflicts with the user job jar? > >Sorry, what do you mean by the "job jar"? When adding the flink-connector-activem

[GitHub] flink issue #2231: [FLINK-4035] Bump Kafka producer in Kafka sink to Kafka 0...

2016-08-15 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2231 @radekg I've opened a PR based on your code: https://github.com/apache/flink/issues/2369 feel free to review it. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #2373: [FLINK-4394] RMQSource: QueueName accessible for subclass...

2016-08-15 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2373 Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2314: [FLINK-3298] Implement ActiveMQ streaming connector

2016-08-15 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2314 Thank you for this contribution. I did an initial check of the code. Once all my comments are addressed, I'll do another check. Did you test the code on a cluster? Were there an

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r74766852 --- Diff: flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java --- @@ -0,0

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r74766651 --- Diff: flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java --- @@ -0,0

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r74766399 --- Diff: flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java --- @@ -0,0

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r74762300 --- Diff: flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSink.java --- @@ -0,0 +1,155

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r74762673 --- Diff: flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSink.java --- @@ -0,0 +1,155

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r74762401 --- Diff: flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSink.java --- @@ -0,0 +1,155

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r74762137 --- Diff: flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSink.java --- @@ -0,0 +1,155

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r74760157 --- Diff: flink-streaming-connectors/flink-connector-activemq/pom.xml --- @@ -0,0 +1,104 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] flink pull request #2314: [FLINK-3298] Implement ActiveMQ streaming connecto...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2314#discussion_r74760042 --- Diff: flink-streaming-connectors/flink-connector-activemq/pom.xml --- @@ -0,0 +1,104 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] flink issue #2314: [FLINK-3298] Implement ActiveMQ streaming connector

2016-08-15 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2314 Thanks a lot for the contribution @mushketyk. It seems like the Flink community prefers to have put the majority of connector modules to Apache Bahir. We are currently in the process of figuring

[GitHub] flink issue #2313: [FLINK-4273] Modify JobClient to attach to running jobs

2016-08-15 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2313 I did a quick pass over the code. I think this change needs another review by our Actor expert @tillrohrmann ;) --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r74757794 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClientActor.java --- @@ -198,10 +211,47 @@ else if (message instanceof

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r74757666 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,168 @@ public static JobExecutionResult

[GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...

2016-08-15 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2313#discussion_r74756158 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java --- @@ -118,27 +138,168 @@ public static JobExecutionResult

[GitHub] flink issue #2373: [FLINK-4394] RMQSource: QueueName accessible for subclass...

2016-08-15 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2373 I'm going to merge the change once travis gives green light. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] flink pull request #2369: [FLINK-4035] Add a streaming connector for Apache ...

2016-08-14 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/2369 [FLINK-4035] Add a streaming connector for Apache Kafka 0.10.x This pull request subsumes https://github.com/apache/flink/pull/2231. Compared to #2231, I've based the connector o

[GitHub] flink issue #2267: [FLINK-4205] Create a simple stratified sampling function...

2016-08-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2267 @greghogan would you be willing to review this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #2289: [FLINK-3866] StringArraySerializer type should be mutable

2016-08-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2289 Hi @mushketyk, I'll try to find somebody to review this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #2231: [FLINK-4035] Bump Kafka producer in Kafka sink to Kafka 0...

2016-08-10 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2231 Okay, cool. Thank you. I'll probably open a pull request with your and my changes. I'll let you know so that you can help reviewing it. --- If your project is set up for it, you can rep

[GitHub] flink issue #2231: [FLINK-4035] Bump Kafka producer in Kafka sink to Kafka 0...

2016-08-10 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2231 @radekg, are you okay with me using your pull request as a base for adding Kafka 0.10 to Flink? I've started changing your code from the PR so that we don't need to copy so much c

[GitHub] flink pull request #2344: [hotfix][build] Remove Scala suffix from Hadoop1 s...

2016-08-09 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/2344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2344: [hotfix][build] Remove Scala suffix from Hadoop1 shading ...

2016-08-09 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2344 True. Thank you, I'll close this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] flink issue #2231: [FLINK-4035] Bump Kafka producer in Kafka sink to Kafka 0...

2016-08-09 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2231 Sorry for joining this discussion late. I've been on vacation. I also stumbled across the code duplicates. I'll check out the code from this pull request and see if there's a

[GitHub] flink pull request #2344: [hotfix][build] Remove Scala suffix from Hadoop1 s...

2016-08-09 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/2344 [hotfix][build] Remove Scala suffix from Hadoop1 shading project It seems that the hadoop1 shaded artifact has a scala suffix, which is not needed anymore. You can merge this pull request into a

[GitHub] flink issue #2338: [FLINK-4316] [core] [hadoop compatibility] Make flink-cor...

2016-08-09 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2338 +1 to merge, once the failing tests are fixed. I think the exception to the API stability check is okay in this case. The class is still in the same java package. This are the test

[GitHub] flink issue #2261: [FLINK-4226] Typo: Define Keys using Field Expressions ex...

2016-08-08 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2261 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2261: [FLINK-4226] Typo: Define Keys using Field Expressions ex...

2016-08-08 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2261 @ASRagab: Could you close the pull request? I can not close the PR from the Github interface and I forgot to include the magic string to close it from the commit message. --- If your project is

[GitHub] flink issue #2261: [FLINK-4226] Typo: Define Keys using Field Expressions ex...

2016-08-08 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2261 merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-15 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2236 I'm merging the change ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] flink pull request #2255: [FLINK-4142][docs] Add warning about YARN HA bug

2016-07-15 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/2255 [FLINK-4142][docs] Add warning about YARN HA bug There is a bug in YARN 2.4.0 preventing container starts from a re-started application master. This is how the updated documentation

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2236 I fixed the failing build and addressed all comments so far ;) (I was working on the code while you've reviewed it ) --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-14 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70827977 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-07-14 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r70800080 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/AvroSerializationSchemaTest.java

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-07-14 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r7082 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/AvroSerializationSchemaTest.java

[GitHub] flink issue #2242: [FLINK-4214] ExceptionHandler keep count of exceptions

2016-07-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2242 Thank you for opening a pull request for this. +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #2228: [FLINK-4170][kinesis-connector] Simplify Kinesis connecte...

2016-07-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2228 Thank you for rebasing again. I'm merging the change ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2236 Thank you for the review @zentol. I addressed all your comments and added metrics for committed offsets as well (I talked to the user who requested this feature and they requested this

[GitHub] flink issue #2247: FLINK-4216

2016-07-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2247 There is already a fix for the issue in this pull request: https://github.com/apache/flink/pull/2246 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-14 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70780347 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/MockRuntimeContext.java

[GitHub] flink issue #2246: [hotfix] [doc] fixed example

2016-07-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2246 Is it the stackoverflow question? +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2237: [FLINK-4206][metrics] Remove alphanumeric name restrictio...

2016-07-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2237 Okay, I see. Then I'm going to merge the change now ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] flink issue #2237: [FLINK-4206][metrics] Remove alphanumeric name restrictio...

2016-07-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2237 I stumbled across this and I found the limitation quite annoying, so if there are no good reasons for the check, I agree to remove it. Since @StephanEwen wrote this, it might be good if he could

[GitHub] flink issue #2234: [hotfix][kinesis-connector] Remove duplicate info in Kine...

2016-07-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2234 Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2236 This will simplify this PR: https://issues.apache.org/jira/browse/FLINK-4206 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-13 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/2236 [FLINK-4186] Use Flink metrics to report Kafka metrics We were using Flink's accumulators in the past to report the Kafka metrics. With this change, we'll use the new metric

[GitHub] flink issue #2228: [FLINK-4170][kinesis-connector] Simplify Kinesis connecte...

2016-07-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2228 I think there was an issue with Github and travis: https://www.traviscistatus.com/incidents/t4xn7bmq7fww --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #421: [FLINK-1501] Add metrics library for monitoring TaskManage...

2016-07-13 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/421 @sumitchawla: These charts have been removed from the TaskManager view due to licensing issues. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #2227: [FLINK-4197] Allow Kinesis endpoint to be overridden via ...

2016-07-12 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2227 Looks good to merge. Waiting for the tests to pass, then merging (probably tomorrow). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request #2227: [FLINK-4197] Allow Kinesis endpoint to be overridd...

2016-07-12 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2227#discussion_r70478621 --- Diff: docs/apis/streaming/connectors/kinesis.md --- @@ -299,3 +299,43 @@ Otherwise, the returned stream name is used. Other optional configuration

[GitHub] flink pull request #2227: [FLINK-4197] Allow Kinesis endpoint to be overridd...

2016-07-12 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2227#discussion_r70477574 --- Diff: docs/apis/streaming/connectors/kinesis.md --- @@ -299,3 +299,43 @@ Otherwise, the returned stream name is used. Other optional configuration

[GitHub] flink issue #2230: [FLINK-4200] [Kafka Connector] Kafka consumers logs the o...

2016-07-12 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2230 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink pull request #2229: [hotfix][docs] Add note about Kinesis producer lim...

2016-07-12 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2229#discussion_r70423762 --- Diff: docs/apis/streaming/connectors/kinesis.md --- @@ -240,8 +239,9 @@ consumer when calling this API can also be modified by using the other keys pref

[GitHub] flink pull request #2229: [hotfix][docs] Add note about Kinesis producer lim...

2016-07-12 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/2229 [hotfix][docs] Add note about Kinesis producer limitations While testing the Kinesis connector @uce and I found out that data is not written in-order with the Kinesis producer. I'

[GitHub] flink issue #2071: [FLINK-4018][streaming-connectors] Configurable idle time...

2016-07-12 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2071 Sry, I forgot to merge it. Will do now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #2225: [FLINK-4191] Expose shard information in kinesis deserial...

2016-07-11 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2225 I fixed the remaining comments. I'll merge the changes tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #2225: [FLINK-4191] Expose shard information in kinesis d...

2016-07-11 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2225#discussion_r70327009 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java

[GitHub] flink issue #2225: [FLINK-4191] Expose shard information in kinesis deserial...

2016-07-11 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2225 I added the javadoc and did some other changes: - Commented out the `isEndOfStream()` method, because its not respected. - Re-ordered the arguments of the deser schema. The first group is

[GitHub] flink pull request #2225: [FLINK-4191] Expose shard information in kinesis d...

2016-07-11 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/2225 [FLINK-4191] Expose shard information in kinesis deserialization schema @tzulitai please review the change. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink issue #2206: [FLINK-4157] Catch Kafka metrics serialization exceptions

2016-07-11 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2206 Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-07-11 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2177 All the container* config keys are now renamed to `containerized.`, so we have `yarn.` and `containerized.` as prefixes. But these config keys will be undocumented for now. In the documentation

[GitHub] flink issue #2209: [FLINK-4111] [table] Flink Table & SQL doesn't work in ve...

2016-07-11 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2209 I think the change is good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

<    1   2   3   4   5   6   7   8   9   10   >