Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3901
I'm currently waiting for a Travis run locally for
https://github.com/tzulitai/flink/tree/FLINK-6288.
That branch also includes more tests and tweak cleanups for the feature.
Once
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3901
I think you've made a good point Gyula.
Alright, let me try to stretch a bit and merge this for 1.3.0 also.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3928
Thanks for the reviews @sunjincheng121 @EronWright.
I personally prefer to stick with the regex approach. But really either way
is fine :)
Don't really expect any test errors
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3928#discussion_r117205738
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityUtils.java
---
@@ -230,10 +230,15 @@ private void validate
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3901
@zjureel I'll be merging this only for 1.4-SNAPSHOT. The main reason is
that there is a lot of deprecation / API change with this, and I'll like to
ship it along with other API changes we had
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3854
Looks good to me, minus one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3854#discussion_r117198127
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointFrom11MigrationITCase.java
---
@@ -129,7 +129,7
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3746
Hi @haohui, I revisited this, but I think there is no easy workaround for
this, unfortunately.
This can only be properly merged in 1.4 after some additional requirements
are added to Flink
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3901
This looks good! I'll do some final tweaks to the styling of the code and
then merge this :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r117175607
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer09.java
---
@@ -171,6
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r117175760
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -311,12
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r117175199
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer08.java
---
@@ -187,31
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3937
[FLINK-6482] [core] Add nested serializers to config snapshots of composite
serializers
This commit adds also the nested serializers themselves to the
configuration snapshots of composite
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3915
@zjureel For Kafka 0.11, I would expect it to just extend
`FlinkKafkaConsumer010`.
As you can see, that is also the case right now for 010; its extending
`FlinkKafkaConsumer09` and not the base
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3928#discussion_r117009648
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityUtils.java
---
@@ -230,10 +231,21 @@ private void validate
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3928#discussion_r117003024
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityUtils.java
---
@@ -230,10 +231,21 @@ private void validate
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3925
Thanks for the review @StefanRRichter!
I'll add the reminder comment and then merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3912
If the only case we currently know of right now is in the Table API with 1
additional element to be added, then I think this is good for now.
I think the improvement should be bounded
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3912
Share the same question as Stefan. Otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3928
[FLINK-6608] [security, config] Relax Kerberos login contexts parsing
This PR allows whitespaces in the list of configured Kerberos login
contexts.
It generally covers some over scenarios
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3746
@haohui I can not guarantee this, but I can try revisiting this for a
workaround after I've done some testing on the current RC1.
---
If your project is set up for it, you can reply to this email
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3925
[FLINK-6600] Add key serializer config snapshot to keyed backend checkpoints
This PR adds the config snapshot of the key serializer of keyed
backends to its checkpoints. This allows
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3915
Also, it seems like 0.8 does support a timestamp-based offset retrieval.
See the "finding start offsets for reads" in
https://cwiki.apache.org/confluence/display/KAFKA/0.8.0+SimpleConsum
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r116674594
--- Diff: flink-connectors/flink-connector-kafka-0.10/pom.xml ---
@@ -53,6 +53,10 @@ under the License
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r116676798
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -290,10
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r116675159
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -290,10
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r116674925
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer09.java
---
@@ -181,12
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r116675083
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -290,10
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r116675211
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -290,10
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r116674541
--- Diff: flink-connectors/flink-connector-kafka-0.10/pom.xml ---
@@ -37,7 +37,7 @@ under the License.
- 0.10.0.1
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3911#discussion_r116659661
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/Kafka010Example.java
---
@@ -17,49 +17,74
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3911#discussion_r116659749
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/Kafka010Example.java
---
@@ -17,49 +17,74
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3911#discussion_r116659709
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/Kafka010Example.java
---
@@ -17,49 +17,74
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3911#discussion_r116659435
--- Diff: .test-infa/end-to-end-test/test_streaming_kafka010.sh ---
@@ -0,0 +1,102 @@
+#!/usr/bin/env bash
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3911#discussion_r116659967
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/WriteIntoKafka.java
---
@@ -1,75 +0,0
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3901
@zjureel then I would suggest to remove the usage of ExecutorService for
the timeout. In what other cases would that be required?
---
If your project is set up for it, you can reply to this email
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3901
@zjureel my main concern is the need of our own timeout when Kafka has the
`max.block.ms` configuration. This seems to be the max timeout you're talking
about?
---
If your project is set up
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3766
@zjureel the rebases don't seem to be done correctly. The PR should contain
the diff commits only.
I'm not sure what went wrong, but perhaps the most easiest way right now is
cherry-pick your
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3766
@zjureel thanks. You would need a proper rebase: `git rebase master` when
you finish your feature branch, instead of merging the latest master.
Regarding timeout: doesn't the Kafka client
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3766
seems like the relevant commits are e6ec702 and 64af26e.
Let me try to resolve this .. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3746
Hi @haohui, unfortunately we might not be able to merge this for 1.3. The
reason is that the feature requires a migration from partitionable list state
to union list state, which currently can
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3746#discussion_r116352819
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -503,23
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3766
@zjureel could you rebase the PR on the latest master? Otherwise I cannot
review the PR like this.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3861
Hi @zjureel, could you rebase your commits for the issue on the latest
master?
Otherwise I cannot review the PR like this.
---
If your project is set up for it, you can reply to this email
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3883
Will address and merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3882
Thanks for the review! Merging to 1.3 / master ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3886
[FLINK-6554] [core] Make CompatibilityResult options more explicitly defined
Previously, if a serializer determines that state migration needs to be
performed but could not provide a fallback
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3883
[FLINK-6566] [core] More restricted interface for
VersionedIOReadableWritable hooks
This PR makes the method hooks for defining compatible
serialization versions
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3882
[FLINK-6565] Fail memory-backed state restores with meaningful message if
previous serializer is unavailable
Currently, without eager state registration, if on restore of memory-backed
states
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3746
@haohui you should be able to the PR now, would be great to hear feedback
on this.
As of now I'm not quite sure whether this will make it into 1.3 though; I
think we'll have to see about
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3766
@fanyon I'll finally have some time to get back to this PR this week
(perhaps over the next 2 days). Thanks a lot for your patience ...
@gyfora I'm personally a +1 to try to get
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3812
Hi, sorry for the late response here @fanyon.
I've left a comment on the umbrella JIRA on how we proceed with this. Could
you take a look? Thanks :-D
---
If your project is set up for it, you
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3750
Hi, sorry for the late response here.
I've left a comment on the umbrella JIRA on how we proceed with this. Could
you take a look? Thanks :-D
---
If your project is set up for it, you can
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3750
Hi, sorry for the late response here.
I've left a comment on the umbrella JIRA on how we proceed with this. Could
you take a look? Thanks :-D
---
If your project is set up for it, you can
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3834
Thanks a lot @StefanRRichter for the review, especially on the weekends :)
I'll proceed to merge this after addressing also the comment on the
priority flow between the serialized old
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3834#discussion_r115141585
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializer.java
---
@@ -161,7 +162,93 @@
public abstract int
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3834#discussion_r115141563
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializer.java
---
@@ -161,7 +162,93 @@
public abstract int
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3834#discussion_r115141548
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -1473,22
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3834#discussion_r115141541
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -1473,22
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3001
@tony810430 Thanks for the update!
I've did a final review + test run, this is good to merge.
Merging ..
---
If your project is set up for it, you can reply to this email and have your
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3834
[FLINK-6425] [runtime] Activate serializer upgrades in state backends
This is a follow-up PR that finalizes serializer upgrades, and is based on
#3804 (therefore, only the 2nd and 3rd commits
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3746#discussion_r114803295
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3746
@aljoscha thanks for the review! Yes, the Kafka 0.8 code hasn't been
touched much, and the `KafkaPartitionDiscoverer08` is mainly just a copy of the
previous partition fetching code with only minor
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3746#discussion_r114795536
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3746#discussion_r114793528
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -424,65
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3750
@fanyon yes that's the general idea. The problem is that if we just replace
the old `getSerializableListState` with new access state methods, the new
serializer and old serializer (which just uses
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3750
@zhangminglei I don't think this properly solves the issue. The problem is
that we need a migration path from the Java serialization shortcut, and not
simply replace it. Otherwise we would
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3804
[FLINK-6190] [core] Reconfigurable TypeSerializers
Reconfigurable TypeSerializers is the first step towards allowing
serializer upgrades. The second step, activating serializer upgrades
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3794
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3766
One thing to be careful with, though:
Since now we're querying Kafka for partition metadata within the `invoke`
method, the query must be handled robustly and make sure it doesn't result
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3766
Nice following the discussions here :) Let me wrap up the discussion so far:
The old way -
```
interface KafkaPartitioner {
void open(int[] partitions, int subtaskIndex, int
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3766
Thanks for the PR @fanyon. I'll try to look at the changes soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3759
This change isn't necessary, as the previous implementation was a
"try-with-resources" statement (see
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResource
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802060
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802220
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802168
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112801654
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -91,6
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802072
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802181
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802258
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802121
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802386
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerMigrationTest.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802344
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802078
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3746
@haohui FYI - tagging you as we discussed about this feature offline
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3746
[FLINK-4022] [kafka] Partition and topic discovery for FlinkKafkaConsumer
This PR adds the required internals to allow partition and topic regex
pattern discovery in the `FlinkKafkaConsumer
Github user tzulitai closed the pull request at:
https://github.com/apache/flink/pull/3476
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3476
Closing this PR in a favor of an updated version ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3738
Thanks @zhangminglei. LGTM!
Merging to {{master}} and {{release-1.2}} (will merge a bit later today ;)
) ..
---
If your project is set up for it, you can reply to this email and have your
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3738#discussion_r112302446
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3738
LGTM after Stephan's comment on making `mainThread` variable `volatile` is
addressed.
Could you do that @zhangminglei?
Once updated I'll proceed to merge this, thanks :)
---
If your
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123126
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122515
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123595
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123170
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112121870
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123765
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122128
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122730
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -66,31
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122336
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
1101 - 1200 of 1924 matches
Mail list logo
