Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802078
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802258
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802121
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802181
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3507
[FLINK-6006] [kafka] Always use complete restored state in
FlinkKafkaConsumer
(This PR is the fix of FLINK-6006 for Flink 1.1)
Previously, the Kafka Consumer performs partition list
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3508
R: @aljoscha @StefanRRichter
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3508
[FLINK-5991] [state-backend, streaming] Expose Broadcast Operator State
This PR exposes broadcast operator state through the `CheckpointedFunction`
interface, by adding broadcast state access
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3505
[backport-1.2] [FLINK-6006] [kafka] Always use complete restored state in
FlinkKafkaConsumer
(This PR is the fix of FLINK-6006 for Flink 1.2)
Previously, the Kafka Consumer performs
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3314
@haohui - one suggestion for future contributions for easier reviews:
We usually use follow-up commits that addresses review comments, instead of
force pushing the whole branch. For reviewers
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3314
I've made some final general improvements in
https://github.com/tzulitai/flink/tree/PR-FLINK-3679.
Doing a Travis run before merging:
https://travis-ci.org/tzulitai/flink/builds
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3527
[FLINK-3398] [kafka] Allow disabling offset committing for
FlinkKafkaConsumer
This PR allows users to completely disable offset committing back to Kafka.
The way configuration works
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2687
Thanks for the fast reviews :-) Merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2687#discussion_r105688259
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -558,11
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3517
Thank you for the reviews @rmetzger! I'll proceed to merge this and the
backport PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2687#discussion_r105687880
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -558,11
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3518
Thanks for the reminder :-D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tzulitai closed the pull request at:
https://github.com/apache/flink/pull/3518
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tzulitai closed the pull request at:
https://github.com/apache/flink/pull/3519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3505#discussion_r105860440
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -489,16
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3505#discussion_r105860279
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2687
Rebased on the latest Kafka consumer changes in `master`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3518
[backport-1.2] [FLINK-6025] [core] Add Flink's own JavaSerializer for Kryo
serialization
This is a backport of #3517 for `release-1.2`.
You can merge this pull request into a Git repository
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3519
[backport-1.1] [FLINK-6025] [core] Add Flink's own JavaSerializer for Kryo
serialization
This is a backport of #3518 for `release-1.1`.
You can merge this pull request into a Git repository
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3517
[FLINK-6025] [core] Add Flink's own JavaSerializer for Kryo serialization
(This PR should also be backported for `release-1.1` and `release-1.2`.
Separate PRs are not opened for the backports
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3528
[FLINK-5949] [yarn] Don't check Kerberos credentials for non-Kerberosâ¦
Additionally uses the `UserGroupInformation#getAuthenticationMethod()` to
determine whether `KERBEROS` is used
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3528
Thanks for the review :-)
Failing tests seem to be something instable with Maven.
Merging this to `master` and `release-1.2` ..
---
If your project is set up for it, you can reply
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3505
Merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3507
Doing another Travis run locally before merging just to be safe:
https://travis-ci.org/tzulitai/flink/builds/211031758
---
If your project is set up for it, you can reply to this email and have
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3527
Did a final test run on a Kafka installation, and things worked as expected.
One minor improvement would be to add logs for what exactly the commit mode
is used when it is determined in `open
Github user tzulitai closed the pull request at:
https://github.com/apache/flink/pull/3505
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3476
Seems like some Kafka tests are failing .. looking into it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3314#discussion_r104311996
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3314#discussion_r104312079
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka09FetcherTest.java
---
@@ -419,6
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3476
[FLINK-4022] [kafka] Partition and topic pattern discovery for
FlinkKafkaConsumer
This PR adds partition and topic regex pattern discovery to the
`FlinkKafkaConsumer`.
It doesn't expose
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3314
LGTM, I'll proceed to merge this later today.
One minor problem: the offset state still isn't updated if `record ==
null`. We need to do the checking in the synchronize block in the `emitRecord
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3508
Updated managed operator state docs.
@aljoscha @StefanRRichter could you have a final look at it? If there's no
other problems I'll proceed to merge this. Thanks :)
---
If your project is set
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3508#discussion_r109547924
--- Diff: docs/dev/stream/state.md ---
@@ -233,45 +229,44 @@ val counts: DataStream[(String, Int)] = stream
## Using Managed Operator State
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3001
Thanks a lot for your work on this. I'll try to review this early next week
:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3556
Thanks for the fix, LGTM.
@rmetzger could you proceed to merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3508
Merging after Travis turns green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123126
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122515
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122128
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122730
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -66,31
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122336
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123170
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112121870
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123595
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122018
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123765
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3001
Hi @tony810430,
The exposure for union list state was just merged to master.
Could you rebase this? Once rebased I'll do a full review so that we can
finally work towards merging
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4309
Thanks for the fix. I think this LGTM, +1.
@NicoK could you rebase on the latest master to incorproate the new test
profiles (just to make sure nothing bad is affected by this change, although I
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r130058523
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r130058404
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r130058545
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r130058480
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r130058073
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3669#discussion_r130080485
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/StatefulSequenceSource.java
---
@@ -61,52 +65,89
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3669#discussion_r130081876
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/StatefulSequenceSource.java
---
@@ -61,52 +65,89
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3669#discussion_r130081125
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/StatefulSequenceSource.java
---
@@ -61,52 +65,89
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4187
Merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4414
Merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4387
Merging this now, as the changes were already reviewed when applying them
onto `release-1.3`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4426
LGTM, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4150
Yes, we do shade the `com.amazonaws.*` packages. It was fixed before to
address problems with running the Kinesis connector on older EMR versions. So I
guess that my assumption
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4425#discussion_r130835728
--- Diff: tools/maven/checkstyle.xml ---
@@ -198,7 +198,7 @@ This file is based on the checkstyle file of Apache
Beam
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4328
@zhangminglei there seems to be a checkstyle violation. Please check the
Travis logs.
Other than that this looks good to merge. Will merge after the violation is
fixed.
---
If your project
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4425#discussion_r130827731
--- Diff: tools/maven/checkstyle.xml ---
@@ -198,7 +198,7 @@ This file is based on the checkstyle file of Apache
Beam
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4309
Merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4328#discussion_r130831063
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredOperatorBackendStateMetaInfo.java
---
@@ -175,14 +175,19 @@ public boolean
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4454#discussion_r131060102
--- Diff: docs/dev/testing.md ---
@@ -0,0 +1,102 @@
+---
+title: "Testing"
+nav-parent_id: dev
+na
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4328
LGTM, merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4349
Thanks for the fix!
LGTM, merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4454#discussion_r131059884
--- Diff: docs/dev/testing.md ---
@@ -0,0 +1,102 @@
+---
+title: "Testing"
+nav-parent_id: dev
+na
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4454#discussion_r131059770
--- Diff: docs/dev/testing.md ---
@@ -0,0 +1,102 @@
+---
+title: "Testing"
+nav-parent_id: dev
+na
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4408
Closing this with the github bot now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4466
Nice catch! LGTM, merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4349
One other thing:
For commit messages, they should convey the exact final fix.
So, instead of "Remove unnecessary null check OR add null check", it should
simply state how it is f
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4368
I would also like another look a bit later today. Can merge after that :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4328#discussion_r131068854
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredOperatorBackendStateMetaInfo.java
---
@@ -175,14 +175,19 @@ public boolean
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3899
I think this LGTM. I also prefer this fix over #4269.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4368#discussion_r131070533
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -51,39 +48,52
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4453
LGTM, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4328#discussion_r131107143
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredOperatorBackendStateMetaInfo.java
---
@@ -175,14 +176,19 @@ public boolean
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4328#discussion_r131107573
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredOperatorBackendStateMetaInfo.java
---
@@ -175,14 +176,19 @@ public boolean
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4328#discussion_r131097669
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredOperatorBackendStateMetaInfo.java
---
@@ -175,14 +175,19 @@ public boolean
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4328#discussion_r131107598
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredOperatorBackendStateMetaInfo.java
---
@@ -175,14 +176,19 @@ public boolean
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4368#discussion_r131094983
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -0,0 +1,311
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4368#discussion_r131094488
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -0,0 +1,311
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4368#discussion_r131094885
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -0,0 +1,311
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4368#discussion_r131093086
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -0,0 +1,311
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4368#discussion_r131093966
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -0,0 +1,311
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4368#discussion_r131091039
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -0,0 +1,311
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4368#discussion_r131091549
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -0,0 +1,311
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4328
Thanks! Alright, this looks good now, merging (will address my final own
comment while merging)!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4328#discussion_r131167537
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredOperatorBackendStateMetaInfo.java
---
@@ -175,14 +176,17 @@ public boolean
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4328
Thanks for that @zhangminglei. However, I've already finished testing a
batch of commits with this fix included, and would like to merge that now.
Sometimes I collect a batch of commits and run
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4454
@pnowojski adding a link to `TwoPhaseCommitSinkFunctionTest` might make
sense for testing exactly-once delivery.
There are also often cases where the user, in particular, wants to check
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4480
Hi @zhangminglei, I merged this to `release-1.2`. Could you close the PR,
thanks!
The git bot doesn't close PRs automatically if it's not merged to `master`.
---
If your project is set up
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4522
@bowenli86 thanks for confirming! Merging this also then ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
701 - 800 of 1924 matches
Mail list logo
