Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/6015
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6015
OK, agree, closing this PR~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6016
agree, closing this...
---
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/6016
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5978
@StephanEwen close this or not?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5954
hi @StephanEwen this PR also reviewed by you, yesterday it has a conflicts
with master branch, I have fixed, would you please review it again, thanks.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5773
cc @zentol can you review this?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5798
cc @StefanRRichter
---
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/5970
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5970
@zentol OK, closing after merged~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6041
cc @zentol @tzulitai if you have time, please review this PR, thanks~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5954
@aljoscha @kl0u
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6134
cc @dawidwys
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6129#discussion_r194696659
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/iterative/aggregators/AggregatorsITCase.java
---
@@ -170,12 +162,12 @@ public void
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5954
@tillrohrmann can you merge this?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6129
hi @zentol does this PR look good to you?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6123
@twalthr can you have a look?
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6134#discussion_r193976690
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateFunction.java
---
@@ -25,13 +25,13 @@
* This functionality is only
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6134#discussion_r194001177
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateFunction.java
---
@@ -25,13 +25,13 @@
* This functionality is only
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6134#discussion_r193985722
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateFunction.java
---
@@ -25,13 +25,13 @@
* This functionality is only
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6134
cc @dawidwys refactored code, please review again~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6081
cc @pnowojski please review this, thanks~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5777
cc @zentol this PR takes a long time, can you review this?
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6081#discussion_r195124501
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
---
@@ -806,6 +811,44 @@ public void
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6123
cc @dawidwys can you review this?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6081
@pnowojski test error has fixed~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6165
@zentol the field `vertexCount` and `uniformlyDistributedScore` been
initialized in open function. if `vertexCount` was set to default value (0). I
think `uniformlyDistributedScore` keeps default
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6166
cc @zentol @pnowojski
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6092
@pnowojski @dawidwys can you review this?
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6166
[FLINK-9580] Potentially unclosed ByteBufInputStream in
RestClient##readRawResponse
## What is the purpose of the change
*This pull request fixed potentially stream connection leak
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6165
[FLINK-9577] Divide-by-zero in PageRank
## What is the purpose of the change
*This pull request fixed a divide-by-zero error in PageRank*
## Brief change log
- *Add
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6081
cc @pnowojski does this PR look good to you?
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6175
[FLINK-9585] Logger in ZooKeeperStateHandleStore is public and non-final
## What is the purpose of the change
*This pull request mark Logger in ZooKeeperStateHandleStore as private
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6175
cc @zentol
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6166
cc @pnowojski
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6134
cc @dawidwys is this PR OK for you?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6123
cc @fhueske can you review this PR?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5448
@StephanEwen any opinion about this PR?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6092
cc @zentol @kl0u
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5777
@StefanRRichter , does this PR look good to you?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5448
hi @dawidwys thanks for your review suggestion, I have refactored the PR
code except the `MANAGED_MEMORY_SIZE `. The problem you concerned is exists,
the key is suitable for this PR, and it seems we
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6092
[FLINK-9352] In Standalone checkpoint recover mode many jobs with same
checkpoint interval cause IO pressure
## What is the purpose of the change
*This pull request fixed a problem
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6092#discussion_r191341746
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -1173,9 +1179,10 @@ public void
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6028
cc @kl0u @zentol
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6101
[FLINK-9458] Unable to recover from job failure on YARN with NPE
## What is the purpose of the change
*This pull request fixed a NPE when recover job on YARN*
## Brief change
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6092
cc @tillrohrmann @zentol
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6101
cc @zentol
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6092
cc @tillrohrmann @StephanEwen
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6101
@tillrohrmann OK, closing...
---
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/6101
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5798
cc @tzulitai
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5448
@StephanEwen
for the `taskmanager.memory.segment-size` because of it's default unit is
`byte`, so whether there is a unit or not, the behavior is consistent.
So we just need to handle
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6060
cc @zentol @tillrohrmann
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5448
@StephanEwen for the open question, this PR's implementation has used some
new key and deprecated the old key, such as `jobmanager.heap.mb ->
jobmanager.heap.size` , `taskmanager.heap
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6123
[FLINK-9521] Add shade plugin executions to package table example jar
## What is the purpose of the change
*This pull request add shade plugin executions to package table example jar
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r193277880
--- Diff: docs/_includes/generated/task_manager_configuration.html ---
@@ -84,13 +84,13
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6123
cc @twalthr
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6092
cc @zentol if you have time, can you review this?
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6125
[FLINK-9532] Flink Overview of Jobs Documentation Incorrect
## What is the purpose of the change
*This pull request fixed Flink Overview of Jobs Documentation Incorrect
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6129
cc @zentol please review again, the reason of CI error is other problem
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6081
@pnowojski I've tried but it seams it's hard to do this. The class loader
can not be accessed out of the class. @GJL any suggestion? Or need to test?
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6134
[FLINK-9538] Make KeyedStateFunction an interface
## What is the purpose of the change
*This pull request makes KeyedStateFunction an interface*
## Brief change log
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6134#discussion_r193651829
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateFunction.java
---
@@ -25,13 +25,13 @@
* This functionality is only
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6129
[FLINK-9503] Migrate integration tests for iterative aggregators
## What is the purpose of the change
*This pull request migrate integration tests for iterative aggregators
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6134
cc @dawidwys
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6129#discussion_r193707442
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/iterative/aggregators/AggregatorsITCase.java
---
@@ -170,12 +162,12 @@ public void
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6085
[Flink-9452] Flink 1.5 document version title shows snapshot
## What is the purpose of the change
*This pull request fixed flink 1.5 release document version title*
## Brief
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/6085
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6086
[FLINK-9452] Flink 1.5 document version title shows snapshot
## What is the purpose of the change
*This pull request fixed 1.5 document version title*
## Brief change log
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6060
cc @zentol have a look at this?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5593
hi @tillrohrmann can this PR been merged into master branch, so that we can
close it?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5593
hi @tillrohrmann can this PR been merged into master branch, so that we can
close it?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6086
@zentol I have tried to switch to release-1.5 and fix it, but it seems in
release-1.5 branch, I can not send a PR correctly, the PR will contains many
changes.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6086
ok, closing...
---
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/6086
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5954
@zentol can this be merged?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6086
cc @tillrohrmann @zentol
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6231
[FLINK-9694] Potentially NPE in CompositeTypeSerializerConfigSnapshot
constructor
## What is the purpose of the change
*This pull request fixed a NPE
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6125
@GJL can you review this?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
cc @twalthr and @fhueske
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6123
hi @tillrohrmann I think we should include the table example jar into
Flink's binary distribution just like `batch`, `streaming`, `gelly`, `python`
examples for those people who do not want to try
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6123
OK, yes, this PR really make the binary package size more bigger. Closing
this issue...
---
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/6123
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6092
hi @tillrohrmann can you review this PR? this issue happens in our inner
standalone Flink cluster. When recover many jobs, will cause performance
problem.
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6223#discussion_r199365966
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
@@ -,6 +,53 @@ class
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6234#discussion_r199365531
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -224,23 +226,26 @@ private boolean isFinalState(ComputationState
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6125
cc @kl0u @pnowojski
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197754848
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/MemorySize.java ---
@@ -148,6 +148,27 @@ public static MemorySize parse(String text
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6129
@zentol seems this PR can be merged?
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197736638
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterSpecification.java
---
@@ -67,8 +68,8 @@ public String toString
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5448
cc @dawidwys the third suggestion has finished, the others has supported
before. can you review this?
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6239#discussion_r199664502
--- Diff: jepsen-flink/README.md ---
@@ -0,0 +1,60 @@
+# jepsen.flink
+
+A Clojure project based on the
[Jepsen](https://github.com/jepsen-io
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6219#discussion_r199316517
--- Diff: docs/monitoring/metrics.md ---
@@ -426,7 +426,7 @@ class MyMapper extends RichMapFunction[Long,Long] {
Every metric is assigned
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6229
Hi @satybald thanks for your contribution, based on [Flink's contribution
guide](http://flink.apache.org/how-to-contribute.html) you'd better open an
issue in
[JIRA](https://issues.apache.org/jira
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6204
@xueyumusic looks good from my side~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6206
hi @zsolt-donca I have seen the Travis build error log, the failed reason
is not because of your code. This PR looks good, but if you can add a test for
`isAnonymousClass` method, that would
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6194
+1, there is a conflicting file~ cc @sihuazhou
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5448
cc @dawidwys introduced `MemoryUnit` and refactor `MemorySize`, please
review~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6216
+1
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6200#discussion_r199551693
--- Diff:
flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/streaming/connectors/pulsar/PulsarConsumerSourceTests.java
---
@@ -0,0
101 - 200 of 473 matches
Mail list logo
