Github user yanghua commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5448#discussion_r193277880
  
    --- Diff: docs/_includes/generated/task_manager_configuration.html ---
    @@ -84,13 +84,13 @@
             </tr>
             <tr>
                 <td><h5>taskmanager.memory.segment-size</h5></td>
    -            <td style="word-wrap: break-word;">32768</td>
    -            <td>Size of memory buffers used by the network stack and the 
memory manager (in bytes).</td>
    +            <td style="word-wrap: break-word;">"32768"</td>
    +            <td>Size of memory buffers used by the network stack and the 
memory manager.</td>
             </tr>
             <tr>
                 <td><h5>taskmanager.memory.size</h5></td>
    -            <td style="word-wrap: break-word;">-1</td>
    -            <td>Amount of memory to be allocated by the task manager's 
memory manager (in megabytes). If not set, a relative fraction will be 
allocated.</td>
    +            <td style="word-wrap: break-word;">"-1"</td>
    --- End diff --
    
    currently, every place we use the value of config item 
`taskmanager.memory.size`, will compare with the default value "-1", if yes, 
will not use the parser, so there is no problem now. But I think the suggestion 
from @zentol  is good. What's your opinion? @StephanEwen 


---

Reply via email to