[GitHub] flink issue #4519: [FLINK-7415][Cassandra Connector] Add comments for `Batch...

2017-08-10 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4519 I ran the test class with an exception, I found the cause finally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #4519: [FLINK-7415][Cassandra Connector] Add comments for...

2017-08-10 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4519 [FLINK-7415][Cassandra Connector] Add comments for `BatchExample.java` ## What is the purpose of the change Help beginners follow it with less confusion. ## Brief change log - Add

[GitHub] flink issue #4484: [FLINK-7376][Client] Cleanup options class and test class...

2017-08-07 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4484 Thank you for your reply.@aljoscha I am sorry for my first PR. I think I need to read this [Contributing Code](http://flink.apache.org/contribute-code.html). --- If your project is set up

[GitHub] flink pull request #4490: [FLINK-7382][docs] Fix some broken links in docs

2017-08-07 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4490 [FLINK-7382][docs] Fix some broken links in docs ## What is the purpose of the change Fix some broken links in docs. ## Brief change log ## Verifying this change

[GitHub] flink pull request #4484: Client clean code

2017-08-06 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4484 Client clean code ## What is the purpose of the change Keeping code clean. ## Brief change log - Move the `args` field to the `CommandLineOptions`(parent class

[GitHub] flink pull request #4677: [FLINK-7626] Add some checkpoints metric descripti...

2017-09-15 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4677 [FLINK-7626] Add some checkpoints metric description in docs I export the metrics to the logfile via Slf4jReporter(https://issues.apache.org/jira/browse/FLINK-4831), and found that there are some

[GitHub] flink pull request #4676: [FLINK-7625] Fix typo in metrics part of documents

2017-09-15 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4676 [FLINK-7625] Fix typo in metrics part of documents metric: **Memory.Heap.Used** ==> **Heap.Used** You can merge this pull request into a Git repository by running: $ git pull ht

[GitHub] flink issue #4693: [FLINK-7645][docs] Modify system-metrics part show in the...

2017-09-21 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4693 https://user-images.githubusercontent.com/4133864/30681471-27f33090-9ed8-11e7-9cf8-d5a74fb998f1.png;> ---

[GitHub] flink pull request #4692: [FLINK-7644][build] Drop unnecessary semicolon

2017-09-21 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4692 [FLINK-7644][build] Drop unnecessary semicolon You can merge this pull request into a Git repository by running: $ git pull https://github.com/yew1eb/flink FLINK-7644 Alternatively you can

[GitHub] flink pull request #4693: [FLINK-7645][docs] Modify system-metrics part show...

2017-09-21 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4693 [FLINK-7645][docs] Modify system-metrics part show in the document *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community

[GitHub] flink issue #4663: [FLINK-6549] [DataStream API] Improve error message for t...

2017-09-18 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4663 LGTM ---

[GitHub] flink pull request #4694: [FLINK-7654][RabbitMQ Connector] Update RabbitMQ J...

2017-09-21 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4694 [FLINK-7654][RabbitMQ Connector] Update RabbitMQ Java client to 4.2.0 ## What is the purpose of the change RabbitMQ Java Client: Starting with 4.0, this client releases are independent

[GitHub] flink pull request #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher...

2017-10-04 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4769 [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher add kafkaMetricGroup ## What is the purpose of the change *Fix bug Kafka09Fetcher no judge the useMetrics is true when add

[GitHub] flink pull request #4768: [Flink-7704][flip6] Add JobPlanHandler for new Res...

2017-10-04 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4768 [Flink-7704][flip6] Add JobPlanHandler for new RestServerEndpoint ## What is the purpose of the change Add `JobPlanHandler` for the new `RestServerEndpoint`. ## Verifying

[GitHub] flink issue #4768: [FLINK-7704][flip6] Add JobPlanHandler for new RestServer...

2017-10-10 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4768 CC @tillrohrmann ---

[GitHub] flink pull request #4753: [FLINK-7741][build][hotfix] Fix NPE when throw new...

2017-10-10 Thread yew1eb
Github user yew1eb closed the pull request at: https://github.com/apache/flink/pull/4753 ---

[GitHub] flink issue #4753: [FLINK-7741][build][hotfix] Fix NPE when throw new SlotNo...

2017-10-10 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4753 ok, I will close this PR. ---

[GitHub] flink pull request #4794: [build][minor] Add missing licenses

2017-10-10 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4794 [build][minor] Add missing licenses You can merge this pull request into a Git repository by running: $ git pull https://github.com/yew1eb/flink add_missing_licenses Alternatively you can

[GitHub] flink issue #4826: [FLINK-7608][metric] Refactoring latency statistics metri...

2017-10-14 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4826 [LatencyStatsJob.java](https://gist.github.com/yew1eb/3329239f866b691364f4d11a7f0a846a) "Source1" and "Source2" Source send a LatencyMarker per 200ms. "Map-1-A&qu

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-14 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4826 [FLINK-7608][metric] Refactoring latency statistics metric A detailed description of this PR, see [#issue FLINK-7608: LatencyGauge change to histogram metric](https://issues.apache.org/jira/browse

[GitHub] flink pull request #4661: [FLINK-4831] Implement a slf4j metric reporter

2017-09-08 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4661 [FLINK-4831] Implement a slf4j metric reporter ## What is the purpose of the change Implement a slf4j metric reporter For debugging. ## Brief change log ## Verifying

[GitHub] flink pull request #4664: [FLINK-7562] Show uploaded-jars descending by uplo...

2017-09-09 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4664 [FLINK-7562] Show uploaded-jars descending by upload time ## What is the purpose of the change Currently, upload the jar package show is unordered in the Apache Flink Web Dashboard page

[GitHub] flink pull request #4619: [FLINK-7559] Typo in flink-quickstart pom.xml

2017-08-30 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4619 [FLINK-7559] Typo in flink-quickstart pom.xml just fix typo. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yew1eb/flink FLINK-7559

[GitHub] flink issue #4619: [FLINK-7559] Typo in flink-quickstart pom.xml

2017-08-30 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4619 Hi @zentol, thanks for your review. I have updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #4575: [FLINK-7494][travis] Add license headers to '.travis.yml'...

2017-09-06 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4575 CC @zentol ---

[GitHub] flink issue #4614: [FLINK-7547] AsyncFunction.scala extends Function, serial...

2017-09-06 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4614 CC @zentol ---

[GitHub] flink issue #4570: [FLINK-7438][DataStream API]Remove useless import, avoid ...

2017-09-06 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4570 CC @zentol ---

[GitHub] flink pull request #4575: [FLINK-7494][travis] Add license headers to '.trav...

2017-09-06 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/4575#discussion_r137297560 --- Diff: .travis.yml --- @@ -1,4 +1,19 @@ -# s3 deployment based on http://about.travis-ci.org/blog/2012-12-18-travis-artifacts/ --- End diff

[GitHub] flink issue #4299: [FLINK-7155] [metrics] Add Influxdb reporter

2017-09-12 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4299 Hi @patricklucas , Coding guidelines “No WIP pull requests.” Maybe you should see: http://flink.apache.org/contribute-code.html BTW, If you do not have free time to finish it, I

[GitHub] flink issue #4666: [FLINK-7613][Documentation] Fixed typographical error

2017-09-12 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4666 LGTM ---

[GitHub] flink pull request #4718: [FLINK-3832][build] POM Cleanup flink-streaming-sc...

2017-09-24 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4718 [FLINK-3832][build] POM Cleanup flink-streaming-scala ## What is the purpose of the change This PR changes the flink-streaming-scala pom to - not contain unused dependencies

[GitHub] flink pull request #4716: [FLINK-3833][build] POM Cleanup flink-test-utils

2017-09-24 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4716 [FLINK-3833][build] POM Cleanup flink-test-utils ## What is the purpose of the change This PR changes the flink-test-utils pom to - not contain unused dependencies - contain all used

[GitHub] flink pull request #4719: [FLINK-3829][build] POM Cleanup flink-java

2017-09-24 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4719 [FLINK-3829][build] POM Cleanup flink-java ## What is the purpose of the change This PR changes the flink-java pom to - not contain unused dependencies - contain all used

[GitHub] flink pull request #4712: fix flink-clients undeclared/unused dependencies

2017-09-24 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4712 fix flink-clients undeclared/unused dependencies ## What is the purpose of the change This PR changes the flink-clients pom to - not contain unused dependencies - contain all used

[GitHub] flink pull request #4717: [FLINK-3831][build] POM Cleanup flink-streaming-ja...

2017-09-24 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4717 [FLINK-3831][build] POM Cleanup flink-streaming-java ## What is the purpose of the change This PR changes the flink-streaming-java pom to - not contain unused dependencies - contain

[GitHub] flink pull request #4713: [FLINK-3828][build] POM Cleanup flink-runtime

2017-09-24 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4713 [FLINK-3828][build] POM Cleanup flink-runtime ## What is the purpose of the change This PR changes the flink-runtime pom to not contain unused dependencies contain all used

[GitHub] flink pull request #4714: [FLINK-7577][build] POM Cleanup flink-core

2017-09-24 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4714 [FLINK-7577][build] POM Cleanup flink-core ## What is the purpose of the change This PR changes the flink-core pom to - not contain unused dependencies - contain all used

[GitHub] flink pull request #4715: [FLINK-3830][build] POM Cleanup flink-scala

2017-09-24 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4715 [FLINK-3830][build] POM Cleanup flink-scala ## What is the purpose of the change This PR changes the flink-scala pom to - not contain unused dependencies - contain all used

[GitHub] flink issue #4694: [FLINK-7654][RabbitMQ Connector] Update RabbitMQ Java cli...

2017-09-25 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4694 Hey @tzulitai, The 4.2.0 version does not bring any other dependencies, we can safely upgrade. ``` [INFO] | +- org.apache.flink:flink-shaded-guava:jar:18.0-1.0:provided [INFO

[GitHub] flink issue #4570: [FLINK-7438][build]Remove useless import, avoid warnings

2017-09-26 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4570 can someone review this please? :) ---

[GitHub] flink pull request #4570: [FLINK-7438][build]Remove useless import, avoid wa...

2017-09-26 Thread yew1eb
GitHub user yew1eb reopened a pull request: https://github.com/apache/flink/pull/4570 [FLINK-7438][build]Remove useless import, avoid warnings ## What is the purpose of the change Avoid warnings,details: [ISSUE #FLINK-7438](https://issues.apache.org/jira/browse/FLINK-7438

[GitHub] flink pull request #4570: [FLINK-7438][build]Remove useless import, avoid wa...

2017-09-26 Thread yew1eb
Github user yew1eb closed the pull request at: https://github.com/apache/flink/pull/4570 ---

[GitHub] flink issue #4614: [FLINK-7547][build] AsyncFunction.scala extends Function,...

2017-09-26 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4614 can someone review this please? :) ---

[GitHub] flink pull request #4614: [FLINK-7547][build] AsyncFunction.scala extends Fu...

2017-09-28 Thread yew1eb
Github user yew1eb closed the pull request at: https://github.com/apache/flink/pull/4614 ---

[GitHub] flink issue #4614: [FLINK-7547][build] AsyncFunction.scala extends Function,...

2017-09-28 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4614 :ok_hand: ---

[GitHub] flink issue #4694: [FLINK-7654][RabbitMQ Connector] Update RabbitMQ Java cli...

2017-09-26 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4694 CC @tzulitai ---

[GitHub] flink issue #4737: [FLINK-7695] [flip6] Add JobConfigHandler for new RestSer...

2017-09-29 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4737 Hey @tillrohrmann, Will you merge this PR ? I want to fix sibling issues (FLINK-7704, FLINK-7705, FLINK-7706). :beers: Best, Hai Zhou ---

[GitHub] flink issue #4535: [FLINK-7474] [ Streaming Connectors] AzureEventhubs-conne...

2017-09-30 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4535 Hi @zhuganghuaonnet , you should drop others commits and squash your commits. :beers: ---

[GitHub] flink pull request #4753: [FLINK-7741][build] Fix NPE when throw new SlotNot...

2017-09-30 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4753 [FLINK-7741][build] Fix NPE when throw new SlotNotFoundException if taskSlot is null then **throw new SlotNotFoundException(taskSlot.getAllocationId());** will have NPE. the code segment

[GitHub] flink pull request #4754: [FLINK-7742] Fix array access might be out of boun...

2017-09-30 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4754 [FLINK-7742] Fix array access might be out of bounds org.apache.flink.api.java.Utils.java ``` public static String getCallLocationName(int depth) { StackTraceElement

[GitHub] flink issue #4737: [FLINK-7695] [flip6] Add JobConfigHandler for new RestSer...

2017-09-28 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4737 LGTM. ---

[GitHub] flink issue #4570: [FLINK-7438][build]Remove useless import, avoid warnings

2017-09-28 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4570 @zentol thank you very much!. :beers: ---

[GitHub] flink issue #4661: [FLINK-4831][metrics] Implement a slf4j metric reporter

2017-09-25 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4661 cc @zentol ---

[GitHub] flink issue #4614: [FLINK-7547][build] AsyncFunction.scala extends Function,...

2017-09-25 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4614 @zentol Let me know what you think about this PR now :) ---

[GitHub] flink issue #4570: [FLINK-7438][build]Remove useless import, avoid warnings

2017-09-25 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4570 @zentol Let me know what you think about this PR now :) ---

[GitHub] flink issue #4694: [FLINK-7654][RabbitMQ Connector] Update RabbitMQ Java cli...

2017-09-25 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4694 @tzulitai, Thank you. I will follow your suggestion. ---

[GitHub] flink issue #4694: [FLINK-7654][RabbitMQ Connector] Update RabbitMQ Java cli...

2017-09-25 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4694 cc @tzulitai ---

[GitHub] flink issue #4664: [FLINK-7562][web] Show uploaded-jars descending by upload...

2017-09-25 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4664 cc @zentol ---

[GitHub] flink issue #4694: [FLINK-7654][RabbitMQ Connector] Update RabbitMQ Java cli...

2017-09-25 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4694 @tzulitai Hi Gordon, can you please take a look at this PR? ---

[GitHub] flink issue #4661: [FLINK-4831][metrics] Implement a slf4j metric reporter

2017-09-25 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4661 @zentol Please let me know if this is good :) ---

[GitHub] flink issue #4693: [FLINK-7645][docs] Modify system-metrics part show in the...

2017-09-25 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4693 @uce Let me know your thoughts on it. :) ---

[GitHub] flink pull request #4575: [FLINK-7494][travis] Add license headers to '.trav...

2017-08-23 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4575 [FLINK-7494][travis] Add license headers to '.travis.yml' file Just add license headers to '.travis.yml' file. :smile: You can merge this pull request into a Git repository by running

[GitHub] flink pull request #4570: [FLINK-7438][DataStream API]Remove useless import,...

2017-08-21 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4570 [FLINK-7438][DataStream API]Remove useless import, avoid warnings ## What is the purpose of the change Avoid warnings,details: [ISSUE #FLINK-7438](https://issues.apache.org/jira/browse/FLINK

[GitHub] flink pull request #4484: [FLINK-7376][Client] Cleanup options class and tes...

2017-08-31 Thread yew1eb
Github user yew1eb closed the pull request at: https://github.com/apache/flink/pull/4484 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #4614: [FLINK-7547] AsyncFunction.scala extends Function, serial...

2017-08-31 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4614 Hi @twalthr @zentol, Please helps to review, Thank you very much. :beers: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #4575: [FLINK-7494][travis] Add license headers to '.travis.yml'...

2017-08-31 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4575 Hi @twalthr @zentol, Please helps to review, Thank you very much. :beers: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #4570: [FLINK-7438][DataStream API]Remove useless import, avoid ...

2017-08-31 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4570 Hi @twalthr @zentol, Please helps to review, Thank you very much. :beers: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #4575: [FLINK-7494][travis] Add license headers to '.travis.yml'...

2017-09-01 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4575 CC @aljoscha :satisfied: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #4570: [FLINK-7438][DataStream API]Remove useless import, avoid ...

2017-09-01 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4570 CC @aljoscha :satisfied: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #4614: [FLINK-7547] AsyncFunction.scala extends Function, serial...

2017-09-01 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4614 CC @aljoscha :satisfied: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #4614: [FLINK-7547] AsyncFunction.scala extends Function,...

2017-08-29 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4614 [FLINK-7547] AsyncFunction.scala extends Function, serialized fix [#issue FLINK-7547](https://issues.apache.org/jira/browse/FLINK-7547) details

[GitHub] flink issue #4826: [FLINK-7608][metric] Refactoring latency statistics metri...

2017-10-18 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4826 @zentol , Thanks a lot for your review. I had updated the PR according to your comments. ---

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-18 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145370731 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogram.java --- @@ -0,0 +1,51 @@ +/* + * Licensed

[GitHub] flink pull request #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher...

2017-10-17 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/4769#discussion_r143331183 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java --- @@ -543,6

[GitHub] flink issue #4794: [build][minor] Add missing licenses

2017-10-17 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4794 @StephanEwen, I see, we need a script to automatically check the headers licenses. I will think about how to implement this script... ---

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145293354 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogramStatistics.java --- @@ -0,0 +1,71

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145295629 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogram.java --- @@ -0,0 +1,51 @@ +/* + * Licensed

[GitHub] flink issue #4661: [FLINK-4831][metrics] Implement a slf4j metric reporter

2017-10-17 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4661 CC @zentol ---

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145293108 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogram.java --- @@ -0,0 +1,51 @@ +/* + * Licensed

[GitHub] flink pull request #4826: [FLINK-7608][metric] Refactoring latency statistic...

2017-10-17 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/4826#discussion_r145294253 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/latency/LatencyHistogramStatistics.java --- @@ -0,0 +1,71

[GitHub] flink pull request #4885: [hotfix][docs] Fix typos in documentation

2017-10-23 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4885 [hotfix][docs] Fix typos in documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/yew1eb/flink fix_typos_in_project_setup_docs

[GitHub] flink pull request #4714: [FLINK-7577][build][WIP] POM Cleanup flink-core

2017-10-22 Thread yew1eb
Github user yew1eb closed the pull request at: https://github.com/apache/flink/pull/4714 ---

[GitHub] flink pull request #4714: [FLINK-7577][build][WIP] POM Cleanup flink-core

2017-10-22 Thread yew1eb
GitHub user yew1eb reopened a pull request: https://github.com/apache/flink/pull/4714 [FLINK-7577][build][WIP] POM Cleanup flink-core ## What is the purpose of the change This PR changes the flink-core pom to - not contain unused dependencies - contain all used

[GitHub] flink issue #4875: [FLINK-7889] Enable dependency convergence in flink-strea...

2017-10-22 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4875 @pnowojski, I found to fix this PR, must first solve the `flink-core`, `flink-runtime`, and so on. Please ignore this PR, I will close it. Please feel free to continue working on **Enable

[GitHub] flink pull request #5071: [FLINK-7907][docs] The metrics documentation missi...

2017-11-26 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/5071 [FLINK-7907][docs] The metrics documentation missing scala snippets ## What is the purpose of the change *The metrics documentation is missing Scala examples for many of the metrics types

[GitHub] flink pull request #5072: [FLINK-7984][build] Bump snappy-java to 1.1.4

2017-11-26 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/5072 [FLINK-7984][build] Bump snappy-java to 1.1.4 ## What is the purpose of the change This PR bumps the snappy-java version to 1.1.14. snappy-java-1.1.4 (2017-05-22): - Fix a 1

[GitHub] flink pull request #4712: [FLINK-7574][build] POM Cleanup flink-clients

2017-11-22 Thread yew1eb
Github user yew1eb closed the pull request at: https://github.com/apache/flink/pull/4712 ---

[GitHub] flink issue #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-11-29 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5076 Hi @greghogan, You're quite right, Thanks for your advice. For a discussion of this improvement, you can see #4712. ---

[GitHub] flink issue #5069: [FLINK-8149][kinesis] Replace usages of deprecated Serial...

2017-11-29 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5069 @tzulitai, thanks for your review. I have updated the PR according to your comments. ---

[GitHub] flink pull request #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-11-29 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/5076#discussion_r153858786 --- Diff: pom.xml --- @@ -891,6 +905,41 @@ under the License

[GitHub] flink pull request #5069: [FLINK-8149][kinesis] Replace usages of deprecated...

2017-11-29 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/5069#discussion_r153841399 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@ -41,7 +42,6

[GitHub] flink issue #5071: [FLINK-7907][docs] The metrics documentation missing scal...

2017-11-29 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5071 @zentol , thanks for your review. I have updated the PR according to your comments. ---

[GitHub] flink pull request #5071: [FLINK-7907][docs] The metrics documentation missi...

2017-11-30 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/5071#discussion_r154031899 --- Diff: docs/monitoring/metrics.md --- @@ -94,8 +94,8 @@ Alternatively you can also use your own `Counter` implementation: {% highlight java

[GitHub] flink issue #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-11-27 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5076 `mvn clean verify -pl flink-clients`, No dependency problems found. > [INFO] --- maven-dependency-plugin:3.0.2:analyze-only (analyze) @ flink-clients_2.11 --- > [INFO] No depe

[GitHub] flink pull request #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-11-26 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/5076 [FLINK-7574][build] POM Cleanup flink-clients Re-created #4712. ## What is the purpose of the change This PR changes the `flink-clients` pom to - contain unused

[GitHub] flink pull request #5067: [FLINK-8142][config] Cleanup reference to deprecat...

2017-11-24 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/5067 [FLINK-8142][config] Cleanup reference to deprecated constants in ConfigConstants ## What is the purpose of the change ConfigConstants contains several deprecated String constants

[GitHub] flink pull request #5069: [FLINK-8149][kinesis] Replace usages of deprecated...

2017-11-25 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/5069 [FLINK-8149][kinesis] Replace usages of deprecated SerializationSchema ## What is the purpose of the change The deprecated `SerializationSchema` in `flink-streaming-java`, has been moved

[GitHub] flink issue #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-12-04 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5076 @zentol thanks for your review. I have updated the PR. `mvn clean verify -Dverbose -pl flink-clients`,No dependency problems found: ``` [INFO] --- maven-dependency-plugin

[GitHub] flink issue #5113: [FLINK-8156][build] Bump commons-beanutils version to 1.9...

2017-12-17 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5113 Thanks @StephanEwen for the suggestion. I will update the PR accordingly. ---

[GitHub] flink issue #5001: [FLINK-7679][build][java9] Upgrade maven enforcer plugin ...

2017-11-16 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5001 :wink: @zentol , Thank you for your careful review. This PR has been updated. ---

  1   2   >