Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/3494
Great, thanks @uce , I will take rebase an push the fix for FLINK-6003
(#3500) now.
I will put you as a reviewer for this one.
---
If your project is set up for it, you can reply to this email
Github user iemejia closed the pull request at:
https://github.com/apache/flink/pull/3500
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/3500
Hey I probably should be more patient, I will wait until #3494 is merged
and rebase from it. So closing for the moment.
---
If your project is set up for it, you can reply to this email and have
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/3500
Sorry @greghogan to put you here as a reviewer but you are the only
committer that I know who can take a look, if you think somebody else can do it
please refer him.
---
If your project is set up
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/3494#discussion_r105171748
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin
EXPOSE 8081
EXPOSE 6123
+# flink
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/3494#discussion_r105171729
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin
EXPOSE 8081
EXPOSE 6123
+# flink
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/3500
R: @greghogan
cc: @jgrier @patricklucas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user iemejia opened a pull request:
https://github.com/apache/flink/pull/3500
[FLINK-6003] Add docker image based on the openjdk one (debian+alpine)
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user iemejia closed the pull request at:
https://github.com/apache/flink/pull/3493
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/3493
I am closing this to create a new one based on the new JIRA
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/3494#discussion_r104984654
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin
EXPOSE 8081
EXPOSE 6123
+# flink
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/3493
I oups not the ubuntu, the non-alpine one :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/3493
I will, and add the commits for the ubuntu image, probably I will create a
JIRA for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/3494#discussion_r104980420
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin
EXPOSE 8081
EXPOSE 6123
+# flink
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/3494#discussion_r104919360
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin
EXPOSE 8081
EXPOSE 6123
+# flink
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/3494#discussion_r104907373
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin
EXPOSE 8081
EXPOSE 6123
+# flink
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/3493
Yes, maybe I was not clear enough, my goal is to support the two variants
of openjdk that you mention.
I was just mentioning ubuntu/debian because this is the base of the
non-alpine base
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/3493
Cool ! Just ping me when you are done and I will rebase to finish the clean
ups, I am going to start contacting the docker people to see what else do we
need and continue to work in the ubuntu
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/3493
R: @greghogan
cc: @jgrier @patricklucas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/3204
@greghogan Definitely a misunderstanding, I had the impression you just
didn't like my solution, so I didn't continue pushing for it (even if we
finished with similar ideas).
For ref
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
@jagatfx Yes, this is still in my TODO list, I have not had a lot of time
to follow the process to make an image official, but I hope I will in the next
days.
---
If your project is set up
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
And remember that my ultimate goal is not to host that image but that we
can convert it into an official one.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
Of course, who do you think I am :P
You can check a ready to run build here in case you don't want to test that
one. But it is true that we need some kind of automatized tests for the image
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
@mxm this should be ready now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74261518
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
We should maybe wait for 1.1.1 to be up before doing this merge, I will add
the commit for this and probably rebase everything once it is ready. Is it ok ?
---
If your project is set up for it, you
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74259291
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74243197
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
I added two additional changes, an extra security fix (default user is not
root now) and I changed the path to the more appropriate /opt.
Now this should be ready for review/merge.
---
If your
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
(notice than when I said need to improve I refer at the missing automation
to change the default release version on the Dockerfile).
---
If your project is set up for it, you can reply
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2340
I referred to the older FLINK issue since this is something we need to
still improve. I can try to fix it in a subsequent PR, do you have any hints of
how can we achieve this ?
R: @aljoscha
GitHub user iemejia opened a pull request:
https://github.com/apache/flink/pull/2340
[FLINK-3155] Update docker flink container to the latest release
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
Ok, I will check how is the procedure and I will tell you if we need
something else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
About the flink image version, we can support multiple versions via tags,
those are pulled with the: separator, e.g. docker pull
flink:1.0.3-hadoop26-scala_2.10
And we can agree on a default
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
Great, closing now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user iemejia closed the pull request at:
https://github.com/apache/flink/pull/2240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
One last thing, are you interested on getting the flink image into becoming
an official docker image ? I took a look around it and it seems we can ask for
this.
The benefit is that users can
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
Yes, it is done, I am really happy of getting rid of python/supervisord in
the image now.
Please merge if you consider it ok.
---
If your project is set up for it, you can reply to this email
Github user iemejia closed the pull request at:
https://github.com/apache/flink/pull/2239
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
I added this last commit to remove the dependency on supervisord, thanks to
@greghogan for the 'wait' idea. Now flink has the thinnest docker image
possible :).
---
If your project is set up
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2239
Thanks Greg, I was probably too tired last night because I put the wait in
a weird place, I just tried now and everything is working, it is still not
'real' foreground, since Ctrl-C gets captured
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2239
I tried not to change the current daemon behavior, that's the reason why I
took
the decision to add an additional option. I am not sure if using wait may
work for what I want but if it does
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/2239#discussion_r70873347
--- Diff: flink-dist/src/main/flink-bin/bin/flink-daemon.sh ---
@@ -77,31 +77,36 @@ if [[ ${JAVA_VERSION} =~ ${IS_NUMBER} ]]; then
fi
case
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2239
Hi, Yes, this is exactly the situation, in a previous pull request I was
optimizing the flink docker image, however I found that the image used
supervisord to catch and keep alive those daemons, so
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2239
I hope this gets into 1.1.0 so I can push the changes to the docker image
once this is available in the official binary distribution.
---
If your project is set up for it, you can reply
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2239
@aljoscha As discussed in FLINK-4118 I am doing this to support this use
case and eventually remove the dependency on python and supervisord from the
docker image.
---
If your project is set up
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2240
I added some additional fixes for example to exclude build dependencies
from the final image, and to make the docker-compose script simpler.
@aljoscha This is a set of small fixes that I missed
GitHub user iemejia opened a pull request:
https://github.com/apache/flink/pull/2240
[FLINK-4209] Docker image breaks with multiple NICs
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your
GitHub user iemejia opened a pull request:
https://github.com/apache/flink/pull/2239
[FLINK-4208] Support Running Flink processes in foreground mode
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2176
Great, thanks for your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2176
This should be ok now. In further commits I expect to fix the daemon thing
+ maybe add a HA version using zookeeper of the docker-compose file.
One more question aljoscha, I intend to add
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/2176#discussion_r69306327
--- Diff: flink-contrib/docker-flink/README.md ---
@@ -1,80 +1,75 @@
-#Apache Flink cluster deployment on Docker using Docker-Compose
+Apache Flink
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/2176#discussion_r69306386
--- Diff: flink-contrib/docker-flink/README.md ---
@@ -1,80 +1,75 @@
-#Apache Flink cluster deployment on Docker using Docker-Compose
+Apache Flink
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2176
Hi, I tested it with the basic word count and with the beam pipeline
example that @ecesena put for his flink/beam demo.
I don't know if your case is maybe because you are running on docker
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2176
Awasome, thanks @aljoscha, let's merge !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user iemejia commented on a diff in the pull request:
https://github.com/apache/flink/pull/2176#discussion_r69150030
--- Diff: flink-contrib/docker-flink/README.md ---
@@ -1,80 +1,75 @@
-#Apache Flink cluster deployment on Docker using Docker-Compose
+Apache Flink
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2176
Nice, I just fixed as you suggested. I have three questions:
1. This container is based on the Java JRE (to keep it small), Does Flink
in any part do some magic that requires a full JDK
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2176
Sorry I had to rebase my previous PR but this is the definitive one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2176
The docker images script was simplified and the image size was reduced.
Previous image:
flink latest 6475add651c7 24 minutes ago 711.6 MB
Image after FLINK-4118
flink latest
GitHub user iemejia opened a pull request:
https://github.com/apache/flink/pull/2176
Flink 4118
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items
Github user iemejia closed the pull request at:
https://github.com/apache/flink/pull/2164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2164
The docker images script was simplified and the image size was reduced.
Previous image:
flink latest
6475add651c724 minutes
GitHub user iemejia opened a pull request:
https://github.com/apache/flink/pull/2164
[FLINK-4118] The docker-flink image is outdated (1.0.2) and can be slimmed
down
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
63 matches
Mail list logo
