[GitHub] flink issue #5769: [FLINK-9069] Add checkstyle rule to detect multiple conse...

2018-03-30 Thread jparkie
Github user jparkie commented on the issue: https://github.com/apache/flink/pull/5769 @zentol Bump. Just wondering if this got lost. :) ---

[GitHub] flink pull request #5769: [FLINK-9069] Add checkstyle rule to detect multipl...

2018-03-26 Thread jparkie
GitHub user jparkie opened a pull request: https://github.com/apache/flink/pull/5769 [FLINK-9069] Add checkstyle rule to detect multiple consecutive semicolons ## What is the purpose of the change This pull request introduces a new checkstyle rule that detects multiple

[GitHub] flink pull request #4652: [FLINK-7465][table]Add cardinality count for table...

2017-09-25 Thread jparkie
Github user jparkie commented on a diff in the pull request: https://github.com/apache/flink/pull/4652#discussion_r140833539 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/runtime/functions/aggfunctions/cardinality/HyperLogLog.java --- @@ -0,0 +1,333

[GitHub] flink pull request #4652: [FLINK-7465][table]Add cardinality count for table...

2017-09-25 Thread jparkie
Github user jparkie commented on a diff in the pull request: https://github.com/apache/flink/pull/4652#discussion_r140832701 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/runtime/functions/aggfunctions/cardinality/HyperLogLog.java --- @@ -0,0 +1,333

[GitHub] flink pull request #4652: [FLINK-7465][table]Add cardinality count for table...

2017-09-25 Thread jparkie
Github user jparkie commented on a diff in the pull request: https://github.com/apache/flink/pull/4652#discussion_r140830364 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/runtime/functions/aggfunctions/cardinality/ICardinality.java --- @@ -0,0 +1,80

[GitHub] flink pull request #4652: [FLINK-7465][table]Add cardinality count for table...

2017-09-25 Thread jparkie
Github user jparkie commented on a diff in the pull request: https://github.com/apache/flink/pull/4652#discussion_r140828795 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/runtime/functions/aggfunctions/cardinality/ICardinality.java --- @@ -0,0 +1,80

[GitHub] flink pull request #4652: [FLINK-7465][table]Add cardinality count for table...

2017-09-25 Thread jparkie
Github user jparkie commented on a diff in the pull request: https://github.com/apache/flink/pull/4652#discussion_r140826158 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/runtime/functions/aggfunctions/cardinality/MurmurHash.java --- @@ -0,0 +1,247

[GitHub] flink pull request #4652: [FLINK-7465][table]Add cardinality count for table...

2017-09-25 Thread jparkie
Github user jparkie commented on a diff in the pull request: https://github.com/apache/flink/pull/4652#discussion_r140823213 --- Diff: docs/dev/table/sql.md --- @@ -2020,7 +2020,16 @@ COUNT(*) Returns the number of input rows