[GitHub] flink issue #4838: [FLINK-7826][QS] Add support for all types of state to th...

2017-10-16 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4838 R @aljoscha ---

[GitHub] flink pull request #4838: [FLINK-7826][QS] Add support for all types of stat...

2017-10-16 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4838 [FLINK-7826][QS] Add support for all types of state to the QS Client. ## What is the purpose of the change As the JIRA describes, it makes the queryable state client able to query all types

[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.

2017-10-13 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4821 Merging this. ---

[GitHub] flink pull request #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer...

2017-10-13 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4821 [FLINK-7835][cep] Fix duplicate() in NFASerializer. R @aljoscha You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink cep-nfa-serializer-bug

[GitHub] flink pull request #4814: [FLINK-7788][QS] Allows to specify a range of port...

2017-10-12 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4814 [FLINK-7788][QS] Allows to specify a range of ports for the QS proxy. ## What is the purpose of the change The queryable state client proxy can now take a port range as argument so

[GitHub] flink pull request #4778: [FLINK-7770][FLINK-7769][Queryable State] Refactor...

2017-10-06 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4778 [FLINK-7770][FLINK-7769][Queryable State] Refactor the Queryable State Client. *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help

[GitHub] flink issue #4654: [FLINK-7521] Add config option to set the content length ...

2017-09-07 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4654 Hi @zjureel ! Thanks for the work! This can be a temporary fix, but I was thinking more of a long term one where there is no limit. The problems that I can find with such temporary

[GitHub] flink issue #4646: [FLINK-7583] [REST] Use static constant for CONTENT_TYPE ...

2017-09-06 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4646 I see. Thanks @zentol. So +1 to merge from me. ---

[GitHub] flink pull request #4645: [FLINK-7582] [REST] Netty thread immediately parse...

2017-09-06 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4645#discussion_r137209983 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java --- @@ -77,14 +77,10 @@ private static final ObjectMapper

[GitHub] flink pull request #4645: [FLINK-7582] [REST] Netty thread immediately parse...

2017-09-06 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4645#discussion_r137210136 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java --- @@ -159,24 +155,17 @@ public void shutdown(Time timeout

[GitHub] flink pull request #4644: [FLINK-7581] [REST] Name netty threads

2017-09-06 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4644#discussion_r137198747 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java --- @@ -104,8 +105,8 @@ protected void initChannel(SocketChannel

[GitHub] flink issue #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP function in CE...

2017-08-30 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4331 I think you can merge it @dawidwys . I was following the evolution of this PR and I think it looks good ;) . Thanks for the work both @yestinchen and @dawidwys ! --- If your project is set up

[GitHub] flink issue #4611: [FLINK-7543] [REST] Simplify handler access to path/query...

2017-08-28 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4611 Changes LGTM @zentol ! When Travis gives a green light, feel free to merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink issue #4569: [FLINK-7040] [REST] Add basics for REST communication

2017-08-25 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4569 Thanks a lot @tillrohrmann ! This is a pretty useful API addition. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #4569: [FLINK-7040] [REST] Add basics for REST communicat...

2017-08-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4569#discussion_r134686921 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/HandlerResponse.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache

[GitHub] flink issue #4523: [FLINK-7123] [cep] Support timesOrMore in CEP

2017-08-22 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4523 LGTM, merging this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4523: [FLINK-7123] [cep] Support timesOrMore in CEP

2017-08-17 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4523 @dianfu I will have a look tomorrow! Thanks for the work btw ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #4550: [FLINK-7461] Remove Backwards compatibility with <= Flink...

2017-08-16 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4550 I agree that this is a change that we agreed upon. My only point is that we have to communicate it also in the ML. Probably with a thread that points to this JIRA and the PR and mentions this issue

[GitHub] flink issue #4550: [FLINK-7461] Remove Backwards compatibility with <= Flink...

2017-08-16 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4550 From a brief check, I see that this also removed backwards compatibility also for 1.2 for the CEP library. The reason is that the CEP library in Flink 1.2 was the same as in Flink 1.1 (no upgrade

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132895649 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/AfterMatchSkipStrategy.java --- @@ -0,0 +1,112 @@ +/* + * Licensed

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132898814 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -340,6 +362,65 @@ public void resetNFAChanged

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132896369 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/TimeoutKeyedCEPPatternOperator.java --- @@ -42,20 +43,21 @@ private

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132896183 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -120,13 +121,16

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132895590 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/AfterMatchSkipStrategy.java --- @@ -0,0 +1,112 @@ +/* + * Licensed

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132896299 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/KeyedCEPPatternOperator.java --- @@ -42,28 +43,29 @@ private static

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132894559 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -96,7 +97,8 @@ } else

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132897107 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -158,9 +158,9 @@ private boolean nfaChanged

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132895822 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/AfterMatchSkipStrategy.java --- @@ -0,0 +1,112 @@ +/* + * Licensed

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132896150 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -120,13 +121,16

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132894611 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -117,9 +119,11 @@ private Map

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132895583 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/AfterMatchSkipStrategy.java --- @@ -0,0 +1,112 @@ +/* + * Licensed

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132895143 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -150,6 +160,29 @@ long getWindowTime

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132895280 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -150,6 +160,29 @@ long getWindowTime

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132895639 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/AfterMatchSkipStrategy.java --- @@ -0,0 +1,112 @@ +/* + * Licensed

[GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...

2017-08-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4331#discussion_r132895977 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/AfterMatchSkipStrategy.java --- @@ -0,0 +1,112 @@ +/* + * Licensed

[GitHub] flink issue #4418: [FLINK-7293] [cep] Support custom order by in PatternStre...

2017-08-07 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4418 @dianfu Changes look good. +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #4487: [FLINK-7379] [qs] Remove HighAvailabilityServices ...

2017-08-07 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4487 [FLINK-7379] [qs] Remove HighAvailabilityServices from QS client constructor. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink qs

[GitHub] flink issue #4418: [FLINK-7293] [cep] Support custom order by in PatternStre...

2017-08-04 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4418 Hi @dianfu and @dawidwys. This PR is actually broken. The reason is that the `comparator` in the `AbstractKeyedCEPPatternOperator` is not `serializable` so when Flink tries to ship the job

[GitHub] flink issue #4406: [FLINK-7280] Wrong clearing SharedBuffer of Equal element...

2017-08-01 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4406 @dawidwys The changes look good! I checked with `oneOrMore()` and `zeroOrMore()` to see if we prematurely clean up the state and it seems to be ok. +1 to merge. --- If your project is set up

[GitHub] flink issue #4406: [FLINK-7280] Wrong clearing SharedBuffer of Equal element...

2017-08-01 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4406 @dawidwys I will have a look later today! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-07-31 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/4225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #4225: [FLINK-7044] [queryable-st] Allow to specify namespace an...

2017-06-30 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4225 @aljoscha thanks for the review, I updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r125007394 --- Diff: flink-tests/src/test/java/org/apache/flink/test/query/AbstractQueryableStateITCase.java --- @@ -534,33 +537,66 @@ public Integer getKey(Tuple2

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r125007122 --- Diff: flink-tests/src/test/java/org/apache/flink/test/query/AbstractQueryableStateITCase.java --- @@ -234,38 +239,28 @@ public Integer getKey(Tuple2

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r125006493 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/query/QueryableStateClient.java --- @@ -267,6 +293,177 @@ public void shutDown

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4225#discussion_r125006417 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/VoidNamespaceTypeInfo.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4225: [FLINK-7044] [queryable-st] Allow to specify names...

2017-06-29 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4225 [FLINK-7044] [queryable-st] Allow to specify namespace and descriptor in the query. R @aljoscha You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] flink issue #4153: [FLINK-6927] [cep] Support pattern group in CEP

2017-06-29 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4153 Hi @dianfu and @dawidwys . I think that we should stick to the current API as: 1) a new API will raise serious backwards compatibility concerns, 2) people have already started

[GitHub] flink issue #4172: [FLINK-6983] [cep] Do not serialize States with NFA

2017-06-29 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4172 Hi @wuchong . I am not an expert in Janino and how it works but I do not think you need Janino's classloader at any point. Using the `open()` of the `CEPOperator` you just need to compile the code

[GitHub] flink issue #4172: [FLINK-6983] [cep] Do not serialize States with NFA

2017-06-28 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4172 @wuchong Yes this is what I had in mind. Could you tell me which class is not found? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #4195: [FLINK-7008] [cep] Update NFA state only when the ...

2017-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4195#discussion_r124500395 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -270,10 +270,12 @@ private void

[GitHub] flink issue #4172: [FLINK-6983] [cep] Do not serialize States with NFA

2017-06-28 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4172 @dianfu So this is a plan that can work to avoid having to generate the code of the `IterativeCondition` every time. This came also after discussion with @fhueske who also explained me how things

[GitHub] flink issue #4172: [FLINK-6983] [cep] Do not serialize States with NFA

2017-06-27 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4172 @dianfu and I also include @wuchong on this as these two are related. The way I see it is that by not serializing the condition and the states, you are trying to gain some speed, especially

[GitHub] flink issue #4172: [FLINK-6983] [cep] Do not serialize States with NFA

2017-06-27 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4172 Hi @dianfu . Thanks for updating the PR. I left some comments on the related JIRA (https://issues.apache.org/jira/browse/FLINK-6983) and the related https://issues.apache.org/jira/browse/FLINK

[GitHub] flink issue #4143: [FLINK-6418][cep] Support for dynamic state changes in CE...

2017-06-26 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4143 LGTM. +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4172: [FLINK-6983] [cep] Do not serialize States with NFA

2017-06-26 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4172 Hi @dianfu , this branch seems to be broken. Most of the migration tests fail when you run them locally. I will keep on checking out the branch, just to see the general idea of the change because

[GitHub] flink issue #4145: [FLINK-6938][FLINK-6939] [cep] Not store IterativeConditi...

2017-06-25 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4145 Hi @wuchong ! Nice work! I have some changes to propose in the code itself, but before moving on with this, I have some questions about the need of the change. For the second, I have

[GitHub] flink issue #4165: [FLINK-6897][cep] Re-add support for Java 8 lambdas in CE...

2017-06-23 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4165 Hi @dawidwys ! This branch seems to be broken (does not compile). In the `Pattern` class, the newly introduced: `public Pattern<T, F> where(SimpleCondition condition) ` and `

[GitHub] flink pull request #4143: [FLINK-6418][cep] Support for dynamic state change...

2017-06-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4143#discussion_r123715144 --- Diff: docs/dev/libs/cep.md --- @@ -547,18 +579,30 @@ pattern.where(event => ... /* some condition */) or(condit

[GitHub] flink pull request #4143: [FLINK-6418][cep] Support for dynamic state change...

2017-06-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4143#discussion_r123715389 --- Diff: docs/dev/libs/cep.md --- @@ -334,6 +334,20 @@ pattern.where(event => ... /* some condition */).or(event => ... /* or con

[GitHub] flink pull request #4143: [FLINK-6418][cep] Support for dynamic state change...

2017-06-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4143#discussion_r123714098 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/UntilConditionITCase.java --- @@ -0,0 +1,427 @@ +/* + * Licensed

[GitHub] flink pull request #4143: [FLINK-6418][cep] Support for dynamic state change...

2017-06-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4143#discussion_r123710396 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Pattern.java --- @@ -186,6 +193,24 @@ public Quantifier getQuantifier

[GitHub] flink pull request #4143: [FLINK-6418][cep] Support for dynamic state change...

2017-06-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4143#discussion_r123713960 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -514,25 +524,46 @@ private void

[GitHub] flink pull request #4143: [FLINK-6418][cep] Support for dynamic state change...

2017-06-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4143#discussion_r123715235 --- Diff: docs/dev/libs/cep.md --- @@ -409,11 +423,28 @@ pattern.where(new IterativeCondition() { }); {% endhighlight

[GitHub] flink issue #4143: [FLINK-6418][cep] Support for dynamic state changes in CE...

2017-06-20 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4143 Thanks a lot @dawidwys ! I will have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #4143: [FLINK-6418][cep] Support for dynamic state changes in CE...

2017-06-19 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4143 Hi @dawidwys ! Thanks for the work. Could you also update the documentation? This will also help the review process. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #4132: [FLINK-6933] [cep] Refactor NFACompiler to reduce code du...

2017-06-16 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4132 After an offline discussion with @dianfu , we decided to close this PR and merge this change with https://github.com/apache/flink/pull/4121/ as it is more relevant there. --- If your project is set

[GitHub] flink issue #4084: [FLINK-6772] [cep] Fix ordering (by timestamp) of matched...

2017-06-07 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4084 Thanks @dawidwys ! I will let travis have another go on the rebased version and then merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request #4084: [FLINK-6772] [cep] Fix ordering (by timestamp) of ...

2017-06-07 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4084 [FLINK-6772] [cep] Fix ordering (by timestamp) of matched events. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink cep-fix-ordering

[GitHub] flink issue #4059: [FLINK-6830] Add StatefulJobSavepointFrom13MigrationITCas...

2017-06-06 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4059 @tzulitai yes I will ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-06 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r120362519 --- Diff: docs/dev/libs/cep.md --- @@ -98,48 +128,105 @@ val result: DataStream[Alert] = patternStream.select(createAlert(_)) -Note

[GitHub] flink issue #4059: [FLINK-6830] Add StatefulJobSavepointFrom13MigrationITCas...

2017-06-06 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4059 Hi @tzulitai ! Thanks for testing also this. The problem with the `CEP` failing test for `1.3` while passing for `1.2` is that the semantics of the `followedBy()` changed between `1.2

[GitHub] flink issue #4059: [FLINK-6830] Add StatefulJobSavepointFrom13MigrationITCas...

2017-06-06 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4059 @aljoscha yes we have already discussed offline with @tzulitai . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-06 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r120303532 --- Diff: docs/dev/libs/cep.md --- @@ -98,48 +128,105 @@ val result: DataStream[Alert] = patternStream.select(createAlert(_)) -Note

[GitHub] flink issue #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-01 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4041 Thanks a lot @dawidwys for having a detailed look at it! I will integrate your comments and then merge. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-01 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4041 Thanks a lot for the thorough review @tzulitai ! I will address your comments and then merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-01 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119596846 --- Diff: docs/dev/libs/cep.md --- @@ -874,3 +1141,19 @@ val alerts = patternStream.select(createAlert(_))) {% endhighlight

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-01 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4041 [FLINK-6198] [cep] Update CEP documentation. R @tzulitai @dawidwys You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink cep-doc

[GitHub] flink issue #3963: [FLINK-6658][cep] Use scala Collections in scala CEP API

2017-05-26 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3963 @dawidwys merged this. Could you close the PR and the related JIRA? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #2937: [FLINK-4303] [cep] Examples for CEP library.

2017-05-26 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2937 Hi @DmytroShkvyra ! Great to hear that you want to contribute to Flink! To see the features that are pending, I would suggest to have a look at the JIRAs that have CEP as component

[GitHub] flink pull request #3963: [FLINK-6658][cep] Use scala Collections in scala C...

2017-05-24 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3963#discussion_r118297586 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/conditions/Context.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed

[GitHub] flink pull request #3963: [FLINK-6658][cep] Use scala Collections in scala C...

2017-05-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3963#discussion_r118051044 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala --- @@ -296,25 +294,94 @@ class PatternStream[T

[GitHub] flink pull request #3963: [FLINK-6658][cep] Use scala Collections in scala C...

2017-05-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3963#discussion_r117989704 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala --- @@ -296,25 +294,94 @@ class PatternStream[T

[GitHub] flink pull request #3963: [FLINK-6658][cep] Use scala Collections in scala C...

2017-05-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3963#discussion_r117985885 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/package.scala --- @@ -40,7 +44,11 @@ package object scala

[GitHub] flink issue #3961: [FLINK-6656] [cep] Change element PriorityQueue to MapSta...

2017-05-22 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3961 Hi @dawidwys ! Your understanding is correct in the sense that it does not leverage to the fullest the fact of keys being returned in order. The reason is that this is valid only in RocksDB state

[GitHub] flink issue #3961: [FLINK-6656] [cep] Change element PriorityQueue to MapSta...

2017-05-22 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3961 The re-ordering is just to verify that at watermark time, we actually order by event-time. On May 22, 2017 2:57 PM, "Aljoscha Krettek" <notificati...@github.c

[GitHub] flink pull request #3961: [FLINK-6656] [cep] Change element PriorityQueue to...

2017-05-22 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3961 [FLINK-6656] [cep] Change element PriorityQueue to MapState. This is to leverage the fact that RocksDB already returns the keys sorted. So now elements, instead of being stores in a PQ and all

[GitHub] flink issue #2937: [FLINK-4303] [cep] Examples for CEP library.

2017-05-22 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2937 Thanks a lot @chermenin ! The same comment also holds for the branching patterns PR. The PR is outdated but the issue is still valid. So if you ever want to work on that, let us know! --- If your

[GitHub] flink issue #2937: [FLINK-4303] [cep] Examples for CEP library.

2017-05-20 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2937 Hi @chermenin . And sorry for the really late reply. As you may have noticed the CEP library has been significantly enriched for the 1.3 version with a bunch of cool new features

[GitHub] flink pull request #3945: [FLINK-6634] [cep] NFASerializer serializes Comput...

2017-05-19 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3945#discussion_r117477471 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -930,6 +930,7 @@ public void serialize(NFA record, DataOutputView

[GitHub] flink pull request #3945: [FLINK-6634] [cep] NFASerializer serializes Comput...

2017-05-19 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3945 [FLINK-6634] [cep] NFASerializer serializes ComputationState counter. Before the recently introduces `NFASerializer` was not serializing the `counter` of the `ComputationState`. This could result

[GitHub] flink issue #3938: [FLINK-6624] [cep] Fix SharedBuffer#hashCode().

2017-05-18 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3938 Merging this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #3938: [FLINK-6624] [cep] Fix SharedBuffer#hashCode().

2017-05-18 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3938 [FLINK-6624] [cep] Fix SharedBuffer#hashCode(). You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink cep-hash Alternatively you can review

[GitHub] flink issue #3909: [FLINK-6578] Fix self-loop handling in SharedBuffer.

2017-05-17 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3909 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3872: [FLINK-6536] [cep] Improve error message in SharedBuffer:...

2017-05-17 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3872 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #3872: [FLINK-6536] [cep] Improve error message in Shared...

2017-05-17 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/3872 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #3909: [FLINK-6578] Fix self-loop handling in SharedBuffe...

2017-05-17 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/3909 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #3927: [FLINK-6609] Wrong version assignment when multiple TAKEs...

2017-05-17 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3927 @dawidwys thanks a lot for the work! I merged it on the master and the 1.3 release. Could you close this PR and the related JIRA? --- If your project is set up for it, you can reply to this email

[GitHub] flink issue #3820: [FLINK-6381] [connector] Unnecessary synchronizing object...

2017-05-16 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3820 Merged this. Could you close the PR and the related JIRA? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3820: [FLINK-6381] [connector] Unnecessary synchronizing object...

2017-05-16 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3820 Thanks for your work @zhangminglei . Changes look good! Merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

  1   2   3   4   5   6   7   >