[GitHub] flink issue #5119: [FLINK-6590] Integrate automatic docs generation

2018-01-17 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5119 Building the documentation seems to be working, and the docs look nice. Thanks a lot for the work @zentol . +1 to merge ---

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

2018-01-12 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r161179351 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java --- @@ -1,55 +0,0 @@ -/* - * Licensed

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-11 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r160904948 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/BroadcastConnectedStream.java --- @@ -0,0 +1,216

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

2018-01-11 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160895447 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java --- @@ -1,55 +0,0 @@ -/* - * Licensed

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-02 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/5230 [FLINK-8345] Add iterator of keyed state on broadcast side of connected streams. *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help

[GitHub] flink pull request #5052: [FLINK-8133][REST][docs] Generate REST API documen...

2017-12-07 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5052#discussion_r155482395 --- Diff: flink-docs/README.md --- @@ -0,0 +1,36 @@ + + +# Documentation generators + +This module contains generators that create HTML

[GitHub] flink pull request #5052: [FLINK-8133][REST][docs] Generate REST API documen...

2017-12-07 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5052#discussion_r155482662 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java --- @@ -317,7 +317,21 @@ public int compare

[GitHub] flink pull request #5052: [FLINK-8133][REST][docs] Generate REST API documen...

2017-12-07 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5052#discussion_r155482491 --- Diff: flink-docs/README.md --- @@ -0,0 +1,36 @@ + + +# Documentation generators + +This module contains generators that create HTML

[GitHub] flink pull request #5052: [FLINK-8133][REST][docs] Generate REST API documen...

2017-12-07 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5052#discussion_r155483634 --- Diff: flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java --- @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #5052: [FLINK-8133][REST][docs] Generate REST API documen...

2017-12-07 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5052#discussion_r155483740 --- Diff: flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java --- @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #5052: [FLINK-8133][REST][docs] Generate REST API documen...

2017-12-07 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5052#discussion_r155482310 --- Diff: flink-docs/README.md --- @@ -0,0 +1,36 @@ + + +# Documentation generators + +This module contains generators that create HTML

[GitHub] flink pull request #5052: [FLINK-8133][REST][docs] Generate REST API documen...

2017-12-07 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5052#discussion_r155482231 --- Diff: flink-docs/README.md --- @@ -0,0 +1,36 @@ + + +# Documentation generators + +This module contains generators that create HTML

[GitHub] flink pull request #5052: [FLINK-8133][REST][docs] Generate REST API documen...

2017-12-07 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5052#discussion_r155482058 --- Diff: flink-docs/README.md --- @@ -0,0 +1,36 @@ + + +# Documentation generators + +This module contains generators that create HTML

[GitHub] flink pull request #5052: [FLINK-8133][REST][docs] Generate REST API documen...

2017-12-07 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5052#discussion_r155483284 --- Diff: flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java --- @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software

[GitHub] flink issue #5052: [FLINK-8133][REST][docs] Generate REST API documentation

2017-12-07 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5052 From what I understand, this PR is just for the tooling, and not for the actual content. So the changes in the `test_api.md` are just a mock to see how it would look. If this is correct

[GitHub] flink issue #4993: [FLINK-7974][FLINK-7975][QS] Wait for shutdown in QS clie...

2017-12-06 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4993 It was merged as part of https://github.com/apache/flink/pull/5062 ---

[GitHub] flink pull request #4993: [FLINK-7974][FLINK-7975][QS] Wait for shutdown in ...

2017-12-06 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/4993 ---

[GitHub] flink issue #5062: [FLINK-7880][QS] Wait for proper resource cleanup after e...

2017-12-06 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5062 Thanks @zentol ! I will let another travis run, and then merge. ---

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-06 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r155212885 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/NonHAAbstractQueryableStateTestBase.java

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-06 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r155212865 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/HAAbstractQueryableStateTestBase.java

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-06 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r155212313 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-06 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r155201806 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java --- @@ -251,34

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-05 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r154890905 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java --- @@ -486,27 +542,25

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-05 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r154890227 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java --- @@ -312,32 +345,41

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-05 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r154886964 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java --- @@ -166,28 +167,57

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-05 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r154885936 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java --- @@ -166,28 +167,57

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-05 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r154885293 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java --- @@ -251,34

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-05 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r154885503 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java --- @@ -133,7 +134,7

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-12-05 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5062#discussion_r154884801 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java --- @@ -251,34

[GitHub] flink issue #5062: [FLINK-7880][QS] Wait for proper resource cleanup after e...

2017-11-29 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5062 Fixed @zentol ! ---

[GitHub] flink issue #5062: [FLINK-7880][QS] Wait for proper resource cleanup after e...

2017-11-24 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5062 This is a follow-up to https://github.com/apache/flink/pull/5062 ---

[GitHub] flink pull request #5062: [FLINK-7880][QS] Wait for proper resource cleanup ...

2017-11-23 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/5062 [FLINK-7880][QS] Wait for proper resource cleanup after each ITCase. R @aljoscha You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink qs

[GitHub] flink pull request #5057: [FLINK-8049] [FLINK-8050] REST client/server repor...

2017-11-23 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/5057 [FLINK-8049] [FLINK-8050] REST client/server report netty exceptions on shutdown. As described in the JIRAs, the rest client/server were swallowing exception without any message. This PR changes

[GitHub] flink issue #5052: [FLINK-8133][REST][docs] Generate REST API documentation

2017-11-22 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5052 Thanks @zentol I will have a look. ---

[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.

2017-11-21 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4821 Sorry to hear that @shashank734 . But on the bright side, the RC0 for Flink 1.4 is out: http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/PREVIEW-Release-1-4-0-release-candidate-0

[GitHub] flink pull request #5038: [FLINK-7880][FLINK-7975][FLINK-7974][QS] QS test i...

2017-11-20 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/5038 ---

[GitHub] flink pull request #5038: [FLINK-7880][FLINK-7975][FLINK-7974][QS] QS test i...

2017-11-20 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/5038 [FLINK-7880][FLINK-7975][FLINK-7974][QS] QS test instability fix. This is a follow-up on https://github.com/apache/flink/pull/4993. It contains one additional commit that makes the QS ITcases

[GitHub] flink issue #5008: [FLINK-8061] [Queryable State] removed trailing asterisk ...

2017-11-17 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5008 @vetriselvan1187 Merged. Can you close this PR? ---

[GitHub] flink issue #5008: [FLINK-8061] [Queryable State] removed trailing asterisk ...

2017-11-17 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5008 Thanks for the work @vetriselvan1187 . I will merge this. ---

[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.

2017-11-17 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4821 Yes, I think manually is the safest bet. Either way the 1.4 will come soon and this fix is going to be included. ---

[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.

2017-11-17 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4821 I think you can but you will have to recompile flink. ---

[GitHub] flink pull request #5028: [FLINK-8057][FLINK-8059][FLINK-8055][FLINK-8065][F...

2017-11-17 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/5028 [FLINK-8057][FLINK-8059][FLINK-8055][FLINK-8065][FLINK-8062] This PR simply fixes multiple minor issues, like error messages. You can merge this pull request into a Git repository by running

[GitHub] flink pull request #5021: [FLINK-8063][QS] QS client does not retry when an ...

2017-11-15 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5021#discussion_r151188168 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java

[GitHub] flink pull request #5021: [FLINK-8063][QS] QS client does not retry when an ...

2017-11-15 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5021#discussion_r151184645 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java

[GitHub] flink pull request #5021: [FLINK-8063][QS] QS client does not retry when an ...

2017-11-15 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5021#discussion_r151184384 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java

[GitHub] flink pull request #5021: [FLINK-8063][QS] QS client does not retry when an ...

2017-11-15 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5021#discussion_r151183957 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java

[GitHub] flink pull request #5021: [FLINK-8063][QS] QS client does not retry when an ...

2017-11-15 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5021#discussion_r151183695 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java

[GitHub] flink issue #5021: [FLINK-8063][QS] QS client does not retry when an Unknown...

2017-11-15 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5021 Thanks for the review @aljoscha ! I will wait a bit for another travis run and then merge. ---

[GitHub] flink pull request #5021: [FLINK-8063][QS] QS client does not retry when an ...

2017-11-15 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5021#discussion_r151162640 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java

[GitHub] flink pull request #5021: [FLINK-8063][QS] QS client does not retry when an ...

2017-11-15 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/5021 [FLINK-8063][QS] QS client does not retry when an UnknownKvStateLocation. ## What is the purpose of the change Fix bug in QS client. Before if the client submitted a query with invalid

[GitHub] flink pull request #4993: [FLINK-7974][FLINK-7975][QS] Wait for shutdown in ...

2017-11-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4993#discussion_r150878782 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java --- @@ -260,25

[GitHub] flink issue #4993: [FLINK-7974][FLINK-7975][QS] Wait for shutdown in QS clie...

2017-11-14 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4993 Thanks for the comments @tillrohrmann . I addressed them. ---

[GitHub] flink pull request #4993: [FLINK-7974][FLINK-7975][QS] Wait for shutdown in ...

2017-11-14 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4993#discussion_r150856825 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java --- @@ -483,27 +511,31

[GitHub] flink pull request #4993: [FLINK-7974][FLINK-7975][QS] Wait for shutdown in ...

2017-11-10 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4993#discussion_r150243346 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java --- @@ -260,25

[GitHub] flink pull request #4993: [FLINK-7974][FLINK-7975][QS] Wait for shutdown in ...

2017-11-10 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4993 [FLINK-7974][FLINK-7975][QS] Wait for shutdown in QS client and servers. ## What is the purpose of the change Previously we were freeing the resources held by the QS client and servers

[GitHub] flink issue #4980: [FLINK-8005] [runtime] Set user code class loader before ...

2017-11-09 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4980 I agree! +1 to merge as soon as Travis gives us the green light. ---

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149984491 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -277,8 +287,12 @@ public void invoke() throws

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149982812 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -277,8 +287,12 @@ public void invoke() throws

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149947069 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -254,12 +300,10 @@ else if (this.error == null

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149947094 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -254,12 +300,10 @@ else if (this.error == null

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149949202 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -58,99 +59,144 @@ import org.junit.Before

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149946930 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/DispatcherThreadFactory.java --- @@ -29,21 +31,41 @@ private final

[GitHub] flink pull request #4966: [FLINK-7822][FLINK-7823] Adds documentation and fi...

2017-11-07 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4966#discussion_r149340569 --- Diff: docs/dev/stream/state/queryable_state.md --- @@ -32,38 +32,67 @@ under the License. likely that there will be breaking API changes

[GitHub] flink pull request #4966: [FLINK-7822][FLINK-7823] Adds documentation and fi...

2017-11-07 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4966 [FLINK-7822][FLINK-7823] Adds documentation and fixes configuration of QS. ## What is the purpose of the change *This PR adds documentation for the new queryable state. R @aljoscha

[GitHub] flink pull request #:

2017-10-31 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/commit/f2c3ff3ee3a5121665e32acebbaeee7bbb380e7f#commitcomment-25306091 @zentol reported instabilities so for now I ignored them until I fix them. ---

[GitHub] flink pull request #4922: [hotfix][metrics] Cleanup ScopeFormats

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4922#discussion_r147719227 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/scope/ScopeFormats.java --- @@ -38,30 +36,9

[GitHub] flink pull request #4919: [FLINK-7902] Use TypeSerializer in TwoPhaseCommitS...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4919#discussion_r147704985 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -361,5 +376,247 @@ public

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147697678 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AggregatingSubtasksMetricsHandler.java --- @@ -0,0 +1,117

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147696972 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AggregatingSubtasksMetricsHandler.java --- @@ -0,0 +1,117

[GitHub] flink pull request #4919: [FLINK-7902] Use TypeSerializer in TwoPhaseCommitS...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4919#discussion_r147692203 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -993,14

[GitHub] flink pull request #4919: [FLINK-7902] Use TypeSerializer in TwoPhaseCommitS...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4919#discussion_r147675623 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -993,14

[GitHub] flink pull request #4919: [FLINK-7902] Use TypeSerializer in TwoPhaseCommitS...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4919#discussion_r147678569 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -79,19 +92,18

[GitHub] flink pull request #4919: [FLINK-7902] Use TypeSerializer in TwoPhaseCommitS...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4919#discussion_r147673504 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -993,14

[GitHub] flink pull request #4919: [FLINK-7902] Use TypeSerializer in TwoPhaseCommitS...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4919#discussion_r147674429 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -993,14

[GitHub] flink pull request #4919: [FLINK-7902] Use TypeSerializer in TwoPhaseCommitS...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4919#discussion_r147688912 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -362,4 +374,213 @@ public

[GitHub] flink pull request #4919: [FLINK-7902] Use TypeSerializer in TwoPhaseCommitS...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4919#discussion_r147676219 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -993,14

[GitHub] flink pull request #4919: [FLINK-7902] Use TypeSerializer in TwoPhaseCommitS...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4919#discussion_r147678946 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java --- @@ -362,4 +374,213 @@ public

[GitHub] flink pull request #4919: [FLINK-7902] Use TypeSerializer in TwoPhaseCommitS...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4919#discussion_r147676539 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -993,14

[GitHub] flink pull request #4919: [FLINK-7902] Use TypeSerializer in TwoPhaseCommitS...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4919#discussion_r147672995 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -958,29

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147649898 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractAggregatingMetricsHandler.java --- @@ -0,0 +1,223

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147655793 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractMetricsHandler.java --- @@ -39,12 +39,15

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147657820 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/DoubleAccumulator.java --- @@ -0,0 +1,260

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147651247 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractAggregatingMetricsHandler.java --- @@ -0,0 +1,223

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147651957 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractAggregatingMetricsHandler.java --- @@ -0,0 +1,223

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147650987 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractAggregatingMetricsHandler.java --- @@ -0,0 +1,223

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147649624 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractAggregatingMetricsHandler.java --- @@ -0,0 +1,223

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147653983 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AggregatingSubtasksMetricsHandler.java --- @@ -0,0 +1,70

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147657052 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/SubtaskMetricsHandler.java --- @@ -0,0 +1,70

[GitHub] flink pull request #4901: [FLINK-7781][metrics][REST] Support on-demand aggr...

2017-10-30 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4901#discussion_r147649786 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/AbstractAggregatingMetricsHandler.java --- @@ -0,0 +1,223

[GitHub] flink issue #4909: [FLINK-7880][QS] Fix QS test instabilities.

2017-10-27 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4909 It should call `dispose()`, you are correct. This was a mistake due to sloppy "manual rebasing". ---

[GitHub] flink pull request #4909: [FLINK-7880][QS] Fix QS test instabilities.

2017-10-26 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4909 [FLINK-7880][QS] Fix QS test instabilities. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink qs-test-instability Alternatively you can

[GitHub] flink issue #4906: [FLINK-7908][FLINK-7824][QS] Restructure QS packages and ...

2017-10-26 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4906 Thanks a lot for the review @aljoscha ! Waiting for travis and then merging. ---

[GitHub] flink issue #4900: [FLINK-7666] Close TimeService after closing operators.

2017-10-25 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4900 Perfect! Merging this... ---

[GitHub] flink pull request #4906: [FLINK-7908][FLINK-7824][QS] Restructure QS packag...

2017-10-25 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4906 [FLINK-7908][FLINK-7824][QS] Restructure QS packages and put QS jars in opt/. ## What is the purpose of the change Make the Queryable State more usable by: 1) Reducing the dependencies

[GitHub] flink issue #4900: [FLINK-7666] Close TimeService after closing operators.

2017-10-25 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4900 In this case, the original problem will persist, right? (The one in the JIRA). In addition, given that: 1) we check the status of the service before firing a timer, and 2) the status is set

[GitHub] flink pull request #4900: [FLINK-7666] Close TimeService after closing opera...

2017-10-25 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4900 [FLINK-7666] Close TimeService after closing operators. R @aljoscha **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of the change

[GitHub] flink issue #4838: [FLINK-7826][QS] Add support for all types of state to th...

2017-10-16 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4838 R @aljoscha ---

[GitHub] flink pull request #4838: [FLINK-7826][QS] Add support for all types of stat...

2017-10-16 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4838 [FLINK-7826][QS] Add support for all types of state to the QS Client. ## What is the purpose of the change As the JIRA describes, it makes the queryable state client able to query all types

[GitHub] flink issue #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer.

2017-10-13 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4821 Merging this. ---

[GitHub] flink pull request #4821: [FLINK-7835][cep] Fix duplicate() in NFASerializer...

2017-10-13 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/4821 [FLINK-7835][cep] Fix duplicate() in NFASerializer. R @aljoscha You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink cep-nfa-serializer-bug

  1   2   3   4   5   6   7   8   >