Github user manuzhang closed the pull request at:
https://github.com/apache/flink/pull/3661
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/3661
By the way, great conference and great contents from
http://sf.flink-forward.org/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/3661
@aljoscha Yeah, that looks better. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/3661
@aljoscha Updated as you proposed although not sure I've got all the needed
tests there (properly).
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/3661
It seems `WindowOperatorContractTest` is for `InternalWindowFunction` while
there is no existing tests for `ProcessWindowFunction`. Should I add them there
?
---
If your project is set up
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3661#discussion_r109821341
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
---
@@ -2560,7 +2560,7
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/3661
Okay. Shall we open a JIRA to deprecate `WindowOperatorTest` ? I found a
minor bug in `WindowOperatorTest#Tuple3ResultSortComparator` (same as
`WindowOperatorMigrationTest`), do we want to fix
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/3661
@aljoscha
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/3661
Not sure what happened here although tests passed in most cases. Looks
unrelated to this PR.
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.18.1
GitHub user manuzhang opened a pull request:
https://github.com/apache/flink/pull/3661
[FLINK-4953] Allow access to "time" in ProcessWindowFunction.Context
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/3285
LGTM. Really excited to see we move further in this direction, and faster
if possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/2756
@aljoscha @VenturaDelMonte This seems to be taking a long time. What is the
progress now ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/2756
@VenturaDelMonte Any updates here ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/2756
@VenturaDelMonte sorry, it was my suggestion to change
`InternalWindowFunction#apply` to `process`. Anyway, great work ð
---
If your project is set up for it, you can reply to this email
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/2756
R: @aljoscha could you take a look ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/flink/pull/2756#discussion_r86973108
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/functions/InternalWindowFunction.java
---
@@ -46,5
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/2715
Thanks for pinging me with quick fix. This looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/2645
Any more comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/2671
@mxm updated. Thanks for teaching me more about the internals. Ignoring the
old Timer make things much simpler actually.
---
If your project is set up for it, you can reply to this email and have
GitHub user manuzhang opened a pull request:
https://github.com/apache/flink/pull/2671
[FLINK-4862] fix Timer register in ContinuousEventTimeTrigger
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user manuzhang closed the pull request at:
https://github.com/apache/flink/pull/2666
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user manuzhang opened a pull request:
https://github.com/apache/flink/pull/2666
[FLINK-4863] fix trigger context window on merge
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your
Github user manuzhang commented on the issue:
https://github.com/apache/flink/pull/2645
@fhueske updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user manuzhang opened a pull request:
https://github.com/apache/flink/pull/2645
[FLINK-4838] remote STREAM keyword in StreamSQLExample
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
24 matches
Mail list logo
