Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/flink/pull/2756#discussion_r86973108
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/functions/InternalWindowFunction.java
---
@@ -46,5 +46,5 @@
*
* @throws Exception The function may throw exceptions to fail the
program and trigger recovery.
*/
- public abstract void apply(KEY key, W window, IN input, Collector<OUT>
out) throws Exception;
+ public abstract void process(KEY key, W window, IN input,
Collector<OUT> out) throws Exception;
--- End diff --
I think this PR is good as a first step but I really want to see the
benefits of introducing the new interface, especially for users. I don't see
how the window metadata is extended with the current implementation. That's my
$0.02. @aljoscha is more of an expert here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
