Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3769
hi, @zentol @StephanEwen It didn't merge in. @zentol Please check again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user shijinkui closed the pull request at:
https://github.com/apache/flink/pull/3769
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user shijinkui reopened a pull request:
https://github.com/apache/flink/pull/3769
[FLINK-6367] support custom header settings of allow origin
`jobmanager.web.access-control-allow-origin`: Enable custom access control
parameter for allow origin header, default is
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3777
@StephanEwen @zentol The Flink webmonitor is netty inside. In generally,
Netty is used as a tcp transfer. For a web or API server, jetty or
Playframework maybe more suitable. Especially we must
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3777
> I can see this flooding the logs like crazy, especially with things like
metrics and watermarks that update often. Some kind of filtering is probably
necessary here.
You are right.
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/3777
[FLINK-6387] [webfrontend]Flink UI support access log
Record the use request to the access log. Append use access to the log file.
- [X] General
- The pull request references the
shijinkui created FLINK-6387:
Summary: Flink UI support access log
Key: FLINK-6387
URL: https://issues.apache.org/jira/browse/FLINK-6387
Project: Flink
Issue Type: Improvement
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3769
@zentol fix that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3769#discussion_r113226235
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -701,6 +701,9 @@
@Deprecated
public static
[
https://issues.apache.org/jira/browse/FLINK-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui reassigned FLINK-6367:
Assignee: shijinkui
> support custom header settings of allow ori
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/3769
[FLINK-6367] support custom header settings of allow origin
`jobmanager.web.access-control-allow-origin`: Enable custom access control
parameter for allow origin header, default is
[
https://issues.apache.org/jira/browse/FLINK-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982764#comment-15982764
]
shijinkui commented on FLINK-6367:
--
[~greghogan] We need configure some spe
shijinkui created FLINK-6367:
Summary: support custom header settings of allow origin
Key: FLINK-6367
URL: https://issues.apache.org/jira/browse/FLINK-6367
Project: Flink
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/FLINK-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui closed FLINK-6193.
Resolution: Fixed
> Flink dist directory normalize
> --
>
>
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
@fhueske Thanks : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
> Hi @shijinkui, yes that sounds good to me.
Thanks. When will we merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
[
https://issues.apache.org/jira/browse/FLINK-5902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958261#comment-15958261
]
shijinkui commented on FLINK-5902:
--
hi, [~ajithshetty] do we have some solu
[
https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950672#comment-15950672
]
shijinkui commented on FLINK-6233:
--
Is this the sub-issue of FLINK-4557?
>
[
https://issues.apache.org/jira/browse/FLINK-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948410#comment-15948410
]
shijinkui commented on FLINK-5860:
--
[~yaroslav.mykhaylov] Thank for your work. Wait
[
https://issues.apache.org/jira/browse/FLINK-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946477#comment-15946477
]
shijinkui commented on FLINK-6204:
--
-1.
hi, guys. I want to know the differance bet
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3628
> I would also suggest to run an example at least once to make sure you
don't break anything.
You are right. Only move the example files
---
If your project is set up for it,
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/3628
[FLINK-6201][example] move python example files from resources to the
examples
Python example in the resource dir is not suitable. Move them to the
examples/python dir.
- [X] General
[
https://issues.apache.org/jira/browse/FLINK-6201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui reassigned FLINK-6201:
Assignee: shijinkui
> move python example files from resources to the examp
[
https://issues.apache.org/jira/browse/FLINK-6201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui updated FLINK-6201:
-
Priority: Trivial (was: Major)
> move python example files from resources to the examp
[
https://issues.apache.org/jira/browse/FLINK-6201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui updated FLINK-6201:
-
Summary: move python example files from resources to the examples (was:
move python example files to the
shijinkui created FLINK-6201:
Summary: move python example files to the examples dir
Key: FLINK-6201
URL: https://issues.apache.org/jira/browse/FLINK-6201
Project: Flink
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/FLINK-4319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943198#comment-15943198
]
shijinkui commented on FLINK-4319:
--
Flink on Kubernetes, do we have some sche
[
https://issues.apache.org/jira/browse/FLINK-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui closed FLINK-5217.
Resolution: Fixed
> Deprecated interface Checkpointed make clear suggest
[
https://issues.apache.org/jira/browse/FLINK-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui closed FLINK-5754.
Resolution: Won't Fix
> released tag missing .gitigonore .travis.yml .gitat
[
https://issues.apache.org/jira/browse/FLINK-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942804#comment-15942804
]
shijinkui commented on FLINK-5754:
--
[~greghogan] It's OK
> released
[
https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui updated FLINK-4562:
-
Issue Type: Sub-task (was: Improvement)
Parent: FLINK-6193
> table examples make an divi
shijinkui created FLINK-6193:
Summary: Flink dist directory normalize
Key: FLINK-6193
URL: https://issues.apache.org/jira/browse/FLINK-6193
Project: Flink
Issue Type: Improvement
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3609#discussion_r108059835
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala
---
@@ -0,0 +1,241
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3609#discussion_r108059875
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala
---
@@ -0,0 +1,241
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
> I agree with @wuchong , that we should follow the example of Gelly and
add the flink-table-examples JAR file to the opt folder.
@fhueske Thanks for your review.
IMO, direct
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3600
@Rucongzhang Please review it whether it meet your requirement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui updated FLINK-6117:
-
Issue Type: Sub-task (was: Bug)
Parent: FLINK-5839
> 'zookeeper.sasl.disable' no
[
https://issues.apache.org/jira/browse/FLINK-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui reassigned FLINK-6148:
Assignee: (was: shijinkui)
> The Zookeeper client occur SASL error when the sasl is disa
[
https://issues.apache.org/jira/browse/FLINK-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui reassigned FLINK-6148:
Assignee: shijinkui
> The Zookeeper client occur SASL error when the sasl is disa
[
https://issues.apache.org/jira/browse/FLINK-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941522#comment-15941522
]
shijinkui commented on FLINK-5217:
--
ping [~srichter]
> Deprecated in
[
https://issues.apache.org/jira/browse/FLINK-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941520#comment-15941520
]
shijinkui commented on FLINK-5860:
--
ping [~yaroslav.mykhaylov]
> Replace all t
[
https://issues.apache.org/jira/browse/FLINK-6060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941519#comment-15941519
]
shijinkui commented on FLINK-6060:
--
[~aljoscha] Sorry for my unclear description.
[
https://issues.apache.org/jira/browse/FLINK-6060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui updated FLINK-6060:
-
Summary: reference nonexistent class in the scaladoc (was: not exist class
referance in the scala
[
https://issues.apache.org/jira/browse/FLINK-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941516#comment-15941516
]
shijinkui commented on FLINK-5754:
--
[~greghogan] At first, I image that the flink ta
[
https://issues.apache.org/jira/browse/FLINK-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929946#comment-15929946
]
shijinkui commented on FLINK-5650:
--
Good job, Thanks.
> Flink-python tests ex
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106617241
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106589672
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106590214
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -159,6 +167,46
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106592513
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106590692
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106590822
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106590304
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -91,6 +91,35 @@ object
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106590402
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -91,6 +91,35 @@ object
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106592195
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106602209
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106605456
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106600097
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106411557
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -191,3 +287,31
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106604502
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106605103
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106602970
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106599975
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106601075
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -785,7 +785,7 @@ object
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106411491
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -136,13 +229,13
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106599719
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106605509
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106600464
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3386
@hongyuhong , IMO, all the function should have detail doc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui updated FLINK-5860:
-
Labels: starter (was: )
> Replace all the file creating from java.io.tmpdir with TemporaryFol
[
https://issues.apache.org/jira/browse/FLINK-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929365#comment-15929365
]
shijinkui commented on FLINK-5754:
--
[~greghogan] I had checkout a branch from tag 1.
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106411203
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/UnboundedRowtimeOverTest.scala
---
@@ -0,0 +1,138
[
https://issues.apache.org/jira/browse/FLINK-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927543#comment-15927543
]
shijinkui commented on FLINK-5650:
--
[~Zentol], Your PR can work. flink-python UT
[
https://issues.apache.org/jira/browse/FLINK-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui updated FLINK-5650:
-
Labels: osx (was: )
> Flink-python tests executing cost too long t
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3540
> I am a bit confused... I think there is no tools/flink* directory that
would need an exclusion...
When execute `tools/create_release_files.sh`, it will clone flink project
from apa
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3540
> Why exactly is it a problem if the rat-plugin checks the tools directory?
There no necessary to check the tmp flink project in the tools, because it
will extra cost some time when build
shijinkui created FLINK-6060:
Summary: not exist class referance in the scala function annotation
Key: FLINK-6060
URL: https://issues.apache.org/jira/browse/FLINK-6060
Project: Flink
Issue Type
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
ping @wuchong @fhueske @twalthr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
[
https://issues.apache.org/jira/browse/FLINK-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925833#comment-15925833
]
shijinkui edited comment on FLINK-5650 at 3/15/17 10:1
[
https://issues.apache.org/jira/browse/FLINK-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925833#comment-15925833
]
shijinkui commented on FLINK-5650:
--
Also we can make PythonPlanStreamer support a
[
https://issues.apache.org/jira/browse/FLINK-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925824#comment-15925824
]
shijinkui commented on FLINK-5650:
--
Now I have to excute `mvn clean test -pl
[
https://issues.apache.org/jira/browse/FLINK-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925816#comment-15925816
]
shijinkui commented on FLINK-5754:
--
ping [~greghogan] where did you make the tag, on
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/3540
[FLINK-6056] apache-rat exclude flink directory in tools
The flink* directory in the tools is temporary cloned when build
distribution.
So when build the Flink project, we should exclude the
[
https://issues.apache.org/jira/browse/FLINK-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923530#comment-15923530
]
shijinkui commented on FLINK-5756:
--
[~StephanEwen] Thank for your reply. [~Syinchwu
[
https://issues.apache.org/jira/browse/FLINK-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907043#comment-15907043
]
shijinkui commented on FLINK-5756:
--
hi, [~StephanEwen]
Do we have some tu
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3459#discussion_r104282631
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java
---
@@ -0,0 +1,162
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3459#discussion_r104283268
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/aggs/StreamAggregator.java
---
@@ -0,0 +1,23
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3459#discussion_r104282413
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java
---
@@ -0,0 +1,162
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3459#discussion_r104282451
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java
---
@@ -0,0 +1,162
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3468
As your current replacement with `ConfigConstants.DEFAULT_CHARSET`, it's
better for setting other charsets. UTF_8 has clear semantics. If we'll never
change the default charset utf_
[
https://issues.apache.org/jira/browse/FLINK-5902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui updated FLINK-5902:
-
Issue Type: Sub-task (was: Bug)
Parent: FLINK-5839
> Some images can not show in
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3468
Good changes. `ConfigConstants.DEFAULT_CHARSET` change to
`ConfigConstants.UTF_8 ` may be more clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3459
@stefanobortoli One PR should has only one commit as soon as possible. If
having so many commit, it's hard to review..
---
If your project is set up for it, you can reply to this email and
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3459#discussion_r104282393
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java
---
@@ -0,0 +1,162
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3408#discussion_r104277608
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -317,6 +319,10 @@ public AbstractYarnClusterDescriptor
[
https://issues.apache.org/jira/browse/FLINK-5818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui reassigned FLINK-5818:
Assignee: Tao Wang
> change checkpoint dir permission to 700 for security rea
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
> Can we just use the ${project.build.directory} as java.io.tmpdir ?
@wenlong88 Sorry for late reply.
It's good question. If use `${project.build.directory}` without sub
direct
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
Get it. Run single test, having no temp created, it should use the default
java.io.tmpdir property.
Let me check that.
In the base test class have a double check about the target
---
If
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
@wuchong @StephanEwen can you review this pull request.
Generating independent example runnable jar will increase the size of flink
distribution.
This table example jar is 13Mb or so
[
https://issues.apache.org/jira/browse/FLINK-5546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui closed FLINK-5546.
Resolution: Duplicate
resolved in FLINK-5817
> java.io.tmpdir setted as project build directory
[
https://issues.apache.org/jira/browse/FLINK-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875418#comment-15875418
]
shijinkui commented on FLINK-5780:
--
Just sound like a extension of apache common
1 - 100 of 260 matches
Mail list logo