[GitHub] [flink] azagrebin commented on issue #10161: [FLINK-13986][runtime] Clean up legacy code for FLIP-49.
azagrebin commented on issue #10161: [FLINK-13986][runtime] Clean up legacy code for FLIP-49. URL: https://github.com/apache/flink/pull/10161#issuecomment-561219932 merged into master by 5dca72169992567837bda21889c187fd56bfb391..5576851e0317b2e1e9e78e7aae02285203eed940 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] azagrebin commented on issue #10161: [FLINK-13986][runtime] Clean up legacy code for FLIP-49.
azagrebin commented on issue #10161: [FLINK-13986][runtime] Clean up legacy
code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#issuecomment-561057717
Actually, I did not notice that we do not snapshot the env vars before the
test and restore them afterwards, like we do e.g. in `PluginConfigTest`:
```
private static Map oldEnvVariables;
@Before
public static void setup() {
oldEnvVariables = System.getenv();
}
@After
public void teardown() {
if (oldEnvVariables != null) {
CommonTestUtils.setEnv(oldEnvVariables, true);
}
}
```
This is a cleaner approach.
Could you add this?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on issue #10161: [FLINK-13986][runtime] Clean up legacy code for FLIP-49.
azagrebin commented on issue #10161: [FLINK-13986][runtime] Clean up legacy code for FLIP-49. URL: https://github.com/apache/flink/pull/10161#issuecomment-560432083 Also, in old scripts we output a warning if user sets deprecated memory config with a hint what to use instead, we do not do this now for all deprecated options which we fallback to in `TaskExecutorResourceUtils` including `FLINK_TM_HEAP` which we should deprecate in release notes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
