[jira] [Commented] (FLINK-5155) Deprecate ValueStateDescriptor constructors with default value
[ https://issues.apache.org/jira/browse/FLINK-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821596#comment-15821596 ] ASF GitHub Bot commented on FLINK-5155: --- Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/3108 > Deprecate ValueStateDescriptor constructors with default value > -- > > Key: FLINK-5155 > URL: https://issues.apache.org/jira/browse/FLINK-5155 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek >Assignee: Aljoscha Krettek > Fix For: 1.2.0 > > > Having the default value in the descriptor is problematic with some > serialisers and we don't lose a feature because users can always check for > the null value and initialise with their own default value if necessary. > Right now, we're always forcing people to specify a default value even though > they don't need one. > Of course, we should add constructors without a default value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-5155) Deprecate ValueStateDescriptor constructors with default value
[ https://issues.apache.org/jira/browse/FLINK-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821595#comment-15821595 ] ASF GitHub Bot commented on FLINK-5155: --- Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3108 Manually merged. > Deprecate ValueStateDescriptor constructors with default value > -- > > Key: FLINK-5155 > URL: https://issues.apache.org/jira/browse/FLINK-5155 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek >Assignee: Aljoscha Krettek > Fix For: 1.2.0 > > > Having the default value in the descriptor is problematic with some > serialisers and we don't lose a feature because users can always check for > the null value and initialise with their own default value if necessary. > Right now, we're always forcing people to specify a default value even though > they don't need one. > Of course, we should add constructors without a default value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-5155) Deprecate ValueStateDescriptor constructors with default value
[ https://issues.apache.org/jira/browse/FLINK-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821551#comment-15821551 ] ASF GitHub Bot commented on FLINK-5155: --- Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3108 Thanks for reviewing. I'll change and then merge. > Deprecate ValueStateDescriptor constructors with default value > -- > > Key: FLINK-5155 > URL: https://issues.apache.org/jira/browse/FLINK-5155 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek > > Having the default value in the descriptor is problematic with some > serialisers and we don't lose a feature because users can always check for > the null value and initialise with their own default value if necessary. > Right now, we're always forcing people to specify a default value even though > they don't need one. > Of course, we should add constructors without a default value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-5155) Deprecate ValueStateDescriptor constructors with default value
[ https://issues.apache.org/jira/browse/FLINK-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821543#comment-15821543 ] ASF GitHub Bot commented on FLINK-5155: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3108 Fine by me. A warning at the top to not rely on default values is good. > Deprecate ValueStateDescriptor constructors with default value > -- > > Key: FLINK-5155 > URL: https://issues.apache.org/jira/browse/FLINK-5155 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek > > Having the default value in the descriptor is problematic with some > serialisers and we don't lose a feature because users can always check for > the null value and initialise with their own default value if necessary. > Right now, we're always forcing people to specify a default value even though > they don't need one. > Of course, we should add constructors without a default value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-5155) Deprecate ValueStateDescriptor constructors with default value
[ https://issues.apache.org/jira/browse/FLINK-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821536#comment-15821536 ] ASF GitHub Bot commented on FLINK-5155: --- Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3108 Should we maybe add such a comment in the Javadoc of `ValueState` or `ValueStateDescriptor`? That way we don't have to duplicate it for every constructor. Or we could add it in all places. > Deprecate ValueStateDescriptor constructors with default value > -- > > Key: FLINK-5155 > URL: https://issues.apache.org/jira/browse/FLINK-5155 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek > > Having the default value in the descriptor is problematic with some > serialisers and we don't lose a feature because users can always check for > the null value and initialise with their own default value if necessary. > Right now, we're always forcing people to specify a default value even though > they don't need one. > Of course, we should add constructors without a default value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-5155) Deprecate ValueStateDescriptor constructors with default value
[ https://issues.apache.org/jira/browse/FLINK-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821522#comment-15821522 ] ASF GitHub Bot commented on FLINK-5155: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3108 I think this is good, +1 What would be good is to add a line in the comment of the constructor that says that the state returns `null` if there is no value present, yet, for the current key. > Deprecate ValueStateDescriptor constructors with default value > -- > > Key: FLINK-5155 > URL: https://issues.apache.org/jira/browse/FLINK-5155 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek > > Having the default value in the descriptor is problematic with some > serialisers and we don't lose a feature because users can always check for > the null value and initialise with their own default value if necessary. > Right now, we're always forcing people to specify a default value even though > they don't need one. > Of course, we should add constructors without a default value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-5155) Deprecate ValueStateDescriptor constructors with default value
[ https://issues.apache.org/jira/browse/FLINK-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821498#comment-15821498 ] Aljoscha Krettek commented on FLINK-5155: - PR in https://github.com/apache/flink/pull/3108 > Deprecate ValueStateDescriptor constructors with default value > -- > > Key: FLINK-5155 > URL: https://issues.apache.org/jira/browse/FLINK-5155 > Project: Flink > Issue Type: Improvement > Components: Streaming >Reporter: Aljoscha Krettek > > Having the default value in the descriptor is problematic with some > serialisers and we don't lose a feature because users can always check for > the null value and initialise with their own default value if necessary. > Right now, we're always forcing people to specify a default value even though > they don't need one. > Of course, we should add constructors without a default value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
