[jira] [Commented] (FLINK-7408) Extract WebRuntimeMonitor options from JobManagerOptions
[
https://issues.apache.org/jira/browse/FLINK-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123007#comment-16123007
]
ASF GitHub Bot commented on FLINK-7408:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4512
> Extract WebRuntimeMonitor options from JobManagerOptions
>
>
> Key: FLINK-7408
> URL: https://issues.apache.org/jira/browse/FLINK-7408
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
> Fix For: 1.4.0
>
>
> With the Flip-6 code changes, the {{WebRuntimeMonitor}} won't run exclusively
> next to the {{JobManager}}. Therefore, it makes sense to refactor the web
> monitor options and moving them from {{JobManagerOptions}} to {{WebOptions}}
> and removing the prefix {{jobmanager}}.
> This is done as requested by
> https://github.com/apache/flink/pull/4492#issuecomment-321271819.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7408) Extract WebRuntimeMonitor options from JobManagerOptions
[
https://issues.apache.org/jira/browse/FLINK-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122998#comment-16122998
]
ASF GitHub Bot commented on FLINK-7408:
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4512
Merging this PR.
> Extract WebRuntimeMonitor options from JobManagerOptions
>
>
> Key: FLINK-7408
> URL: https://issues.apache.org/jira/browse/FLINK-7408
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
>
> With the Flip-6 code changes, the {{WebRuntimeMonitor}} won't run exclusively
> next to the {{JobManager}}. Therefore, it makes sense to refactor the web
> monitor options and moving them from {{JobManagerOptions}} to {{WebOptions}}
> and removing the prefix {{jobmanager}}.
> This is done as requested by
> https://github.com/apache/flink/pull/4492#issuecomment-321271819.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7408) Extract WebRuntimeMonitor options from JobManagerOptions
[
https://issues.apache.org/jira/browse/FLINK-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121803#comment-16121803
]
ASF GitHub Bot commented on FLINK-7408:
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4512
Thanks for the review @zentol. You're right that we should remove the
`key()` method calls.
> Extract WebRuntimeMonitor options from JobManagerOptions
>
>
> Key: FLINK-7408
> URL: https://issues.apache.org/jira/browse/FLINK-7408
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
>
> With the Flip-6 code changes, the {{WebRuntimeMonitor}} won't run exclusively
> next to the {{JobManager}}. Therefore, it makes sense to refactor the web
> monitor options and moving them from {{JobManagerOptions}} to {{WebOptions}}
> and removing the prefix {{jobmanager}}.
> This is done as requested by
> https://github.com/apache/flink/pull/4492#issuecomment-321271819.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7408) Extract WebRuntimeMonitor options from JobManagerOptions
[
https://issues.apache.org/jira/browse/FLINK-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121477#comment-16121477
]
ASF GitHub Bot commented on FLINK-7408:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4512#discussion_r132426175
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
---
@@ -388,7 +388,7 @@ abstract class FlinkMiniCluster(
: Option[WebMonitor] = {
if(
config.getBoolean(ConfigConstants.LOCAL_START_WEBSERVER, false) &&
-config.getInteger(JobManagerOptions.WEB_PORT.key(), 0) >= 0) {
+config.getInteger(WebOptions.PORT.key(), 0) >= 0) {
--- End diff --
you can drop the call to `key()`.
> Extract WebRuntimeMonitor options from JobManagerOptions
>
>
> Key: FLINK-7408
> URL: https://issues.apache.org/jira/browse/FLINK-7408
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
>
> With the Flip-6 code changes, the {{WebRuntimeMonitor}} won't run exclusively
> next to the {{JobManager}}. Therefore, it makes sense to refactor the web
> monitor options and moving them from {{JobManagerOptions}} to {{WebOptions}}
> and removing the prefix {{jobmanager}}.
> This is done as requested by
> https://github.com/apache/flink/pull/4492#issuecomment-321271819.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7408) Extract WebRuntimeMonitor options from JobManagerOptions
[
https://issues.apache.org/jira/browse/FLINK-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121480#comment-16121480
]
ASF GitHub Bot commented on FLINK-7408:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4512#discussion_r132426305
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -2216,7 +2216,7 @@ object JobManager {
: (ActorRef, ActorRef, Option[WebMonitor], Option[ActorRef]) = {
val webMonitor: Option[WebMonitor] =
- if (configuration.getInteger(JobManagerOptions.WEB_PORT.key(), 0) >=
0) {
+ if (configuration.getInteger(WebOptions.PORT.key(), 0) >= 0) {
--- End diff --
drop call to `key()`
> Extract WebRuntimeMonitor options from JobManagerOptions
>
>
> Key: FLINK-7408
> URL: https://issues.apache.org/jira/browse/FLINK-7408
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
>
> With the Flip-6 code changes, the {{WebRuntimeMonitor}} won't run exclusively
> next to the {{JobManager}}. Therefore, it makes sense to refactor the web
> monitor options and moving them from {{JobManagerOptions}} to {{WebOptions}}
> and removing the prefix {{jobmanager}}.
> This is done as requested by
> https://github.com/apache/flink/pull/4492#issuecomment-321271819.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7408) Extract WebRuntimeMonitor options from JobManagerOptions
[
https://issues.apache.org/jira/browse/FLINK-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121478#comment-16121478
]
ASF GitHub Bot commented on FLINK-7408:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4512#discussion_r132426290
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtils.java
---
@@ -104,8 +105,8 @@ public static Configuration loadConfiguration(String
workingDirectory, Map= 0) {
- configuration.setInteger(JobManagerOptions.WEB_PORT, 0);
+ if (configuration.getInteger(WebOptions.PORT.key(), 0) >= 0) {
--- End diff --
drop call to `key()`
> Extract WebRuntimeMonitor options from JobManagerOptions
>
>
> Key: FLINK-7408
> URL: https://issues.apache.org/jira/browse/FLINK-7408
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
>
> With the Flip-6 code changes, the {{WebRuntimeMonitor}} won't run exclusively
> next to the {{JobManager}}. Therefore, it makes sense to refactor the web
> monitor options and moving them from {{JobManagerOptions}} to {{WebOptions}}
> and removing the prefix {{jobmanager}}.
> This is done as requested by
> https://github.com/apache/flink/pull/4492#issuecomment-321271819.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7408) Extract WebRuntimeMonitor options from JobManagerOptions
[
https://issues.apache.org/jira/browse/FLINK-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121475#comment-16121475
]
ASF GitHub Bot commented on FLINK-7408:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4512#discussion_r132426478
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -214,7 +214,7 @@ public WebRuntimeMonitor(
ExecutionContextExecutor context =
ExecutionContext$.MODULE$.fromExecutor(executorService);
// Config to enable https access to the web-ui
- boolean enableSSL =
config.getBoolean(JobManagerOptions.WEB_SSL_ENABLED) &&
SSLUtils.getSSLEnabled(config);
+ boolean enableSSL = config.getBoolean(WebOptions.SSL_ENABLED)
&&SSLUtils.getSSLEnabled(config);
--- End diff --
whitespace after `&&` seems off.
> Extract WebRuntimeMonitor options from JobManagerOptions
>
>
> Key: FLINK-7408
> URL: https://issues.apache.org/jira/browse/FLINK-7408
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
>
> With the Flip-6 code changes, the {{WebRuntimeMonitor}} won't run exclusively
> next to the {{JobManager}}. Therefore, it makes sense to refactor the web
> monitor options and moving them from {{JobManagerOptions}} to {{WebOptions}}
> and removing the prefix {{jobmanager}}.
> This is done as requested by
> https://github.com/apache/flink/pull/4492#issuecomment-321271819.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7408) Extract WebRuntimeMonitor options from JobManagerOptions
[
https://issues.apache.org/jira/browse/FLINK-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121476#comment-16121476
]
ASF GitHub Bot commented on FLINK-7408:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4512#discussion_r132426338
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
---
@@ -188,7 +189,7 @@ public static WebMonitor startWebMonitorIfConfigured(
config.setString(JobManagerOptions.ADDRESS,
address.host().get());
config.setInteger(JobManagerOptions.PORT,
Integer.parseInt(address.port().get().toString()));
- if (config.getInteger(JobManagerOptions.WEB_PORT.key(), 0) >=
0) {
+ if (config.getInteger(WebOptions.PORT.key(), 0) >= 0) {
--- End diff --
drop call to `key()`
> Extract WebRuntimeMonitor options from JobManagerOptions
>
>
> Key: FLINK-7408
> URL: https://issues.apache.org/jira/browse/FLINK-7408
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
>
> With the Flip-6 code changes, the {{WebRuntimeMonitor}} won't run exclusively
> next to the {{JobManager}}. Therefore, it makes sense to refactor the web
> monitor options and moving them from {{JobManagerOptions}} to {{WebOptions}}
> and removing the prefix {{jobmanager}}.
> This is done as requested by
> https://github.com/apache/flink/pull/4492#issuecomment-321271819.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7408) Extract WebRuntimeMonitor options from JobManagerOptions
[
https://issues.apache.org/jira/browse/FLINK-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121479#comment-16121479
]
ASF GitHub Bot commented on FLINK-7408:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4512#discussion_r132426263
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java
---
@@ -510,8 +511,8 @@ private static Configuration createConfiguration(String
baseDirectory, Map= 0) {
- configuration.setInteger(JobManagerOptions.WEB_PORT, 0);
+ if (configuration.getInteger(WebOptions.PORT.key(), 0) >= 0) {
--- End diff --
drop call to `key()`
> Extract WebRuntimeMonitor options from JobManagerOptions
>
>
> Key: FLINK-7408
> URL: https://issues.apache.org/jira/browse/FLINK-7408
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
>
> With the Flip-6 code changes, the {{WebRuntimeMonitor}} won't run exclusively
> next to the {{JobManager}}. Therefore, it makes sense to refactor the web
> monitor options and moving them from {{JobManagerOptions}} to {{WebOptions}}
> and removing the prefix {{jobmanager}}.
> This is done as requested by
> https://github.com/apache/flink/pull/4492#issuecomment-321271819.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7408) Extract WebRuntimeMonitor options from JobManagerOptions
[
https://issues.apache.org/jira/browse/FLINK-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121372#comment-16121372
]
ASF GitHub Bot commented on FLINK-7408:
---
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4512
[FLINK-7408] [conf] Create WebOptions for WebRuntimeMonitor
## What is the purpose of the change
This commit moves the WebRuntimeMonitor related configuration options from
JobManagerOptions to WebOptions. Moreover, it removes the prefix jobmanager.
As you've requested @zentol.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink portWebMonitorOptions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4512.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4512
commit 34c0fcb40f9704f6eab6a9cc520e9a27b91ff0d0
Author: Till Rohrmann
Date: 2017-08-10T09:42:09Z
[FLINK-7408] [conf] Create WebOptions for WebRuntimeMonitor
This commit moves the WebRuntimeMonitor related configuration options from
JobManagerOptions to WebOptions. Moreover, it removes the prefix jobmanager.
> Extract WebRuntimeMonitor options from JobManagerOptions
>
>
> Key: FLINK-7408
> URL: https://issues.apache.org/jira/browse/FLINK-7408
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.4.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Trivial
>
> With the Flip-6 code changes, the {{WebRuntimeMonitor}} won't run exclusively
> next to the {{JobManager}}. Therefore, it makes sense to refactor the web
> monitor options and moving them from {{JobManagerOptions}} to {{WebOptions}}
> and removing the prefix {{jobmanager}}.
> This is done as requested by
> https://github.com/apache/flink/pull/4492#issuecomment-321271819.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
