[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r699250923 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitRetrier.java ## @@ -0,0 +1,84 @@ +/* + *

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r699524495 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java ## @@ -406,8 +406,14 @@

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698508026 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/sink/GlobalBatchCommitterHandlerTest.java ## @@ -44,16

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r699384463 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java ## @@ -183,62 +181,83 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r699262279 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java ## @@ -141,13 +138,15 @@

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r699253994 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java ## @@ -226,11 +236,12 @@

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r699250923 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitRetrier.java ## @@ -0,0 +1,84 @@ +/* + *

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698558016 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaTransactionLogITCase.java ## @@ -17,7 +17,8

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698558016 ## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaTransactionLogITCase.java ## @@ -17,7 +17,8

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698557571 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java ## @@ -327,41 +346,43 @@

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698546414 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java ## @@ -183,62 +181,83 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698545675 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java ## @@ -183,62 +181,83 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698539256 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java ## @@ -183,62 +181,83 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698535910 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java ## @@ -164,13 +163,12 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698522877 ## File path: flink-connectors/flink-connector-kafka/pom.xml ## @@ -124,6 +124,12 @@ under the License. test +

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698522463 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/FlinkKafkaInternalProducer.java ## @@ -36,25

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698520700 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/FlinkKafkaInternalProducer.java ## @@ -86,6

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698510559 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java ## @@ -174,6 +174,9 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698509422 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/FlinkKafkaInternalProducer.java ## @@ -47,6

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698508026 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/sink/GlobalBatchCommitterHandlerTest.java ## @@ -44,16

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698445334 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/GlobalStreamingCommitterHandler.java ## @@ -60,27

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698402630 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitRetryer.java ## @@ -0,0 +1,65 @@ +/* + *

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698395936 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/AbstractCommitterHandler.java ## @@ -19,18 +19,58 @@

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698393854 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java ## @@ -91,12 +106,14 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r698393164 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamOperatorStateContext.java ## @@ -31,9 +31,17 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r697712620 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java ## @@ -254,11 +254,9 @@ private void