[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-10-24 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r735267747 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-10-02 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r720673107 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-10-02 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r720673107 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-10-02 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r720667956 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-09-24 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r715486971 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-09-23 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r714616649 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-09-23 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r714616649 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-09-22 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r713954142 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-09-22 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r713951668 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-09-22 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r713951668 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-09-22 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r713951668 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-09-22 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r713675261 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-09-22 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r713675261 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-09-22 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r713665638 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-09-22 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r713637141 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-09-21 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r713600160 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@