[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API
WencongLiu commented on code in PR #23026: URL: https://github.com/apache/flink/pull/23026#discussion_r1283910488 ## flink-examples/flink-examples-batch/pom.xml: ## @@ -48,25 +48,6 @@ under the License. - - - org.apache.maven.plugins - maven-compiler-plugin - - - compile - process-sources - - compile - - - -Xlint:deprecation - true - - - - - Review Comment: 1. The classes in `flink-examples-batch` module is still utilized for testing purpose. I have added the warning log in all batch example classes to remind the developer that the DataSet API is deprecated. I also have added the note to `bin.xml` in `flink-disk` module to explain the batch examples in example package is only for tests. I have create an issue [FLINK-32642](https://issues.apache.org/jira/browse/FLINK-32742) to track the removal of `flink-examples-batch` module. 2. I have created an issue [FLINK-32741](https://issues.apache.org/jira/browse/FLINK-32741) to track the removal of DataSet related documentations. Currently the issue is assigned to @pegasas . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API
WencongLiu commented on code in PR #23026:
URL: https://github.com/apache/flink/pull/23026#discussion_r1283959998
##
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##
@@ -544,6 +544,13 @@ public ExecutionConfig setExecutionRetryDelay(long
executionRetryDelay) {
* The default execution mode is {@link ExecutionMode#PIPELINED}.
*
* @param executionMode The execution mode to use.
+ * @deprecated The {@link ExecutionMode} is deprecated because it's only
used in DataSet APIs.
+ * All Flink DataSet APIs are deprecated since Flink 1.18 and will be
removed in a future
+ * Flink major version. You can still build your application in
DataSet, but you should move
+ * to either the DataStream and/or Table API.
+ * @see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741;>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API
*/
public void setExecutionMode(ExecutionMode executionMode) {
Review Comment:
The annotation is added.
##
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java:
##
@@ -77,12 +80,23 @@
* Broadcast variables in bulk iterations
* Custom Java objects (POJOs)
*
+ *
+ * Note: All Flink DataSet APIs are deprecated since Flink 1.18 and will be
removed in a future
+ * Flink major version. You can still build your application in DataSet, but
you should move to
+ * either the DataStream and/or Table API. This class is retained for testing
purposes.
*/
@SuppressWarnings("serial")
public class KMeans {
+private static final Logger LOGGER = LoggerFactory.getLogger(KMeans.class);
+
public static void main(String[] args) throws Exception {
+LOGGER.warn(
+"All Flink DataSet APIs are deprecated since Flink 1.18 and
will be removed in a future"
++ " Flink major version. You can still build your
application in DataSet, but you should move to"
++ " either the DataStream and/or Table API. This class
is retained for testing purposes.");
Review Comment:
I have added a static String instant DATASET_DEPRECATION_INFO to contain the
message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API
WencongLiu commented on code in PR #23026:
URL: https://github.com/apache/flink/pull/23026#discussion_r1283910488
##
flink-examples/flink-examples-batch/pom.xml:
##
@@ -48,25 +48,6 @@ under the License.
-
-
- org.apache.maven.plugins
- maven-compiler-plugin
-
-
- compile
- process-sources
-
- compile
-
-
-
-Xlint:deprecation
-
true
-
-
-
-
-
Review Comment:
1. The classes in `flink-examples-batch` module is still utilized for
testing purpose. I have added the warning log in all batch example classes to
remind the developer that the DataSet API is deprecated. I also have added the
note to `bin.xml` in `flink-disk` module to explain the batch examples in
example package is only for tests.
2. I have created an issue
[FLINK-32741](https://issues.apache.org/jira/browse/FLINK-32741) to track the
removal of DataSet related documentations. Currently the issue is assigned to
@pegasas .
##
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##
@@ -556,7 +556,14 @@ public void setExecutionMode(ExecutionMode executionMode) {
* The default execution mode is {@link ExecutionMode#PIPELINED}.
*
* @return The execution mode for the program.
+ * @deprecated All Flink DataSet APIs are deprecated since Flink 1.18 and
will be removed in a
+ * future Flink major version. You can still build your application in
DataSet, but you
+ * should move to either the DataStream and/or Table API.
+ * @see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741;>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API
*/
+@Deprecated
Review Comment:
1. `ExecutionMode` and `setExecutionMode ` are both deprecated.
2. The class JavaDoc of execution mode is updated.
##
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##
@@ -913,6 +920,18 @@ public LinkedHashSet> getRegisteredPojoTypes() {
return registeredPojoTypes;
}
+/**
+ * Get if the auto type registration is disabled.
+ *
+ * @return if the auto type registration is disabled.
+ * @deprecated All Flink DataSet APIs are deprecated since Flink 1.18 and
will be removed in a
+ * future Flink major version. You can still build your application in
DataSet, but you
+ * should move to either the DataStream and/or Table API.
+ * @see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741;>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API
+ */
+@Deprecated
Review Comment:
Both `disableAutoTypeRegistration ` and `AUTO_TYPE_REGISTRATION ` are
deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API
WencongLiu commented on code in PR #23026:
URL: https://github.com/apache/flink/pull/23026#discussion_r1283910551
##
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##
@@ -913,6 +920,18 @@ public LinkedHashSet> getRegisteredPojoTypes() {
return registeredPojoTypes;
}
+/**
+ * Get if the auto type registration is disabled.
+ *
+ * @return if the auto type registration is disabled.
+ * @deprecated All Flink DataSet APIs are deprecated since Flink 1.18 and
will be removed in a
+ * future Flink major version. You can still build your application in
DataSet, but you
+ * should move to either the DataStream and/or Table API.
+ * @see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741;>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API
+ */
+@Deprecated
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API
WencongLiu commented on code in PR #23026:
URL: https://github.com/apache/flink/pull/23026#discussion_r1283910579
##
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##
@@ -544,6 +544,13 @@ public ExecutionConfig setExecutionRetryDelay(long
executionRetryDelay) {
* The default execution mode is {@link ExecutionMode#PIPELINED}.
*
* @param executionMode The execution mode to use.
+ * @deprecated The {@link ExecutionMode} is deprecated because it's only
used in DataSet APIs.
+ * All Flink DataSet APIs are deprecated since Flink 1.18 and will be
removed in a future
+ * Flink major version. You can still build your application in
DataSet, but you should move
+ * to either the DataStream and/or Table API.
+ * @see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741;>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API
*/
public void setExecutionMode(ExecutionMode executionMode) {
Review Comment:
Fixed.
##
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java:
##
@@ -77,12 +80,23 @@
* Broadcast variables in bulk iterations
* Custom Java objects (POJOs)
*
+ *
+ * Note: All Flink DataSet APIs are deprecated since Flink 1.18 and will be
removed in a future
+ * Flink major version. You can still build your application in DataSet, but
you should move to
+ * either the DataStream and/or Table API. This class is retained for testing
purposes.
*/
@SuppressWarnings("serial")
public class KMeans {
+private static final Logger LOGGER = LoggerFactory.getLogger(KMeans.class);
+
public static void main(String[] args) throws Exception {
+LOGGER.warn(
+"All Flink DataSet APIs are deprecated since Flink 1.18 and
will be removed in a future"
++ " Flink major version. You can still build your
application in DataSet, but you should move to"
++ " either the DataStream and/or Table API. This class
is retained for testing purposes.");
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API
WencongLiu commented on code in PR #23026:
URL: https://github.com/apache/flink/pull/23026#discussion_r1283910526
##
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##
@@ -556,7 +556,14 @@ public void setExecutionMode(ExecutionMode executionMode) {
* The default execution mode is {@link ExecutionMode#PIPELINED}.
*
* @return The execution mode for the program.
+ * @deprecated All Flink DataSet APIs are deprecated since Flink 1.18 and
will be removed in a
+ * future Flink major version. You can still build your application in
DataSet, but you
+ * should move to either the DataStream and/or Table API.
+ * @see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741;>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API
*/
+@Deprecated
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API
WencongLiu commented on code in PR #23026:
URL: https://github.com/apache/flink/pull/23026#discussion_r1283910595
##
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java:
##
@@ -77,12 +80,23 @@
* Broadcast variables in bulk iterations
* Custom Java objects (POJOs)
*
+ *
+ * Note: All Flink DataSet APIs are deprecated since Flink 1.18 and will be
removed in a future
+ * Flink major version. You can still build your application in DataSet, but
you should move to
+ * either the DataStream and/or Table API. This class is retained for testing
purposes.
*/
@SuppressWarnings("serial")
public class KMeans {
+private static final Logger LOGGER = LoggerFactory.getLogger(KMeans.class);
+
public static void main(String[] args) throws Exception {
+LOGGER.warn(
+"All Flink DataSet APIs are deprecated since Flink 1.18 and
will be removed in a future"
++ " Flink major version. You can still build your
application in DataSet, but you should move to"
++ " either the DataStream and/or Table API. This class
is retained for testing purposes.");
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API
WencongLiu commented on code in PR #23026:
URL: https://github.com/apache/flink/pull/23026#discussion_r1283910488
##
flink-examples/flink-examples-batch/pom.xml:
##
@@ -48,25 +48,6 @@ under the License.
-
-
- org.apache.maven.plugins
- maven-compiler-plugin
-
-
- compile
- process-sources
-
- compile
-
-
-
-Xlint:deprecation
-
true
-
-
-
-
-
Review Comment:
Fixed.
##
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##
@@ -556,7 +556,14 @@ public void setExecutionMode(ExecutionMode executionMode) {
* The default execution mode is {@link ExecutionMode#PIPELINED}.
*
* @return The execution mode for the program.
+ * @deprecated All Flink DataSet APIs are deprecated since Flink 1.18 and
will be removed in a
+ * future Flink major version. You can still build your application in
DataSet, but you
+ * should move to either the DataStream and/or Table API.
+ * @see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741;>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API
*/
+@Deprecated
Review Comment:
Fixed.
##
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##
@@ -913,6 +920,18 @@ public LinkedHashSet> getRegisteredPojoTypes() {
return registeredPojoTypes;
}
+/**
+ * Get if the auto type registration is disabled.
+ *
+ * @return if the auto type registration is disabled.
+ * @deprecated All Flink DataSet APIs are deprecated since Flink 1.18 and
will be removed in a
+ * future Flink major version. You can still build your application in
DataSet, but you
+ * should move to either the DataStream and/or Table API.
+ * @see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741;>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API
+ */
+@Deprecated
Review Comment:
Fixed.
##
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##
@@ -544,6 +544,13 @@ public ExecutionConfig setExecutionRetryDelay(long
executionRetryDelay) {
* The default execution mode is {@link ExecutionMode#PIPELINED}.
*
* @param executionMode The execution mode to use.
+ * @deprecated The {@link ExecutionMode} is deprecated because it's only
used in DataSet APIs.
+ * All Flink DataSet APIs are deprecated since Flink 1.18 and will be
removed in a future
+ * Flink major version. You can still build your application in
DataSet, but you should move
+ * to either the DataStream and/or Table API.
+ * @see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741;>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API
*/
public void setExecutionMode(ExecutionMode executionMode) {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
