[GitHub] [flink] XComp commented on a diff in pull request #22794: [FLINK-25002][build] Add java 17 add-opens/add-exports JVM arguments

XComp commented on code in PR #22794: URL: https://github.com/apache/flink/pull/22794#discussion_r1232031873 ## flink-dist/src/main/resources/flink-conf.yaml: ## @@ -16,6 +16,7 @@ # limitations under the License.

[GitHub] [flink] XComp commented on a diff in pull request #22794: [FLINK-25002][build] Add java 17 add-opens/add-exports JVM arguments

XComp commented on code in PR #22794: URL: https://github.com/apache/flink/pull/22794#discussion_r1231921789 ## flink-python/pyflink/pyflink_gateway_server.py: ## @@ -254,8 +254,10 @@ def launch_gateway_server_process(env, args): [construct_flink_classpath(env),

[GitHub] [flink] XComp commented on a diff in pull request #22794: [FLINK-25002][build] Add java 17 add-opens/add-exports JVM arguments

XComp commented on code in PR #22794: URL: https://github.com/apache/flink/pull/22794#discussion_r1231879226 ## .mvn/jvm.config: ## @@ -1 +1,7 @@ -XX:+IgnoreUnrecognizedVMOptions Review Comment: I see, I didn't check that it's restricted - fair enough. -- This is an

[GitHub] [flink] XComp commented on a diff in pull request #22794: [FLINK-25002][build] Add java 17 add-opens/add-exports JVM arguments

XComp commented on code in PR #22794: URL: https://github.com/apache/flink/pull/22794#discussion_r1231118109 ## .mvn/jvm.config: ## @@ -1 +1,7 @@ -XX:+IgnoreUnrecognizedVMOptions +--add-exports=java.security.jgss/sun.security.krb5=ALL-UNNAMED Review Comment: I mean what

[GitHub] [flink] XComp commented on a diff in pull request #22794: [FLINK-25002][build] Add java 17 add-opens/add-exports JVM arguments

XComp commented on code in PR #22794: URL: https://github.com/apache/flink/pull/22794#discussion_r1231055996 ## flink-dist/src/main/resources/flink-conf.yaml: ## @@ -16,6 +16,7 @@ # limitations under the License. Review Comment: ```suggestion # limitations under the

[GitHub] [flink] XComp commented on a diff in pull request #22794: [FLINK-25002][build] Add java 17 add-opens/add-exports JVM arguments

XComp commented on code in PR #22794: URL: https://github.com/apache/flink/pull/22794#discussion_r1231053607 ## pom.xml: ## @@ -196,6 +196,12 @@ under the License. */ + Review Comment: It's beautiful -- This is an automated message