[GitHub] [flink] fsk119 commented on a diff in pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

2023-01-28 Thread via GitHub
fsk119 commented on code in PR #21717: URL: https://github.com/apache/flink/pull/21717#discussion_r1089677325 ## flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/ExecutorImplITCase.java: ## @@ -414,50 +462,130 @@ void testStopJob() throws

[GitHub] [flink] fsk119 commented on a diff in pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

2023-01-23 Thread via GitHub
fsk119 commented on code in PR #21717: URL: https://github.com/apache/flink/pull/21717#discussion_r1083995101 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/message/session/ConfigureSessionRequestBody.java: ## @@ -39,6 +39,10 @@ public class

[GitHub] [flink] fsk119 commented on a diff in pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

2023-01-19 Thread GitBox
fsk119 commented on code in PR #21717: URL: https://github.com/apache/flink/pull/21717#discussion_r1082055861 ## flink-table/flink-sql-client/src/test/resources/sql/table.q: ## @@ -79,7 +79,10 @@ show tables; # test SHOW CREATE TABLE show create table orders; -CREATE TABLE