[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-07-01 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1249015509 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayElementOutputTypeStrategy.java: ## @@ -1,47 +0,0 @@ -/* - *

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-07-01 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1249022952 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-07-01 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1249015509 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayElementOutputTypeStrategy.java: ## @@ -1,47 +0,0 @@ -/* - *

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1248318340 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1248317688 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -303,7 +302,7 @@ ANY,

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1248317688 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -303,7 +302,7 @@ ANY,

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247961308 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247961308 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247961308 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247936489 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247936489 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247936489 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247936489 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247920168 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247910219 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247910219 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247910219 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247903483 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247903483 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247887335 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247887335 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247882335 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayElementOutputTypeStrategy.java: ## @@ -1,47 +0,0 @@ -/* - *

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247882335 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayElementOutputTypeStrategy.java: ## @@ -1,47 +0,0 @@ -/* - *

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247859173 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247859173 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247859173 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247859173 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247843799 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247841188 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247833079 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-06-30 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1247822858 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -632,7 +632,8 @@ private Stream