[GitHub] [flink] shenzhu commented on pull request #17788: [FLINK-15826][Tabel SQL/API] Add renameFunction() to Catalog

2022-02-27 Thread GitBox
shenzhu commented on pull request #17788: URL: https://github.com/apache/flink/pull/17788#issuecomment-1053767381 Hey @wuchong , would you mind taking a look at this PR when you have a moment? Thanks! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] shenzhu commented on pull request #17788: [FLINK-15826][Tabel SQL/API] Add renameFunction() to Catalog

2021-11-30 Thread GitBox
shenzhu commented on pull request #17788: URL: https://github.com/apache/flink/pull/17788#issuecomment-983287432 > @shenzhu My PR was merged now. If you rebase I think those violations should not show up anymore. Hey @Airblader , thanks for your PR! I just rebased my code, would you

[GitHub] [flink] shenzhu commented on pull request #17788: [FLINK-15826][Tabel SQL/API] Add renameFunction() to Catalog

2021-11-29 Thread GitBox
shenzhu commented on pull request #17788: URL: https://github.com/apache/flink/pull/17788#issuecomment-982309892 Hey @Airblader , I got some architecture tests failing for this PR, the failing messages are as follows ``` java.lang.AssertionError: Architecture Violation

[GitHub] [flink] shenzhu commented on pull request #17788: [FLINK-15826][Tabel SQL/API] Add renameFunction() to Catalog

2021-11-25 Thread GitBox
shenzhu commented on pull request #17788: URL: https://github.com/apache/flink/pull/17788#issuecomment-979761896 Hey @JingsongLi , thanks for assigning the ticket to me! Would you mind taking a look at this PR when you have a moment? -- This is an automated message from the Apache Git

[GitHub] [flink] shenzhu commented on pull request #17788: [FLINK-15826][Tabel SQL/API] Add renameFunction() to Catalog

2021-11-15 Thread GitBox
shenzhu commented on pull request #17788: URL: https://github.com/apache/flink/pull/17788#issuecomment-969977283 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] shenzhu commented on pull request #17788: [FLINK-15826][Tabel SQL/API] Add renameFunction() to Catalog

2021-11-15 Thread GitBox
shenzhu commented on pull request #17788: URL: https://github.com/apache/flink/pull/17788#issuecomment-969976164 > ## CI report: > * [b59b4a5](https://github.com/apache/flink/commit/b59b4a592c14990f7d916fa116d0a1cc8f5ed085) Azure: