xuzhiwen1255 commented on PR #22010:
URL: https://github.com/apache/flink/pull/22010#issuecomment-1637414390
> I'm not a big fan of adding tests that belong in a PR into a separate PR.
You could just create the test class in this PR with the set of tests that fit
to this PR. PR #21971
xuzhiwen1255 commented on PR #22010:
URL: https://github.com/apache/flink/pull/22010#issuecomment-1566386306
> > I think about it, the change of parallelism already exists in the
existing unit test, I think we don't need to add the test, because it already
includes the complete generated
xuzhiwen1255 commented on PR #22010:
URL: https://github.com/apache/flink/pull/22010#issuecomment-1484436957
@reswqa CI is fine now, can you come over and have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
xuzhiwen1255 commented on PR #22010:
URL: https://github.com/apache/flink/pull/22010#issuecomment-1463436077
@reswqa Re-running the cli is no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
xuzhiwen1255 commented on PR #22010:
URL: https://github.com/apache/flink/pull/22010#issuecomment-1463322542
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
xuzhiwen1255 commented on PR #22010:
URL: https://github.com/apache/flink/pull/22010#issuecomment-1442997250
@reswqa Can you review it for me, Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
