[GitHub] flink issue #5068: [FLINK-8122] [table] Name all built-in table sinks and so...

2018-01-04 Thread twalthr 
Github user twalthr commented on the issue:

https://github.com/apache/flink/pull/5068
  
Thank you @xccui. I will merge this...


---

[GitHub] flink issue #5068: [FLINK-8122] [table] Name all built-in table sinks and so...

2017-12-14 Thread xccui 
Github user xccui commented on the issue:

https://github.com/apache/flink/pull/5068
  
Hi @fhueske and @twalthr, I wonder if you could have a look at the latest 
update. Thanks!


---

[GitHub] flink issue #5068: [FLINK-8122] [table] Name all built-in table sinks and so...

2017-12-07 Thread xccui 
Github user xccui commented on the issue:

https://github.com/apache/flink/pull/5068
  
Thanks for the review @fhueske.
* I added the `explainSink()` method to make the `TableSink` consistent 
with the `TableSource`. Discarding this method and using the 
`TableConnectorUtil.genRuntimeName()` in each table sink should also be OK.
* Yes, the test sources and sinks are not exposed. I'll revert them.
* The source name was set via this call 
`execEnv.createInput(orcIF).name(explainSource())`. The `createInput()` method 
for a **mocked** `execEnv` will return `null` and cause a NPE.

Thanks,
Xingcan


---

[GitHub] flink issue #5068: [FLINK-8122] [table] Name all built-in table sinks and so...

2017-12-04 Thread xccui 
Github user xccui commented on the issue:

https://github.com/apache/flink/pull/5068
  
Hi @fhueske, do you think the PR needs some other updates? 


---