[GitHub] flink issue #5632: [FLINK-8843][REST] Decouple bind REST address from advert...

2018-03-13 Thread GJL
Github user GJL commented on the issue:

https://github.com/apache/flink/pull/5632
  
I'll verify the changes @yanghua 


---


[GitHub] flink issue #5632: [FLINK-8843][REST] Decouple bind REST address from advert...

2018-03-13 Thread tillrohrmann
Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/5632
  
Thanks for the PR @yanghua, I'll take a look asap.


---


[GitHub] flink issue #5632: [FLINK-8843][REST] Decouple bind REST address from advert...

2018-03-13 Thread yanghua
Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/5632
  
hi @tillrohrmann I think you should review this PR and add it to 1.5 
version as a hotfix. Because I just download the release-1.5 branch. And 
install it as standalone-session mode. But the general config in 
`flink-conf.yaml` can not let me access the web frontend with the JM server's 
remote IP(I access from remote node's browser), and I run command `netstat -anp 
| grep 8081` shows : 

```
tcp0  0 127.0.0.1:8081  0.0.0.0:*   
LISTEN  130475/java
```

and the log print: 

```
Rest endpoint listening at 127.0.0.:8081
```
and the config item : `jobmanager.web.address` can not fix this problem, 
unless we add the config : 

```
rest.address: 0.0.0.0
```

to override the default `localhost` value

but this config item is not in `flink-conf.yaml`, and user may be not 
familiar with it.

And I think if we do not change this config's default value, it will 
confuse users.



---


[GitHub] flink issue #5632: [FLINK-8843][REST] Decouple bind REST address from advert...

2018-03-07 Thread yanghua
Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/5632
  
hi @zentol , it seems @tillrohrmann has no free time recently. Would you 
please review this?


---