Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1898#issuecomment-219910631
Thanks for the review @tillrohrmann
I need to find a markdown editor with spell check...
---
If your project is set up for it, you can reply to this email
Github user rawkintrevo commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r63605367
--- Diff: docs/apis/batch/libs/ml/cross_validation.md ---
@@ -0,0 +1,175 @@
+---
+mathjax: include
+title: Cross Validation
+
+# Sub
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1898#issuecomment-219696697
As you've said, the failing test case is unrelated and therefore not a
problem.
---
If your project is set up for it, you can reply to this email and have your
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1898#issuecomment-219696600
The PR looks really good @rawkintrevo. I had some minor comments. Once they
are fixed, we should be good to merge this PR :-)
---
If your project is set up for
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r63508795
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala
---
@@ -0,0 +1,102 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r63508672
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,210 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r63498454
--- Diff: docs/apis/batch/libs/ml/index.md ---
@@ -86,10 +87,18 @@ Now you can start solving your analysis task.
The following code snippet shows
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r63498396
--- Diff: docs/apis/batch/libs/ml/cross_validation.md ---
@@ -0,0 +1,175 @@
+---
+mathjax: include
+title: Cross Validation
+
+# Sub
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r63498199
--- Diff: docs/apis/batch/libs/ml/cross_validation.md ---
@@ -0,0 +1,175 @@
+---
+mathjax: include
+title: Cross Validation
+
+# Sub
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r63498117
--- Diff: docs/apis/batch/libs/ml/cross_validation.md ---
@@ -0,0 +1,175 @@
+---
+mathjax: include
+title: Cross Validation
+
+# Sub
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r63498002
--- Diff: docs/apis/batch/libs/ml/cross_validation.md ---
@@ -0,0 +1,175 @@
+---
+mathjax: include
+title: Cross Validation
+
+# Sub
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r63497505
--- Diff: docs/apis/batch/libs/ml/cross_validation.md ---
@@ -0,0 +1,175 @@
+---
+mathjax: include
+title: Cross Validation
+
+# Sub
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1898#issuecomment-219120765
bump? failing on flaky test, can someone restart/verify/etc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1898#issuecomment-216241912
This should be gtg
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1898#issuecomment-215826478
Hey @tillrohrmann, thanks for the review. I've addressed your commments in
the code. I am in the middle of documentation had to commit. Should finish up
docs this
Github user rawkintrevo commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r61582494
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the
Github user rawkintrevo commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r61504020
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user rawkintrevo commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r61503436
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1898#issuecomment-213434810
Thanks for your contribution @rawkintrevo. Good work. I had some minor
inline comments. I'm mainly concerned about the efficiency of
`multiRandomSplit` because it
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60739883
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60739818
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60739509
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60739425
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60739344
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60739128
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60738935
--- Diff:
flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/SplitterITSuite.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60738627
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60738393
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60738251
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60737947
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60737984
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60736953
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60735615
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60735451
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60733883
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60732832
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60732781
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1898#discussion_r60732457
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/Splitter.scala
---
@@ -0,0 +1,215 @@
+/*
+ * Licensed to
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1898#issuecomment-211507574
Any thoughts on this approach or go ahead and write docs/prepare to merge?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1898#issuecomment-211471397
Yes the failing tests are most likely caused by the build infrastructure.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1898#issuecomment-210728264
One build failed on error: scala.reflect.internal.MissingRequirementError:
object scala.runtime in compiler mirror not found.
Another on some weird YARN
GitHub user rawkintrevo opened a pull request:
https://github.com/apache/flink/pull/1898
[FLINK-2259][ml] Add Train-Testing Splitters
This PR adds an object in ml/pipeline called splitter with the following
methods:
randomSplit: Splits a DataSet into two data sets using
42 matches
Mail list logo
