Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/970
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131579342
Looks good, merging this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131575300
Addressed comments. @StephanEwen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131570789
Aside from the comment above, this looks good. Would merge this, after the
comment is addressed.
---
If your project is set up for it, you can reply to this email an
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131570435
In the `CollectionExecutor`, can you skip creating the `ExecutiorService`?
You can eagerly resolve the path and then put an already finished future into
the map.
--
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131570065
We are indeed falling behind on merging pull requests, right now. Many
committers are on vacation this month, and for the others, the large amount of
pull requests is
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131519550
Reverting back to make this PR only about the distributed cache.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r37144300
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -897,7 +897,7 @@ class TaskManager(
c
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r37144275
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -897,7 +897,7 @@ class TaskManager(
config.ti
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r37144194
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -897,7 +897,7 @@ class TaskManager(
c
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r37144152
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -897,7 +897,7 @@ class TaskManager(
config.ti
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r37143936
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -897,7 +897,7 @@ class TaskManager(
c
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r37143896
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -897,7 +897,7 @@ class TaskManager(
config.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131504643
I decided to go ahead and implement things which touch the Runtime Context
constructors with this PR. This now closes five Jiras, namely 2449, 2458, 2488,
2496 and
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-131496338
I'd like to get this merged soon. This removes multiple constructors for
Runtime contexts and establishes a clean hierarchy, making any changes to the
constructors
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-129648092
I've moved the test to an existing MultipleProgramTestBase`. Should be good
to merge now. :)
---
If your project is set up for it, you can reply to this email and
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r36680981
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/CollectionExecutor.java
---
@@ -501,4 +536,22 @@ public int getSuperstepNumber
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-129481422
Looks good, in general.
Can you add the test to one of the other iteration test files? This saves
cluster startup and shutdown costs, making builds faster. Ma
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r36640260
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/CollectionExecutor.java
---
@@ -501,4 +536,22 @@ public int getSuperstepNumber()
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/970#issuecomment-128732528
Addressed PR comments. There is one unrelated failure on the
GroupReduceITCase. I've filed a JIRA for that.
---
If your project is set up for it, you can reply to
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r36513272
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/CollectionExecutor.java
---
@@ -501,4 +536,22 @@ public int getSuperstepNumber
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r36513206
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java
---
@@ -79,7 +68,7 @@ public AbstractRunti
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r36512933
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/CollectionExecutor.java
---
@@ -501,4 +536,22 @@ public int getSuperstepNumber() {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r36512186
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/util/RuntimeUDFContext.java
---
@@ -37,18 +37,17 @@
private final HashMap init
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r36512101
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java
---
@@ -79,7 +68,7 @@ public AbstractRuntimeUDFCon
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/970
[FLINK-2458][FLINK-2449]Access distributed cache entries for
CollectionExecution and in Iterative tasks.
1. This PR adds support for accessing distributed cache entries when
running iteration
26 matches
Mail list logo
