Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/977
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-132118720
Looks good and CI passes.
Will merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-132100631
@StephanEwen
Hi, I`m really very sorry to bother you again.
I just wonder whether this can be merged or I need to do some fix more or
close this PR?
---
If
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-131473233
Ok, I`ve done it.
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/977#discussion_r37086274
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketClientSinkTest.java
---
@@ -0,0
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-131144157
I think this is good, minus two small comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/977#discussion_r37086314
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketClientSinkTest.java
---
@@ -0,0
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-131001646
@StephanEwen
Hi, I did some changes few days ago.
Could you take a look again?
Thank you!
---
If your project is set up for it, you can reply to this emai
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-129854454
@StephanEwen
Hi, I push a new fix about the exception.
Would you please to check whether it`s correct?
And there is another PR(https://github.com/apache/fli
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-129829151
Looks much better. Two more comments:
1. It would be good to print the exception in addition to failing the test,
because otherwise the tests only fails and g
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-129785617
@StephanEwen
Hi,
I fixed all of your reviews but the problem about one thread (for server
and connection).
I just plan to do some complex test late.
So
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/977#discussion_r36714718
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketClientSinkTest.java
---
@@ -0,0 +
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/977#discussion_r36714696
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketClientSinkTest.java
---
@@ -0,0 +
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/977#discussion_r36707683
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketClientSinkTest.java
---
@@ -0,0 +
Github user HuangWHWHW commented on a diff in the pull request:
https://github.com/apache/flink/pull/977#discussion_r36707458
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketClientSinkTest.java
---
@@ -0,0 +
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/977#discussion_r36672245
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketClientSinkTest.java
---
@@ -0,0
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/977#discussion_r36672173
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketClientSinkTest.java
---
@@ -0,0
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/977#discussion_r36671992
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketClientSinkTest.java
---
@@ -0,0
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/977#discussion_r36672088
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketClientSinkTest.java
---
@@ -0,0
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/977#discussion_r36671921
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketClientSinkTest.java
---
@@ -0,0
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-129570014
This test actually does not fail if the sink does not work properly. It
contains no assertions, but only prints the status.
Here are a few points that we try
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-128208126
@rkh
Yes, I asked the travis support too.
They told me that it will be usable within next week hopefully.
Thanks for info.
---
If your project is set up f
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-128200510
Hi,
don`t worry and have a nice vacation!
I`ll fix on the Class documentation and the static ports.
As for the tests, I was considering the case coverage.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-128131074
Hi,
unfortunately the PR still needs a bit of work: The Class documentation
does not match the class. It would be good if the ports where not statically
set since th
Github user rkh commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-128011316
FYI the problems @HuangWHWHW is experiencing with Travis CI stem from our
CDN being blocked in China. We're working on a fix.
---
If your project is set up for it, you can r
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-127982738
Hi, the CI has passed.
Can it be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-127832555
@rmetzger
Hi, Thank you very much.
So,any progress lately?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-127606171
For the Travis problem, I would write an email to supp...@travis-ci.com.
They are very friendly and helpful.
---
If your project is set up for it, you can reply to this
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-127569323
Ok, I opened the jira Issue FLINK-2480.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user HuangWHWHW closed the pull request at:
https://github.com/apache/flink/pull/981
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-127541271
You're welcome. And yes the streaming API is quite a bit newer than the
other code so it is not that well covered with tests. If you want to, you can
open a Jira Issue (
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-127539612
Ok, I`ll remember next time since the new CI has been running already.
It`s very kind of you.
In addition, I found that the test cases of flink-streaming-api are
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-127536235
Don't worry, everyone was a novice once. :smile:
You can do it either way. Either close this PR and we'll look at the other
one or close the other one and update
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-127534169
Sorry, I`m still a novice in using GIT.
So, what about now?
Need I cancel the new PR and push changes here?
---
If your project is set up for it, you can reply
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-127533577
Hi,
you don't need to create a new Pull Request. You can also just push your
changes to your old branch (HuangWHWHW:FLINK-2477 in this case) and then the
Pull Reques
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-127532073
@aljoscha
Thank you for the help and the CI info.
There is some bug in my tests before and I fixed it.
I`ve made a new PR already.
---
If your project is
GitHub user HuangWHWHW opened a pull request:
https://github.com/apache/flink/pull/981
[FLINK-2477][ADD]Add tests for SocketClientSink
Add tests for SocketClientSink.
1.Test SocketClientSink open function:
setup a socket server --> using SocketClientSink to connect the server
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-127522856
Hi,
you can rerun the tests on Travis by changing your commit slightly and
re-pushing it to your branch, for example using:
```bash
git commit --amend
git
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/977#issuecomment-127508946
Hi, I cannot see the CI Details.
Does anyone help?
Problem like this:
