Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1257#issuecomment-155432214
Hi @zentol, this is another step towards the Maven module refactoring that
we decided to do.
I think you can merge this PR to the master branch.
---
If your
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1257#issuecomment-149206297
Looks like you did quite some refactoring e.g. in `FlinkPlanBinder`. Could
you elaborate on your changes besides moving everything to flink-libraries?
Otherwise +1
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1257#issuecomment-149221457
I moved the PythonOperationInfo into a separate file (along with a few
static helper methods). Apart from that i only merged the PlanBinder and
PythonPlanBinder classes
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1257#issuecomment-149232075
Ah, that makes sense and looks much cleaner. Thank you. +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1257
[FLINK-2851] Move PythonAPI to flink-libraries
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink _move_libraries
Alternatively you
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1257#discussion_r42016074
--- Diff:
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonOperationInfo.java
---
@@ -1,3 +1,5 @@
+package
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1257#discussion_r42018555
--- Diff:
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonOperationInfo.java
---
@@ -1,3 +1,5 @@
+package
