Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1469#issuecomment-174946482
Thanks for the update @ChengXiangLi!
PR is good to merge, IMO.
Do you want to do it yourself?
---
If your project is set up for it, you can reply to this
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50511127
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50391192
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -486,11 +518,43 @@ protected boolean
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50385614
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50390858
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTableITCase.java
---
@@ -1534,6 +1534,106 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50385880
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/HashFullOuterJoinBuildFirstDescriptor.java
---
@@ -0,0 +1,66 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50385924
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/HashFullOuterJoinBuildSecondDescriptor.java
---
@@ -0,0 +1,65 @@
+/*
+
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1469#issuecomment-173547539
Thanks for the update and the regression test @ChengXiangLi!
Looks good, only minor changes to do, IMO.
---
If your project is set up for it, you can reply to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50390580
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTableITCase.java
---
@@ -1534,6 +1534,106 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50384749
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -486,11 +518,43 @@ protected boolean
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50381597
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/HashVsSortMiniBenchmark.java
---
@@ -184,7 +184,7 @@ public void
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50495621
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -486,11 +518,43 @@ protected boolean
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50495814
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50232198
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1469#issuecomment-173151704
I did simple regression test based on `HashVsSortMiniBenchmark`, the result
looks like:
Test | Before | After
-- | -- |
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50218331
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -486,11 +518,43 @@ protected boolean
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50219555
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTableITCase.java
---
@@ -1534,6 +1534,106 @@ public void
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50220144
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/HashVsSortMiniBenchmark.java
---
@@ -130,11 +130,11 @@ public void
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50217624
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -486,11 +518,43 @@ protected boolean
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r50220219
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/HashVsSortMiniBenchmark.java
---
@@ -184,7 +184,7 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49726468
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTableITCase.java
---
@@ -1534,6 +1534,106 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49726803
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTableITCase.java
---
@@ -1534,6 +1534,106 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49728566
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/HashVsSortMiniBenchmark.java
---
@@ -184,7 +184,7 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49655894
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -420,15 +440,23 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49656489
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49656473
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49656407
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49656659
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49654822
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/HashFullOuterJoinBuildFirstDescriptor.java
---
@@ -0,0 +1,66 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49656327
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -486,11 +518,43 @@ protected boolean
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49656172
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -486,11 +518,43 @@ protected boolean
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49655529
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/NonReusingBuildFirstHashJoinIterator.java
---
@@ -144,13 +148,20 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49657465
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49657379
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49655245
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/DriverStrategy.java
---
@@ -73,6 +73,8 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49655692
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -57,7 +58,7 @@
*
*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49657059
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49654923
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/HashFullOuterJoinBuildSecondDescriptor.java
---
@@ -0,0 +1,65 @@
+/*
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49655995
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -420,15 +440,23 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49656801
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49656918
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49656863
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1558,7 +1641,209 @@ public void reset() {
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1469#issuecomment-165740727
Thanks for the PR! I will shepherd it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
44 matches
Mail list logo
