Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-187700884
Thanks @rmetzger
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1588
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-187606854
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-186835009
The expected output of the test is the following
```
Test testQueryCluster(org.apache.flink.yarn.YARNSessionFIFOITCase) is
running.
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-186832973
@rmetzger I am trying to reproduce it but so far I cannot. I will keep you
posted.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-186396847
In my private tests and here, `YARNSessionFIFOITCase.testQueryCluster`
failed with a timeout. Something has made this test unstable.
---
If your project is set up for
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-186364227
I started some tests on my travis as well to see whether the one YARN test
failure is a coincidence: https://travis-ci.org/rmetzger/flink/builds/110454166
---
If your
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1588#discussion_r53296170
--- Diff:
flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
---
@@ -436,7 +430,7 @@ public void perJobYarnCluster() {
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1588#discussion_r53296134
--- Diff:
flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
---
@@ -114,9 +108,9 @@ public void testClientStartup() {
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-180847040
Thanks a lot for the comments @rmetzger and @StephanEwen .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-180789530
The fallback behavior here is now different than the original behavior.
I think it would be good to make the fallback the same as before, meaning
to use the
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1588#discussion_r52106077
--- Diff: docs/setup/config.md ---
@@ -211,6 +211,8 @@ The parameters define the behavior of tasks that create
result files.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1588#discussion_r52101633
--- Diff: docs/setup/config.md ---
@@ -211,6 +211,8 @@ The parameters define the behavior of tasks that create
result files.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-180753220
I hope its a coincidence that the YARN tests failed in this PR. If they
fail after your next push again, we have to check if your changes caused the
failure
---
If
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-180753150
I didn't test this myself, but this diff could be sufficient for testing
your change:
```diff
diff --git
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1588
FLINK-2213 Makes the number of vcores per YARN container configurable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink vcores_param
16 matches
Mail list logo
