Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1524
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-184703065
Perfect! Thanks a lot @rmetzger
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-184702790
I tested the change again on a cluster. Everything is working nicely with
YARN.
I'll merge the PR.
---
If your project is set up for it, you can reply to
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r53014739
--- Diff:
flink-yarn/src/main/scala/org/apache/flink/yarn/ApplicationMasterBase.scala ---
@@ -176,6 +184,8 @@ abstract class ApplicationMasterBase {
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r53014234
--- Diff:
flink-yarn/src/main/scala/org/apache/flink/yarn/ApplicationMasterBase.scala ---
@@ -176,6 +184,8 @@ abstract class ApplicationMasterBase {
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-183288223
Thank you.
- ` ./bin/yarn-session.sh -tm 1024 -n 7 -s 2 -Dfs.default-scheme=hdfs:///`
is now working
- Setting the fs.default-scheme to `thisIsWrong` and
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-183330257
Thanks for the comment @rmetzger. I changed the error message. Please
review and let me know.
---
If your project is set up for it, you can reply to this email and have
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-182817638
Thanks @rmetzger for the comment. Will fix it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-182951707
I have updated the PR with the new comments.
Please review the new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-182065768
I identified the following issues:
- Setting the configuration using the yarn session "dynamic properties":
`./bin/yarn-session.sh -n 2
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-182066864
Setting the value to `fs.default-scheme: thisIsWrong:///`
is good:
```
robert@cdh544-master:~/flink/build-target$ ./bin/flink run
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-182054657
I'm testing the change on a cluster (with YARN) to see if everything is
working as expected.
---
If your project is set up for it, you can reply to this email and
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-178507931
Could you explain what more tests do you have in mind? So far I am testing
1) if the scheme provided in the configuration is used when one is not
explicitly provided, 2)
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r51123237
--- Diff:
flink-core/src/test/java/org/apache/flink/configuration/GlobalConfigurationTest.java
---
@@ -19,13 +19,19 @@
package
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-176194702
Thanks for picking up this issue. This goes into a very good direction.
Few remaining points:
- There are a lot of unrelated reformattings. The general
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r51123709
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java
---
@@ -159,56 +163,109 @@ public int hashCode() {
/**
*
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50253093
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -303,6 +303,16 @@
// File System
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50253153
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java
---
@@ -46,30 +48,35 @@
public abstract class FileSystem {
private
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50252252
--- Diff: docs/setup/config.md ---
@@ -52,6 +52,14 @@ The configuration files for the TaskManagers can be
different, Flink does not as
-
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50252158
--- Diff: docs/setup/config.md ---
@@ -52,6 +52,14 @@ The configuration files for the TaskManagers can be
different, Flink does not as
-
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50253320
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java
---
@@ -159,56 +164,91 @@ public int hashCode() {
/**
* Returns a
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50253291
--- Diff: docs/setup/config.md ---
@@ -52,6 +52,14 @@ The configuration files for the TaskManagers can be
different, Flink does not as
-
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50252183
--- Diff: docs/setup/config.md ---
@@ -52,6 +52,14 @@ The configuration files for the TaskManagers can be
different, Flink does not as
-
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50252356
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/FlinkYarnSessionCli.java ---
@@ -146,6 +147,15 @@ public AbstractFlinkYarnClient
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50252906
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/FlinkYarnSessionCli.java ---
@@ -146,6 +147,15 @@ public AbstractFlinkYarnClient
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50253229
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java
---
@@ -159,56 +164,91 @@ public int hashCode() {
/**
* Returns a
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50253495
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java
---
@@ -159,56 +164,91 @@ public int hashCode() {
/**
* Returns a
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50253604
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java
---
@@ -159,56 +164,91 @@ public int hashCode() {
/**
* Returns a
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50253565
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java
---
@@ -159,56 +164,91 @@ public int hashCode() {
/**
* Returns a
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-173212170
Hey Klou! Nice addition. A couple of users have asked for this. I guess
they will be happy. I made some minor comments inline. The changes look good, I
haven't tested it
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1524
FLINK-2380: allow to specify the default filesystem scheme in the flink
configuration file.
You can merge this pull request into a Git repository by running:
$ git pull
31 matches
Mail list logo
