Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/1546
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1546#issuecomment-176189641
This is going into a good direction. Two suggestions:
- Since you already have the `ExecutionConfig` in the Task, I would put
it into the `Environment`
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1546#discussion_r51122613
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java
---
@@ -93,24 +94,28 @@
private final
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1546#issuecomment-175514254
Ah, true, the `ExecutionConfig` is currently grabed in a pretty
non-transparent way from the JobConfig.
I think it would be a good refactoring to pass the
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1546#discussion_r50694061
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java
---
@@ -60,6 +60,7 @@ public static
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1546#issuecomment-174520820
The `JobManagerITCase` is completely commented out. I guess this is a
testing artifact.
---
If your project is set up for it, you can reply to this email and
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1546#discussion_r50694370
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java
---
@@ -60,6 +60,7 @@ public static void
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1546#issuecomment-174518267
Thank you for this patch. The idea is good, but I think it needs a bit of
improvement:
- The value is pulled in a fairly complicated way though all the
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1546
FLINK-2523: making the task cancellation interval configurable.
FLINK-2523: Makes the task cancellation interval configurable.
You can merge this pull request into a Git repository by running:
$
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1546#issuecomment-174548688
Hi @StephanEwen ,
Could you please elaborate more on how you think that the ExecutionConfig
could be accessed differently by the Task?
Thanks!
---
If
10 matches
Mail list logo
