[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2490 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-19 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r79441284 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/sca/UdfAnalyzerTest.java --- @@ -971,10 +971,7 @@ public void

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r79404090 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/sca/UdfAnalyzerTest.java --- @@ -971,10 +971,7 @@ public void

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-13 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78631478 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -129,14 +129,11 @@ private String getDefaultName() {

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-10 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78288200 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -129,14 +129,11 @@ private String getDefaultName() {

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-10 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78287335 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -129,14 +129,11 @@ private String getDefaultName() {

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-10 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78286377 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -129,14 +129,11 @@ private String getDefaultName() {

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-10 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78285322 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -133,10 +133,6 @@ public DefaultCross(DataSet input1,

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-10 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78283727 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -133,10 +133,6 @@ public DefaultCross(DataSet input1,

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-10 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78283317 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -133,10 +133,6 @@ public DefaultCross(DataSet input1,

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-10 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78273103 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -133,10 +133,6 @@ public DefaultCross(DataSet input1,

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-09 Thread apivovarov
GitHub user apivovarov opened a pull request: https://github.com/apache/flink/pull/2490 [FLINK-4609] Remove redundant check for null in CrossOperator https://issues.apache.org/jira/browse/FLINK-4609 You can merge this pull request into a Git repository by running: $ git pull