[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-25 Thread StephanEwen
Github user StephanEwen closed the pull request at: https://github.com/apache/flink/pull/2754 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87043464 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BarrierBuffer.java --- @@ -135,19 +138,20 @@ else if

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87043110 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/BarrierBufferTest.java --- @@ -899,26 +926,480 @@ public void

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87039138 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/BarrierBufferTest.java --- @@ -899,26 +926,480 @@ public void

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87039301 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/decline/AlignmentLimitExceededException.java --- @@ -0,0 +1,33 @@ +/*

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87035779 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/decline/InputEndOfStreamException.java --- @@ -0,0 +1,32 @@ +/* + *

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87035938 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/StatefulTask.java --- @@ -69,7 +69,7 @@ * * @param

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87035590 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/decline/CheckpointDeclineOnCancellationBarrierException.java --- @@ -0,0

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87034115 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java --- @@ -525,81 +527,63 @@ else if

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87033063 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/BarrierBufferTest.java --- @@ -899,26 +926,480 @@ public void

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87030844 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/BarrierBufferTest.java --- @@ -899,26 +926,480 @@ public void

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87028376 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BarrierBuffer.java --- @@ -254,8 +357,20 @@ public void cleanup()

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87019713 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BarrierBuffer.java --- @@ -254,8 +357,20 @@ public void cleanup()

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87017313 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java --- @@ -525,81 +527,63 @@ else if

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87017118 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/messages/checkpoint/DeclineCheckpoint.java --- @@ -31,44 +34,44 @@ private

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87016959 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BufferSpiller.java --- @@ -418,5 +422,16 @@ public void cleanup()

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-08 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2754#discussion_r87013382 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BarrierBuffer.java --- @@ -135,19 +138,20 @@ else if

[GitHub] flink pull request #2754: [FLINK-4975] [checkpointing] Add a limit for how m...

2016-11-04 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/2754 [FLINK-4975] [checkpointing] Add a limit for how much data may be buffered in alignment In corner case situations, checkpoint alignment can take very long and buffer/spill a lot of data. This