Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r101014900
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetWindowAggregate.scala
---
@@ -281,9 +279,36 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r101014280
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/dataset/DataSetWindowAggregateITCase.scala
---
@@ -141,16 +141,18 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r101016814
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -306,6 +307,85 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r101014879
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetWindowAggregate.scala
---
@@ -294,18 +319,29 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r101015171
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregateProcessor.scala
---
@@ -59,7
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r101014526
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregatePreProcessor.scala
---
@@ -19,30
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r101016955
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -306,6 +307,85 @@ object
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r101013750
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregateProcessor.scala
---
@@ -19,15
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r11509
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -210,14 +210,14 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r10375
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/dataset/DataSetWindowAggregateITCase.scala
---
@@ -141,16 +141,18 @@
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r99987780
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetWindowAggregate.scala
---
@@ -271,19 +269,46 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r6840
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -291,13 +292,13 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r7022
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -306,6 +307,85 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r8638
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregatePreProcessor.scala
---
@@ -19,30
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r7024
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -306,6 +307,85 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r99987789
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetWindowAggregate.scala
---
@@ -299,13 +324,24 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r8655
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregateProcessor.scala
---
@@ -59,7
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/3266
[FLINK-5219][TableAPI] Add non-grouped session windows for batch â¦
â¦tables
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following
19 matches
Mail list logo
